dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove EXPERIMENTAL tag for MultiCfIterators (#13142) 

Summary:
As title

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13142

Test Plan: N/A

Reviewed By: jowlyzhang

Differential Revision: D66107254

Pulled By: jaykorean

fbshipit-source-id: 3927a411f62ba965017ac726ed818cc9f8d24f2d
This commit is contained in:
Jay Huh 2024-11-18 11:23:17 -08:00 committed by Facebook GitHub Bot
parent 3495c94761
commit d3296260c2
5 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
db/coalescing_iterator.h
View File

@ -9,7 +9,6 @@
namespace ROCKSDB_NAMESPACE { namespace ROCKSDB_NAMESPACE {
// EXPERIMENTAL
class CoalescingIterator : public Iterator { class CoalescingIterator : public Iterator {
public: public:
CoalescingIterator( CoalescingIterator(

2
db/db_impl/db_impl.h
View File

@ -363,12 +363,10 @@ class DBImpl : public DB {
const Snapshot* GetSnapshot() override; const Snapshot* GetSnapshot() override;
void ReleaseSnapshot(const Snapshot* snapshot) override; void ReleaseSnapshot(const Snapshot* snapshot) override;
// EXPERIMENTAL
std::unique_ptr<Iterator> NewCoalescingIterator( std::unique_ptr<Iterator> NewCoalescingIterator(
const ReadOptions& options, const ReadOptions& options,
const std::vector<ColumnFamilyHandle*>& column_families) override; const std::vector<ColumnFamilyHandle*>& column_families) override;
// EXPERIMENTAL
std::unique_ptr<AttributeGroupIterator> NewAttributeGroupIterator( std::unique_ptr<AttributeGroupIterator> NewAttributeGroupIterator(
const ReadOptions& options, const ReadOptions& options,
const std::vector<ColumnFamilyHandle*>& column_families) override; const std::vector<ColumnFamilyHandle*>& column_families) override;

1
include/rocksdb/attribute_groups.h
View File

@ -116,7 +116,6 @@ using IteratorAttributeGroups = std::vector<IteratorAttributeGroup>;
extern const IteratorAttributeGroups kNoIteratorAttributeGroups; extern const IteratorAttributeGroups kNoIteratorAttributeGroups;
// EXPERIMENTAL
// A cross-column-family iterator that collects and returns attribute groups for // A cross-column-family iterator that collects and returns attribute groups for
// each key in order provided by comparator // each key in order provided by comparator
class AttributeGroupIterator : public IteratorBase { class AttributeGroupIterator : public IteratorBase {

2
include/rocksdb/db.h
View File

@ -1007,7 +1007,6 @@ class DB {
const std::vector<ColumnFamilyHandle*>& column_families, const std::vector<ColumnFamilyHandle*>& column_families,
std::vector<Iterator*>* iterators) = 0; std::vector<Iterator*>* iterators) = 0;
// EXPERIMENTAL
// Return a cross-column-family iterator from a consistent database state. // Return a cross-column-family iterator from a consistent database state.
// //
// If a key exists in more than one column family, value() will be determined // If a key exists in more than one column family, value() will be determined
@ -1025,7 +1024,6 @@ class DB {
const ReadOptions& options, const ReadOptions& options,
const std::vector<ColumnFamilyHandle*>& column_families) = 0; const std::vector<ColumnFamilyHandle*>& column_families) = 0;
// EXPERIMENTAL
// A cross-column-family iterator that collects and returns attribute groups // A cross-column-family iterator that collects and returns attribute groups
// for each key in order provided by comparator // for each key in order provided by comparator
virtual std::unique_ptr<AttributeGroupIterator> NewAttributeGroupIterator( virtual std::unique_ptr<AttributeGroupIterator> NewAttributeGroupIterator(

1
unreleased_history/new_features/multi_cf_iterator.md Normal file
View File

@ -0,0 +1 @@
Multi-Column-Family-Iterator (CoalescingIterator/AttributeGroupIterator) is no longer marked as experimental