From c287c098a4112d0b2577e205fd78d556885f43de Mon Sep 17 00:00:00 2001 From: Siying Dong Date: Tue, 27 Feb 2018 12:32:09 -0800 Subject: [PATCH] Update comments in DB::Close() Summary: Closes https://github.com/facebook/rocksdb/pull/3543 Differential Revision: D7093251 Pulled By: siying fbshipit-source-id: 4066b82c95ecb65866c5842d68ab13ab9f85d567 --- include/rocksdb/db.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/rocksdb/db.h b/include/rocksdb/db.h index 7e89261535..8b4d7ae56e 100644 --- a/include/rocksdb/db.h +++ b/include/rocksdb/db.h @@ -174,7 +174,8 @@ class DB { // Close the DB by releasing resources, closing files etc. This should be // called before calling the desctructor so that the caller can get back a // status in case there are any errors. This will not fsync the WAL files. - // If syncing is required, the caller must first call SyncWAL. + // If syncing is required, the caller must first call SyncWAL(), or Write() + // using an empty write batch with WriteOptions.sync=true. // Regardless of the return status, the DB must be freed. If the return // status is NotSupported(), then the DB implementation does cleanup in the // destructor