dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable flaky part of TransactionLogIteratorCheckWhenArchive (#12423) 

Summary:
https://github.com/facebook/rocksdb/issues/12397 attempted to make the test more honest about its failures, and they're really showing up in CI now (but not locally). Disable pending investigation

Pull Request resolved: https://github.com/facebook/rocksdb/pull/12423

Test Plan: watch CI

Reviewed By: ltamasi

Differential Revision: D54817705

Pulled By: pdillinger

fbshipit-source-id: 4721834c49b225ac52d1a28ecb06b9d05de977b3
This commit is contained in:
Peter Dillinger 2024-03-12 12:54:53 -07:00 committed by Facebook GitHub Bot
parent d9a441113e
commit c0ae5be934
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
db/db_log_iter_test.cc
View File

@ -182,7 +182,8 @@ TEST_F(DBTestXactLogIterator, TransactionLogIteratorCheckWhenArchive) {
ASSERT_OK(dbfull()->Flush(FlushOptions(), cf)); ASSERT_OK(dbfull()->Flush(FlushOptions(), cf));
delete cf; delete cf;
// Normally hit several times; WART: perhaps more in parallel after flush // Normally hit several times; WART: perhaps more in parallel after flush
ASSERT_TRUE(callback_hit.LoadRelaxed()); // FIXME: this test is flaky
// ASSERT_TRUE(callback_hit.LoadRelaxed());
} while (ChangeCompactOptions()); } while (ChangeCompactOptions());
Close(); Close();
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing(); ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->DisableProcessing();