mirror of https://github.com/facebook/rocksdb.git
Fix incorrect refillPeriodMicros unit in the document (#12832)
Summary: The default value for `refillPeriodMicros` is `100 * 1000`, which means 100ms (or 100,000us). The document comments say 100,000ms (equivalent to 100 seconds), which is incorrect and misleading. This PR fixes this typo. Pull Request resolved: https://github.com/facebook/rocksdb/pull/12832 Reviewed By: cbi42 Differential Revision: D59492336 Pulled By: ajkr fbshipit-source-id: c2f55a8b996fe078a1510fcbebaea92ec0075929
This commit is contained in:
parent
f471e56190
commit
a97a1f3247
|
@ -45,7 +45,7 @@ public class RateLimiter extends RocksObject {
|
|||
* when rate_bytes_per_sec is set to 10MB/s and refill_period_us is set to
|
||||
* 100ms, then 1MB is refilled every 100ms internally. Larger value can
|
||||
* lead to burstier writes while smaller value introduces more CPU
|
||||
* overhead. The default of 100,000ms should work for most cases.
|
||||
* overhead. The default of 100,000us should work for most cases.
|
||||
*/
|
||||
public RateLimiter(final long rateBytesPerSecond,
|
||||
final long refillPeriodMicros) {
|
||||
|
@ -66,7 +66,7 @@ public class RateLimiter extends RocksObject {
|
|||
* when rate_bytes_per_sec is set to 10MB/s and refill_period_us is set to
|
||||
* 100ms, then 1MB is refilled every 100ms internally. Larger value can
|
||||
* lead to burstier writes while smaller value introduces more CPU
|
||||
* overhead. The default of 100,000ms should work for most cases.
|
||||
* overhead. The default of 100,000us should work for most cases.
|
||||
* @param fairness RateLimiter accepts high-pri requests and low-pri requests.
|
||||
* A low-pri request is usually blocked in favor of hi-pri request.
|
||||
* Currently, RocksDB assigns low-pri to request from compaction and
|
||||
|
@ -95,7 +95,7 @@ public class RateLimiter extends RocksObject {
|
|||
* when rate_bytes_per_sec is set to 10MB/s and refill_period_us is set to
|
||||
* 100ms, then 1MB is refilled every 100ms internally. Larger value can
|
||||
* lead to burstier writes while smaller value introduces more CPU
|
||||
* overhead. The default of 100,000ms should work for most cases.
|
||||
* overhead. The default of 100,000us should work for most cases.
|
||||
* @param fairness RateLimiter accepts high-pri requests and low-pri requests.
|
||||
* A low-pri request is usually blocked in favor of hi-pri request.
|
||||
* Currently, RocksDB assigns low-pri to request from compaction and
|
||||
|
@ -127,7 +127,7 @@ public class RateLimiter extends RocksObject {
|
|||
* when rate_bytes_per_sec is set to 10MB/s and refill_period_us is set to
|
||||
* 100ms, then 1MB is refilled every 100ms internally. Larger value can
|
||||
* lead to burstier writes while smaller value introduces more CPU
|
||||
* overhead. The default of 100,000ms should work for most cases.
|
||||
* overhead. The default of 100,000us should work for most cases.
|
||||
* @param fairness RateLimiter accepts high-pri requests and low-pri requests.
|
||||
* A low-pri request is usually blocked in favor of hi-pri request.
|
||||
* Currently, RocksDB assigns low-pri to request from compaction and
|
||||
|
|
Loading…
Reference in New Issue