dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Windows build by replacing strings.h include 

Summary:
strings.h header does not exist on Windows. So, we can try another way
to compare strings ignoring case.

Test Plan:
built and ran:

  $ ./ldb_cmd_test

Reviewers: sdong, yhchiang, IslamAbdelRahman

Reviewed By: IslamAbdelRahman

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D56535
This commit is contained in:
Andrew Kryczka 2016-04-11 19:21:00 -07:00
parent 5675d5037f
commit 8e0e22f76b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
tools/ldb_cmd_test.cc
View File

@ -6,7 +6,6 @@
#ifndef ROCKSDB_LITE
#include "tools/ldb_cmd.h"
#include <strings.h>
#include "util/testharness.h"
class LdbCmdTest : public testing::Test {};
@ -26,7 +25,7 @@ TEST_F(LdbCmdTest, HexToString) {
EXPECT_EQ(expected[i], static_cast<int>(actual[i]));
}
auto reverse = rocksdb::LDBCommand::StringToHex(actual);
EXPECT_EQ(strcasecmp(inPair.first.c_str(), reverse.c_str()), 0);
EXPECT_STRCASEEQ(inPair.first.c_str(), reverse.c_str());
}
}