From 8972dd1ffa941834bbd8e69f76ad8aff0d89bfb8 Mon Sep 17 00:00:00 2001 From: Xavier Deguillard Date: Mon, 12 Apr 2021 10:56:42 -0700 Subject: [PATCH] Add util/crc32c_arm64.cc to TARGETS (#8168) Summary: When compiling RocksDB with Buck for ARM64, the linker complains about missing crc32 symbols that are defined in the crc32c_arm64.cc file. Since this file wasn't included in the build this is totally expected Pull Request resolved: https://github.com/facebook/rocksdb/pull/8168 Test Plan: The following no longer fails to link rocksdb: buck build mode/mac-xcode //eden/fs/service:edenfs#macosx-arm64 Reviewed By: zhichao-cao Differential Revision: D27664627 Pulled By: xavierd fbshipit-source-id: fb9d7a538599ee7a08882f87628731de6e641f8d --- TARGETS | 2 ++ src.mk | 6 +----- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/TARGETS b/TARGETS index 7f813623d7..4cb069139e 100644 --- a/TARGETS +++ b/TARGETS @@ -340,6 +340,7 @@ cpp_library( "util/compression_context_cache.cc", "util/concurrent_task_limiter_impl.cc", "util/crc32c.cc", + "util/crc32c_arm64.cc", "util/dynamic_bloom.cc", "util/file_checksum_helper.cc", "util/hash.cc", @@ -649,6 +650,7 @@ cpp_library( "util/compression_context_cache.cc", "util/concurrent_task_limiter_impl.cc", "util/crc32c.cc", + "util/crc32c_arm64.cc", "util/dynamic_bloom.cc", "util/file_checksum_helper.cc", "util/hash.cc", diff --git a/src.mk b/src.mk index f485f38038..371db196b9 100644 --- a/src.mk +++ b/src.mk @@ -205,6 +205,7 @@ LIB_SOURCES = \ util/compression_context_cache.cc \ util/concurrent_task_limiter_impl.cc \ util/crc32c.cc \ + util/crc32c_arm64.cc \ util/dynamic_bloom.cc \ util/hash.cc \ util/murmurhash.cc \ @@ -275,11 +276,6 @@ LIB_SOURCES = \ utilities/write_batch_with_index/write_batch_with_index.cc \ utilities/write_batch_with_index/write_batch_with_index_internal.cc \ -ifeq ($(ARMCRC_SOURCE),1) -LIB_SOURCES +=\ - util/crc32c_arm64.cc -endif - ifeq (,$(shell $(CXX) -fsyntax-only -maltivec -xc /dev/null 2>&1)) LIB_SOURCES_ASM =\ util/crc32c_ppc_asm.S