dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[Rocksdb] Simplify Printing code in db_bench 

Summary:
simplify the printing code in db_bench
         use TickersMap and HistogramsNameMap introduced in previous diffs.

Test Plan: ./db_bench --statistics=1 and see if all the statistics are printed

Reviewers: haobo, dhruba

Reviewed By: haobo

CC: leveldb

Differential Revision: https://reviews.facebook.net/D11355
This commit is contained in:
Abhishek Kona 2013-06-18 14:58:00 -07:00
parent 6acbe0fc45
commit 79f4fd2b62
1 changed files with 13 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
db/db_bench.cc
View File

@ -732,7 +732,8 @@ class Benchmark {
#endif #endif
} }
void PrintHistogram(Histograms histogram_type, std::string name) { void PrintHistogram(const Histograms& histogram_type,
const std::string& name) {
HistogramData histogramData; HistogramData histogramData;
dbstats->histogramData(histogram_type, &histogramData); dbstats->histogramData(histogram_type, &histogramData);
fprintf(stdout, "%s statistics Percentiles :", name.c_str()); fprintf(stdout, "%s statistics Percentiles :", name.c_str());
@ -741,33 +742,19 @@ class Benchmark {
fprintf(stdout, "99 : %f\n", histogramData.percentile99); fprintf(stdout, "99 : %f\n", histogramData.percentile99);
} }
void PrintTicker(const Tickers& ticker, const std::string& name) {
fprintf(stdout, "%s COUNT : %ld\n",
name.c_str(), dbstats->getTickerCount(ticker));
}
void PrintStatistics() { void PrintStatistics() {
if (FLAGS_statistics) { if (FLAGS_statistics) {
fprintf(stdout, "File opened:%ld closed:%ld errors:%ld\n" for (auto& t : TickersNameMap) {
"Block Cache Hit Count:%ld Block Cache Miss Count:%ld\n" PrintTicker(t.first, t.second);
"Bloom Filter Useful: %ld \n" }
"Compaction key_drop_newer_entry: %ld key_drop_obsolete: %ld " for (auto& h : HistogramsNameMap) {
"Compaction key_drop_user: %ld\n", PrintHistogram(h.first, h.second);
dbstats->getTickerCount(NO_FILE_OPENS), }
dbstats->getTickerCount(NO_FILE_CLOSES),
dbstats->getTickerCount(NO_FILE_ERRORS),
dbstats->getTickerCount(BLOCK_CACHE_HIT),
dbstats->getTickerCount(BLOCK_CACHE_MISS),
dbstats->getTickerCount(BLOOM_FILTER_USEFUL),
dbstats->getTickerCount(COMPACTION_KEY_DROP_NEWER_ENTRY),
dbstats->getTickerCount(COMPACTION_KEY_DROP_OBSOLETE),
dbstats->getTickerCount(COMPACTION_KEY_DROP_USER));
PrintHistogram(DB_GET, "DB_GET");
PrintHistogram(DB_WRITE, "DB_WRITE");
PrintHistogram(COMPACTION_TIME, "COMPACTION_TIME");
PrintHistogram(TABLE_SYNC_MICROS, "TABLE SYNC MICROS");
PrintHistogram(
COMPACTION_OUTFILE_SYNC_MICROS,
"COMPACTION OUT FILE SYNC MICROS");
PrintHistogram(WAL_FILE_SYNC_MICROS, "WAL FILE SYNC MICROS");
PrintHistogram(MANIFEST_FILE_SYNC_MICROS, "Manifest SYNC MICROS");
PrintHistogram(TABLE_OPEN_IO_MICROS, "Table Open IO Micros");
PrintHistogram(DB_MULTIGET, "DB_MULTIGET");
} }
} }