dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use uint64_t for `compaction_readahead_size` in stress test (#11849) 

Summary:
Internal clang check complains: `tools/db_bench_tool.cc:722:43: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'const gflags::int32' (aka 'const int') [-Werror,-Wshorten-64-to-32]
             ROCKSDB_NAMESPACE::Options().compaction_readahead_size,`

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11849

Test Plan: `make -C internal_repo_rocksdb/repo -j64 USE_CLANG=1 J=40 check`, I can only repro when using on-demand devserver.

Reviewed By: hx235

Differential Revision: D49344491

Pulled By: cbi42

fbshipit-source-id: 8c2c0bf2a075c3190b8b91f14f64e26ee252f20f
This commit is contained in:
Changyu Bi 2023-09-16 12:08:55 -07:00 committed by Facebook GitHub Bot
parent 99f8820054
commit 60de713e15
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tools/db_bench_tool.cc
View File

@ -718,9 +718,9 @@ DEFINE_int32(file_opening_threads,
"If open_files is set to -1, this option set the number of "
"threads that will be used to open files during DB::Open()");
DEFINE_int32(compaction_readahead_size,
ROCKSDB_NAMESPACE::Options().compaction_readahead_size,
"Compaction readahead size");
DEFINE_uint64(compaction_readahead_size,
ROCKSDB_NAMESPACE::Options().compaction_readahead_size,
"Compaction readahead size");
DEFINE_int32(log_readahead_size, 0, "WAL and manifest readahead size");