dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-26 16:30:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix BlockBasedTableTest.BlockCacheLeak valgrind failure

Browse source 
Summary:
I added this line in my previous patch D48999 (which is incorrect)
We should not release the iterator since releasing it will evict the blocks from cache

Test Plan:
Run the test under valgrind
make check

Reviewers: rven, yhchiang, sdong

Reviewed By: sdong

Subscribers: dhruba

Differential Revision: https://reviews.facebook.net/D52161
This commit is contained in:
Islam AbdelRahman 2015-12-18 11:17:21 -08:00
parent a48382399d
commit 521da3abb3
1 changed files with 0 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
table/table_test.cc
View file

@ -1807,7 +1807,6 @@ TEST_F(BlockBasedTableTest, BlockCacheLeak) {
iter->Next(); iter->Next();
} }
ASSERT_OK(iter->status()); ASSERT_OK(iter->status());
iter.release();
const ImmutableCFOptions ioptions1(opt); const ImmutableCFOptions ioptions1(opt);
ASSERT_OK(c.Reopen(ioptions1)); ASSERT_OK(c.Reopen(ioptions1));