dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove comment about locking about TestIterateAgainstExpected (#11695) 

Summary:
**Context/Summary**
After https://github.com/facebook/rocksdb/pull/11058, we no longer lock the key range to iterate in TestIterateAgainstExpected, except for working with timestamp feature.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11695

Test Plan: no code change

Reviewed By: ajkr

Differential Revision: D48276668

Pulled By: hx235

fbshipit-source-id: dc92a3708b2281dc737c0877fb755548bf03a9fc
This commit is contained in:
Hui Xiao 2023-08-11 13:14:04 -07:00 committed by Facebook GitHub Bot
parent 52816ff64d
commit 38ecfabed2
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
db_stress_tool/no_batched_ops_stress.cc
View File

@ -1589,8 +1589,6 @@ class NonBatchedOpsStressTest : public StressTest {
const int64_t ub = lb + num_iter;
// Lock the whole range over which we might iterate to ensure it doesn't
// change under us.
const int rand_column_family = rand_column_families[0];
// Testing parallel read and write to the same key with user timestamp

2
tools/db_crashtest.py
View File

@ -346,7 +346,7 @@ simple_default_params = {
"write_buffer_size": 32 * 1024 * 1024,
"level_compaction_dynamic_level_bytes": lambda: random.randint(0, 1),
"paranoid_file_checks": lambda: random.choice([0, 1, 1, 1]),
"verify_iterator_with_expected_state_one_in": 5, # this locks a range of keys
"verify_iterator_with_expected_state_one_in": 5,
}
blackbox_simple_default_params = {