dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable partitioned index/filter in stress tests (#5895) 

Summary:
This is the 2nd attempt after the revert of https://github.com/facebook/rocksdb/pull/4020
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5895

Test Plan:
```
./tools/db_crashtest.py blackbox --simple --interval=10 --max_key=10000000
```

Differential Revision: D17822137

Pulled By: maysamyabandeh

fbshipit-source-id: 3d148c0d8cc129080410ff859c04b544223c8ea3
This commit is contained in:
Maysam Yabandeh 2019-10-08 16:48:57 -07:00 committed by Facebook Github Bot
parent e3a93c9ee1
commit 2f4e288143
2 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tools/db_crashtest.py
View File

@ -41,8 +41,8 @@ default_params = {
"enable_pipelined_write": 0, "enable_pipelined_write": 0,
"expected_values_path": expected_values_file.name, "expected_values_path": expected_values_file.name,
"flush_one_in": 1000000, "flush_one_in": 1000000,
# Temporarily disable hash and partitioned index # Temporarily disable hash index
"index_type": 0, "index_type": lambda: random.choice([0,2]),
"max_background_compactions": 20, "max_background_compactions": 20,
"max_bytes_for_level_base": 10485760, "max_bytes_for_level_base": 10485760,
"max_key": 100000000, "max_key": 100000000,
@ -51,7 +51,7 @@ default_params = {
"nooverwritepercent": 1, "nooverwritepercent": 1,
"open_files": lambda : random.choice([-1, 500000]), "open_files": lambda : random.choice([-1, 500000]),
# Temporarily disable partitioned filter # Temporarily disable partitioned filter
"partition_filters": 0, "partition_filters": lambda: random.randint(0, 1),
"prefixpercent": 5, "prefixpercent": 5,
"progress_reports": 0, "progress_reports": 0,
"readpercent": 45, "readpercent": 45,
@ -179,8 +179,10 @@ def finalize_and_sanitize(src_params):
# now assertion failures are triggered. # now assertion failures are triggered.
dest_params["compaction_ttl"] = 0 dest_params["compaction_ttl"] = 0
if dest_params["partition_filters"] == 1: if dest_params["partition_filters"] == 1:
dest_params["index_type"] = 2 if dest_params["index_type"] != 2:
dest_params["use_block_based_filter"] = 0 dest_params["partition_filters"] = 0
else:
dest_params["use_block_based_filter"] = 0
return dest_params return dest_params

3
tools/db_stress.cc
View File

@ -354,8 +354,7 @@ DEFINE_bool(use_block_based_filter, false, "use block based filter"
"instead of full filter for block based table"); "instead of full filter for block based table");
DEFINE_bool(partition_filters, false, DEFINE_bool(partition_filters, false,
"use partitioned filters " "use partitioned filters for block-based table");
"for block-based table");
DEFINE_int32( DEFINE_int32(
index_type, index_type,