From 22ecb752dbab4d134fe9891e244924aaae1ff07a Mon Sep 17 00:00:00 2001 From: krad Date: Mon, 25 Jan 2016 13:06:11 -0800 Subject: [PATCH] Add valgrind to pre-commit sandcastle testing Summary: Initially I removed "valgrind" from the list since it take too much time (3+hr) compared to tsan (40 min) when the tests are run in parallel. It is not effective to run the tests in parallel in sandcastle and tsan takes about 3hrs as well. Adding valgrind to the list. Test Plan: Submit this diff and watch the run Reviewers: sdong, rven Subscribers: dhruba, leveldb Differential Revision: https://reviews.facebook.net/D53337 --- arcanist_util/config/FacebookArcanistConfiguration.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arcanist_util/config/FacebookArcanistConfiguration.php b/arcanist_util/config/FacebookArcanistConfiguration.php index c4785bc00e..31fa27c9b1 100644 --- a/arcanist_util/config/FacebookArcanistConfiguration.php +++ b/arcanist_util/config/FacebookArcanistConfiguration.php @@ -123,7 +123,7 @@ class FacebookArcanistConfiguration extends ArcanistConfiguration { // list of tests we want to run in sandcastle $tests = array( - "unit", "unit_481", "clang_unit", "tsan", "asan", "lite" + "unit", "unit_481", "clang_unit", "tsan", "asan", "lite", "valgrind" ); // construct a job definition for each test and add it to the master plan