From 2190e967272ad825b45959a62d3f54911b11b798 Mon Sep 17 00:00:00 2001 From: Yi Wu Date: Mon, 18 Dec 2017 17:48:41 -0800 Subject: [PATCH] Remove incorrect comment Summary: We actually create individual compaction filter from compaction filter factory per sub-compaction in `CompactionJob::ProcessKeyValueCompaction`: https://github.com/facebook/rocksdb/blob/master/db/compaction_job.cc#L742 The comment seems incorrect. Closes https://github.com/facebook/rocksdb/pull/3288 Differential Revision: D6598455 Pulled By: yiwu-arbug fbshipit-source-id: a6bc059a9103b87a73ae6ec4bb01ca33f5d48cf5 --- include/rocksdb/compaction_filter.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/include/rocksdb/compaction_filter.h b/include/rocksdb/compaction_filter.h index 64f61a35e0..344b1001e8 100644 --- a/include/rocksdb/compaction_filter.h +++ b/include/rocksdb/compaction_filter.h @@ -94,10 +94,6 @@ class CompactionFilter { // be used by a single thread that is doing the compaction run, and this // call does not need to be thread-safe. However, multiple filters may be // in existence and operating concurrently. - // - // The last paragraph is not true if you set max_subcompactions to more than - // 1. In that case, subcompaction from multiple threads may call a single - // CompactionFilter concurrently. virtual bool Filter(int level, const Slice& key, const Slice& existing_value, std::string* new_value, bool* value_changed) const { return false;