dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make sandcastle access secure 

Summary: Making access credentials for sandcastle configurable

Test Plan: Submit for review

Reviewers: sdong

Subscribers: andrewkr, dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D59649
This commit is contained in:
krad 2016-06-14 16:13:08 -07:00
parent 8366e10ffc
commit 162c9170dd
1 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
arcanist_util/config/FacebookArcanistConfiguration.php
View File

@ -3,7 +3,6 @@
// This source code is licensed under the BSD-style license found in the // This source code is licensed under the BSD-style license found in the
// LICENSE file in the root directory of this source tree. An additional grant // LICENSE file in the root directory of this source tree. An additional grant
// of patent rights can be found in the PATENTS file in the same directory. // of patent rights can be found in the PATENTS file in the same directory.
class FacebookArcanistConfiguration extends ArcanistConfiguration { class FacebookArcanistConfiguration extends ArcanistConfiguration {
public function didRunWorkflow($command, public function didRunWorkflow($command,
@ -171,17 +170,37 @@ class FacebookArcanistConfiguration extends ArcanistConfiguration {
.'&user=krad&alias=rocksdb-precommit' .'&user=krad&alias=rocksdb-precommit'
.'&command-args=' . urlencode(json_encode($command)); .'&command-args=' . urlencode(json_encode($command));
$cmd = 'https_proxy= HTTPS_PROXY= curl -s -k -F app=659387027470559 ' if (file_exists('/home/krad/.sandcastle')) {
. '-F token=AeO_3f2Ya3TujjnxGD4 "' . $url . '"'; $cmd = 'cat /home/krad/.sandcastle';
} else {
$cmd = 'cat ~/.sandcastle';
}
$sandcastle_config = explode(':', rtrim(shell_exec($cmd)));
if (count($sandcastle_config) != 2) {
print('.sandcastle does not contain valid configuration');
return;
}
$app = $sandcastle_config[0];
$token = $sandcastle_config[1];
$cmd = 'https_proxy= HTTPS_PROXY= curl -s -k -F app=' . $app . ' '
. '-F token=' . $token . ' "' . $url . '"';
$output = shell_exec($cmd); $output = shell_exec($cmd);
// extract sandcastle URL from the response // extract sandcastle URL from the response
preg_match('/url": "(.+)"/', $output, $sandcastle_url); preg_match('/url": "(.+)"/', $output, $sandcastle_url);
echo "\nSandcastle URL: " . $sandcastle_url[1] . "\n"; if (count($sandcastle_url) > 1) {
echo "\nSandcastle URL: " . $sandcastle_url[1] . "\n";
// Ask phabricator to display it on the diff UI // Ask phabricator to display it on the diff UI
$this->postURL($diffID, $sandcastle_url[1]); $this->postURL($diffID, $sandcastle_url[1]);
} else {
print("Error submitting job to sandcastle.");
print($output);
}
} }
} }