dolysis/rocksdb
3
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2024-11-28 15:33:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

clarify TODO for whitebox disable_wal=1 in db_crashtest.py (#11665)

Browse source 
Summary:
See https://github.com/facebook/rocksdb/issues/11613

Pull Request resolved: https://github.com/facebook/rocksdb/pull/11665

Reviewed By: hx235

Differential Revision: D48010507

Pulled By: ajkr

fbshipit-source-id: 65c6d87d2c6ffc9d25f1d17106eae467ec528082
This commit is contained in:
Andrew Kryczka 2023-08-16 09:43:20 -07:00 committed by Facebook GitHub Bot
parent b63018fb59
commit 0b6ee88d51
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
tools/db_crashtest.py
View file

@ -323,10 +323,14 @@ blackbox_default_params = {
} }
whitebox_default_params = { whitebox_default_params = {
# TODO: enable this once we figure out how to adjust kill odds for WAL- # TODO: enable this at random once we figure out two things. First, we need
# disabled runs, and either (1) separate full `db_stress` runs out of # to ensure the kill odds in WAL-disabled runs result in regular crashing
# whitebox crash or (2) support verification at end of `db_stress` runs # before the fifteen minute timeout. When WAL is disabled there are very few
# that ran with WAL disabled. # calls to write functions since writes to SST files are buffered and other
# writes (e.g., MANIFEST) are infrequent. Crashing in reasonable time might
# currently assume killpoints in write functions are reached frequently.
#
# Second, we need to make sure disabling WAL works with `-reopen > 0`.
"disable_wal": 0, "disable_wal": 0,
"duration": 10000, "duration": 10000,
"log2_keys_per_lock": 10, "log2_keys_per_lock": 10,