mirror of https://github.com/facebook/rocksdb.git
clarify TODO for whitebox disable_wal=1 in db_crashtest.py (#11665)
Summary: See https://github.com/facebook/rocksdb/issues/11613 Pull Request resolved: https://github.com/facebook/rocksdb/pull/11665 Reviewed By: hx235 Differential Revision: D48010507 Pulled By: ajkr fbshipit-source-id: 65c6d87d2c6ffc9d25f1d17106eae467ec528082
This commit is contained in:
parent
b63018fb59
commit
0b6ee88d51
|
@ -323,10 +323,14 @@ blackbox_default_params = {
|
|||
}
|
||||
|
||||
whitebox_default_params = {
|
||||
# TODO: enable this once we figure out how to adjust kill odds for WAL-
|
||||
# disabled runs, and either (1) separate full `db_stress` runs out of
|
||||
# whitebox crash or (2) support verification at end of `db_stress` runs
|
||||
# that ran with WAL disabled.
|
||||
# TODO: enable this at random once we figure out two things. First, we need
|
||||
# to ensure the kill odds in WAL-disabled runs result in regular crashing
|
||||
# before the fifteen minute timeout. When WAL is disabled there are very few
|
||||
# calls to write functions since writes to SST files are buffered and other
|
||||
# writes (e.g., MANIFEST) are infrequent. Crashing in reasonable time might
|
||||
# currently assume killpoints in write functions are reached frequently.
|
||||
#
|
||||
# Second, we need to make sure disabling WAL works with `-reopen > 0`.
|
||||
"disable_wal": 0,
|
||||
"duration": 10000,
|
||||
"log2_keys_per_lock": 10,
|
||||
|
|
Loading…
Reference in New Issue