From 08ab1d83ac01c5e36673e844f3590f8ae14a6f2b Mon Sep 17 00:00:00 2001 From: Volker Mische Date: Wed, 20 Jul 2016 23:41:11 +0200 Subject: [PATCH] Remove bashism from `make check` (#1225) The tests run by `make check` require Bash. On Debian you'd need to run the test as `make SHELL=/bin/bash check`. This commit makes it work on all POSIX compatible shells (tested on Debian with `dash`). --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 6445c5c5da..94358b57c7 100644 --- a/Makefile +++ b/Makefile @@ -550,7 +550,7 @@ $(parallel_tests): $(PARALLEL_TEST) -e '/^(\s*)(\S+)/; !$$1 and do {$$p=$$2; break};' \ -e 'print qq! $$p$$2!'`; \ for TEST_NAME in $$TEST_NAMES; do \ - TEST_SCRIPT=t/run-$$TEST_BINARY-$${TEST_NAME//\//-}; \ + TEST_SCRIPT=t/run-$$TEST_BINARY-`echo $$TEST_NAME|sed -e 's/\//-/g'`; \ echo " GEN " $$TEST_SCRIPT; \ printf '%s\n' \ '#!/bin/sh' \ @@ -613,7 +613,7 @@ check_0: } \ | $(prioritize_long_running_tests) \ | grep -E '$(tests-regexp)' \ - | parallel -j$(J) --joblog=LOG $$eta --gnu '{} >& t/log-{/}' + | parallel -j$(J) --joblog=LOG $$eta --gnu '{} >&2 t/log-{/}' .PHONY: valgrind_check_0 valgrind_check_0: