dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

sst_dump: Fix incorrect cmd args parsing 

Summary: The current parsing logic ignores any additional chars after the arg.

Test Plan: "./sst_dump --verify_checksumAAA" now outputs error.

Reviewers: dhruba, sheki, emayanke

Reviewed By: dhruba

CC: leveldb

Differential Revision: https://reviews.facebook.net/D7611
This commit is contained in:
Zheng Shao 2012-12-25 17:33:15 -08:00
parent 396c3aa08e
commit 04832dbc02
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/sst_dump.cc
View File

@ -105,12 +105,11 @@ int main(int argc, char** argv) {
{ {
if (strncmp(argv[i], "--file=", 7) == 0) { if (strncmp(argv[i], "--file=", 7) == 0) {
dir_or_file = argv[i] + 7; dir_or_file = argv[i] + 7;
} else if (strncmp(argv[i], "--output_hex", 12) == 0) { } else if (strcmp(argv[i], "--output_hex") == 0) {
output_hex = true; output_hex = true;
} else if (sscanf(argv[i], "--read_num=%ld%c", &n, &junk) == 1) { } else if (sscanf(argv[i], "--read_num=%ld%c", &n, &junk) == 1) {
read_num = n; read_num = n;
} else if (strncmp(argv[i], "--verify_checksum", } else if (strcmp(argv[i], "--verify_checksum") == 0) {
strlen("--verify_checksum")) == 0) {
verify_checksum = true; verify_checksum = true;
} else if (strncmp(argv[i], "--command=", 10) == 0) { } else if (strncmp(argv[i], "--command=", 10) == 0) {
command = argv[i] + 10; command = argv[i] + 10;