dolysis
/
rocksdb
mirror of https://github.com/facebook/rocksdb.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable iterator refresh for CoalescingIterator in TestIterateAgainstExpected (#12723) 

Summary:
Pull Request resolved: https://github.com/facebook/rocksdb/pull/12723

`CoalescingIterator` doesn't support `Refresh` currently; the patch adds a check that was missing from https://github.com/facebook/rocksdb/pull/12721 to disable this operation when multi-CF iterators are in use in the stress test.

Reviewed By: jaykorean

Differential Revision: D58053334

fbshipit-source-id: 3146f0e7e87230b49b244cecdfcee345c0ce78fa
This commit is contained in:
Levi Tamasi 2024-06-01 09:52:48 -07:00 committed by Facebook GitHub Bot
parent fc59d8f9c6
commit 023a808417
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
db_stress_tool/no_batched_ops_stress.cc
View File

@ -2116,9 +2116,10 @@ class NonBatchedOpsStressTest : public StressTest {
op_logs += "P";
}
// Write-prepared and Write-unprepared do not support Refresh() yet.
// Write-prepared/write-unprepared transactions and multi-CF iterator do not
// support Refresh() yet.
if (!(FLAGS_use_txn && FLAGS_txn_write_policy != 0) &&
thread->rand.OneIn(2)) {
!FLAGS_use_multi_cf_iterator && thread->rand.OneIn(2)) {
pre_read_expected_values.clear();
post_read_expected_values.clear();
// Refresh after forward/backward scan to allow higher chance of SV