2016-02-09 23:12:00 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2015-02-17 19:29:36 +00:00
|
|
|
|
|
|
|
#include <atomic>
|
|
|
|
|
2017-04-06 02:02:00 +00:00
|
|
|
#include "monitoring/thread_status_updater.h"
|
|
|
|
#include "monitoring/thread_status_util.h"
|
2021-01-26 06:07:26 +00:00
|
|
|
#include "rocksdb/system_clock.h"
|
2015-02-17 19:29:36 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2015-02-17 19:29:36 +00:00
|
|
|
|
|
|
|
#ifndef NDEBUG
|
|
|
|
// the delay for debugging purpose.
|
|
|
|
static std::atomic<int> states_delay[ThreadStatus::NUM_STATE_TYPES];
|
|
|
|
|
2022-10-25 03:45:54 +00:00
|
|
|
void ThreadStatusUtil::TEST_SetStateDelay(const ThreadStatus::StateType state,
|
|
|
|
int micro) {
|
2015-02-17 19:29:36 +00:00
|
|
|
states_delay[state].store(micro, std::memory_order_relaxed);
|
|
|
|
}
|
|
|
|
|
2015-04-13 22:58:45 +00:00
|
|
|
void ThreadStatusUtil::TEST_StateDelay(const ThreadStatus::StateType state) {
|
|
|
|
auto delay = states_delay[state].load(std::memory_order_relaxed);
|
|
|
|
if (delay > 0) {
|
2021-01-26 06:07:26 +00:00
|
|
|
SystemClock::Default()->SleepForMicroseconds(delay);
|
2015-04-13 22:58:45 +00:00
|
|
|
}
|
2015-02-17 19:29:36 +00:00
|
|
|
}
|
|
|
|
|
2023-04-21 16:07:18 +00:00
|
|
|
Env::IOActivity ThreadStatusUtil::TEST_GetExpectedIOActivity(
|
|
|
|
ThreadStatus::OperationType thread_op) {
|
|
|
|
switch (thread_op) {
|
|
|
|
case ThreadStatus::OperationType::OP_FLUSH:
|
|
|
|
return Env::IOActivity::kFlush;
|
|
|
|
case ThreadStatus::OperationType::OP_COMPACTION:
|
|
|
|
return Env::IOActivity::kCompaction;
|
|
|
|
case ThreadStatus::OperationType::OP_DBOPEN:
|
|
|
|
return Env::IOActivity::kDBOpen;
|
Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version: https://github.com/google/benchmark/commit/604f6fd3f4b34a84ec4eb4db81d842fa4db829cd
- db_basic_bench_base: upstream
- db_basic_bench_pr: db_basic_bench_base + this PR
- asyncread_db_basic_bench_base: upstream + [db basic bench patch for IteratorNext](https://github.com/facebook/rocksdb/compare/main...hx235:rocksdb:micro_bench_async_read)
- asyncread_db_basic_bench_pr: asyncread_db_basic_bench_base + this PR
**Test**
Get
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{null_stat|base|pr} --benchmark_filter=DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/negative_query:0/enable_filter:0/mmap:1/threads:1 --benchmark_repetitions=1000
```
Result
```
Coming soon
```
AsyncRead
```
TEST_TMPDIR=/dev/shm ./asyncread_db_basic_bench_{base|pr} --benchmark_filter=IteratorNext/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/async_io:1/include_detailed_timers:0 --benchmark_repetitions=1000 > syncread_db_basic_bench_{base|pr}.out
```
Result
```
Base:
1956,1956,1968,1977,1979,1986,1988,1988,1988,1990,1991,1991,1993,1993,1993,1993,1994,1996,1997,1997,1997,1998,1999,2001,2001,2002,2004,2007,2007,2008,
PR (2.3% regression, due to measuring `SST_READ_MICRO` that wasn't measured before):
1993,2014,2016,2022,2024,2027,2027,2028,2028,2030,2031,2031,2032,2032,2038,2039,2042,2044,2044,2047,2047,2047,2048,2049,2050,2052,2052,2052,2053,2053,
```
Reviewed By: ajkr
Differential Revision: D45918925
Pulled By: hx235
fbshipit-source-id: 58a54560d9ebeb3a59b6d807639692614dad058a
2023-08-09 00:26:50 +00:00
|
|
|
case ThreadStatus::OperationType::OP_GET:
|
|
|
|
return Env::IOActivity::kGet;
|
|
|
|
case ThreadStatus::OperationType::OP_MULTIGET:
|
|
|
|
return Env::IOActivity::kMultiGet;
|
|
|
|
case ThreadStatus::OperationType::OP_DBITERATOR:
|
|
|
|
return Env::IOActivity::kDBIterator;
|
|
|
|
case ThreadStatus::OperationType::OP_VERIFY_DB_CHECKSUM:
|
|
|
|
return Env::IOActivity::kVerifyDBChecksum;
|
|
|
|
case ThreadStatus::OperationType::OP_VERIFY_FILE_CHECKSUMS:
|
|
|
|
return Env::IOActivity::kVerifyFileChecksums;
|
2023-09-15 15:30:44 +00:00
|
|
|
case ThreadStatus::OperationType::OP_GETENTITY:
|
|
|
|
return Env::IOActivity::kGetEntity;
|
|
|
|
case ThreadStatus::OperationType::OP_MULTIGETENTITY:
|
|
|
|
return Env::IOActivity::kMultiGetEntity;
|
2023-04-21 16:07:18 +00:00
|
|
|
default:
|
|
|
|
return Env::IOActivity::kUnknown;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-02-17 19:29:36 +00:00
|
|
|
#endif // !NDEBUG
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|