dolysis/rocksdb - Stateless Git Forge

dolysis/rocksdb

mirror of https://github.com/facebook/rocksdb.git synced 2024-11-25 14:31:35 +00:00

2 lines

110 B

Markdown

Raw Normal View History

Fix a case of ignored corruption in creating backups (#12200) Summary: We often need to read the table properties of an SST file when taking a backup. However, we currently do not check checksums for this step, and even with that enabled, we ignore failures. This change ensures we fail creating a backup if corruption is detected in that step of reading table properties. To get this working properly (with existing unit tests), we also add some temperature handling logic like already exists in BackupEngineImpl::ReadFileAndComputeChecksum and elsewhere in BackupEngine. Also, SstFileDumper needed a fix to its error handling logic. This was originally intended to help diagnose some mysterious failures (apparent corruptions) seen in taking backups in the crash test, though that is now fixed in https://github.com/facebook/rocksdb/pull/12206 Pull Request resolved: https://github.com/facebook/rocksdb/pull/12200 Test Plan: unit test added that corrupts table properties, along with existing tests Reviewed By: ajkr Differential Revision: D52520674 Pulled By: pdillinger fbshipit-source-id: 032cfc0791428f3b8147d34c7d424ab128e28f42

2024-01-05 17:48:19 +00:00

Fixed some cases in which DB file corruption was detected but ignored on creating a backup with BackupEngine.