2020-03-14 04:51:26 +00:00
version : 2.1
orbs :
2022-10-28 16:14:47 +00:00
win : circleci/windows@5.0.0
2020-09-23 21:40:53 +00:00
commands :
2020-12-05 07:22:18 +00:00
install-cmake-on-macos :
steps :
- run :
name : Install cmake on macos
command : |
HOMEBREW_NO_AUTO_UPDATE=1 brew install cmake
2022-01-13 01:19:41 +00:00
install-jdk8-on-macos :
steps :
- run :
name : Install JDK 8 on macos
command : |
2023-08-21 18:53:40 +00:00
HOMEBREW_NO_AUTO_UPDATE=1 brew tap bell-sw/liberica
HOMEBREW_NO_AUTO_UPDATE=1 brew install --cask liberica-jdk8
2022-01-13 01:19:41 +00:00
2020-10-12 17:45:21 +00:00
increase-max-open-files-on-macos :
steps :
- run :
name : Increase max open files
command : |
sudo sysctl -w kern.maxfiles=1048576
sudo sysctl -w kern.maxfilesperproc=1048576
sudo launchctl limit maxfiles 1048576
2020-09-23 21:40:53 +00:00
pre-steps :
steps :
- checkout
- run :
name : Setup Environment Variables
command : |
echo "export GTEST_THROW_ON_FAILURE=0" >> $BASH_ENV
echo "export GTEST_OUTPUT=\"xml:/tmp/test-results/\"" >> $BASH_ENV
echo "export SKIP_FORMAT_BUCK_CHECKS=1" >> $BASH_ENV
2021-06-01 21:42:06 +00:00
echo "export GTEST_COLOR=1" >> $BASH_ENV
echo "export CTEST_OUTPUT_ON_FAILURE=1" >> $BASH_ENV
echo "export CTEST_TEST_TIMEOUT=300" >> $BASH_ENV
2022-01-21 17:32:03 +00:00
echo "export ZLIB_DOWNLOAD_BASE=https://rocksdb-deps.s3.us-west-2.amazonaws.com/pkgs/zlib" >> $BASH_ENV
echo "export BZIP2_DOWNLOAD_BASE=https://rocksdb-deps.s3.us-west-2.amazonaws.com/pkgs/bzip2" >> $BASH_ENV
echo "export SNAPPY_DOWNLOAD_BASE=https://rocksdb-deps.s3.us-west-2.amazonaws.com/pkgs/snappy" >> $BASH_ENV
echo "export LZ4_DOWNLOAD_BASE=https://rocksdb-deps.s3.us-west-2.amazonaws.com/pkgs/lz4" >> $BASH_ENV
echo "export ZSTD_DOWNLOAD_BASE=https://rocksdb-deps.s3.us-west-2.amazonaws.com/pkgs/zstd" >> $BASH_ENV
2020-09-23 21:40:53 +00:00
2022-10-28 16:14:47 +00:00
windows-build-steps :
steps :
- checkout
- run :
name : "Install thirdparty dependencies"
command : |
echo "Installing CMake..."
choco install cmake --installargs 'ADD_CMAKE_TO_PATH=System' -y
2023-11-14 22:39:31 +00:00
choco install liberica8jdk -y
2022-10-28 16:14:47 +00:00
mkdir $Env:THIRDPARTY_HOME
cd $Env:THIRDPARTY_HOME
echo "Building Snappy dependency..."
curl https://github.com/google/snappy/archive/refs/tags/1.1.8.zip -O snappy-1.1.8.zip
unzip -q snappy-1.1.8.zip
cd snappy-1.1.8
mkdir build
cd build
& $Env:CMAKE_BIN -G "$Env:CMAKE_GENERATOR" ..
msbuild.exe Snappy.sln -maxCpuCount -property:Configuration=Debug -property:Platform=x64
- run :
name : "Build RocksDB"
command : |
2023-11-14 22:39:31 +00:00
$env:Path = $env:JAVA_HOME + ";" + $env:Path
2022-10-28 16:14:47 +00:00
mkdir build
cd build
2023-10-24 23:20:37 +00:00
& $Env:CMAKE_BIN -G "$Env:CMAKE_GENERATOR" -DCMAKE_BUILD_TYPE=Debug -DOPTDBG=1 -DPORTABLE="$Env:CMAKE_PORTABLE" -DSNAPPY=1 -DJNI=1 ..
2022-10-28 16:14:47 +00:00
cd ..
echo "Building with VS version: $Env:CMAKE_GENERATOR"
msbuild.exe build/rocksdb.sln -maxCpuCount -property:Configuration=Debug -property:Platform=x64
- run :
name : "Test RocksDB"
shell : powershell.exe
command : |
build_tools\run_ci_db_test.ps1 -SuiteRun arena_test,db_basic_test,db_test,db_test2,db_merge_operand_test,bloom_test,c_test,coding_test,crc32c_test,dynamic_bloom_test,env_basic_test,env_test,hash_test,random_test -Concurrency 16
2023-10-18 19:51:50 +00:00
- run :
name : "Test RocksJava"
command : |
cd build\java
& $Env:CTEST_BIN -C Debug -j 16
2020-12-16 23:58:56 +00:00
pre-steps-macos :
steps :
2022-01-21 17:32:03 +00:00
- pre-steps
2020-12-16 23:58:56 +00:00
2020-09-23 21:40:53 +00:00
post-steps :
steps :
- store_test_results : # store test result if there's any
path : /tmp/test-results
- store_artifacts : # store LOG for debugging if there's any
path : LOG
2021-01-08 01:11:50 +00:00
- run : # on fail, compress Test Logs for diagnosing the issue
2022-08-11 00:34:38 +00:00
name : Compress Test Logs
command : tar -cvzf t.tar.gz t
when : on_fail
2021-01-08 01:11:50 +00:00
- store_artifacts : # on fail, store Test Logs for diagnosing the issue
path : t.tar.gz
destination : test_logs
when : on_fail
2022-08-11 00:34:38 +00:00
- run : # store core dumps if there's any
2020-09-23 21:40:53 +00:00
command : |
2022-08-11 00:34:38 +00:00
mkdir -p /tmp/core_dumps
cp core.* /tmp/core_dumps
when : on_fail
- store_artifacts :
path : /tmp/core_dumps
when : on_fail
2022-01-11 18:35:22 +00:00
2023-10-17 17:04:35 +00:00
post-pmd-steps :
steps :
- store_artifacts :
path : /home/circleci/project/java/target/pmd.xml
when : on_fail
- store_artifacts :
path : /home/circleci/project/java/target/site
when : on_fail
2022-09-12 04:40:11 +00:00
upgrade-cmake :
steps :
- run :
name : Upgrade cmake
command : |
sudo apt remove --purge cmake
sudo snap install cmake --classic
2020-09-23 21:40:53 +00:00
install-gflags :
steps :
- run :
name : Install gflags
command : |
sudo apt-get update -y && sudo apt-get install -y libgflags-dev
2020-12-05 07:22:18 +00:00
2020-10-12 17:45:21 +00:00
install-gflags-on-macos :
steps :
- run :
name : Install gflags on macos
command : |
HOMEBREW_NO_AUTO_UPDATE=1 brew install gflags
2020-09-23 21:40:53 +00:00
2023-10-17 17:04:35 +00:00
install-maven :
steps :
- run :
name : Install maven
command : |
sudo apt-get update -y && sudo apt-get install -y maven
2022-06-17 20:08:45 +00:00
setup-folly :
steps :
- run :
name : Checkout folly sources
command : |
make checkout_folly
2022-02-01 18:29:56 +00:00
2022-09-12 04:40:11 +00:00
build-folly :
steps :
- run :
name : Build folly and dependencies
command : |
make build_folly
2022-06-04 16:31:47 +00:00
build-for-benchmarks :
steps :
- pre-steps
- run :
name : "Linux build for benchmarks"
command : #sized for the resource-class rocksdb-benchmark-sys1
make V=1 J=8 -j8 release
perform-benchmarks :
steps :
- run :
2022-07-25 21:44:10 +00:00
name : "Test low-variance benchmarks"
2023-02-02 19:11:40 +00:00
command : ./tools/benchmark_ci.py --db_dir /tmp/rocksdb-benchmark-datadir --output_dir /tmp/benchmark-results --num_keys 20000000
2022-06-04 16:31:47 +00:00
environment :
LD_LIBRARY_PATH : /usr/local/lib
2022-07-25 21:44:10 +00:00
# How long to run parts of the test(s)
2023-02-06 19:13:39 +00:00
DURATION_RO : 300
DURATION_RW : 500
2022-08-25 16:47:03 +00:00
# Keep threads within physical capacity of server (much lower than default)
NUM_THREADS : 1
2023-02-02 19:11:40 +00:00
MAX_BACKGROUND_JOBS : 4
2022-08-25 16:47:03 +00:00
# Don't run a couple of "optional" initial tests
CI_TESTS_ONLY : "true"
# Reduce configured size of levels to ensure more levels in the leveled compaction LSM tree
WRITE_BUFFER_SIZE_MB : 16
TARGET_FILE_SIZE_BASE_MB : 16
MAX_BYTES_FOR_LEVEL_BASE_MB : 64
2022-07-25 21:44:10 +00:00
# The benchmark host has 32GB memory
2022-08-25 16:47:03 +00:00
# The following values are tailored to work with that
2022-07-25 21:44:10 +00:00
# Note, tests may not exercise the targeted issues if the memory is increased on new test hosts.
2023-02-02 19:11:40 +00:00
COMPRESSION_TYPE : "none"
CACHE_INDEX_AND_FILTER_BLOCKS : 1
MIN_LEVEL_TO_COMPRESS : 3
CACHE_SIZE_MB : 10240
MB_WRITE_PER_SEC : 2
2022-06-04 16:31:47 +00:00
post-benchmarks :
steps :
- store_artifacts : # store the benchmark output
path : /tmp/benchmark-results
destination : test_logs
- run :
name : Send benchmark report to visualisation
2022-06-22 16:26:13 +00:00
command : |
set +e
set +o pipefail
2022-07-25 21:44:10 +00:00
./build_tools/benchmark_log_tool.py --tsvfile /tmp/benchmark-results/report.tsv --esdocument https://search-rocksdb-bench-k2izhptfeap2hjfxteolsgsynm.us-west-2.es.amazonaws.com/bench_test3_rix/_doc
2022-06-22 16:26:13 +00:00
true
2022-06-04 16:31:47 +00:00
2020-03-14 04:51:26 +00:00
executors :
2022-08-11 00:34:38 +00:00
linux-docker :
docker :
# The image configuration is build_tools/ubuntu20_image/Dockerfile
# To update and build the image:
# $ cd build_tools/ubuntu20_image
# $ docker build -t zjay437/rocksdb:0.5 .
# $ docker push zjay437/rocksdb:0.5
# `zjay437` is the account name for zjay@meta.com which readwrite token is shared internally. To login:
# $ docker login --username zjay437
# Or please feel free to change it to your docker hub account for hosting the image, meta employee should already have the account and able to login with SSO.
# To avoid impacting the existing CI runs, please bump the version every time creating a new image
# to run the CI image environment locally:
# $ docker run --cap-add=SYS_PTRACE --security-opt seccomp=unconfined -it zjay437/rocksdb:0.5 bash
# option `--cap-add=SYS_PTRACE --security-opt seccomp=unconfined` is used to enable gdb to attach an existing process
2022-09-12 04:40:11 +00:00
- image : zjay437/rocksdb:0.6
2023-10-31 19:23:34 +00:00
linux-java-docker :
docker :
- image : evolvedbinary/rocksjava:centos6_x64-be
2020-03-14 04:51:26 +00:00
jobs :
2020-10-12 17:45:21 +00:00
build-macos :
macos :
2023-08-21 18:53:40 +00:00
xcode : 14.3 .1
resource_class : macos.m1.medium.gen1
2022-01-20 17:40:34 +00:00
environment :
2022-01-21 17:32:03 +00:00
ROCKSDB_DISABLE_JEMALLOC : 1 # jemalloc cause env_test hang, disable it for now
2020-10-12 17:45:21 +00:00
steps :
- increase-max-open-files-on-macos
- install-gflags-on-macos
2020-12-16 23:58:56 +00:00
- pre-steps-macos
2023-08-21 18:53:40 +00:00
- run : ulimit -S -n `ulimit -H -n` && OPT=-DCIRCLECI make V=1 J=16 -j16 all
2020-10-12 17:45:21 +00:00
- post-steps
2020-12-05 07:22:18 +00:00
build-macos-cmake :
macos :
2023-08-21 18:53:40 +00:00
xcode : 14.3 .1
resource_class : macos.m1.medium.gen1
2022-03-03 19:58:51 +00:00
parameters :
run_even_tests :
description : run even or odd tests, used to split tests to 2 groups
type : boolean
default : true
2020-12-05 07:22:18 +00:00
steps :
- increase-max-open-files-on-macos
- install-cmake-on-macos
- install-gflags-on-macos
2020-12-16 23:58:56 +00:00
- pre-steps-macos
2022-03-03 19:58:51 +00:00
- run :
name : "cmake generate project file"
2022-05-10 16:51:03 +00:00
command : ulimit -S -n `ulimit -H -n` && mkdir build && cd build && cmake -DWITH_GFLAGS=1 ..
2022-03-03 19:58:51 +00:00
- run :
name : "Build tests"
2023-08-21 18:53:40 +00:00
command : cd build && make V=1 -j16
2022-03-03 19:58:51 +00:00
- when :
condition : << parameters.run_even_tests >>
steps :
- run :
name : "Run even tests"
2023-08-21 18:53:40 +00:00
command : ulimit -S -n `ulimit -H -n` && cd build && ctest -j16 -I 0,,2
2022-03-03 19:58:51 +00:00
- when :
condition :
not : << parameters.run_even_tests >>
steps :
- run :
name : "Run odd tests"
2023-08-21 18:53:40 +00:00
command : ulimit -S -n `ulimit -H -n` && cd build && ctest -j16 -I 1,,2
2020-12-05 07:22:18 +00:00
- post-steps
2020-06-09 02:32:18 +00:00
build-linux :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-06-09 02:32:18 +00:00
resource_class : 2xlarge
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-02-05 01:12:03 +00:00
- run : make V=1 J=32 -j32 check
2020-09-23 21:40:53 +00:00
- post-steps
Major CircleCI/Linux fixes / tweaks / enhancements (#7078)
Summary:
Primarily, this change adds a way to work around a bug limiting the effective output (and therefore debugability) of the Linux builds using parallel make. We would get
make[1]: write error: stdout
probably due to a kernel bug, apparently affecting both available ubuntu 16 machine images (maybe not affecting docker images, less horsepower). https://bugs.launchpad.net/ubuntu/+source/linux-signed/+bug/1814393
Now in the CircleCI config, make output on Ubuntu is piped through a custom 'cat' that ignores EAGAIN errors, which seems to fix the problem.
Significant other changes:
* Add another linux build that combines
* LIB_MODE=shared, to ensure this works with compile and unit test execution
* Alternative rocksdb namespace, to ensure this works (not rely on Travis)
* ASSERT_STATUS_CHECKED=1, but with building all unit tests and running those expected to pass with it
* Run release build with and without gflags. (Was running only without, ignore large swaths of code in a normal release build! Two regressions in this build, only with gflags, in the last week not caught by CI!)
* Use gflags with unity and LITE build, as typical case.
Debugability improvements:
* Use V=1 to show commands being executed (thanks to EAGAIN work-around)
* Print kernel version and compiler versions as part of V=1 output from Makefile
Cosmetic other changes:
* Put more commands on one line, for less clutter in CircleCI output pages
* Remove redundant "all" in "make all check" and put make command options before targets
* Change some recursive "make clean" into dependency on "clean," toward minimizing unnecessary overhead (detect platform, build version, etc.) of extra recursive makes
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7078
Reviewed By: siying
Differential Revision: D22391647
Pulled By: pdillinger
fbshipit-source-id: d446fccf5a8c568b37dc8748621c8a5c546fe135
2020-07-07 18:24:00 +00:00
2022-04-18 19:47:16 +00:00
build-linux-encrypted_env-no_compression :
2022-08-11 00:34:38 +00:00
executor : linux-docker
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
resource_class : 2xlarge
steps :
- pre-steps
2022-04-18 19:47:16 +00:00
- run : ENCRYPTED_ENV=1 ROCKSDB_DISABLE_SNAPPY=1 ROCKSDB_DISABLE_ZLIB=1 ROCKSDB_DISABLE_BZIP=1 ROCKSDB_DISABLE_LZ4=1 ROCKSDB_DISABLE_ZSTD=1 make V=1 J=32 -j32 check
- run : |
2022-09-22 23:58:21 +00:00
./sst_dump --help | grep -E -q 'Supported compression types : kNoCompression$' # Verify no compiled in compression
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
- post-steps
2023-02-03 23:28:52 +00:00
build-linux-static_lib-alt_namespace-status_checked :
2022-08-11 00:34:38 +00:00
executor : linux-docker
Major CircleCI/Linux fixes / tweaks / enhancements (#7078)
Summary:
Primarily, this change adds a way to work around a bug limiting the effective output (and therefore debugability) of the Linux builds using parallel make. We would get
make[1]: write error: stdout
probably due to a kernel bug, apparently affecting both available ubuntu 16 machine images (maybe not affecting docker images, less horsepower). https://bugs.launchpad.net/ubuntu/+source/linux-signed/+bug/1814393
Now in the CircleCI config, make output on Ubuntu is piped through a custom 'cat' that ignores EAGAIN errors, which seems to fix the problem.
Significant other changes:
* Add another linux build that combines
* LIB_MODE=shared, to ensure this works with compile and unit test execution
* Alternative rocksdb namespace, to ensure this works (not rely on Travis)
* ASSERT_STATUS_CHECKED=1, but with building all unit tests and running those expected to pass with it
* Run release build with and without gflags. (Was running only without, ignore large swaths of code in a normal release build! Two regressions in this build, only with gflags, in the last week not caught by CI!)
* Use gflags with unity and LITE build, as typical case.
Debugability improvements:
* Use V=1 to show commands being executed (thanks to EAGAIN work-around)
* Print kernel version and compiler versions as part of V=1 output from Makefile
Cosmetic other changes:
* Put more commands on one line, for less clutter in CircleCI output pages
* Remove redundant "all" in "make all check" and put make command options before targets
* Change some recursive "make clean" into dependency on "clean," toward minimizing unnecessary overhead (detect platform, build version, etc.) of extra recursive makes
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7078
Reviewed By: siying
Differential Revision: D22391647
Pulled By: pdillinger
fbshipit-source-id: d446fccf5a8c568b37dc8748621c8a5c546fe135
2020-07-07 18:24:00 +00:00
resource_class : 2xlarge
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2023-02-09 01:00:46 +00:00
- run : ASSERT_STATUS_CHECKED=1 TEST_UINT128_COMPAT=1 ROCKSDB_MODIFY_NPHASH=1 LIB_MODE=static OPT="-DROCKSDB_NAMESPACE=alternative_rocksdb_ns" make V=1 -j24 check
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-09 02:32:18 +00:00
build-linux-release :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-03-03 19:58:51 +00:00
resource_class : 2xlarge
2020-06-09 02:32:18 +00:00
steps :
- checkout # check out the code in the project directory
2023-02-03 23:28:52 +00:00
- run : make V=1 -j32 LIB_MODE=shared release
2023-02-07 19:26:55 +00:00
- run : ls librocksdb.so # ensure shared lib built
2023-02-03 23:28:52 +00:00
- run : ./db_stress --version # ensure with gflags
- run : make clean
2023-02-07 19:26:55 +00:00
- run : make V=1 -j32 release
- run : ls librocksdb.a # ensure static lib built
Major CircleCI/Linux fixes / tweaks / enhancements (#7078)
Summary:
Primarily, this change adds a way to work around a bug limiting the effective output (and therefore debugability) of the Linux builds using parallel make. We would get
make[1]: write error: stdout
probably due to a kernel bug, apparently affecting both available ubuntu 16 machine images (maybe not affecting docker images, less horsepower). https://bugs.launchpad.net/ubuntu/+source/linux-signed/+bug/1814393
Now in the CircleCI config, make output on Ubuntu is piped through a custom 'cat' that ignores EAGAIN errors, which seems to fix the problem.
Significant other changes:
* Add another linux build that combines
* LIB_MODE=shared, to ensure this works with compile and unit test execution
* Alternative rocksdb namespace, to ensure this works (not rely on Travis)
* ASSERT_STATUS_CHECKED=1, but with building all unit tests and running those expected to pass with it
* Run release build with and without gflags. (Was running only without, ignore large swaths of code in a normal release build! Two regressions in this build, only with gflags, in the last week not caught by CI!)
* Use gflags with unity and LITE build, as typical case.
Debugability improvements:
* Use V=1 to show commands being executed (thanks to EAGAIN work-around)
* Print kernel version and compiler versions as part of V=1 output from Makefile
Cosmetic other changes:
* Put more commands on one line, for less clutter in CircleCI output pages
* Remove redundant "all" in "make all check" and put make command options before targets
* Change some recursive "make clean" into dependency on "clean," toward minimizing unnecessary overhead (detect platform, build version, etc.) of extra recursive makes
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7078
Reviewed By: siying
Differential Revision: D22391647
Pulled By: pdillinger
fbshipit-source-id: d446fccf5a8c568b37dc8748621c8a5c546fe135
2020-07-07 18:24:00 +00:00
- run : ./db_stress --version # ensure with gflags
2022-08-11 00:34:38 +00:00
- run : make clean
- run : apt-get remove -y libgflags-dev
2023-02-03 23:28:52 +00:00
- run : make V=1 -j32 LIB_MODE=shared release
2023-02-07 19:26:55 +00:00
- run : ls librocksdb.so # ensure shared lib built
2023-02-03 23:28:52 +00:00
- run : if ./db_stress --version; then false; else true; fi # ensure without gflags
- run : make clean
2023-02-07 19:26:55 +00:00
- run : make V=1 -j32 release
- run : ls librocksdb.a # ensure static lib built
2022-08-11 00:34:38 +00:00
- run : if ./db_stress --version; then false; else true; fi # ensure without gflags
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-09 02:32:18 +00:00
2020-09-22 17:26:34 +00:00
build-linux-release-rtti :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-03-03 19:58:51 +00:00
resource_class : xlarge
2020-09-22 17:26:34 +00:00
steps :
- checkout # check out the code in the project directory
2022-03-03 19:58:51 +00:00
- run : USE_RTTI=1 DEBUG_LEVEL=0 make V=1 -j16 static_lib tools db_bench
2022-08-11 00:34:38 +00:00
- run : ./db_stress --version # ensure with gflags
2020-09-22 17:26:34 +00:00
- run : make clean
2022-08-11 00:34:38 +00:00
- run : apt-get remove -y libgflags-dev
2022-03-03 19:58:51 +00:00
- run : USE_RTTI=1 DEBUG_LEVEL=0 make V=1 -j16 static_lib tools db_bench
2022-08-11 00:34:38 +00:00
- run : if ./db_stress --version; then false; else true; fi # ensure without gflags
2020-09-22 17:26:34 +00:00
2020-12-22 08:19:44 +00:00
build-linux-clang-no_test_run :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-12-22 08:19:44 +00:00
resource_class : xlarge
2020-06-09 02:32:18 +00:00
steps :
- checkout # check out the code in the project directory
2022-02-05 01:12:03 +00:00
- run : CC=clang CXX=clang++ USE_CLANG=1 PORTABLE=1 make V=1 -j16 all
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-24 23:20:55 +00:00
2020-06-26 00:40:08 +00:00
build-linux-clang10-asan :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-06-26 00:40:08 +00:00
resource_class : 2xlarge
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-04-19 03:26:37 +00:00
- run : COMPILE_WITH_ASAN=1 CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 make V=1 -j32 check # aligned new doesn't work for reason we haven't figured out
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-26 00:40:08 +00:00
2020-07-14 22:31:57 +00:00
build-linux-clang10-mini-tsan :
2022-08-11 00:34:38 +00:00
executor : linux-docker
resource_class : 2xlarge+
2020-07-14 22:31:57 +00:00
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-08-11 00:34:38 +00:00
- run : COMPILE_WITH_TSAN=1 CC=clang-13 CXX=clang++-13 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 make V=1 -j32 check
2020-09-23 21:40:53 +00:00
- post-steps
2020-07-14 22:31:57 +00:00
2020-07-11 03:02:16 +00:00
build-linux-clang10-ubsan :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-07-11 03:02:16 +00:00
resource_class : 2xlarge
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-02-05 01:12:03 +00:00
- run : COMPILE_WITH_UBSAN=1 OPT="-fsanitize-blacklist=.circleci/ubsan_suppression_list.txt" CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 USE_CLANG=1 make V=1 -j32 ubsan_check # aligned new doesn't work for reason we haven't figured out
2020-09-23 21:40:53 +00:00
- post-steps
2020-07-11 03:02:16 +00:00
2022-04-19 03:26:37 +00:00
build-linux-valgrind :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-04-19 03:26:37 +00:00
resource_class : 2xlarge
steps :
- pre-steps
- run : PORTABLE=1 make V=1 -j32 valgrind_test
- post-steps
2020-07-13 19:31:41 +00:00
build-linux-clang10-clang-analyze :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-07-13 19:31:41 +00:00
resource_class : 2xlarge
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-02-05 01:12:03 +00:00
- run : CC=clang-10 CXX=clang++-10 ROCKSDB_DISABLE_ALIGNED_NEW=1 CLANG_ANALYZER="/usr/bin/clang++-10" CLANG_SCAN_BUILD=scan-build-10 USE_CLANG=1 make V=1 -j32 analyze # aligned new doesn't work for reason we haven't figured out. For unknown, reason passing "clang++-10" as CLANG_ANALYZER doesn't work, and we need a full path.
2020-09-23 21:40:53 +00:00
- post-steps
2022-08-11 00:34:38 +00:00
- run :
name : "compress test report"
command : tar -cvzf scan_build_report.tar.gz scan_build_report
when : on_fail
- store_artifacts :
path : scan_build_report.tar.gz
destination : scan_build_report
when : on_fail
2020-07-13 19:31:41 +00:00
2022-06-04 16:31:47 +00:00
build-linux-runner :
machine : true
resource_class : facebook/rocksdb-benchmark-sys1
steps :
- pre-steps
- run :
name : "Checked Linux build (Runner)"
command : make V=1 J=8 -j8 check
environment :
LD_LIBRARY_PATH : /usr/local/lib
- post-steps
Meta-internal folly integration with F14FastMap (#9546)
Summary:
Especially after updating to C++17, I don't see a compelling case for
*requiring* any folly components in RocksDB. I was able to purge the existing
hard dependencies, and it can be quite difficult to strip out non-trivial components
from folly for use in RocksDB. (The prospect of doing that on F14 has changed
my mind on the best approach here.)
But this change creates an optional integration where we can plug in
components from folly at compile time, starting here with F14FastMap to replace
std::unordered_map when possible (probably no public APIs for example). I have
replaced the biggest CPU users of std::unordered_map with compile-time
pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set.
USE_FOLLY is always set in the Meta-internal buck build, and a simulation of
that is in the Makefile for public CI testing. A full folly build is not needed, but
checking out the full folly repo is much simpler for getting the dependency,
and anything else we might want to optionally integrate in the future.
Some picky details:
* I don't think the distributed mutex stuff is actually used, so it was easy to remove.
* I implemented an alternative to `folly::constexpr_log2` (which is much easier
in C++17 than C++11) so that I could pull out the hard dependencies on
`ConstexprMath.h`
* I had to add noexcept move constructors/operators to some types to make
F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a
macro to make that easier in some common cases.
* Updated Meta-internal buck build to use folly F14Map (always)
No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a
production integration for open source users.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546
Test Plan:
CircleCI tests updated so that a couple of them use folly.
Most internal unit & stress/crash tests updated to use Meta-internal latest folly.
(Note: they should probably use buck but they currently use Makefile.)
Example performance improvement: when filter partitions are pinned in cache,
they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build
a test that exercises that heavily. Build DB with
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters
```
and test with (simultaneous runs with & without folly, ~20 times each to see
convergence)
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache
```
Average ops/s no folly: 26229.2
Average ops/s with folly: 26853.3 (+2.4%)
Reviewed By: ajkr
Differential Revision: D34181736
Pulled By: pdillinger
fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
2022-04-13 14:34:01 +00:00
build-linux-cmake-with-folly :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2021-06-01 21:42:06 +00:00
resource_class : 2xlarge
steps :
2021-07-15 20:36:48 +00:00
- pre-steps
2022-06-17 20:08:45 +00:00
- setup-folly
2022-09-12 04:40:11 +00:00
- build-folly
- run : (mkdir build && cd build && cmake -DUSE_FOLLY=1 -DWITH_GFLAGS=1 -DROCKSDB_BUILD_SHARED=0 .. && make V=1 -j20 && ctest -j20)
- post-steps
build-linux-cmake-with-folly-lite-no-test :
executor : linux-docker
resource_class : 2xlarge
steps :
- pre-steps
- setup-folly
- run : (mkdir build && cd build && cmake -DUSE_FOLLY_LITE=1 -DWITH_GFLAGS=1 .. && make V=1 -j20)
2021-06-01 21:42:06 +00:00
- post-steps
Meta-internal folly integration with F14FastMap (#9546)
Summary:
Especially after updating to C++17, I don't see a compelling case for
*requiring* any folly components in RocksDB. I was able to purge the existing
hard dependencies, and it can be quite difficult to strip out non-trivial components
from folly for use in RocksDB. (The prospect of doing that on F14 has changed
my mind on the best approach here.)
But this change creates an optional integration where we can plug in
components from folly at compile time, starting here with F14FastMap to replace
std::unordered_map when possible (probably no public APIs for example). I have
replaced the biggest CPU users of std::unordered_map with compile-time
pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set.
USE_FOLLY is always set in the Meta-internal buck build, and a simulation of
that is in the Makefile for public CI testing. A full folly build is not needed, but
checking out the full folly repo is much simpler for getting the dependency,
and anything else we might want to optionally integrate in the future.
Some picky details:
* I don't think the distributed mutex stuff is actually used, so it was easy to remove.
* I implemented an alternative to `folly::constexpr_log2` (which is much easier
in C++17 than C++11) so that I could pull out the hard dependencies on
`ConstexprMath.h`
* I had to add noexcept move constructors/operators to some types to make
F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a
macro to make that easier in some common cases.
* Updated Meta-internal buck build to use folly F14Map (always)
No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a
production integration for open source users.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546
Test Plan:
CircleCI tests updated so that a couple of them use folly.
Most internal unit & stress/crash tests updated to use Meta-internal latest folly.
(Note: they should probably use buck but they currently use Makefile.)
Example performance improvement: when filter partitions are pinned in cache,
they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build
a test that exercises that heavily. Build DB with
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters
```
and test with (simultaneous runs with & without folly, ~20 times each to see
convergence)
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache
```
Average ops/s no folly: 26229.2
Average ops/s with folly: 26853.3 (+2.4%)
Reviewed By: ajkr
Differential Revision: D34181736
Pulled By: pdillinger
fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
2022-04-13 14:34:01 +00:00
build-linux-cmake-with-benchmark :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2021-06-01 21:42:06 +00:00
resource_class : 2xlarge
2020-06-09 02:32:18 +00:00
steps :
2021-07-15 20:36:48 +00:00
- pre-steps
2022-08-11 00:34:38 +00:00
- run : mkdir build && cd build && cmake -DWITH_GFLAGS=1 -DWITH_BENCHMARK=1 .. && make V=1 -j20 && ctest -j20
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-09 02:32:18 +00:00
2021-09-10 16:59:05 +00:00
build-linux-unity-and-headers :
2020-06-26 18:12:06 +00:00
docker : # executor type
- image : gcc:latest
Avoid some warnings-as-error in CircleCI+unity+AVX512F (#9978)
Summary:
Example failure when compiling on sufficiently new hardware and built-in headers:
```
In file included from /usr/local/lib/gcc/x86_64-linux-gnu/12.1.0/include/immintrin.h:49,
from ./util/bloom_impl.h:21,
from table/block_based/filter_policy.cc:31,
from unity.cc:167:
In function '__m512i _mm512_shuffle_epi32(__m512i, _MM_PERM_ENUM)',
inlined from 'void XXH3_accumulate_512_avx512(void*, const void*, const void*)' at util/xxhash.h:3605:58,
inlined from 'void XXH3_accumulate(xxh_u64*, const xxh_u8*, const xxh_u8*, size_t, XXH3_f_accumulate_512)' at util/xxhash.h:4229:17,
inlined from 'void XXH3_hashLong_internal_loop(xxh_u64*, const xxh_u8*, size_t, const xxh_u8*, size_t, XXH3_f_accumulate_512, XXH3_f_scrambleAcc)' at util/xxhash.h:4251:24,
inlined from 'XXH128_hash_t XXH3_hashLong_128b_internal(const void*, size_t, const xxh_u8*, size_t, XXH3_f_accumulate_512, XXH3_f_scrambleAcc)' at util/xxhash.h:5065:32,
inlined from 'XXH128_hash_t XXH3_hashLong_128b_withSecret(const void*, size_t, XXH64_hash_t, const void*, size_t)' at util/xxhash.h:5104:39:
/usr/local/lib/gcc/x86_64-linux-gnu/12.1.0/include/avx512fintrin.h:4459:50: error: '__Y' may be used uninitialized [-Werror=maybe-uninitialized]
```
https://app.circleci.com/pipelines/github/facebook/rocksdb/13295/workflows/1695fb5c-40c1-423b-96b4-45107dc3012d/jobs/360416
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9978
Test Plan:
I was able to re-run in CircleCI with ssh, see the failure, ssh in and
verify that adding -fno-avx512f fixed the failure. Will watch build-linux-unity-and-headers
Reviewed By: riversand963
Differential Revision: D36296028
Pulled By: pdillinger
fbshipit-source-id: ba5955cf2ac730f57d1d18c2f517e92f34be77a3
2022-05-10 22:24:40 +00:00
environment :
EXTRA_CXXFLAGS : -mno-avx512f # Warnings-as-error in avx512fintrin.h, would be used on newer hardware
2020-12-22 08:19:44 +00:00
resource_class : large
2020-06-26 18:12:06 +00:00
steps :
- checkout # check out the code in the project directory
Major CircleCI/Linux fixes / tweaks / enhancements (#7078)
Summary:
Primarily, this change adds a way to work around a bug limiting the effective output (and therefore debugability) of the Linux builds using parallel make. We would get
make[1]: write error: stdout
probably due to a kernel bug, apparently affecting both available ubuntu 16 machine images (maybe not affecting docker images, less horsepower). https://bugs.launchpad.net/ubuntu/+source/linux-signed/+bug/1814393
Now in the CircleCI config, make output on Ubuntu is piped through a custom 'cat' that ignores EAGAIN errors, which seems to fix the problem.
Significant other changes:
* Add another linux build that combines
* LIB_MODE=shared, to ensure this works with compile and unit test execution
* Alternative rocksdb namespace, to ensure this works (not rely on Travis)
* ASSERT_STATUS_CHECKED=1, but with building all unit tests and running those expected to pass with it
* Run release build with and without gflags. (Was running only without, ignore large swaths of code in a normal release build! Two regressions in this build, only with gflags, in the last week not caught by CI!)
* Use gflags with unity and LITE build, as typical case.
Debugability improvements:
* Use V=1 to show commands being executed (thanks to EAGAIN work-around)
* Print kernel version and compiler versions as part of V=1 output from Makefile
Cosmetic other changes:
* Put more commands on one line, for less clutter in CircleCI output pages
* Remove redundant "all" in "make all check" and put make command options before targets
* Change some recursive "make clean" into dependency on "clean," toward minimizing unnecessary overhead (detect platform, build version, etc.) of extra recursive makes
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7078
Reviewed By: siying
Differential Revision: D22391647
Pulled By: pdillinger
fbshipit-source-id: d446fccf5a8c568b37dc8748621c8a5c546fe135
2020-07-07 18:24:00 +00:00
- run : apt-get update -y && apt-get install -y libgflags-dev
2023-02-06 22:35:15 +00:00
- run :
name : "Unity build"
command : make V=1 -j8 unity_test
no_output_timeout : 20m
2022-02-05 01:12:03 +00:00
- run : make V=1 -j8 -k check-headers # could be moved to a different build
2020-09-23 21:40:53 +00:00
- post-steps
2020-06-26 18:12:06 +00:00
Meta-internal folly integration with F14FastMap (#9546)
Summary:
Especially after updating to C++17, I don't see a compelling case for
*requiring* any folly components in RocksDB. I was able to purge the existing
hard dependencies, and it can be quite difficult to strip out non-trivial components
from folly for use in RocksDB. (The prospect of doing that on F14 has changed
my mind on the best approach here.)
But this change creates an optional integration where we can plug in
components from folly at compile time, starting here with F14FastMap to replace
std::unordered_map when possible (probably no public APIs for example). I have
replaced the biggest CPU users of std::unordered_map with compile-time
pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set.
USE_FOLLY is always set in the Meta-internal buck build, and a simulation of
that is in the Makefile for public CI testing. A full folly build is not needed, but
checking out the full folly repo is much simpler for getting the dependency,
and anything else we might want to optionally integrate in the future.
Some picky details:
* I don't think the distributed mutex stuff is actually used, so it was easy to remove.
* I implemented an alternative to `folly::constexpr_log2` (which is much easier
in C++17 than C++11) so that I could pull out the hard dependencies on
`ConstexprMath.h`
* I had to add noexcept move constructors/operators to some types to make
F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a
macro to make that easier in some common cases.
* Updated Meta-internal buck build to use folly F14Map (always)
No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a
production integration for open source users.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546
Test Plan:
CircleCI tests updated so that a couple of them use folly.
Most internal unit & stress/crash tests updated to use Meta-internal latest folly.
(Note: they should probably use buck but they currently use Makefile.)
Example performance improvement: when filter partitions are pinned in cache,
they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build
a test that exercises that heavily. Build DB with
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters
```
and test with (simultaneous runs with & without folly, ~20 times each to see
convergence)
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache
```
Average ops/s no folly: 26229.2
Average ops/s with folly: 26853.3 (+2.4%)
Reviewed By: ajkr
Differential Revision: D34181736
Pulled By: pdillinger
fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
2022-04-13 14:34:01 +00:00
build-linux-gcc-7-with-folly :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-02-05 01:12:03 +00:00
resource_class : 2xlarge
2020-09-08 19:08:05 +00:00
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-06-17 20:08:45 +00:00
- setup-folly
2022-09-12 04:40:11 +00:00
- build-folly
2023-02-03 23:28:52 +00:00
- run: USE_FOLLY=1 LIB_MODE=static CC=gcc-7 CXX=g++-7 V=1 make -j32 check # TODO : LIB_MODE only to work around unresolved linker failures
2020-12-22 08:19:44 +00:00
- post-steps
2022-09-12 04:40:11 +00:00
build-linux-gcc-7-with-folly-lite-no-test :
executor : linux-docker
resource_class : 2xlarge
steps :
- pre-steps
- setup-folly
- run : USE_FOLLY_LITE=1 CC=gcc-7 CXX=g++-7 V=1 make -j32 all
- post-steps
2020-12-22 08:19:44 +00:00
build-linux-gcc-8-no_test_run :
2022-08-11 00:34:38 +00:00
executor : linux-docker
resource_class : 2xlarge
2020-12-22 08:19:44 +00:00
steps :
- pre-steps
2022-08-11 00:34:38 +00:00
- run : CC=gcc-8 CXX=g++-8 V=1 make -j32 all
2020-12-22 08:19:44 +00:00
- post-steps
2022-09-12 04:40:11 +00:00
build-linux-cmake-with-folly-coroutines :
executor : linux-docker
resource_class : 2xlarge
environment :
CC : gcc-10
CXX : g++-10
steps :
- pre-steps
- setup-folly
- build-folly
- run : (mkdir build && cd build && cmake -DUSE_COROUTINES=1 -DWITH_GFLAGS=1 -DROCKSDB_BUILD_SHARED=0 .. && make V=1 -j20 && ctest -j20)
- post-steps
2020-12-22 08:19:44 +00:00
build-linux-gcc-10-cxx20-no_test_run :
2022-08-11 00:34:38 +00:00
executor : linux-docker
resource_class : 2xlarge
2020-12-22 08:19:44 +00:00
steps :
- pre-steps
2022-08-11 00:34:38 +00:00
- run : CC=gcc-10 CXX=g++-10 V=1 ROCKSDB_CXX_STANDARD=c++20 make -j32 all
2020-09-23 21:40:53 +00:00
- post-steps
2020-09-08 19:08:05 +00:00
2021-10-18 19:21:25 +00:00
build-linux-gcc-11-no_test_run :
2022-08-11 00:34:38 +00:00
executor : linux-docker
resource_class : 2xlarge
2021-10-18 19:21:25 +00:00
steps :
- pre-steps
2023-02-03 23:28:52 +00:00
- run: LIB_MODE=static CC=gcc-11 CXX=g++-11 V=1 make -j32 all microbench # TODO : LIB_MODE only to work around unresolved linker failures
2021-10-18 19:21:25 +00:00
- post-steps
2022-01-11 18:35:22 +00:00
build-linux-clang-13-no_test_run :
2022-08-11 00:34:38 +00:00
executor : linux-docker
resource_class : 2xlarge
2022-01-11 18:35:22 +00:00
steps :
- pre-steps
2022-08-11 00:34:38 +00:00
- run : CC=clang-13 CXX=clang++-13 USE_CLANG=1 make -j32 all microbench
2022-01-11 18:35:22 +00:00
- post-steps
2022-04-19 03:26:37 +00:00
# Ensure ASAN+UBSAN with folly, and full testsuite with clang 13
build-linux-clang-13-asan-ubsan-with-folly :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-04-19 03:26:37 +00:00
resource_class : 2xlarge
steps :
- pre-steps
2022-06-17 20:08:45 +00:00
- setup-folly
2022-09-12 04:40:11 +00:00
- build-folly
2023-02-06 22:35:15 +00:00
- run: CC=clang-13 CXX=clang++-13 LIB_MODE=static USE_CLANG=1 USE_FOLLY=1 COMPILE_WITH_UBSAN=1 COMPILE_WITH_ASAN=1 make -j32 check # TODO : LIB_MODE only to work around unresolved linker failures
2022-04-19 03:26:37 +00:00
- post-steps
2021-07-09 00:50:55 +00:00
# This job is only to make sure the microbench tests are able to run, the benchmark result is not meaningful as the CI host is changing.
2022-03-03 19:58:51 +00:00
build-linux-run-microbench :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-03-03 19:58:51 +00:00
resource_class : 2xlarge
2021-07-09 00:50:55 +00:00
steps :
- pre-steps
2023-02-07 19:26:55 +00:00
- run : DEBUG_LEVEL=0 make -j32 run_microbench
2021-07-09 00:50:55 +00:00
- post-steps
2022-03-16 22:58:06 +00:00
build-linux-mini-crashtest :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-03-16 22:58:06 +00:00
resource_class : large
steps :
- pre-steps
2023-02-21 20:53:55 +00:00
- run : ulimit -S -n `ulimit -H -n` && make V=1 -j8 CRASH_TEST_EXT_ARGS='--duration=960 --max_key=2500000 --use_io_uring=0' blackbox_crash_test_with_atomic_flush
2022-03-16 22:58:06 +00:00
- post-steps
2022-08-08 20:08:35 +00:00
build-linux-crashtest-tiered-storage-bb :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-08-08 20:08:35 +00:00
resource_class : 2xlarge
steps :
- pre-steps
- run :
name : "run crashtest"
2023-02-21 20:53:55 +00:00
command : ulimit -S -n `ulimit -H -n` && make V=1 -j32 CRASH_TEST_EXT_ARGS='--duration=10800 --use_io_uring=0' blackbox_crash_test_with_tiered_storage
2022-08-08 20:08:35 +00:00
no_output_timeout : 100m
- post-steps
build-linux-crashtest-tiered-storage-wb :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-08-08 20:08:35 +00:00
resource_class : 2xlarge
steps :
- pre-steps
- run :
name : "run crashtest"
2023-02-21 20:53:55 +00:00
command : ulimit -S -n `ulimit -H -n` && make V=1 -j32 CRASH_TEST_EXT_ARGS='--duration=10800 --use_io_uring=0' whitebox_crash_test_with_tiered_storage
2022-08-08 20:08:35 +00:00
no_output_timeout : 100m
- post-steps
2023-10-24 23:20:37 +00:00
build-windows-vs2022-avx2 :
executor :
name : win/server-2022
size : 2xlarge
environment :
THIRDPARTY_HOME : C:/Users/circleci/thirdparty
CMAKE_HOME : C:/Program Files/CMake
CMAKE_BIN : C:/Program Files/CMake/bin/cmake.exe
CTEST_BIN : C:/Program Files/CMake/bin/ctest.exe
2023-11-14 22:39:31 +00:00
JAVA_HOME : C:/Program Files/BellSoft/LibericaJDK-8
2023-10-24 23:20:37 +00:00
SNAPPY_HOME : C:/Users/circleci/thirdparty/snappy-1.1.8
SNAPPY_INCLUDE : C:/Users/circleci/thirdparty/snappy-1.1.8;C:/Users/circleci/thirdparty/snappy-1.1.8/build
SNAPPY_LIB_DEBUG : C:/Users/circleci/thirdparty/snappy-1.1.8/build/Debug/snappy.lib
CMAKE_GENERATOR : Visual Studio 17 2022
CMAKE_PORTABLE : AVX2
steps :
- windows-build-steps
2022-10-28 16:14:47 +00:00
build-windows-vs2022 :
executor :
name : win/server-2022
size : 2xlarge
environment :
THIRDPARTY_HOME : C:/Users/circleci/thirdparty
CMAKE_HOME : C:/Program Files/CMake
CMAKE_BIN : C:/Program Files/CMake/bin/cmake.exe
2023-10-18 19:51:50 +00:00
CTEST_BIN : C:/Program Files/CMake/bin/ctest.exe
2023-11-14 22:39:31 +00:00
JAVA_HOME : C:/Program Files/BellSoft/LibericaJDK-8
2022-10-28 16:14:47 +00:00
SNAPPY_HOME : C:/Users/circleci/thirdparty/snappy-1.1.8
SNAPPY_INCLUDE : C:/Users/circleci/thirdparty/snappy-1.1.8;C:/Users/circleci/thirdparty/snappy-1.1.8/build
SNAPPY_LIB_DEBUG : C:/Users/circleci/thirdparty/snappy-1.1.8/build/Debug/snappy.lib
CMAKE_GENERATOR : Visual Studio 17 2022
2023-10-24 23:20:37 +00:00
CMAKE_PORTABLE : 1
2022-10-28 16:14:47 +00:00
steps :
- windows-build-steps
build-windows-vs2019 :
executor :
name : win/server-2019
size : 2xlarge
2020-03-14 04:51:26 +00:00
environment :
THIRDPARTY_HOME : C:/Users/circleci/thirdparty
2022-10-28 16:14:47 +00:00
CMAKE_HOME : C:/Program Files/CMake
CMAKE_BIN : C:/Program Files/CMake/bin/cmake.exe
2023-10-18 19:51:50 +00:00
CTEST_BIN : C:/Program Files/CMake/bin/ctest.exe
2023-11-14 22:39:31 +00:00
JAVA_HOME : C:/Program Files/BellSoft/LibericaJDK-8
2022-10-28 16:14:47 +00:00
SNAPPY_HOME : C:/Users/circleci/thirdparty/snappy-1.1.8
SNAPPY_INCLUDE : C:/Users/circleci/thirdparty/snappy-1.1.8;C:/Users/circleci/thirdparty/snappy-1.1.8/build
SNAPPY_LIB_DEBUG : C:/Users/circleci/thirdparty/snappy-1.1.8/build/Debug/snappy.lib
CMAKE_GENERATOR : Visual Studio 16 2019
2023-10-24 23:20:37 +00:00
CMAKE_PORTABLE : 1
2020-03-14 04:51:26 +00:00
steps :
2022-10-28 16:14:47 +00:00
- windows-build-steps
2020-06-09 02:32:18 +00:00
2020-07-13 22:04:27 +00:00
build-linux-java :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-12-16 23:58:56 +00:00
resource_class : large
2020-07-13 22:04:27 +00:00
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2020-07-13 22:04:27 +00:00
- run :
2020-12-16 23:58:56 +00:00
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "Test RocksDBJava"
2022-02-05 01:12:03 +00:00
command : make V=1 J=8 -j8 jtest
2020-12-16 23:58:56 +00:00
- post-steps
2023-10-17 17:04:35 +00:00
build-linux-java-pmd :
2023-10-24 23:20:37 +00:00
machine :
2023-10-17 17:04:35 +00:00
image : ubuntu-2004:202111-02
resource_class : large
environment :
JAVA_HOME : /usr/lib/jvm/java-8-openjdk-amd64
steps :
- install-maven
- pre-steps
- run :
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "PMD RocksDBJava"
command : make V=1 J=8 -j8 jpmd
- post-pmd-steps
2020-12-16 23:58:56 +00:00
build-linux-java-static :
2023-10-31 19:23:34 +00:00
executor : linux-java-docker
2020-12-16 23:58:56 +00:00
resource_class : large
steps :
- pre-steps
- run :
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "Build RocksDBJava Static Library"
2023-10-31 19:23:34 +00:00
command : scl enable devtoolset-7 'make V=1 J=8 -j8 rocksdbjavastatic'
2020-12-16 23:58:56 +00:00
- post-steps
build-macos-java :
macos :
2023-08-21 18:53:40 +00:00
xcode : 14.3 .1
resource_class : macos.m1.medium.gen1
2020-12-16 23:58:56 +00:00
environment :
2023-08-21 18:53:40 +00:00
JAVA_HOME : /Library/Java/JavaVirtualMachines/liberica-jdk-8.jdk/Contents/Home
2022-01-21 17:32:03 +00:00
ROCKSDB_DISABLE_JEMALLOC : 1 # jemalloc causes java 8 crash
2020-12-16 23:58:56 +00:00
steps :
- increase-max-open-files-on-macos
- install-gflags-on-macos
2022-01-20 17:40:34 +00:00
- install-jdk8-on-macos
2020-12-16 23:58:56 +00:00
- pre-steps-macos
- run :
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "Test RocksDBJava"
2022-03-03 19:58:51 +00:00
command : make V=1 J=16 -j16 jtest
2022-09-02 00:32:25 +00:00
no_output_timeout : 20m
2020-12-16 23:58:56 +00:00
- post-steps
build-macos-java-static :
macos :
2023-08-21 18:53:40 +00:00
xcode : 14.3 .1
resource_class : macos.m1.medium.gen1
2020-12-16 23:58:56 +00:00
environment :
2023-08-21 18:53:40 +00:00
JAVA_HOME : /Library/Java/JavaVirtualMachines/liberica-jdk-8.jdk/Contents/Home
2020-12-16 23:58:56 +00:00
steps :
- increase-max-open-files-on-macos
- install-gflags-on-macos
- install-cmake-on-macos
2022-01-13 01:19:41 +00:00
- install-jdk8-on-macos
2020-12-16 23:58:56 +00:00
- pre-steps-macos
- run :
name : "Set Java Environment"
2020-07-13 22:04:27 +00:00
command : |
echo "JAVA_HOME=${JAVA_HOME}"
2020-12-16 23:58:56 +00:00
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
2020-07-13 22:04:27 +00:00
which java && java -version
which javac && javac -version
2020-12-16 23:58:56 +00:00
- run :
2022-01-13 01:19:41 +00:00
name : "Build RocksDBJava x86 and ARM Static Libraries"
2022-03-03 19:58:51 +00:00
command : make V=1 J=16 -j16 rocksdbjavastaticosx
2022-09-02 00:32:25 +00:00
no_output_timeout : 20m
2022-01-13 01:19:41 +00:00
- post-steps
build-macos-java-static-universal :
macos :
2023-08-21 18:53:40 +00:00
xcode : 14.3 .1
resource_class : macos.m1.medium.gen1
2022-01-13 01:19:41 +00:00
environment :
2023-08-21 18:53:40 +00:00
JAVA_HOME : /Library/Java/JavaVirtualMachines/liberica-jdk-8.jdk/Contents/Home
2022-01-13 01:19:41 +00:00
steps :
- increase-max-open-files-on-macos
- install-gflags-on-macos
- install-cmake-on-macos
- install-jdk8-on-macos
- pre-steps-macos
- run :
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "Build RocksDBJava Universal Binary Static Library"
2022-03-03 19:58:51 +00:00
command : make V=1 J=16 -j16 rocksdbjavastaticosx_ub
2022-09-02 00:32:25 +00:00
no_output_timeout : 20m
2020-09-23 21:40:53 +00:00
- post-steps
2020-07-13 22:04:27 +00:00
2020-07-16 00:46:18 +00:00
build-examples :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-11-18 02:18:13 +00:00
resource_class : large
2020-07-16 00:46:18 +00:00
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2020-07-16 00:46:18 +00:00
- run :
name : "Build examples"
command : |
2022-08-11 00:34:38 +00:00
make V=1 -j4 static_lib && cd examples && make V=1 -j4
2020-09-23 21:40:53 +00:00
- post-steps
2020-07-16 00:46:18 +00:00
2020-11-18 02:18:13 +00:00
build-cmake-mingw :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-03-03 19:58:51 +00:00
resource_class : large
2020-11-18 02:18:13 +00:00
steps :
- pre-steps
2022-08-11 00:34:38 +00:00
- run : update-alternatives --set x86_64-w64-mingw32-g++ /usr/bin/x86_64-w64-mingw32-g++-posix
2020-11-18 02:18:13 +00:00
- run :
name : "Build cmake-mingw"
command : |
export PATH=$JAVA_HOME/bin:$PATH
echo "JAVA_HOME=${JAVA_HOME}"
which java && java -version
which javac && javac -version
mkdir build && cd build && cmake -DJNI=1 -DWITH_GFLAGS=OFF .. -DCMAKE_C_COMPILER=x86_64-w64-mingw32-gcc -DCMAKE_CXX_COMPILER=x86_64-w64-mingw32-g++ -DCMAKE_SYSTEM_NAME=Windows && make -j4 rocksdb rocksdbjni
- post-steps
2020-08-12 01:29:15 +00:00
build-linux-non-shm :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2020-08-12 01:29:15 +00:00
resource_class : 2xlarge
2022-03-03 19:58:51 +00:00
environment :
TEST_TMPDIR : /tmp/rocksdb_test_tmp
2020-08-12 01:29:15 +00:00
steps :
2020-09-23 21:40:53 +00:00
- pre-steps
2022-03-03 19:58:51 +00:00
- run : make V=1 -j32 check
2020-09-23 21:40:53 +00:00
- post-steps
2020-08-12 01:29:15 +00:00
2021-04-20 15:41:32 +00:00
build-linux-arm-test-full :
machine :
2022-02-05 01:12:03 +00:00
image : ubuntu-2004:202111-02
2021-04-20 15:41:32 +00:00
resource_class : arm.large
steps :
- pre-steps
- install-gflags
2022-02-05 01:12:03 +00:00
- run : make V=1 J=4 -j4 check
2021-04-20 15:41:32 +00:00
- post-steps
2021-04-20 03:05:56 +00:00
build-linux-arm :
machine :
2022-02-05 01:12:03 +00:00
image : ubuntu-2004:202111-02
2021-04-20 03:05:56 +00:00
resource_class : arm.large
steps :
- pre-steps
- install-gflags
2022-02-05 01:12:03 +00:00
- run : ROCKSDBTESTS_PLATFORM_DEPENDENT=only make V=1 J=4 -j4 all_but_some_tests check_some
2021-04-20 03:05:56 +00:00
- post-steps
build-linux-arm-cmake-no_test_run :
machine :
2022-02-05 01:12:03 +00:00
image : ubuntu-2004:202111-02
2021-04-20 03:05:56 +00:00
resource_class : arm.large
environment :
JAVA_HOME : /usr/lib/jvm/java-8-openjdk-arm64
steps :
- pre-steps
2021-06-01 21:42:06 +00:00
- install-gflags
2021-04-20 03:05:56 +00:00
- run :
name : "Set Java Environment"
command : |
echo "JAVA_HOME=${JAVA_HOME}"
echo 'export PATH=$JAVA_HOME/bin:$PATH' >> $BASH_ENV
which java && java -version
which javac && javac -version
- run :
name : "Build with cmake"
command : |
mkdir build
cd build
2021-06-01 21:42:06 +00:00
cmake -DCMAKE_BUILD_TYPE=Release -DWITH_TESTS=0 -DWITH_GFLAGS=1 -DWITH_BENCHMARK_TOOLS=0 -DWITH_TOOLS=0 -DWITH_CORE_TOOLS=1 ..
2021-04-20 03:05:56 +00:00
make -j4
- run :
name : "Build Java with cmake"
command : |
rm -rf build
mkdir build
cd build
2021-06-01 21:42:06 +00:00
cmake -DJNI=1 -DCMAKE_BUILD_TYPE=Release -DWITH_GFLAGS=1 ..
2021-04-20 03:05:56 +00:00
make -j4 rocksdb rocksdbjni
2021-04-20 15:41:32 +00:00
- post-steps
2021-04-20 03:05:56 +00:00
2021-02-10 04:47:06 +00:00
build-format-compatible :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2021-02-10 04:47:06 +00:00
resource_class : 2xlarge
steps :
- pre-steps
- run :
name : "test"
command : |
export TEST_TMPDIR=/dev/shm/rocksdb
rm -rf /dev/shm/rocksdb
mkdir /dev/shm/rocksdb
tools/check_format_compatible.sh
- post-steps
2022-02-01 18:29:56 +00:00
build-fuzzers :
2022-08-11 00:34:38 +00:00
executor : linux-docker
2022-02-01 18:29:56 +00:00
resource_class : large
steps :
- pre-steps
- run :
name : "Build rocksdb lib"
command : CC=clang-13 CXX=clang++-13 USE_CLANG=1 make -j4 static_lib
- run :
name : "Build fuzzers"
command : cd fuzz && make sst_file_writer_fuzzer db_fuzzer db_map_fuzzer
- post-steps
2022-06-04 16:31:47 +00:00
benchmark-linux : #use a private Circle CI runner (resource_class) to run the job
machine : true
resource_class : facebook/rocksdb-benchmark-sys1
steps :
- build-for-benchmarks
- perform-benchmarks
- post-benchmarks
2020-06-09 02:32:18 +00:00
workflows :
2021-02-10 04:47:06 +00:00
version : 2
2022-05-11 18:16:09 +00:00
jobs-linux-run-tests :
2020-06-09 02:32:18 +00:00
jobs :
- build-linux
Meta-internal folly integration with F14FastMap (#9546)
Summary:
Especially after updating to C++17, I don't see a compelling case for
*requiring* any folly components in RocksDB. I was able to purge the existing
hard dependencies, and it can be quite difficult to strip out non-trivial components
from folly for use in RocksDB. (The prospect of doing that on F14 has changed
my mind on the best approach here.)
But this change creates an optional integration where we can plug in
components from folly at compile time, starting here with F14FastMap to replace
std::unordered_map when possible (probably no public APIs for example). I have
replaced the biggest CPU users of std::unordered_map with compile-time
pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set.
USE_FOLLY is always set in the Meta-internal buck build, and a simulation of
that is in the Makefile for public CI testing. A full folly build is not needed, but
checking out the full folly repo is much simpler for getting the dependency,
and anything else we might want to optionally integrate in the future.
Some picky details:
* I don't think the distributed mutex stuff is actually used, so it was easy to remove.
* I implemented an alternative to `folly::constexpr_log2` (which is much easier
in C++17 than C++11) so that I could pull out the hard dependencies on
`ConstexprMath.h`
* I had to add noexcept move constructors/operators to some types to make
F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a
macro to make that easier in some common cases.
* Updated Meta-internal buck build to use folly F14Map (always)
No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a
production integration for open source users.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546
Test Plan:
CircleCI tests updated so that a couple of them use folly.
Most internal unit & stress/crash tests updated to use Meta-internal latest folly.
(Note: they should probably use buck but they currently use Makefile.)
Example performance improvement: when filter partitions are pinned in cache,
they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build
a test that exercises that heavily. Build DB with
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters
```
and test with (simultaneous runs with & without folly, ~20 times each to see
convergence)
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache
```
Average ops/s no folly: 26229.2
Average ops/s with folly: 26853.3 (+2.4%)
Reviewed By: ajkr
Differential Revision: D34181736
Pulled By: pdillinger
fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
2022-04-13 14:34:01 +00:00
- build-linux-cmake-with-folly
2022-09-12 04:40:11 +00:00
- build-linux-cmake-with-folly-lite-no-test
2022-05-11 18:16:09 +00:00
- build-linux-gcc-7-with-folly
2022-09-12 04:40:11 +00:00
- build-linux-gcc-7-with-folly-lite-no-test
- build-linux-cmake-with-folly-coroutines
Meta-internal folly integration with F14FastMap (#9546)
Summary:
Especially after updating to C++17, I don't see a compelling case for
*requiring* any folly components in RocksDB. I was able to purge the existing
hard dependencies, and it can be quite difficult to strip out non-trivial components
from folly for use in RocksDB. (The prospect of doing that on F14 has changed
my mind on the best approach here.)
But this change creates an optional integration where we can plug in
components from folly at compile time, starting here with F14FastMap to replace
std::unordered_map when possible (probably no public APIs for example). I have
replaced the biggest CPU users of std::unordered_map with compile-time
pluggable UnorderedMap which will use F14FastMap when USE_FOLLY is set.
USE_FOLLY is always set in the Meta-internal buck build, and a simulation of
that is in the Makefile for public CI testing. A full folly build is not needed, but
checking out the full folly repo is much simpler for getting the dependency,
and anything else we might want to optionally integrate in the future.
Some picky details:
* I don't think the distributed mutex stuff is actually used, so it was easy to remove.
* I implemented an alternative to `folly::constexpr_log2` (which is much easier
in C++17 than C++11) so that I could pull out the hard dependencies on
`ConstexprMath.h`
* I had to add noexcept move constructors/operators to some types to make
F14's complainUnlessNothrowMoveAndDestroy check happy, and I added a
macro to make that easier in some common cases.
* Updated Meta-internal buck build to use folly F14Map (always)
No updates to HISTORY.md nor INSTALL.md as this is not (yet?) considered a
production integration for open source users.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9546
Test Plan:
CircleCI tests updated so that a couple of them use folly.
Most internal unit & stress/crash tests updated to use Meta-internal latest folly.
(Note: they should probably use buck but they currently use Makefile.)
Example performance improvement: when filter partitions are pinned in cache,
they are tracked by PartitionedFilterBlockReader::filter_map_ and we can build
a test that exercises that heavily. Build DB with
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=30000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters
```
and test with (simultaneous runs with & without folly, ~20 times each to see
convergence)
```
TEST_TMPDIR=/dev/shm/rocksdb ./db_bench_folly -readonly -use_existing_db -benchmarks=readrandom -num=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -partition_index_and_filters -duration=40 -pin_l0_filter_and_index_blocks_in_cache
```
Average ops/s no folly: 26229.2
Average ops/s with folly: 26853.3 (+2.4%)
Reviewed By: ajkr
Differential Revision: D34181736
Pulled By: pdillinger
fbshipit-source-id: ffa6ad5104c2880321d8a1aa7187e00ab0d02e94
2022-04-13 14:34:01 +00:00
- build-linux-cmake-with-benchmark
2022-04-18 19:47:16 +00:00
- build-linux-encrypted_env-no_compression
2022-05-11 18:16:09 +00:00
jobs-linux-run-tests-san :
2020-06-26 00:40:08 +00:00
jobs :
- build-linux-clang10-asan
2022-05-11 18:16:09 +00:00
- build-linux-clang10-ubsan
2022-08-11 00:34:38 +00:00
- build-linux-clang10-mini-tsan
2023-02-03 23:28:52 +00:00
- build-linux-static_lib-alt_namespace-status_checked
2022-05-11 18:16:09 +00:00
jobs-linux-no-test-run :
2020-07-11 03:02:16 +00:00
jobs :
2022-05-11 18:16:09 +00:00
- build-linux-release
- build-linux-release-rtti
- build-examples
- build-fuzzers
- build-linux-clang-no_test_run
- build-linux-clang-13-no_test_run
- build-linux-gcc-8-no_test_run
- build-linux-gcc-10-cxx20-no_test_run
- build-linux-gcc-11-no_test_run
- build-linux-arm-cmake-no_test_run
jobs-linux-other-checks :
2020-07-13 19:31:41 +00:00
jobs :
- build-linux-clang10-clang-analyze
2021-09-10 16:59:05 +00:00
- build-linux-unity-and-headers
2022-03-16 22:58:06 +00:00
- build-linux-mini-crashtest
2022-05-11 18:16:09 +00:00
jobs-windows :
2021-01-11 21:31:03 +00:00
jobs :
2022-10-28 16:14:47 +00:00
- build-windows-vs2019
2022-05-11 18:16:09 +00:00
- build-cmake-mingw
jobs-java :
2020-07-13 22:04:27 +00:00
jobs :
- build-linux-java
2020-12-16 23:58:56 +00:00
- build-linux-java-static
- build-macos-java
- build-macos-java-static
2022-01-13 01:19:41 +00:00
- build-macos-java-static-universal
2023-10-17 17:04:35 +00:00
- build-linux-java-pmd
2022-05-11 18:16:09 +00:00
jobs-macos :
2020-10-12 17:45:21 +00:00
jobs :
- build-macos
2022-03-03 19:58:51 +00:00
- build-macos-cmake :
run_even_tests : true
- build-macos-cmake :
run_even_tests : false
2022-05-11 18:16:09 +00:00
jobs-linux-arm :
2021-04-20 03:05:56 +00:00
jobs :
- build-linux-arm
2022-06-04 16:31:47 +00:00
build-fuzzers :
jobs :
- build-fuzzers
2022-06-22 16:26:13 +00:00
benchmark-linux :
triggers :
- schedule :
cron : "0 * * * *"
filters :
branches :
only :
- main
jobs :
- benchmark-linux
2021-02-10 04:47:06 +00:00
nightly :
triggers :
- schedule :
2022-05-11 18:16:09 +00:00
cron : "0 9 * * *"
2021-02-10 04:47:06 +00:00
filters :
branches :
only :
2021-09-01 18:56:37 +00:00
- main
2021-02-10 04:47:06 +00:00
jobs :
- build-format-compatible
2021-04-20 15:41:32 +00:00
- build-linux-arm-test-full
2022-03-03 19:58:51 +00:00
- build-linux-run-microbench
- build-linux-non-shm
2022-04-19 03:26:37 +00:00
- build-linux-clang-13-asan-ubsan-with-folly
- build-linux-valgrind
2023-11-22 18:40:52 +00:00
- build-windows-vs2022-avx2
- build-windows-vs2022