2016-06-02 23:24:14 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2016-06-02 23:24:14 +00:00
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "rocksdb/db_bench_tool.h"
|
2017-04-06 02:02:00 +00:00
|
|
|
#include "options/options_parser.h"
|
2016-06-02 23:24:14 +00:00
|
|
|
#include "rocksdb/utilities/options_util.h"
|
2019-05-30 18:21:38 +00:00
|
|
|
#include "test_util/testharness.h"
|
|
|
|
#include "test_util/testutil.h"
|
2019-05-31 00:39:43 +00:00
|
|
|
#include "util/random.h"
|
2016-06-02 23:24:14 +00:00
|
|
|
|
|
|
|
#ifdef GFLAGS
|
2017-12-01 18:40:45 +00:00
|
|
|
#include "util/gflags_compat.h"
|
2016-06-02 23:24:14 +00:00
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
namespace {
|
|
|
|
static const int kMaxArgCount = 100;
|
|
|
|
static const size_t kArgBufferSize = 100000;
|
|
|
|
} // namespace
|
|
|
|
|
|
|
|
class DBBenchTest : public testing::Test {
|
|
|
|
public:
|
|
|
|
DBBenchTest() : rnd_(0xFB) {
|
2018-07-14 00:18:39 +00:00
|
|
|
test_path_ = test::PerThreadDBPath("db_bench_test");
|
2016-06-02 23:24:14 +00:00
|
|
|
Env::Default()->CreateDir(test_path_);
|
|
|
|
db_path_ = test_path_ + "/db";
|
|
|
|
wal_path_ = test_path_ + "/wal";
|
|
|
|
}
|
|
|
|
|
|
|
|
~DBBenchTest() {
|
|
|
|
// DestroyDB(db_path_, Options());
|
|
|
|
}
|
|
|
|
|
|
|
|
void ResetArgs() {
|
|
|
|
argc_ = 0;
|
|
|
|
cursor_ = 0;
|
|
|
|
memset(arg_buffer_, 0, kArgBufferSize);
|
|
|
|
}
|
|
|
|
|
|
|
|
void AppendArgs(const std::vector<std::string>& args) {
|
|
|
|
for (const auto& arg : args) {
|
|
|
|
ASSERT_LE(cursor_ + arg.size() + 1, kArgBufferSize);
|
|
|
|
ASSERT_LE(argc_ + 1, kMaxArgCount);
|
|
|
|
snprintf(arg_buffer_ + cursor_, arg.size() + 1, "%s", arg.c_str());
|
|
|
|
|
|
|
|
argv_[argc_++] = arg_buffer_ + cursor_;
|
|
|
|
cursor_ += arg.size() + 1;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void RunDbBench(const std::string& options_file_name) {
|
|
|
|
AppendArgs({"./db_bench", "--benchmarks=fillseq", "--use_existing_db=0",
|
|
|
|
"--num=1000",
|
|
|
|
std::string(std::string("--db=") + db_path_).c_str(),
|
|
|
|
std::string(std::string("--wal_dir=") + wal_path_).c_str(),
|
|
|
|
std::string(std::string("--options_file=") + options_file_name)
|
|
|
|
.c_str()});
|
|
|
|
ASSERT_EQ(0, db_bench_tool(argc(), argv()));
|
|
|
|
}
|
|
|
|
|
|
|
|
void VerifyOptions(const Options& opt) {
|
|
|
|
DBOptions loaded_db_opts;
|
|
|
|
std::vector<ColumnFamilyDescriptor> cf_descs;
|
Introduce a new storage specific Env API (#5761)
Summary:
The current Env API encompasses both storage/file operations, as well as OS related operations. Most of the APIs return a Status, which does not have enough metadata about an error, such as whether its retry-able or not, scope (i.e fault domain) of the error etc., that may be required in order to properly handle a storage error. The file APIs also do not provide enough control over the IO SLA, such as timeout, prioritization, hinting about placement and redundancy etc.
This PR separates out the file/storage APIs from Env into a new FileSystem class. The APIs are updated to return an IOStatus with metadata about the error, as well as to take an IOOptions structure as input in order to allow more control over the IO.
The user can set both ```options.env``` and ```options.file_system``` to specify that RocksDB should use the former for OS related operations and the latter for storage operations. Internally, a ```CompositeEnvWrapper``` has been introduced that inherits from ```Env``` and redirects individual methods to either an ```Env``` implementation or the ```FileSystem``` as appropriate. When options are sanitized during ```DB::Open```, ```options.env``` is replaced with a newly allocated ```CompositeEnvWrapper``` instance if both env and file_system have been specified. This way, the rest of the RocksDB code can continue to function as before.
This PR also ports PosixEnv to the new API by splitting it into two - PosixEnv and PosixFileSystem. PosixEnv is defined as a sub-class of CompositeEnvWrapper, and threading/time functions are overridden with Posix specific implementations in order to avoid an extra level of indirection.
The ```CompositeEnvWrapper``` translates ```IOStatus``` return code to ```Status```, and sets the severity to ```kSoftError``` if the io_status is retryable. The error handling code in RocksDB can then recover the DB automatically.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5761
Differential Revision: D18868376
Pulled By: anand1976
fbshipit-source-id: 39efe18a162ea746fabac6360ff529baba48486f
2019-12-13 22:47:08 +00:00
|
|
|
ASSERT_OK(LoadLatestOptions(db_path_, FileSystem::Default(),
|
|
|
|
&loaded_db_opts, &cf_descs));
|
2016-06-02 23:24:14 +00:00
|
|
|
|
|
|
|
ASSERT_OK(
|
|
|
|
RocksDBOptionsParser::VerifyDBOptions(DBOptions(opt), loaded_db_opts));
|
|
|
|
ASSERT_OK(RocksDBOptionsParser::VerifyCFOptions(ColumnFamilyOptions(opt),
|
|
|
|
cf_descs[0].options));
|
|
|
|
|
|
|
|
// check with the default rocksdb options and expect failure
|
|
|
|
ASSERT_NOK(
|
|
|
|
RocksDBOptionsParser::VerifyDBOptions(DBOptions(), loaded_db_opts));
|
|
|
|
ASSERT_NOK(RocksDBOptionsParser::VerifyCFOptions(ColumnFamilyOptions(),
|
|
|
|
cf_descs[0].options));
|
|
|
|
}
|
|
|
|
|
|
|
|
char** argv() { return argv_; }
|
|
|
|
|
|
|
|
int argc() { return argc_; }
|
|
|
|
|
|
|
|
std::string db_path_;
|
|
|
|
std::string test_path_;
|
|
|
|
std::string wal_path_;
|
|
|
|
|
|
|
|
char arg_buffer_[kArgBufferSize];
|
|
|
|
char* argv_[kMaxArgCount];
|
|
|
|
int argc_ = 0;
|
|
|
|
int cursor_ = 0;
|
|
|
|
Random rnd_;
|
|
|
|
};
|
|
|
|
|
|
|
|
namespace {} // namespace
|
|
|
|
|
|
|
|
TEST_F(DBBenchTest, OptionsFile) {
|
|
|
|
const std::string kOptionsFileName = test_path_ + "/OPTIONS_test";
|
|
|
|
|
|
|
|
Options opt;
|
|
|
|
opt.create_if_missing = true;
|
|
|
|
opt.max_open_files = 256;
|
|
|
|
opt.max_background_compactions = 10;
|
|
|
|
opt.arena_block_size = 8388608;
|
|
|
|
ASSERT_OK(PersistRocksDBOptions(DBOptions(opt), {"default"},
|
|
|
|
{ColumnFamilyOptions(opt)}, kOptionsFileName,
|
|
|
|
Env::Default()));
|
|
|
|
|
|
|
|
// override the following options as db_bench will not take these
|
|
|
|
// options from the options file
|
|
|
|
opt.wal_dir = wal_path_;
|
|
|
|
|
|
|
|
RunDbBench(kOptionsFileName);
|
|
|
|
|
|
|
|
VerifyOptions(opt);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DBBenchTest, OptionsFileUniversal) {
|
|
|
|
const std::string kOptionsFileName = test_path_ + "/OPTIONS_test";
|
|
|
|
|
|
|
|
Options opt;
|
|
|
|
opt.compaction_style = kCompactionStyleUniversal;
|
|
|
|
opt.num_levels = 1;
|
|
|
|
opt.create_if_missing = true;
|
|
|
|
opt.max_open_files = 256;
|
|
|
|
opt.max_background_compactions = 10;
|
|
|
|
opt.arena_block_size = 8388608;
|
|
|
|
ASSERT_OK(PersistRocksDBOptions(DBOptions(opt), {"default"},
|
|
|
|
{ColumnFamilyOptions(opt)}, kOptionsFileName,
|
|
|
|
Env::Default()));
|
|
|
|
|
|
|
|
// override the following options as db_bench will not take these
|
|
|
|
// options from the options file
|
|
|
|
opt.wal_dir = wal_path_;
|
|
|
|
|
|
|
|
RunDbBench(kOptionsFileName);
|
|
|
|
|
|
|
|
VerifyOptions(opt);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST_F(DBBenchTest, OptionsFileMultiLevelUniversal) {
|
|
|
|
const std::string kOptionsFileName = test_path_ + "/OPTIONS_test";
|
|
|
|
|
|
|
|
Options opt;
|
|
|
|
opt.compaction_style = kCompactionStyleUniversal;
|
|
|
|
opt.num_levels = 12;
|
|
|
|
opt.create_if_missing = true;
|
|
|
|
opt.max_open_files = 256;
|
|
|
|
opt.max_background_compactions = 10;
|
|
|
|
opt.arena_block_size = 8388608;
|
|
|
|
ASSERT_OK(PersistRocksDBOptions(DBOptions(opt), {"default"},
|
|
|
|
{ColumnFamilyOptions(opt)}, kOptionsFileName,
|
|
|
|
Env::Default()));
|
|
|
|
|
|
|
|
// override the following options as db_bench will not take these
|
|
|
|
// options from the options file
|
|
|
|
opt.wal_dir = wal_path_;
|
|
|
|
|
|
|
|
RunDbBench(kOptionsFileName);
|
|
|
|
|
|
|
|
VerifyOptions(opt);
|
|
|
|
}
|
|
|
|
|
|
|
|
const std::string options_file_content = R"OPTIONS_FILE(
|
|
|
|
[Version]
|
|
|
|
rocksdb_version=4.3.1
|
|
|
|
options_file_version=1.1
|
|
|
|
|
|
|
|
[DBOptions]
|
|
|
|
wal_bytes_per_sync=1048576
|
|
|
|
delete_obsolete_files_period_micros=0
|
|
|
|
WAL_ttl_seconds=0
|
|
|
|
WAL_size_limit_MB=0
|
|
|
|
db_write_buffer_size=0
|
|
|
|
max_subcompactions=1
|
|
|
|
table_cache_numshardbits=4
|
|
|
|
max_open_files=-1
|
|
|
|
max_file_opening_threads=10
|
|
|
|
max_background_compactions=5
|
|
|
|
use_fsync=false
|
|
|
|
use_adaptive_mutex=false
|
|
|
|
max_total_wal_size=18446744073709551615
|
|
|
|
compaction_readahead_size=0
|
|
|
|
new_table_reader_for_compaction_inputs=false
|
|
|
|
keep_log_file_num=10
|
|
|
|
skip_stats_update_on_db_open=false
|
|
|
|
max_manifest_file_size=18446744073709551615
|
|
|
|
db_log_dir=
|
|
|
|
skip_log_error_on_recovery=false
|
|
|
|
writable_file_max_buffer_size=1048576
|
|
|
|
paranoid_checks=true
|
|
|
|
is_fd_close_on_exec=true
|
|
|
|
bytes_per_sync=1048576
|
|
|
|
enable_thread_tracking=true
|
|
|
|
recycle_log_file_num=0
|
|
|
|
create_missing_column_families=false
|
|
|
|
log_file_time_to_roll=0
|
|
|
|
max_background_flushes=1
|
|
|
|
create_if_missing=true
|
|
|
|
error_if_exists=false
|
|
|
|
delayed_write_rate=1048576
|
|
|
|
manifest_preallocation_size=4194304
|
2016-12-22 20:51:29 +00:00
|
|
|
allow_mmap_reads=false
|
2016-06-02 23:24:14 +00:00
|
|
|
allow_mmap_writes=false
|
2016-12-22 20:51:29 +00:00
|
|
|
use_direct_reads=false
|
2017-04-13 20:07:33 +00:00
|
|
|
use_direct_io_for_flush_and_compaction=false
|
2016-06-02 23:24:14 +00:00
|
|
|
stats_dump_period_sec=600
|
|
|
|
allow_fallocate=true
|
|
|
|
max_log_file_size=83886080
|
|
|
|
random_access_max_buffer_size=1048576
|
|
|
|
advise_random_on_open=true
|
|
|
|
|
|
|
|
|
|
|
|
[CFOptions "default"]
|
|
|
|
compaction_filter_factory=nullptr
|
|
|
|
table_factory=BlockBasedTable
|
|
|
|
prefix_extractor=nullptr
|
|
|
|
comparator=leveldb.BytewiseComparator
|
|
|
|
compression_per_level=
|
|
|
|
max_bytes_for_level_base=104857600
|
|
|
|
bloom_locality=0
|
|
|
|
target_file_size_base=10485760
|
2016-07-27 01:05:30 +00:00
|
|
|
memtable_huge_page_size=0
|
2016-06-02 23:24:14 +00:00
|
|
|
max_successive_merges=1000
|
|
|
|
max_sequential_skip_in_iterations=8
|
|
|
|
arena_block_size=52428800
|
|
|
|
target_file_size_multiplier=1
|
|
|
|
source_compaction_factor=1
|
|
|
|
min_write_buffer_number_to_merge=1
|
|
|
|
max_write_buffer_number=2
|
|
|
|
write_buffer_size=419430400
|
|
|
|
max_grandparent_overlap_factor=10
|
|
|
|
max_bytes_for_level_multiplier=10
|
|
|
|
memtable_factory=SkipListFactory
|
|
|
|
compression=kSnappyCompression
|
|
|
|
min_partial_merge_operands=2
|
|
|
|
level0_stop_writes_trigger=100
|
|
|
|
num_levels=1
|
|
|
|
level0_slowdown_writes_trigger=50
|
|
|
|
level0_file_num_compaction_trigger=10
|
|
|
|
expanded_compaction_factor=25
|
|
|
|
soft_rate_limit=0.000000
|
|
|
|
max_write_buffer_number_to_maintain=0
|
Refactor trimming logic for immutable memtables (#5022)
Summary:
MyRocks currently sets `max_write_buffer_number_to_maintain` in order to maintain enough history for transaction conflict checking. The effectiveness of this approach depends on the size of memtables. When memtables are small, it may not keep enough history; when memtables are large, this may consume too much memory.
We are proposing a new way to configure memtable list history: by limiting the memory usage of immutable memtables. The new option is `max_write_buffer_size_to_maintain` and it will take precedence over the old `max_write_buffer_number_to_maintain` if they are both set to non-zero values. The new option accounts for the total memory usage of flushed immutable memtables and mutable memtable. When the total usage exceeds the limit, RocksDB may start dropping immutable memtables (which is also called trimming history), starting from the oldest one.
The semantics of the old option actually works both as an upper bound and lower bound. History trimming will start if number of immutable memtables exceeds the limit, but it will never go below (limit-1) due to history trimming.
In order the mimic the behavior with the new option, history trimming will stop if dropping the next immutable memtable causes the total memory usage go below the size limit. For example, assuming the size limit is set to 64MB, and there are 3 immutable memtables with sizes of 20, 30, 30. Although the total memory usage is 80MB > 64MB, dropping the oldest memtable will reduce the memory usage to 60MB < 64MB, so in this case no memtable will be dropped.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/5022
Differential Revision: D14394062
Pulled By: miasantreble
fbshipit-source-id: 60457a509c6af89d0993f988c9b5c2aa9e45f5c5
2019-08-23 20:54:09 +00:00
|
|
|
max_write_buffer_size_to_maintain=0
|
2016-06-02 23:24:14 +00:00
|
|
|
verify_checksums_in_compaction=true
|
|
|
|
merge_operator=nullptr
|
|
|
|
memtable_prefix_bloom_bits=0
|
2019-02-19 20:12:25 +00:00
|
|
|
memtable_whole_key_filtering=true
|
2016-06-02 23:24:14 +00:00
|
|
|
paranoid_file_checks=false
|
|
|
|
inplace_update_num_locks=10000
|
|
|
|
optimize_filters_for_hits=false
|
|
|
|
level_compaction_dynamic_level_bytes=false
|
|
|
|
inplace_update_support=false
|
|
|
|
compaction_style=kCompactionStyleUniversal
|
|
|
|
memtable_prefix_bloom_probes=6
|
|
|
|
purge_redundant_kvs_while_flush=true
|
|
|
|
filter_deletes=false
|
|
|
|
hard_pending_compaction_bytes_limit=0
|
|
|
|
disable_auto_compactions=false
|
|
|
|
compaction_measure_io_stats=false
|
|
|
|
|
|
|
|
[TableOptions/BlockBasedTable "default"]
|
|
|
|
format_version=0
|
|
|
|
skip_table_builder_flush=false
|
|
|
|
cache_index_and_filter_blocks=false
|
|
|
|
flush_block_policy_factory=FlushBlockBySizePolicyFactory
|
|
|
|
hash_index_allow_collision=true
|
|
|
|
index_type=kBinarySearch
|
|
|
|
whole_key_filtering=true
|
|
|
|
checksum=kCRC32c
|
|
|
|
no_block_cache=false
|
|
|
|
block_size=32768
|
|
|
|
block_size_deviation=10
|
|
|
|
block_restart_interval=16
|
|
|
|
filter_policy=rocksdb.BuiltinBloomFilter
|
|
|
|
)OPTIONS_FILE";
|
|
|
|
|
|
|
|
TEST_F(DBBenchTest, OptionsFileFromFile) {
|
|
|
|
const std::string kOptionsFileName = test_path_ + "/OPTIONS_flash";
|
2018-11-09 19:17:34 +00:00
|
|
|
std::unique_ptr<WritableFile> writable;
|
2016-06-02 23:24:14 +00:00
|
|
|
ASSERT_OK(Env::Default()->NewWritableFile(kOptionsFileName, &writable,
|
|
|
|
EnvOptions()));
|
|
|
|
ASSERT_OK(writable->Append(options_file_content));
|
|
|
|
ASSERT_OK(writable->Close());
|
|
|
|
|
|
|
|
DBOptions db_opt;
|
|
|
|
std::vector<ColumnFamilyDescriptor> cf_descs;
|
|
|
|
ASSERT_OK(LoadOptionsFromFile(kOptionsFileName, Env::Default(), &db_opt,
|
|
|
|
&cf_descs));
|
|
|
|
Options opt(db_opt, cf_descs[0].options);
|
|
|
|
|
|
|
|
opt.create_if_missing = true;
|
|
|
|
|
|
|
|
// override the following options as db_bench will not take these
|
|
|
|
// options from the options file
|
|
|
|
opt.wal_dir = wal_path_;
|
|
|
|
|
|
|
|
RunDbBench(kOptionsFileName);
|
|
|
|
|
|
|
|
VerifyOptions(opt);
|
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace rocksdb
|
|
|
|
|
|
|
|
int main(int argc, char** argv) {
|
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
google::ParseCommandLineFlags(&argc, &argv, true);
|
|
|
|
return RUN_ALL_TESTS();
|
|
|
|
}
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
|
|
|
int main(int argc, char** argv) {
|
|
|
|
printf("Skip db_bench_tool_test as the required library GFLAG is missing.");
|
|
|
|
}
|
|
|
|
#endif // #ifdef GFLAGS
|