2019-12-16 22:28:06 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#ifdef GFLAGS
|
|
|
|
#pragma once
|
|
|
|
#include "db_stress_tool/db_stress_common.h"
|
2023-04-21 16:07:18 +00:00
|
|
|
#include "monitoring/thread_status_util.h"
|
2019-12-16 22:28:06 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2023-04-21 16:07:18 +00:00
|
|
|
class DbStressRandomAccessFileWrapper : public FSRandomAccessFileOwnerWrapper {
|
|
|
|
public:
|
|
|
|
explicit DbStressRandomAccessFileWrapper(
|
|
|
|
std::unique_ptr<FSRandomAccessFile>&& target)
|
|
|
|
: FSRandomAccessFileOwnerWrapper(std::move(target)) {}
|
|
|
|
|
|
|
|
IOStatus Read(uint64_t offset, size_t n, const IOOptions& options,
|
|
|
|
Slice* result, char* scratch,
|
|
|
|
IODebugContext* dbg) const override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Read(offset, n, options, result, scratch, dbg);
|
|
|
|
}
|
Group rocksdb.sst.read.micros stat by different user read IOActivity + misc (#11444)
Summary:
**Context/Summary:**
- Similar to https://github.com/facebook/rocksdb/pull/11288 but for user read such as `Get(), MultiGet(), DBIterator::XXX(), Verify(File)Checksum()`.
- For this, I refactored some user-facing `MultiGet` calls in `TransactionBase` and various types of `DB` so that it does not call a user-facing `Get()` but `GetImpl()` for passing the `ReadOptions::io_activity` check (see PR conversation)
- New user read stats breakdown are guarded by `kExceptDetailedTimers` since measurement shows they have 4-5% regression to the upstream/main.
- Misc
- More refactoring: with https://github.com/facebook/rocksdb/pull/11288, we complete passing `ReadOptions/IOOptions` to FS level. So we can now replace the previously [added](https://github.com/facebook/rocksdb/pull/9424) `rate_limiter_priority` parameter in `RandomAccessFileReader`'s `Read/MultiRead/Prefetch()` with `IOOptions::rate_limiter_priority`
- Also, `ReadAsync()` call time is measured in `SST_READ_MICRO` now
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11444
Test Plan:
- CI fake db crash/stress test
- Microbenchmarking
**Build** `make clean && ROCKSDB_NO_FBCODE=1 DEBUG_LEVEL=0 make -jN db_basic_bench`
- google benchmark version: https://github.com/google/benchmark/commit/604f6fd3f4b34a84ec4eb4db81d842fa4db829cd
- db_basic_bench_base: upstream
- db_basic_bench_pr: db_basic_bench_base + this PR
- asyncread_db_basic_bench_base: upstream + [db basic bench patch for IteratorNext](https://github.com/facebook/rocksdb/compare/main...hx235:rocksdb:micro_bench_async_read)
- asyncread_db_basic_bench_pr: asyncread_db_basic_bench_base + this PR
**Test**
Get
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{null_stat|base|pr} --benchmark_filter=DBGet/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/negative_query:0/enable_filter:0/mmap:1/threads:1 --benchmark_repetitions=1000
```
Result
```
Coming soon
```
AsyncRead
```
TEST_TMPDIR=/dev/shm ./asyncread_db_basic_bench_{base|pr} --benchmark_filter=IteratorNext/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1/async_io:1/include_detailed_timers:0 --benchmark_repetitions=1000 > syncread_db_basic_bench_{base|pr}.out
```
Result
```
Base:
1956,1956,1968,1977,1979,1986,1988,1988,1988,1990,1991,1991,1993,1993,1993,1993,1994,1996,1997,1997,1997,1998,1999,2001,2001,2002,2004,2007,2007,2008,
PR (2.3% regression, due to measuring `SST_READ_MICRO` that wasn't measured before):
1993,2014,2016,2022,2024,2027,2027,2028,2028,2030,2031,2031,2032,2032,2038,2039,2042,2044,2044,2047,2047,2047,2048,2049,2050,2052,2052,2052,2053,2053,
```
Reviewed By: ajkr
Differential Revision: D45918925
Pulled By: hx235
fbshipit-source-id: 58a54560d9ebeb3a59b6d807639692614dad058a
2023-08-09 00:26:50 +00:00
|
|
|
|
|
|
|
IOStatus MultiRead(FSReadRequest* reqs, size_t num_reqs,
|
|
|
|
const IOOptions& options, IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->MultiRead(reqs, num_reqs, options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
IOStatus Prefetch(uint64_t offset, size_t n, const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Prefetch(offset, n, options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
IOStatus ReadAsync(FSReadRequest& req, const IOOptions& options,
|
|
|
|
std::function<void(const FSReadRequest&, void*)> cb,
|
|
|
|
void* cb_arg, void** io_handle, IOHandleDeleter* del_fn,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->ReadAsync(req, options, cb, cb_arg, io_handle, del_fn,
|
|
|
|
dbg);
|
|
|
|
}
|
2023-04-21 16:07:18 +00:00
|
|
|
};
|
|
|
|
|
Group SST write in flush, compaction and db open with new stats (#11910)
Summary:
## Context/Summary
Similar to https://github.com/facebook/rocksdb/pull/11288, https://github.com/facebook/rocksdb/pull/11444, categorizing SST/blob file write according to different io activities allows more insight into the activity.
For that, this PR does the following:
- Tag different write IOs by passing down and converting WriteOptions to IOOptions
- Add new SST_WRITE_MICROS histogram in WritableFileWriter::Append() and breakdown FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS
Some related code refactory to make implementation cleaner:
- Blob stats
- Replace high-level write measurement with low-level WritableFileWriter::Append() measurement for BLOB_DB_BLOB_FILE_WRITE_MICROS. This is to make FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS include blob file. As a consequence, this introduces some behavioral changes on it, see HISTORY and db bench test plan below for more info.
- Fix bugs where BLOB_DB_BLOB_FILE_SYNCED/BLOB_DB_BLOB_FILE_BYTES_WRITTEN include file failed to sync and bytes failed to write.
- Refactor WriteOptions constructor for easier construction with io_activity and rate_limiter_priority
- Refactor DBImpl::~DBImpl()/BlobDBImpl::Close() to bypass thread op verification
- Build table
- TableBuilderOptions now includes Read/WriteOpitons so BuildTable() do not need to take these two variables
- Replace the io_priority passed into BuildTable() with TableBuilderOptions::WriteOpitons::rate_limiter_priority. Similar for BlobFileBuilder.
This parameter is used for dynamically changing file io priority for flush, see https://github.com/facebook/rocksdb/pull/9988?fbclid=IwAR1DtKel6c-bRJAdesGo0jsbztRtciByNlvokbxkV6h_L-AE9MACzqRTT5s for more
- Update ThreadStatus::FLUSH_BYTES_WRITTEN to use io_activity to track flush IO in flush job and db open instead of io_priority
## Test
### db bench
Flush
```
./db_bench --statistics=1 --benchmarks=fillseq --num=100000 --write_buffer_size=100
rocksdb.sst.write.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377
rocksdb.file.write.flush.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377
rocksdb.file.write.compaction.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
rocksdb.file.write.db.open.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
```
compaction, db oopen
```
Setup: ./db_bench --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
Run:./db_bench --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1
rocksdb.sst.write.micros P50 : 2.675325 P95 : 9.578788 P99 : 18.780000 P100 : 314.000000 COUNT : 638 SUM : 3279
rocksdb.file.write.flush.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
rocksdb.file.write.compaction.micros P50 : 2.757353 P95 : 9.610687 P99 : 19.316667 P100 : 314.000000 COUNT : 615 SUM : 3213
rocksdb.file.write.db.open.micros P50 : 2.055556 P95 : 3.925000 P99 : 9.000000 P100 : 9.000000 COUNT : 23 SUM : 66
```
blob stats - just to make sure they aren't broken by this PR
```
Integrated Blob DB
Setup: ./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
Run:./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1
pre-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 7.298246 P95 : 9.771930 P99 : 9.991813 P100 : 16.000000 COUNT : 235 SUM : 1600
rocksdb.blobdb.blob.file.synced COUNT : 1
rocksdb.blobdb.blob.file.bytes.written COUNT : 34842
post-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 2.000000 P95 : 2.829360 P99 : 2.993779 P100 : 9.000000 COUNT : 707 SUM : 1614
- COUNT is higher and values are smaller as it includes header and footer write
- COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164
rocksdb.blobdb.blob.file.synced COUNT : 1 (stay the same)
rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 (stay the same)
```
```
Stacked Blob DB
Run: ./db_bench --use_blob_db=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
pre-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 12.808042 P95 : 19.674497 P99 : 28.539683 P100 : 51.000000 COUNT : 10000 SUM : 140876
rocksdb.blobdb.blob.file.synced COUNT : 8
rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445
post-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 1.657370 P95 : 2.952175 P99 : 3.877519 P100 : 24.000000 COUNT : 30001 SUM : 67924
- COUNT is higher and values are smaller as it includes header and footer write
- COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164
rocksdb.blobdb.blob.file.synced COUNT : 8 (stay the same)
rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 (stay the same)
```
### Rehearsal CI stress test
Trigger 3 full runs of all our CI stress tests
### Performance
Flush
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=ManualFlush/key_num:524288/per_key_size:256 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark; enable_statistics = true
Pre-pr: avg 507515519.3 ns
497686074,499444327,500862543,501389862,502994471,503744435,504142123,504224056,505724198,506610393,506837742,506955122,507695561,507929036,508307733,508312691,508999120,509963561,510142147,510698091,510743096,510769317,510957074,511053311,511371367,511409911,511432960,511642385,511691964,511730908,
Post-pr: avg 511971266.5 ns, regressed 0.88%
502744835,506502498,507735420,507929724,508313335,509548582,509994942,510107257,510715603,511046955,511352639,511458478,512117521,512317380,512766303,512972652,513059586,513804934,513808980,514059409,514187369,514389494,514447762,514616464,514622882,514641763,514666265,514716377,514990179,515502408,
```
Compaction
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{pre|post}_pr --benchmark_filter=ManualCompaction/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark
Pre-pr: avg 495346098.30 ns
492118301,493203526,494201411,494336607,495269217,495404950,496402598,497012157,497358370,498153846
Post-pr: avg 504528077.20, regressed 1.85%. "ManualCompaction" include flush so the isolated regression for compaction should be around 1.85-0.88 = 0.97%
502465338,502485945,502541789,502909283,503438601,504143885,506113087,506629423,507160414,507393007
```
Put with WAL (in case passing WriteOptions slows down this path even without collecting SST write stats)
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark
Pre-pr: avg 3848.10 ns
3814,3838,3839,3848,3854,3854,3854,3860,3860,3860
Post-pr: avg 3874.20 ns, regressed 0.68%
3863,3867,3871,3874,3875,3877,3877,3877,3880,3881
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11910
Reviewed By: ajkr
Differential Revision: D49788060
Pulled By: hx235
fbshipit-source-id: 79e73699cda5be3b66461687e5147c2484fc5eff
2023-12-29 23:29:23 +00:00
|
|
|
class DbStressWritableFileWrapper : public FSWritableFileOwnerWrapper {
|
|
|
|
public:
|
|
|
|
explicit DbStressWritableFileWrapper(std::unique_ptr<FSWritableFile>&& target)
|
|
|
|
: FSWritableFileOwnerWrapper(std::move(target)) {}
|
|
|
|
|
|
|
|
IOStatus Append(const Slice& data, const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Append(data, options, dbg);
|
|
|
|
}
|
|
|
|
IOStatus Append(const Slice& data, const IOOptions& options,
|
|
|
|
const DataVerificationInfo& verification_info,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Append(data, options, verification_info, dbg);
|
|
|
|
}
|
|
|
|
IOStatus PositionedAppend(const Slice& data, uint64_t offset,
|
|
|
|
const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->PositionedAppend(data, offset, options, dbg);
|
|
|
|
}
|
|
|
|
IOStatus PositionedAppend(const Slice& data, uint64_t offset,
|
|
|
|
const IOOptions& options,
|
|
|
|
const DataVerificationInfo& verification_info,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->PositionedAppend(data, offset, options, verification_info,
|
|
|
|
dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual IOStatus Truncate(uint64_t size, const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Truncate(size, options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual IOStatus Close(const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Close(options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual IOStatus Flush(const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Flush(options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual IOStatus Sync(const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Sync(options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
virtual IOStatus Fsync(const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Fsync(options, dbg);
|
|
|
|
}
|
|
|
|
|
|
|
|
#ifdef ROCKSDB_FALLOCATE_PRESENT
|
|
|
|
virtual IOStatus Allocate(uint64_t offset, uint64_t len,
|
|
|
|
const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->Allocate(offset, len, options, dbg);
|
|
|
|
}
|
|
|
|
#endif
|
|
|
|
|
|
|
|
virtual IOStatus RangeSync(uint64_t offset, uint64_t nbytes,
|
|
|
|
const IOOptions& options,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
#ifndef NDEBUG
|
|
|
|
const ThreadStatus::OperationType thread_op =
|
|
|
|
ThreadStatusUtil::GetThreadOperation();
|
|
|
|
Env::IOActivity io_activity =
|
|
|
|
ThreadStatusUtil::TEST_GetExpectedIOActivity(thread_op);
|
|
|
|
assert(io_activity == Env::IOActivity::kUnknown ||
|
|
|
|
io_activity == options.io_activity);
|
|
|
|
#endif
|
|
|
|
return target()->RangeSync(offset, nbytes, options, dbg);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2022-12-15 23:48:50 +00:00
|
|
|
class DbStressFSWrapper : public FileSystemWrapper {
|
2019-12-16 22:28:06 +00:00
|
|
|
public:
|
2022-12-15 23:48:50 +00:00
|
|
|
explicit DbStressFSWrapper(const std::shared_ptr<FileSystem>& t)
|
|
|
|
: FileSystemWrapper(t) {}
|
|
|
|
static const char* kClassName() { return "DbStressFS"; }
|
2022-01-05 00:44:54 +00:00
|
|
|
const char* Name() const override { return kClassName(); }
|
2019-12-16 22:28:06 +00:00
|
|
|
|
2023-04-21 16:07:18 +00:00
|
|
|
IOStatus NewRandomAccessFile(const std::string& f,
|
|
|
|
const FileOptions& file_opts,
|
|
|
|
std::unique_ptr<FSRandomAccessFile>* r,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
std::unique_ptr<FSRandomAccessFile> file;
|
|
|
|
IOStatus s = target()->NewRandomAccessFile(f, file_opts, &file, dbg);
|
|
|
|
if (s.ok()) {
|
|
|
|
r->reset(new DbStressRandomAccessFileWrapper(std::move(file)));
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
Group SST write in flush, compaction and db open with new stats (#11910)
Summary:
## Context/Summary
Similar to https://github.com/facebook/rocksdb/pull/11288, https://github.com/facebook/rocksdb/pull/11444, categorizing SST/blob file write according to different io activities allows more insight into the activity.
For that, this PR does the following:
- Tag different write IOs by passing down and converting WriteOptions to IOOptions
- Add new SST_WRITE_MICROS histogram in WritableFileWriter::Append() and breakdown FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS
Some related code refactory to make implementation cleaner:
- Blob stats
- Replace high-level write measurement with low-level WritableFileWriter::Append() measurement for BLOB_DB_BLOB_FILE_WRITE_MICROS. This is to make FILE_WRITE_{FLUSH|COMPACTION|DB_OPEN}_MICROS include blob file. As a consequence, this introduces some behavioral changes on it, see HISTORY and db bench test plan below for more info.
- Fix bugs where BLOB_DB_BLOB_FILE_SYNCED/BLOB_DB_BLOB_FILE_BYTES_WRITTEN include file failed to sync and bytes failed to write.
- Refactor WriteOptions constructor for easier construction with io_activity and rate_limiter_priority
- Refactor DBImpl::~DBImpl()/BlobDBImpl::Close() to bypass thread op verification
- Build table
- TableBuilderOptions now includes Read/WriteOpitons so BuildTable() do not need to take these two variables
- Replace the io_priority passed into BuildTable() with TableBuilderOptions::WriteOpitons::rate_limiter_priority. Similar for BlobFileBuilder.
This parameter is used for dynamically changing file io priority for flush, see https://github.com/facebook/rocksdb/pull/9988?fbclid=IwAR1DtKel6c-bRJAdesGo0jsbztRtciByNlvokbxkV6h_L-AE9MACzqRTT5s for more
- Update ThreadStatus::FLUSH_BYTES_WRITTEN to use io_activity to track flush IO in flush job and db open instead of io_priority
## Test
### db bench
Flush
```
./db_bench --statistics=1 --benchmarks=fillseq --num=100000 --write_buffer_size=100
rocksdb.sst.write.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377
rocksdb.file.write.flush.micros P50 : 1.830863 P95 : 4.094720 P99 : 6.578947 P100 : 26.000000 COUNT : 7875 SUM : 20377
rocksdb.file.write.compaction.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
rocksdb.file.write.db.open.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
```
compaction, db oopen
```
Setup: ./db_bench --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
Run:./db_bench --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1
rocksdb.sst.write.micros P50 : 2.675325 P95 : 9.578788 P99 : 18.780000 P100 : 314.000000 COUNT : 638 SUM : 3279
rocksdb.file.write.flush.micros P50 : 0.000000 P95 : 0.000000 P99 : 0.000000 P100 : 0.000000 COUNT : 0 SUM : 0
rocksdb.file.write.compaction.micros P50 : 2.757353 P95 : 9.610687 P99 : 19.316667 P100 : 314.000000 COUNT : 615 SUM : 3213
rocksdb.file.write.db.open.micros P50 : 2.055556 P95 : 3.925000 P99 : 9.000000 P100 : 9.000000 COUNT : 23 SUM : 66
```
blob stats - just to make sure they aren't broken by this PR
```
Integrated Blob DB
Setup: ./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
Run:./db_bench --enable_blob_files=1 --statistics=1 --benchmarks=compact --db=../db_bench --use_existing_db=1
pre-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 7.298246 P95 : 9.771930 P99 : 9.991813 P100 : 16.000000 COUNT : 235 SUM : 1600
rocksdb.blobdb.blob.file.synced COUNT : 1
rocksdb.blobdb.blob.file.bytes.written COUNT : 34842
post-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 2.000000 P95 : 2.829360 P99 : 2.993779 P100 : 9.000000 COUNT : 707 SUM : 1614
- COUNT is higher and values are smaller as it includes header and footer write
- COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164
rocksdb.blobdb.blob.file.synced COUNT : 1 (stay the same)
rocksdb.blobdb.blob.file.bytes.written COUNT : 34842 (stay the same)
```
```
Stacked Blob DB
Run: ./db_bench --use_blob_db=1 --statistics=1 --benchmarks=fillseq --num=10000 --disable_auto_compactions=1 -write_buffer_size=100 --db=../db_bench
pre-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 12.808042 P95 : 19.674497 P99 : 28.539683 P100 : 51.000000 COUNT : 10000 SUM : 140876
rocksdb.blobdb.blob.file.synced COUNT : 8
rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445
post-PR:
rocksdb.blobdb.blob.file.write.micros P50 : 1.657370 P95 : 2.952175 P99 : 3.877519 P100 : 24.000000 COUNT : 30001 SUM : 67924
- COUNT is higher and values are smaller as it includes header and footer write
- COUNT is 3X higher due to each Append() count as one post-PR, while in pre-PR, 3 Append()s counts as one. See https://github.com/facebook/rocksdb/pull/11910/files#diff-32b811c0a1c000768cfb2532052b44dc0b3bf82253f3eab078e15ff201a0dabfL157-L164
rocksdb.blobdb.blob.file.synced COUNT : 8 (stay the same)
rocksdb.blobdb.blob.file.bytes.written COUNT : 1043445 (stay the same)
```
### Rehearsal CI stress test
Trigger 3 full runs of all our CI stress tests
### Performance
Flush
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=ManualFlush/key_num:524288/per_key_size:256 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark; enable_statistics = true
Pre-pr: avg 507515519.3 ns
497686074,499444327,500862543,501389862,502994471,503744435,504142123,504224056,505724198,506610393,506837742,506955122,507695561,507929036,508307733,508312691,508999120,509963561,510142147,510698091,510743096,510769317,510957074,511053311,511371367,511409911,511432960,511642385,511691964,511730908,
Post-pr: avg 511971266.5 ns, regressed 0.88%
502744835,506502498,507735420,507929724,508313335,509548582,509994942,510107257,510715603,511046955,511352639,511458478,512117521,512317380,512766303,512972652,513059586,513804934,513808980,514059409,514187369,514389494,514447762,514616464,514622882,514641763,514666265,514716377,514990179,515502408,
```
Compaction
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_{pre|post}_pr --benchmark_filter=ManualCompaction/comp_style:0/max_data:134217728/per_key_size:256/enable_statistics:1 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark
Pre-pr: avg 495346098.30 ns
492118301,493203526,494201411,494336607,495269217,495404950,496402598,497012157,497358370,498153846
Post-pr: avg 504528077.20, regressed 1.85%. "ManualCompaction" include flush so the isolated regression for compaction should be around 1.85-0.88 = 0.97%
502465338,502485945,502541789,502909283,503438601,504143885,506113087,506629423,507160414,507393007
```
Put with WAL (in case passing WriteOptions slows down this path even without collecting SST write stats)
```
TEST_TMPDIR=/dev/shm ./db_basic_bench_pre_pr --benchmark_filter=DBPut/comp_style:0/max_data:107374182400/per_key_size:256/enable_statistics:1/wal:1 --benchmark_repetitions=1000
-- default: 1 thread is used to run benchmark
Pre-pr: avg 3848.10 ns
3814,3838,3839,3848,3854,3854,3854,3860,3860,3860
Post-pr: avg 3874.20 ns, regressed 0.68%
3863,3867,3871,3874,3875,3877,3877,3877,3880,3881
```
Pull Request resolved: https://github.com/facebook/rocksdb/pull/11910
Reviewed By: ajkr
Differential Revision: D49788060
Pulled By: hx235
fbshipit-source-id: 79e73699cda5be3b66461687e5147c2484fc5eff
2023-12-29 23:29:23 +00:00
|
|
|
IOStatus NewWritableFile(const std::string& f, const FileOptions& file_opts,
|
|
|
|
std::unique_ptr<FSWritableFile>* r,
|
|
|
|
IODebugContext* dbg) override {
|
|
|
|
std::unique_ptr<FSWritableFile> file;
|
|
|
|
IOStatus s = target()->NewWritableFile(f, file_opts, &file, dbg);
|
|
|
|
if (s.ok()) {
|
|
|
|
r->reset(new DbStressWritableFileWrapper(std::move(file)));
|
|
|
|
}
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2022-12-15 23:48:50 +00:00
|
|
|
IOStatus DeleteFile(const std::string& f, const IOOptions& opts,
|
|
|
|
IODebugContext* dbg) override {
|
2019-12-16 22:28:06 +00:00
|
|
|
// We determine whether it is a manifest file by searching a strong,
|
|
|
|
// so that there will be false positive if the directory path contains the
|
|
|
|
// keyword but it is unlikely.
|
Fix, enable, and enhance backup/restore in db_stress (#7348)
Summary:
Although added to db_stress, testing of backup/restore
was never integrated into the crash test, originally concerned about
performance. I've enabled it now and to address the peformance concern,
testing backup/restore is always skipped once the db exceeds a certain
size threshold, default 100MB. This should provide sufficient
opportunity for testing BackupEngine without bogging down everything
else with heavier and heavier operations.
Also fixed backup/restore in db_stress by making sure PurgeOldBackups
can remove manifest files, which are normally kept around for db_stress.
Added more coverage of backup options, and up to three backups being
saved in one backup directory (in some cases).
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7348
Test Plan:
ran 'make blackbox_crash_test' for a while, with heightened
probabilitly of taking backups (1/10k). Also confirmed with some debug
output that the code is being covered, TestBackupRestore only takes
a few seconds to complete when triggered, and even at 1/10k and ~50MB
database, there's <,~ 1 thread testing backups at any time.
Reviewed By: ajkr
Differential Revision: D23510835
Pulled By: pdillinger
fbshipit-source-id: b6b8735591808141f81f10773ac31634cf03b6c0
2020-09-04 03:11:45 +00:00
|
|
|
// Checkpoint, backup, and restore directories needs to be exempted.
|
2019-12-16 22:28:06 +00:00
|
|
|
if (!if_preserve_all_manifests ||
|
2019-12-21 06:08:44 +00:00
|
|
|
f.find("MANIFEST-") == std::string::npos ||
|
Fix, enable, and enhance backup/restore in db_stress (#7348)
Summary:
Although added to db_stress, testing of backup/restore
was never integrated into the crash test, originally concerned about
performance. I've enabled it now and to address the peformance concern,
testing backup/restore is always skipped once the db exceeds a certain
size threshold, default 100MB. This should provide sufficient
opportunity for testing BackupEngine without bogging down everything
else with heavier and heavier operations.
Also fixed backup/restore in db_stress by making sure PurgeOldBackups
can remove manifest files, which are normally kept around for db_stress.
Added more coverage of backup options, and up to three backups being
saved in one backup directory (in some cases).
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7348
Test Plan:
ran 'make blackbox_crash_test' for a while, with heightened
probabilitly of taking backups (1/10k). Also confirmed with some debug
output that the code is being covered, TestBackupRestore only takes
a few seconds to complete when triggered, and even at 1/10k and ~50MB
database, there's <,~ 1 thread testing backups at any time.
Reviewed By: ajkr
Differential Revision: D23510835
Pulled By: pdillinger
fbshipit-source-id: b6b8735591808141f81f10773ac31634cf03b6c0
2020-09-04 03:11:45 +00:00
|
|
|
f.find("checkpoint") != std::string::npos ||
|
|
|
|
f.find(".backup") != std::string::npos ||
|
|
|
|
f.find(".restore") != std::string::npos) {
|
2022-12-15 23:48:50 +00:00
|
|
|
return target()->DeleteFile(f, opts, dbg);
|
2019-12-16 22:28:06 +00:00
|
|
|
}
|
2021-04-28 17:57:11 +00:00
|
|
|
// Rename the file instead of deletion to keep the history, and
|
|
|
|
// at the same time it is not visible to RocksDB.
|
2022-12-15 23:48:50 +00:00
|
|
|
return target()->RenameFile(f, f + "_renamed_", opts, dbg);
|
2019-12-16 22:28:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// If true, all manifest files will not be delted in DeleteFile().
|
|
|
|
bool if_preserve_all_manifests = true;
|
|
|
|
};
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
2019-12-16 22:28:06 +00:00
|
|
|
#endif // GFLAGS
|