2016-02-09 23:12:00 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2014-08-12 03:21:07 +00:00
|
|
|
|
2015-07-20 17:50:46 +00:00
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
|
2019-05-31 18:52:59 +00:00
|
|
|
#include "db/db_impl/db_impl.h"
|
2014-08-12 03:21:07 +00:00
|
|
|
#include "rocksdb/db.h"
|
|
|
|
#include "rocksdb/env.h"
|
2019-05-30 21:47:29 +00:00
|
|
|
#include "table/cuckoo/cuckoo_table_factory.h"
|
|
|
|
#include "table/cuckoo/cuckoo_table_reader.h"
|
2017-04-06 21:49:13 +00:00
|
|
|
#include "table/meta_blocks.h"
|
2019-05-30 18:21:38 +00:00
|
|
|
#include "test_util/testharness.h"
|
|
|
|
#include "test_util/testutil.h"
|
2020-07-03 02:24:25 +00:00
|
|
|
#include "util/cast_util.h"
|
2019-05-31 00:39:43 +00:00
|
|
|
#include "util/string_util.h"
|
2014-08-12 03:21:07 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2014-08-12 03:21:07 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
class CuckooTableDBTest : public testing::Test {
|
2014-08-12 03:21:07 +00:00
|
|
|
private:
|
|
|
|
std::string dbname_;
|
|
|
|
Env* env_;
|
|
|
|
DB* db_;
|
|
|
|
|
|
|
|
public:
|
|
|
|
CuckooTableDBTest() : env_(Env::Default()) {
|
2018-07-14 00:18:39 +00:00
|
|
|
dbname_ = test::PerThreadDBPath("cuckoo_table_db_test");
|
rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value
Summary:
gtest does not use exceptions to fail a unit test by design, and `ASSERT*`s are implemented using `return`. As a consequence we cannot use `ASSERT*` in a function that does not return `void` value ([[ https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement | 1]]), and have to fix our existing code. This diff does this in a generic way, with no manual changes.
In order to detect all existing `ASSERT*` that are used in functions that doesn't return void value, I change the code to generate compile errors for such cases.
In `util/testharness.h` I defined `EXPECT*` assertions, the same way as `ASSERT*`, and redefined `ASSERT*` to return `void`. Then executed:
```lang=bash
% USE_CLANG=1 make all -j55 -k 2> build.log
% perl -naF: -e 'print "-- -number=".$F[1]." ".$F[0]."\n" if /: error:/' \
build.log | xargs -L 1 perl -spi -e 's/ASSERT/EXPECT/g if $. == $number'
% make format
```
After that I reverted back change to `ASSERT*` in `util/testharness.h`. But preserved introduced `EXPECT*`, which is the same as `ASSERT*`. This will be deleted once switched to gtest.
This diff is independent and contains manual changes only in `util/testharness.h`.
Test Plan:
Make sure all tests are passing.
```lang=bash
% USE_CLANG=1 make check
```
Reviewers: igor, lgalanis, sdong, yufei.zhu, rven, meyering
Reviewed By: meyering
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D33333
2015-03-17 03:52:32 +00:00
|
|
|
EXPECT_OK(DestroyDB(dbname_, Options()));
|
2014-08-12 03:21:07 +00:00
|
|
|
db_ = nullptr;
|
|
|
|
Reopen();
|
|
|
|
}
|
|
|
|
|
2019-02-14 21:52:47 +00:00
|
|
|
~CuckooTableDBTest() override {
|
2014-08-12 03:21:07 +00:00
|
|
|
delete db_;
|
rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value
Summary:
gtest does not use exceptions to fail a unit test by design, and `ASSERT*`s are implemented using `return`. As a consequence we cannot use `ASSERT*` in a function that does not return `void` value ([[ https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement | 1]]), and have to fix our existing code. This diff does this in a generic way, with no manual changes.
In order to detect all existing `ASSERT*` that are used in functions that doesn't return void value, I change the code to generate compile errors for such cases.
In `util/testharness.h` I defined `EXPECT*` assertions, the same way as `ASSERT*`, and redefined `ASSERT*` to return `void`. Then executed:
```lang=bash
% USE_CLANG=1 make all -j55 -k 2> build.log
% perl -naF: -e 'print "-- -number=".$F[1]." ".$F[0]."\n" if /: error:/' \
build.log | xargs -L 1 perl -spi -e 's/ASSERT/EXPECT/g if $. == $number'
% make format
```
After that I reverted back change to `ASSERT*` in `util/testharness.h`. But preserved introduced `EXPECT*`, which is the same as `ASSERT*`. This will be deleted once switched to gtest.
This diff is independent and contains manual changes only in `util/testharness.h`.
Test Plan:
Make sure all tests are passing.
```lang=bash
% USE_CLANG=1 make check
```
Reviewers: igor, lgalanis, sdong, yufei.zhu, rven, meyering
Reviewed By: meyering
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D33333
2015-03-17 03:52:32 +00:00
|
|
|
EXPECT_OK(DestroyDB(dbname_, Options()));
|
2014-08-12 03:21:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
Options CurrentOptions() {
|
|
|
|
Options options;
|
|
|
|
options.table_factory.reset(NewCuckooTableFactory());
|
|
|
|
options.memtable_factory.reset(NewHashLinkListRepFactory(4, 0, 3, true));
|
|
|
|
options.allow_mmap_reads = true;
|
|
|
|
options.create_if_missing = true;
|
2016-11-16 17:24:52 +00:00
|
|
|
options.allow_concurrent_memtable_write = false;
|
2014-08-12 03:21:07 +00:00
|
|
|
return options;
|
|
|
|
}
|
|
|
|
|
2020-07-03 02:24:25 +00:00
|
|
|
DBImpl* dbfull() { return static_cast_with_check<DBImpl>(db_); }
|
2014-08-12 03:21:07 +00:00
|
|
|
|
|
|
|
// The following util methods are copied from plain_table_db_test.
|
|
|
|
void Reopen(Options* options = nullptr) {
|
|
|
|
delete db_;
|
|
|
|
db_ = nullptr;
|
|
|
|
Options opts;
|
|
|
|
if (options != nullptr) {
|
|
|
|
opts = *options;
|
|
|
|
} else {
|
|
|
|
opts = CurrentOptions();
|
|
|
|
opts.create_if_missing = true;
|
|
|
|
}
|
|
|
|
ASSERT_OK(DB::Open(opts, dbname_, &db_));
|
|
|
|
}
|
|
|
|
|
Fix a recovery corner case (#7621)
Summary:
Consider the following sequence of events:
1. Db flushed an SST with file number N, appended to MANIFEST, and tried to sync the MANIFEST.
2. Syncing MANIFEST failed and db crashed.
3. Db tried to recover with this MANIFEST. In the meantime, no entry about the newly-flushed SST was found in the MANIFEST. Therefore, RocksDB replayed WAL and tried to flush to an SST file reusing the same file number N. This failed because file system does not support overwrite. Then Db deleted this file.
4. Db crashed again.
5. Db tried to recover. When db read the MANIFEST, there was an entry referencing N.sst. This could happen probably because the append in step 1 finally reached the MANIFEST and became visible. Since N.sst had been deleted in step 3, recovery failed.
It is possible that N.sst created in step 1 is valid. Although step 3 would still fail since the MANIFEST was not synced properly in step 1 and 2, deleting N.sst would make it impossible for the db to recover even if the remaining part of MANIFEST was appended and visible after step 5.
After this PR, in step 3, immediately after recovering from MANIFEST, a new MANIFEST is created, then we find that N.sst is not referenced in the MANIFEST, so we delete it, and we'll not reuse N as file number. Then in step 5, since the new MANIFEST does not contain N.sst, the recovery failure situation in step 5 won't happen.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7621
Test Plan:
1. some tests are updated, because these tests assume that new MANIFEST is created after WAL recovery.
2. a new unit test is added in db_basic_test to simulate step 3.
Reviewed By: riversand963
Differential Revision: D24668144
Pulled By: cheng-chang
fbshipit-source-id: 90d7487fbad2bc3714f5ede46ea949895b15ae3b
2020-11-08 05:54:55 +00:00
|
|
|
void DestroyAndReopen(Options* options) {
|
|
|
|
assert(options);
|
|
|
|
ASSERT_OK(db_->Close());
|
|
|
|
delete db_;
|
|
|
|
db_ = nullptr;
|
|
|
|
ASSERT_OK(DestroyDB(dbname_, *options));
|
|
|
|
Reopen(options);
|
|
|
|
}
|
|
|
|
|
2014-08-12 03:21:07 +00:00
|
|
|
Status Put(const Slice& k, const Slice& v) {
|
|
|
|
return db_->Put(WriteOptions(), k, v);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status Delete(const std::string& k) {
|
|
|
|
return db_->Delete(WriteOptions(), k);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::string Get(const std::string& k) {
|
|
|
|
ReadOptions options;
|
|
|
|
std::string result;
|
|
|
|
Status s = db_->Get(options, k, &result);
|
|
|
|
if (s.IsNotFound()) {
|
|
|
|
result = "NOT_FOUND";
|
|
|
|
} else if (!s.ok()) {
|
|
|
|
result = s.ToString();
|
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
int NumTableFilesAtLevel(int level) {
|
|
|
|
std::string property;
|
rocksdb: Replace ASSERT* with EXPECT* in functions that does not return void value
Summary:
gtest does not use exceptions to fail a unit test by design, and `ASSERT*`s are implemented using `return`. As a consequence we cannot use `ASSERT*` in a function that does not return `void` value ([[ https://code.google.com/p/googletest/wiki/AdvancedGuide#Assertion_Placement | 1]]), and have to fix our existing code. This diff does this in a generic way, with no manual changes.
In order to detect all existing `ASSERT*` that are used in functions that doesn't return void value, I change the code to generate compile errors for such cases.
In `util/testharness.h` I defined `EXPECT*` assertions, the same way as `ASSERT*`, and redefined `ASSERT*` to return `void`. Then executed:
```lang=bash
% USE_CLANG=1 make all -j55 -k 2> build.log
% perl -naF: -e 'print "-- -number=".$F[1]." ".$F[0]."\n" if /: error:/' \
build.log | xargs -L 1 perl -spi -e 's/ASSERT/EXPECT/g if $. == $number'
% make format
```
After that I reverted back change to `ASSERT*` in `util/testharness.h`. But preserved introduced `EXPECT*`, which is the same as `ASSERT*`. This will be deleted once switched to gtest.
This diff is independent and contains manual changes only in `util/testharness.h`.
Test Plan:
Make sure all tests are passing.
```lang=bash
% USE_CLANG=1 make check
```
Reviewers: igor, lgalanis, sdong, yufei.zhu, rven, meyering
Reviewed By: meyering
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D33333
2015-03-17 03:52:32 +00:00
|
|
|
EXPECT_TRUE(db_->GetProperty(
|
|
|
|
"rocksdb.num-files-at-level" + NumberToString(level), &property));
|
2014-08-12 03:21:07 +00:00
|
|
|
return atoi(property.c_str());
|
|
|
|
}
|
|
|
|
|
|
|
|
// Return spread of files per level
|
|
|
|
std::string FilesPerLevel() {
|
|
|
|
std::string result;
|
2014-11-11 21:47:22 +00:00
|
|
|
size_t last_non_zero_offset = 0;
|
2014-08-12 03:21:07 +00:00
|
|
|
for (int level = 0; level < db_->NumberLevels(); level++) {
|
|
|
|
int f = NumTableFilesAtLevel(level);
|
|
|
|
char buf[100];
|
|
|
|
snprintf(buf, sizeof(buf), "%s%d", (level ? "," : ""), f);
|
|
|
|
result += buf;
|
|
|
|
if (f > 0) {
|
|
|
|
last_non_zero_offset = result.size();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
result.resize(last_non_zero_offset);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, Flush) {
|
2014-08-12 03:21:07 +00:00
|
|
|
// Try with empty DB first.
|
|
|
|
ASSERT_TRUE(dbfull() != nullptr);
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get("key2"));
|
|
|
|
|
|
|
|
// Add some values to db.
|
|
|
|
Options options = CurrentOptions();
|
|
|
|
Reopen(&options);
|
|
|
|
|
|
|
|
ASSERT_OK(Put("key1", "v1"));
|
|
|
|
ASSERT_OK(Put("key2", "v2"));
|
|
|
|
ASSERT_OK(Put("key3", "v3"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
TablePropertiesCollection ptc;
|
|
|
|
reinterpret_cast<DB*>(dbfull())->GetPropertiesOfAllTables(&ptc);
|
|
|
|
ASSERT_EQ(1U, ptc.size());
|
2014-08-13 00:35:09 +00:00
|
|
|
ASSERT_EQ(3U, ptc.begin()->second->num_entries);
|
2014-08-12 03:21:07 +00:00
|
|
|
ASSERT_EQ("1", FilesPerLevel());
|
|
|
|
|
|
|
|
ASSERT_EQ("v1", Get("key1"));
|
|
|
|
ASSERT_EQ("v2", Get("key2"));
|
|
|
|
ASSERT_EQ("v3", Get("key3"));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get("key4"));
|
|
|
|
|
|
|
|
// Now add more keys and flush.
|
|
|
|
ASSERT_OK(Put("key4", "v4"));
|
|
|
|
ASSERT_OK(Put("key5", "v5"));
|
|
|
|
ASSERT_OK(Put("key6", "v6"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
reinterpret_cast<DB*>(dbfull())->GetPropertiesOfAllTables(&ptc);
|
|
|
|
ASSERT_EQ(2U, ptc.size());
|
|
|
|
auto row = ptc.begin();
|
2014-08-13 00:35:09 +00:00
|
|
|
ASSERT_EQ(3U, row->second->num_entries);
|
|
|
|
ASSERT_EQ(3U, (++row)->second->num_entries);
|
2014-08-12 03:21:07 +00:00
|
|
|
ASSERT_EQ("2", FilesPerLevel());
|
|
|
|
ASSERT_EQ("v1", Get("key1"));
|
|
|
|
ASSERT_EQ("v2", Get("key2"));
|
|
|
|
ASSERT_EQ("v3", Get("key3"));
|
|
|
|
ASSERT_EQ("v4", Get("key4"));
|
|
|
|
ASSERT_EQ("v5", Get("key5"));
|
|
|
|
ASSERT_EQ("v6", Get("key6"));
|
|
|
|
|
|
|
|
ASSERT_OK(Delete("key6"));
|
|
|
|
ASSERT_OK(Delete("key5"));
|
|
|
|
ASSERT_OK(Delete("key4"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
reinterpret_cast<DB*>(dbfull())->GetPropertiesOfAllTables(&ptc);
|
|
|
|
ASSERT_EQ(3U, ptc.size());
|
|
|
|
row = ptc.begin();
|
2014-08-13 00:35:09 +00:00
|
|
|
ASSERT_EQ(3U, row->second->num_entries);
|
|
|
|
ASSERT_EQ(3U, (++row)->second->num_entries);
|
|
|
|
ASSERT_EQ(3U, (++row)->second->num_entries);
|
2014-08-12 03:21:07 +00:00
|
|
|
ASSERT_EQ("3", FilesPerLevel());
|
|
|
|
ASSERT_EQ("v1", Get("key1"));
|
|
|
|
ASSERT_EQ("v2", Get("key2"));
|
|
|
|
ASSERT_EQ("v3", Get("key3"));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get("key4"));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get("key5"));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get("key6"));
|
|
|
|
}
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, FlushWithDuplicateKeys) {
|
2014-08-12 03:21:07 +00:00
|
|
|
Options options = CurrentOptions();
|
|
|
|
Reopen(&options);
|
|
|
|
ASSERT_OK(Put("key1", "v1"));
|
|
|
|
ASSERT_OK(Put("key2", "v2"));
|
|
|
|
ASSERT_OK(Put("key1", "v3")); // Duplicate
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
TablePropertiesCollection ptc;
|
|
|
|
reinterpret_cast<DB*>(dbfull())->GetPropertiesOfAllTables(&ptc);
|
|
|
|
ASSERT_EQ(1U, ptc.size());
|
2014-08-13 00:35:09 +00:00
|
|
|
ASSERT_EQ(2U, ptc.begin()->second->num_entries);
|
2014-08-12 03:21:07 +00:00
|
|
|
ASSERT_EQ("1", FilesPerLevel());
|
|
|
|
ASSERT_EQ("v3", Get("key1"));
|
|
|
|
ASSERT_EQ("v2", Get("key2"));
|
|
|
|
}
|
|
|
|
|
|
|
|
namespace {
|
|
|
|
static std::string Key(int i) {
|
|
|
|
char buf[100];
|
|
|
|
snprintf(buf, sizeof(buf), "key_______%06d", i);
|
|
|
|
return std::string(buf);
|
|
|
|
}
|
2014-08-27 17:39:31 +00:00
|
|
|
static std::string Uint64Key(uint64_t i) {
|
|
|
|
std::string str;
|
|
|
|
str.resize(8);
|
|
|
|
memcpy(&str[0], static_cast<void*>(&i), 8);
|
|
|
|
return str;
|
|
|
|
}
|
|
|
|
} // namespace.
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, Uint64Comparator) {
|
2014-08-27 17:39:31 +00:00
|
|
|
Options options = CurrentOptions();
|
|
|
|
options.comparator = test::Uint64Comparator();
|
Fix a recovery corner case (#7621)
Summary:
Consider the following sequence of events:
1. Db flushed an SST with file number N, appended to MANIFEST, and tried to sync the MANIFEST.
2. Syncing MANIFEST failed and db crashed.
3. Db tried to recover with this MANIFEST. In the meantime, no entry about the newly-flushed SST was found in the MANIFEST. Therefore, RocksDB replayed WAL and tried to flush to an SST file reusing the same file number N. This failed because file system does not support overwrite. Then Db deleted this file.
4. Db crashed again.
5. Db tried to recover. When db read the MANIFEST, there was an entry referencing N.sst. This could happen probably because the append in step 1 finally reached the MANIFEST and became visible. Since N.sst had been deleted in step 3, recovery failed.
It is possible that N.sst created in step 1 is valid. Although step 3 would still fail since the MANIFEST was not synced properly in step 1 and 2, deleting N.sst would make it impossible for the db to recover even if the remaining part of MANIFEST was appended and visible after step 5.
After this PR, in step 3, immediately after recovering from MANIFEST, a new MANIFEST is created, then we find that N.sst is not referenced in the MANIFEST, so we delete it, and we'll not reuse N as file number. Then in step 5, since the new MANIFEST does not contain N.sst, the recovery failure situation in step 5 won't happen.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7621
Test Plan:
1. some tests are updated, because these tests assume that new MANIFEST is created after WAL recovery.
2. a new unit test is added in db_basic_test to simulate step 3.
Reviewed By: riversand963
Differential Revision: D24668144
Pulled By: cheng-chang
fbshipit-source-id: 90d7487fbad2bc3714f5ede46ea949895b15ae3b
2020-11-08 05:54:55 +00:00
|
|
|
DestroyAndReopen(&options);
|
2014-08-27 17:39:31 +00:00
|
|
|
|
|
|
|
ASSERT_OK(Put(Uint64Key(1), "v1"));
|
|
|
|
ASSERT_OK(Put(Uint64Key(2), "v2"));
|
|
|
|
ASSERT_OK(Put(Uint64Key(3), "v3"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
ASSERT_EQ("v1", Get(Uint64Key(1)));
|
|
|
|
ASSERT_EQ("v2", Get(Uint64Key(2)));
|
|
|
|
ASSERT_EQ("v3", Get(Uint64Key(3)));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get(Uint64Key(4)));
|
|
|
|
|
|
|
|
// Add more keys.
|
|
|
|
ASSERT_OK(Delete(Uint64Key(2))); // Delete.
|
2014-09-29 19:14:18 +00:00
|
|
|
dbfull()->TEST_FlushMemTable();
|
2014-08-27 17:39:31 +00:00
|
|
|
ASSERT_OK(Put(Uint64Key(3), "v0")); // Update.
|
|
|
|
ASSERT_OK(Put(Uint64Key(4), "v4"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
ASSERT_EQ("v1", Get(Uint64Key(1)));
|
|
|
|
ASSERT_EQ("NOT_FOUND", Get(Uint64Key(2)));
|
|
|
|
ASSERT_EQ("v0", Get(Uint64Key(3)));
|
|
|
|
ASSERT_EQ("v4", Get(Uint64Key(4)));
|
2014-08-12 03:21:07 +00:00
|
|
|
}
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, CompactionIntoMultipleFiles) {
|
2014-09-05 18:18:01 +00:00
|
|
|
// Create a big L0 file and check it compacts into multiple files in L1.
|
|
|
|
Options options = CurrentOptions();
|
|
|
|
options.write_buffer_size = 270 << 10;
|
|
|
|
// Two SST files should be created, each containing 14 keys.
|
|
|
|
// Number of buckets will be 16. Total size ~156 KB.
|
|
|
|
options.target_file_size_base = 160 << 10;
|
|
|
|
Reopen(&options);
|
|
|
|
|
|
|
|
// Write 28 values, each 10016 B ~ 10KB
|
|
|
|
for (int idx = 0; idx < 28; ++idx) {
|
2017-10-19 17:48:47 +00:00
|
|
|
ASSERT_OK(Put(Key(idx), std::string(10000, 'a' + char(idx))));
|
2014-09-05 18:18:01 +00:00
|
|
|
}
|
|
|
|
dbfull()->TEST_WaitForFlushMemTable();
|
|
|
|
ASSERT_EQ("1", FilesPerLevel());
|
|
|
|
|
Allowing L0 -> L1 trivial move on sorted data
Summary:
This diff updates the logic of how we do trivial move, now trivial move can run on any number of files in input level as long as they are not overlapping
The conditions for trivial move have been updated
Introduced conditions:
- Trivial move cannot happen if we have a compaction filter (except if the compaction is not manual)
- Input level files cannot be overlapping
Removed conditions:
- Trivial move only run when the compaction is not manual
- Input level should can contain only 1 file
More context on what tests failed because of Trivial move
```
DBTest.CompactionsGenerateMultipleFiles
This test is expecting compaction on a file in L0 to generate multiple files in L1, this test will fail with trivial move because we end up with one file in L1
```
```
DBTest.NoSpaceCompactRange
This test expect compaction to fail when we force environment to report running out of space, of course this is not valid in trivial move situation
because trivial move does not need any extra space, and did not check for that
```
```
DBTest.DropWrites
Similar to DBTest.NoSpaceCompactRange
```
```
DBTest.DeleteObsoleteFilesPendingOutputs
This test expect that a file in L2 is deleted after it's moved to L3, this is not valid with trivial move because although the file was moved it is now used by L3
```
```
CuckooTableDBTest.CompactionIntoMultipleFiles
Same as DBTest.CompactionsGenerateMultipleFiles
```
This diff is based on a work by @sdong https://reviews.facebook.net/D34149
Test Plan: make -j64 check
Reviewers: rven, sdong, igor
Reviewed By: igor
Subscribers: yhchiang, ott, march, dhruba, sdong
Differential Revision: https://reviews.facebook.net/D34797
2015-06-04 23:51:25 +00:00
|
|
|
dbfull()->TEST_CompactRange(0, nullptr, nullptr, nullptr,
|
|
|
|
true /* disallow trivial move */);
|
2014-09-05 18:18:01 +00:00
|
|
|
ASSERT_EQ("0,2", FilesPerLevel());
|
|
|
|
for (int idx = 0; idx < 28; ++idx) {
|
2017-10-19 17:48:47 +00:00
|
|
|
ASSERT_EQ(std::string(10000, 'a' + char(idx)), Get(Key(idx)));
|
2014-09-05 18:18:01 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, SameKeyInsertedInTwoDifferentFilesAndCompacted) {
|
2014-08-12 03:21:07 +00:00
|
|
|
// Insert same key twice so that they go to different SST files. Then wait for
|
|
|
|
// compaction and check if the latest value is stored and old value removed.
|
|
|
|
Options options = CurrentOptions();
|
|
|
|
options.write_buffer_size = 100 << 10; // 100KB
|
|
|
|
options.level0_file_num_compaction_trigger = 2;
|
|
|
|
Reopen(&options);
|
|
|
|
|
|
|
|
// Write 11 values, each 10016 B
|
|
|
|
for (int idx = 0; idx < 11; ++idx) {
|
|
|
|
ASSERT_OK(Put(Key(idx), std::string(10000, 'a')));
|
|
|
|
}
|
|
|
|
dbfull()->TEST_WaitForFlushMemTable();
|
|
|
|
ASSERT_EQ("1", FilesPerLevel());
|
|
|
|
|
|
|
|
// Generate one more file in level-0, and should trigger level-0 compaction
|
|
|
|
for (int idx = 0; idx < 11; ++idx) {
|
2017-10-19 17:48:47 +00:00
|
|
|
ASSERT_OK(Put(Key(idx), std::string(10000, 'a' + char(idx))));
|
2014-08-12 03:21:07 +00:00
|
|
|
}
|
|
|
|
dbfull()->TEST_WaitForFlushMemTable();
|
|
|
|
dbfull()->TEST_CompactRange(0, nullptr, nullptr);
|
|
|
|
|
|
|
|
ASSERT_EQ("0,1", FilesPerLevel());
|
|
|
|
for (int idx = 0; idx < 11; ++idx) {
|
2017-10-19 17:48:47 +00:00
|
|
|
ASSERT_EQ(std::string(10000, 'a' + char(idx)), Get(Key(idx)));
|
2014-08-12 03:21:07 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(CuckooTableDBTest, AdaptiveTable) {
|
2014-08-12 03:21:07 +00:00
|
|
|
Options options = CurrentOptions();
|
|
|
|
|
2019-10-21 23:51:19 +00:00
|
|
|
// Ensure options compatible with PlainTable
|
|
|
|
options.prefix_extractor.reset(NewCappedPrefixTransform(8));
|
|
|
|
|
2014-08-12 03:21:07 +00:00
|
|
|
// Write some keys using cuckoo table.
|
|
|
|
options.table_factory.reset(NewCuckooTableFactory());
|
|
|
|
Reopen(&options);
|
|
|
|
|
|
|
|
ASSERT_OK(Put("key1", "v1"));
|
|
|
|
ASSERT_OK(Put("key2", "v2"));
|
|
|
|
ASSERT_OK(Put("key3", "v3"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
// Write some keys using plain table.
|
2020-02-14 16:15:24 +00:00
|
|
|
std::shared_ptr<TableFactory> block_based_factory(
|
|
|
|
NewBlockBasedTableFactory());
|
|
|
|
std::shared_ptr<TableFactory> plain_table_factory(
|
|
|
|
NewPlainTableFactory());
|
|
|
|
std::shared_ptr<TableFactory> cuckoo_table_factory(
|
|
|
|
NewCuckooTableFactory());
|
2014-08-12 03:21:07 +00:00
|
|
|
options.create_if_missing = false;
|
2020-02-14 16:15:24 +00:00
|
|
|
options.table_factory.reset(NewAdaptiveTableFactory(
|
|
|
|
plain_table_factory, block_based_factory, plain_table_factory,
|
|
|
|
cuckoo_table_factory));
|
2014-08-12 03:21:07 +00:00
|
|
|
Reopen(&options);
|
|
|
|
ASSERT_OK(Put("key4", "v4"));
|
|
|
|
ASSERT_OK(Put("key1", "v5"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
// Write some keys using block based table.
|
2020-02-14 16:15:24 +00:00
|
|
|
options.table_factory.reset(NewAdaptiveTableFactory(
|
|
|
|
block_based_factory, block_based_factory, plain_table_factory,
|
|
|
|
cuckoo_table_factory));
|
2014-08-12 03:21:07 +00:00
|
|
|
Reopen(&options);
|
|
|
|
ASSERT_OK(Put("key5", "v6"));
|
|
|
|
ASSERT_OK(Put("key2", "v7"));
|
|
|
|
dbfull()->TEST_FlushMemTable();
|
|
|
|
|
|
|
|
ASSERT_EQ("v5", Get("key1"));
|
|
|
|
ASSERT_EQ("v7", Get("key2"));
|
|
|
|
ASSERT_EQ("v3", Get("key3"));
|
|
|
|
ASSERT_EQ("v4", Get("key4"));
|
|
|
|
ASSERT_EQ("v6", Get("key5"));
|
|
|
|
}
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
2014-08-12 03:21:07 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
int main(int argc, char** argv) {
|
2020-02-20 20:07:53 +00:00
|
|
|
if (ROCKSDB_NAMESPACE::port::kLittleEndian) {
|
2017-04-22 03:41:37 +00:00
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
return RUN_ALL_TESTS();
|
2020-02-20 20:07:53 +00:00
|
|
|
} else {
|
2017-04-22 03:41:37 +00:00
|
|
|
fprintf(stderr, "SKIPPED as Cuckoo table doesn't support Big Endian\n");
|
|
|
|
return 0;
|
|
|
|
}
|
2015-03-17 21:08:00 +00:00
|
|
|
}
|
2015-07-20 17:50:46 +00:00
|
|
|
|
|
|
|
#else
|
|
|
|
#include <stdio.h>
|
|
|
|
|
2018-04-16 00:19:57 +00:00
|
|
|
int main(int /*argc*/, char** /*argv*/) {
|
2015-07-20 17:50:46 +00:00
|
|
|
fprintf(stderr, "SKIPPED as Cuckoo table is not supported in ROCKSDB_LITE\n");
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif // ROCKSDB_LITE
|