2017-06-26 23:52:06 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2017-06-26 23:52:06 +00:00
|
|
|
//
|
|
|
|
#include "db/db_test_util.h"
|
|
|
|
#include "port/stack_trace.h"
|
|
|
|
#include "rocksdb/perf_context.h"
|
|
|
|
#if !defined(ROCKSDB_LITE)
|
2019-05-30 18:21:38 +00:00
|
|
|
#include "test_util/sync_point.h"
|
2017-06-26 23:52:06 +00:00
|
|
|
#endif
|
|
|
|
#include <iostream>
|
|
|
|
#include <string>
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2017-06-26 23:52:06 +00:00
|
|
|
|
|
|
|
class DBEncryptionTest : public DBTestBase {
|
|
|
|
public:
|
2020-08-18 01:41:20 +00:00
|
|
|
DBEncryptionTest()
|
2021-07-23 15:37:27 +00:00
|
|
|
: DBTestBase("db_encryption_test", /*env_do_fsync=*/true) {}
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
Env* GetTargetEnv() {
|
|
|
|
if (encrypted_env_ != nullptr) {
|
|
|
|
return (static_cast<EnvWrapper*>(encrypted_env_))->target();
|
|
|
|
} else {
|
|
|
|
return env_;
|
|
|
|
}
|
|
|
|
}
|
2017-06-26 23:52:06 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
|
|
|
|
TEST_F(DBEncryptionTest, CheckEncrypted) {
|
|
|
|
ASSERT_OK(Put("foo567", "v1.fetdq"));
|
|
|
|
ASSERT_OK(Put("bar123", "v2.dfgkjdfghsd"));
|
|
|
|
Close();
|
|
|
|
|
|
|
|
// Open all files and look for the values we've put in there.
|
|
|
|
// They should not be found if encrypted, otherwise
|
|
|
|
// they should be found.
|
|
|
|
std::vector<std::string> fileNames;
|
|
|
|
auto status = env_->GetChildren(dbname_, &fileNames);
|
|
|
|
ASSERT_OK(status);
|
|
|
|
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
Env* target = GetTargetEnv();
|
2017-06-26 23:52:06 +00:00
|
|
|
int hits = 0;
|
|
|
|
for (auto it = fileNames.begin() ; it != fileNames.end(); ++it) {
|
2021-01-09 17:42:21 +00:00
|
|
|
if (*it == "LOCK") {
|
2017-06-26 23:52:06 +00:00
|
|
|
continue;
|
|
|
|
}
|
|
|
|
auto filePath = dbname_ + "/" + *it;
|
2018-11-09 19:17:34 +00:00
|
|
|
std::unique_ptr<SequentialFile> seqFile;
|
2017-06-26 23:52:06 +00:00
|
|
|
auto envOptions = EnvOptions(CurrentOptions());
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
status = target->NewSequentialFile(filePath, &seqFile, envOptions);
|
2017-06-26 23:52:06 +00:00
|
|
|
ASSERT_OK(status);
|
|
|
|
|
|
|
|
uint64_t fileSize;
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
status = target->GetFileSize(filePath, &fileSize);
|
2017-06-26 23:52:06 +00:00
|
|
|
ASSERT_OK(status);
|
|
|
|
|
|
|
|
std::string scratch;
|
|
|
|
scratch.reserve(fileSize);
|
|
|
|
Slice data;
|
|
|
|
status = seqFile->Read(fileSize, &data, (char*)scratch.data());
|
|
|
|
ASSERT_OK(status);
|
|
|
|
|
|
|
|
if (data.ToString().find("foo567") != std::string::npos) {
|
|
|
|
hits++;
|
|
|
|
//std::cout << "Hit in " << filePath << "\n";
|
|
|
|
}
|
|
|
|
if (data.ToString().find("v1.fetdq") != std::string::npos) {
|
|
|
|
hits++;
|
|
|
|
//std::cout << "Hit in " << filePath << "\n";
|
|
|
|
}
|
|
|
|
if (data.ToString().find("bar123") != std::string::npos) {
|
|
|
|
hits++;
|
|
|
|
//std::cout << "Hit in " << filePath << "\n";
|
|
|
|
}
|
|
|
|
if (data.ToString().find("v2.dfgkjdfghsd") != std::string::npos) {
|
|
|
|
hits++;
|
|
|
|
//std::cout << "Hit in " << filePath << "\n";
|
|
|
|
}
|
|
|
|
if (data.ToString().find("dfgk") != std::string::npos) {
|
|
|
|
hits++;
|
|
|
|
//std::cout << "Hit in " << filePath << "\n";
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if (encrypted_env_) {
|
|
|
|
ASSERT_EQ(hits, 0);
|
|
|
|
} else {
|
|
|
|
ASSERT_GE(hits, 4);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-09-06 00:18:36 +00:00
|
|
|
TEST_F(DBEncryptionTest, ReadEmptyFile) {
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
auto defaultEnv = GetTargetEnv();
|
2019-09-06 00:18:36 +00:00
|
|
|
|
|
|
|
// create empty file for reading it back in later
|
|
|
|
auto envOptions = EnvOptions(CurrentOptions());
|
|
|
|
auto filePath = dbname_ + "/empty.empty";
|
|
|
|
|
|
|
|
Status status;
|
|
|
|
{
|
|
|
|
std::unique_ptr<WritableFile> writableFile;
|
|
|
|
status = defaultEnv->NewWritableFile(filePath, &writableFile, envOptions);
|
|
|
|
ASSERT_OK(status);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::unique_ptr<SequentialFile> seqFile;
|
|
|
|
status = defaultEnv->NewSequentialFile(filePath, &seqFile, envOptions);
|
|
|
|
ASSERT_OK(status);
|
|
|
|
|
|
|
|
std::string scratch;
|
|
|
|
Slice data;
|
|
|
|
// reading back 16 bytes from the empty file shouldn't trigger an assertion.
|
|
|
|
// it should just work and return an empty string
|
|
|
|
status = seqFile->Read(16, &data, (char*)scratch.data());
|
|
|
|
ASSERT_OK(status);
|
|
|
|
|
|
|
|
ASSERT_TRUE(data.empty());
|
|
|
|
}
|
|
|
|
|
2017-06-26 23:52:06 +00:00
|
|
|
#endif // ROCKSDB_LITE
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
2017-06-26 23:52:06 +00:00
|
|
|
|
|
|
|
int main(int argc, char** argv) {
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
2017-06-26 23:52:06 +00:00
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
return RUN_ALL_TESTS();
|
|
|
|
}
|