2016-02-09 23:12:00 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
#include <string>
|
|
|
|
|
#include <vector>
|
|
|
|
|
#include <algorithm>
|
|
|
|
|
#include <utility>
|
|
|
|
|
|
2015-08-06 20:23:02 +00:00
|
|
|
#include "db/db_iter.h"
|
2014-07-16 21:51:43 +00:00
|
|
|
#include "db/dbformat.h"
|
|
|
|
|
#include "rocksdb/comparator.h"
|
|
|
|
|
#include "rocksdb/options.h"
|
2015-06-25 16:44:30 +00:00
|
|
|
#include "rocksdb/perf_context.h"
|
2014-07-16 21:51:43 +00:00
|
|
|
#include "rocksdb/slice.h"
|
|
|
|
|
#include "rocksdb/statistics.h"
|
2015-08-19 01:08:49 +00:00
|
|
|
#include "table/iterator_wrapper.h"
|
2017-02-03 00:38:40 +00:00
|
|
|
#include "table/merging_iterator.h"
|
2015-03-20 00:29:37 +00:00
|
|
|
#include "util/string_util.h"
|
2015-08-06 20:23:02 +00:00
|
|
|
#include "util/sync_point.h"
|
2014-07-16 21:51:43 +00:00
|
|
|
#include "util/testharness.h"
|
|
|
|
|
#include "utilities/merge_operators.h"
|
|
|
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
|
|
2014-11-11 21:47:22 +00:00
|
|
|
static uint64_t TestGetTickerCount(const Options& options,
|
2014-07-16 21:51:43 +00:00
|
|
|
Tickers ticker_type) {
|
|
|
|
|
return options.statistics->getTickerCount(ticker_type);
|
|
|
|
|
}
|
|
|
|
|
|
2015-10-12 22:06:38 +00:00
|
|
|
class TestIterator : public InternalIterator {
|
2014-07-16 21:51:43 +00:00
|
|
|
public:
|
|
|
|
|
explicit TestIterator(const Comparator* comparator)
|
|
|
|
|
: initialized_(false),
|
|
|
|
|
valid_(false),
|
|
|
|
|
sequence_number_(0),
|
|
|
|
|
iter_(0),
|
|
|
|
|
cmp(comparator) {}
|
|
|
|
|
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
void AddPut(std::string argkey, std::string argvalue) {
|
|
|
|
|
Add(argkey, kTypeValue, argvalue);
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
2014-11-06 19:14:28 +00:00
|
|
|
void AddDeletion(std::string argkey) {
|
|
|
|
|
Add(argkey, kTypeDeletion, std::string());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
void AddSingleDeletion(std::string argkey) {
|
|
|
|
|
Add(argkey, kTypeSingleDeletion, std::string());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void AddMerge(std::string argkey, std::string argvalue) {
|
|
|
|
|
Add(argkey, kTypeMerge, argvalue);
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
2014-11-06 19:14:28 +00:00
|
|
|
void Add(std::string argkey, ValueType type, std::string argvalue) {
|
2015-08-06 20:23:02 +00:00
|
|
|
Add(argkey, type, argvalue, sequence_number_++);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
void Add(std::string argkey, ValueType type, std::string argvalue,
|
2015-08-19 01:08:49 +00:00
|
|
|
size_t seq_num, bool update_iter = false) {
|
2014-07-16 21:51:43 +00:00
|
|
|
valid_ = true;
|
2015-08-06 20:23:02 +00:00
|
|
|
ParsedInternalKey internal_key(argkey, seq_num, type);
|
2014-11-06 19:14:28 +00:00
|
|
|
data_.push_back(
|
|
|
|
|
std::pair<std::string, std::string>(std::string(), argvalue));
|
2014-07-16 21:51:43 +00:00
|
|
|
AppendInternalKey(&data_.back().first, internal_key);
|
2015-08-19 01:08:49 +00:00
|
|
|
if (update_iter && valid_ && cmp.Compare(data_.back().first, key()) < 0) {
|
|
|
|
|
// insert a key smaller than current key
|
|
|
|
|
Finish();
|
|
|
|
|
// data_[iter_] is not anymore the current element of the iterator.
|
|
|
|
|
// Increment it to reposition it to the right position.
|
|
|
|
|
iter_++;
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// should be called before operations with iterator
|
|
|
|
|
void Finish() {
|
|
|
|
|
initialized_ = true;
|
|
|
|
|
std::sort(data_.begin(), data_.end(),
|
|
|
|
|
[this](std::pair<std::string, std::string> a,
|
|
|
|
|
std::pair<std::string, std::string> b) {
|
|
|
|
|
return (cmp.Compare(a.first, b.first) < 0);
|
|
|
|
|
});
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual bool Valid() const override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
return valid_;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual void SeekToFirst() override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
valid_ = (data_.size() > 0);
|
|
|
|
|
iter_ = 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual void SeekToLast() override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
valid_ = (data_.size() > 0);
|
|
|
|
|
iter_ = data_.size() - 1;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual void Seek(const Slice& target) override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
SeekToFirst();
|
|
|
|
|
if (!valid_) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
while (iter_ < data_.size() &&
|
|
|
|
|
(cmp.Compare(data_[iter_].first, target) < 0)) {
|
|
|
|
|
++iter_;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (iter_ == data_.size()) {
|
|
|
|
|
valid_ = false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-28 01:20:57 +00:00
|
|
|
virtual void SeekForPrev(const Slice& target) override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
SeekForPrevImpl(target, &cmp);
|
|
|
|
|
}
|
|
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
virtual void Next() override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
if (data_.empty() || (iter_ == data_.size() - 1)) {
|
|
|
|
|
valid_ = false;
|
|
|
|
|
} else {
|
|
|
|
|
++iter_;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual void Prev() override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
if (iter_ == 0) {
|
|
|
|
|
valid_ = false;
|
|
|
|
|
} else {
|
|
|
|
|
--iter_;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual Slice key() const override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
return data_[iter_].first;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual Slice value() const override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
return data_[iter_].second;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
virtual Status status() const override {
|
|
|
|
|
assert(initialized_);
|
|
|
|
|
return Status::OK();
|
|
|
|
|
}
|
|
|
|
|
|
Introduce FullMergeV2 (eliminate memcpy from merge operators)
Summary:
This diff update the code to pin the merge operator operands while the merge operation is done, so that we can eliminate the memcpy cost, to do that we need a new public API for FullMerge that replace the std::deque<std::string> with std::vector<Slice>
This diff is stacked on top of D56493 and D56511
In this diff we
- Update FullMergeV2 arguments to be encapsulated in MergeOperationInput and MergeOperationOutput which will make it easier to add new arguments in the future
- Replace std::deque<std::string> with std::vector<Slice> to pass operands
- Replace MergeContext std::deque with std::vector (based on a simple benchmark I ran https://gist.github.com/IslamAbdelRahman/78fc86c9ab9f52b1df791e58943fb187)
- Allow FullMergeV2 output to be an existing operand
```
[Everything in Memtable | 10K operands | 10 KB each | 1 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="mergerandom,readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --merge_keys=10000 --num=10000 --disable_auto_compactions --value_size=10240 --write_buffer_size=1000000000
[FullMergeV2]
readseq : 0.607 micros/op 1648235 ops/sec; 16121.2 MB/s
readseq : 0.478 micros/op 2091546 ops/sec; 20457.2 MB/s
readseq : 0.252 micros/op 3972081 ops/sec; 38850.5 MB/s
readseq : 0.237 micros/op 4218328 ops/sec; 41259.0 MB/s
readseq : 0.247 micros/op 4043927 ops/sec; 39553.2 MB/s
[master]
readseq : 3.935 micros/op 254140 ops/sec; 2485.7 MB/s
readseq : 3.722 micros/op 268657 ops/sec; 2627.7 MB/s
readseq : 3.149 micros/op 317605 ops/sec; 3106.5 MB/s
readseq : 3.125 micros/op 320024 ops/sec; 3130.1 MB/s
readseq : 4.075 micros/op 245374 ops/sec; 2400.0 MB/s
```
```
[Everything in Memtable | 10K operands | 10 KB each | 10 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="mergerandom,readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --merge_keys=1000 --num=10000 --disable_auto_compactions --value_size=10240 --write_buffer_size=1000000000
[FullMergeV2]
readseq : 3.472 micros/op 288018 ops/sec; 2817.1 MB/s
readseq : 2.304 micros/op 434027 ops/sec; 4245.2 MB/s
readseq : 1.163 micros/op 859845 ops/sec; 8410.0 MB/s
readseq : 1.192 micros/op 838926 ops/sec; 8205.4 MB/s
readseq : 1.250 micros/op 800000 ops/sec; 7824.7 MB/s
[master]
readseq : 24.025 micros/op 41623 ops/sec; 407.1 MB/s
readseq : 18.489 micros/op 54086 ops/sec; 529.0 MB/s
readseq : 18.693 micros/op 53495 ops/sec; 523.2 MB/s
readseq : 23.621 micros/op 42335 ops/sec; 414.1 MB/s
readseq : 18.775 micros/op 53262 ops/sec; 521.0 MB/s
```
```
[Everything in Block cache | 10K operands | 10 KB each | 1 operand per key]
[FullMergeV2]
$ DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --num=100000 --db="/dev/shm/merge-random-10K-10KB" --cache_size=1000000000 --use_existing_db --disable_auto_compactions
readseq : 14.741 micros/op 67837 ops/sec; 663.5 MB/s
readseq : 1.029 micros/op 971446 ops/sec; 9501.6 MB/s
readseq : 0.974 micros/op 1026229 ops/sec; 10037.4 MB/s
readseq : 0.965 micros/op 1036080 ops/sec; 10133.8 MB/s
readseq : 0.943 micros/op 1060657 ops/sec; 10374.2 MB/s
[master]
readseq : 16.735 micros/op 59755 ops/sec; 584.5 MB/s
readseq : 3.029 micros/op 330151 ops/sec; 3229.2 MB/s
readseq : 3.136 micros/op 318883 ops/sec; 3119.0 MB/s
readseq : 3.065 micros/op 326245 ops/sec; 3191.0 MB/s
readseq : 3.014 micros/op 331813 ops/sec; 3245.4 MB/s
```
```
[Everything in Block cache | 10K operands | 10 KB each | 10 operand per key]
DEBUG_LEVEL=0 make db_bench -j64 && ./db_bench --benchmarks="readseq,readseq,readseq,readseq,readseq" --merge_operator="max" --num=100000 --db="/dev/shm/merge-random-10-operands-10K-10KB" --cache_size=1000000000 --use_existing_db --disable_auto_compactions
[FullMergeV2]
readseq : 24.325 micros/op 41109 ops/sec; 402.1 MB/s
readseq : 1.470 micros/op 680272 ops/sec; 6653.7 MB/s
readseq : 1.231 micros/op 812347 ops/sec; 7945.5 MB/s
readseq : 1.091 micros/op 916590 ops/sec; 8965.1 MB/s
readseq : 1.109 micros/op 901713 ops/sec; 8819.6 MB/s
[master]
readseq : 27.257 micros/op 36687 ops/sec; 358.8 MB/s
readseq : 4.443 micros/op 225073 ops/sec; 2201.4 MB/s
readseq : 5.830 micros/op 171526 ops/sec; 1677.7 MB/s
readseq : 4.173 micros/op 239635 ops/sec; 2343.8 MB/s
readseq : 4.150 micros/op 240963 ops/sec; 2356.8 MB/s
```
Test Plan: COMPILE_WITH_ASAN=1 make check -j64
Reviewers: yhchiang, andrewkr, sdong
Reviewed By: sdong
Subscribers: lovro, andrewkr, dhruba
Differential Revision: https://reviews.facebook.net/D57075
2016-07-20 16:49:03 +00:00
|
|
|
virtual bool IsKeyPinned() const override { return true; }
|
|
|
|
|
virtual bool IsValuePinned() const override { return true; }
|
|
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
private:
|
|
|
|
|
bool initialized_;
|
|
|
|
|
bool valid_;
|
|
|
|
|
size_t sequence_number_;
|
|
|
|
|
size_t iter_;
|
|
|
|
|
|
|
|
|
|
InternalKeyComparator cmp;
|
|
|
|
|
std::vector<std::pair<std::string, std::string>> data_;
|
|
|
|
|
};
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
class DBIteratorTest : public testing::Test {
|
2014-07-16 21:51:43 +00:00
|
|
|
public:
|
|
|
|
|
Env* env_;
|
|
|
|
|
|
|
|
|
|
DBIteratorTest() : env_(Env::Default()) {}
|
|
|
|
|
};
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorPrevNext) {
|
2014-07-16 21:51:43 +00:00
|
|
|
Options options;
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2015-06-25 16:44:30 +00:00
|
|
|
// Test to check the SeekToLast() with iterate_upper_bound not set
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test to check the SeekToLast() with iterate_upper_bound set
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("d", "val_d");
|
|
|
|
|
internal_iter->AddPut("e", "val_e");
|
|
|
|
|
internal_iter->AddPut("f", "val_f");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("d");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
}
|
|
|
|
|
// Test to check the SeekToLast() iterate_upper_bound set to a key that
|
|
|
|
|
// is not Put yet
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("d", "val_d");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("z");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
}
|
|
|
|
|
// Test to check the SeekToLast() with iterate_upper_bound set to the
|
|
|
|
|
// first key
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("a");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
// Test case to check SeekToLast with iterate_upper_bound set
|
|
|
|
|
// (same key put may times - SeekToLast should start with the
|
|
|
|
|
// maximum sequence id of the upper bound)
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("c");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 7,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
SetPerfLevel(kEnableCount);
|
|
|
|
|
ASSERT_TRUE(GetPerfLevel() == kEnableCount);
|
|
|
|
|
|
2017-06-03 00:12:39 +00:00
|
|
|
get_perf_context()->Reset();
|
2015-06-25 16:44:30 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2017-11-30 06:48:55 +00:00
|
|
|
ASSERT_EQ(static_cast<int>(get_perf_context()->internal_key_skipped_count), 1);
|
2015-06-25 16:44:30 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
|
|
|
|
|
SetPerfLevel(kDisable);
|
|
|
|
|
}
|
|
|
|
|
// Test to check the SeekToLast() with the iterate_upper_bound set
|
|
|
|
|
// (Checking the value of the key which has sequence ids greater than
|
|
|
|
|
// and less that the iterator's sequence id)
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a1");
|
|
|
|
|
internal_iter->AddPut("a", "val_a2");
|
|
|
|
|
internal_iter->AddPut("b", "val_b1");
|
|
|
|
|
internal_iter->AddPut("c", "val_c1");
|
|
|
|
|
internal_iter->AddPut("c", "val_c2");
|
|
|
|
|
internal_iter->AddPut("c", "val_c3");
|
|
|
|
|
internal_iter->AddPut("b", "val_b2");
|
|
|
|
|
internal_iter->AddPut("d", "val_d1");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("c");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 4,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b1");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test to check the SeekToLast() with the iterate_upper_bound set to the
|
|
|
|
|
// key that is deleted
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("a");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
// Test to check the SeekToLast() with the iterate_upper_bound set
|
|
|
|
|
// (Deletion cases)
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("c");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
}
|
|
|
|
|
// Test to check the SeekToLast() with iterate_upper_bound set
|
|
|
|
|
// (Deletion cases - Lot of internal keys after the upper_bound
|
|
|
|
|
// is deleted)
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddDeletion("e");
|
|
|
|
|
internal_iter->AddDeletion("f");
|
|
|
|
|
internal_iter->AddDeletion("g");
|
|
|
|
|
internal_iter->AddDeletion("h");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
Slice prefix("c");
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iterate_upper_bound = &prefix;
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 7,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2015-06-25 16:44:30 +00:00
|
|
|
|
|
|
|
|
SetPerfLevel(kEnableCount);
|
|
|
|
|
ASSERT_TRUE(GetPerfLevel() == kEnableCount);
|
|
|
|
|
|
2017-06-03 00:12:39 +00:00
|
|
|
get_perf_context()->Reset();
|
2015-06-25 16:44:30 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2017-11-30 06:48:55 +00:00
|
|
|
ASSERT_EQ(static_cast<int>(get_perf_context()->internal_delete_skipped_count), 0);
|
2015-06-25 16:44:30 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
|
|
|
|
|
SetPerfLevel(kDisable);
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_b");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorEmpty) {
|
2014-07-16 21:51:43 +00:00
|
|
|
Options options;
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
|
|
|
|
ReadOptions ro;
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 0,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 0,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorUseSkipCountSkips) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2014-07-16 21:51:43 +00:00
|
|
|
Options options;
|
|
|
|
|
options.statistics = rocksdb::CreateDBStatistics();
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
internal_iter->AddPut("a", "a");
|
|
|
|
|
internal_iter->AddPut("b", "b");
|
|
|
|
|
internal_iter->AddPut("c", "c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 2, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "c");
|
2014-07-20 14:56:40 +00:00
|
|
|
ASSERT_EQ(TestGetTickerCount(options, NUMBER_OF_RESEEKS_IN_ITERATION), 1u);
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "b");
|
2014-07-20 14:56:40 +00:00
|
|
|
ASSERT_EQ(TestGetTickerCount(options, NUMBER_OF_RESEEKS_IN_ITERATION), 2u);
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "a");
|
2014-07-20 14:56:40 +00:00
|
|
|
ASSERT_EQ(TestGetTickerCount(options, NUMBER_OF_RESEEKS_IN_ITERATION), 3u);
|
2014-07-16 21:51:43 +00:00
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-20 14:56:40 +00:00
|
|
|
ASSERT_EQ(TestGetTickerCount(options, NUMBER_OF_RESEEKS_IN_ITERATION), 3u);
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorUseSkip) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2014-07-16 21:51:43 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
|
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("b", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-11-25 04:44:49 +00:00
|
|
|
internal_iter->AddPut("c", ToString(k));
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
options.statistics = rocksdb::CreateDBStatistics();
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, i + 2,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
2014-11-25 04:44:49 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), ToString(i));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("b", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "200");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, i + 2,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("b", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "200");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 202,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "200");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "200");
|
|
|
|
|
internal_iter->Finish();
|
2016-03-01 02:38:03 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, i,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "200");
|
|
|
|
|
internal_iter->Finish();
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 200,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "200");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "200");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("b", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-11-25 04:44:49 +00:00
|
|
|
internal_iter->AddPut("d", ToString(k));
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-11-25 04:44:49 +00:00
|
|
|
internal_iter->AddPut("c", ToString(k));
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, i + 2,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
2014-11-25 04:44:49 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), ToString(i));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 0; i < 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("b", "b");
|
|
|
|
|
internal_iter->AddMerge("a", "a");
|
2014-10-31 18:59:54 +00:00
|
|
|
for (size_t k = 0; k < 200; ++k) {
|
2014-11-25 04:44:49 +00:00
|
|
|
internal_iter->AddMerge("c", ToString(k));
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, i + 2,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
std::string merge_result = "0";
|
|
|
|
|
for (size_t j = 1; j <= i; ++j) {
|
2014-11-25 04:44:49 +00:00
|
|
|
merge_result += "," + ToString(j);
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), merge_result);
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "b");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "a");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-03-30 18:57:05 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorSkipInternalKeys) {
|
|
|
|
|
Options options;
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
2017-03-30 18:57:05 +00:00
|
|
|
ReadOptions ro;
|
|
|
|
|
|
|
|
|
|
// Basic test case ... Make sure explicityly passing the default value works.
|
|
|
|
|
// Skipping internal keys is disabled by default, when the value is 0.
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->AddPut("d", "val_d");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 0;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_d");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().ok());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_d");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().ok());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test to make sure that the request will *not* fail as incomplete if
|
|
|
|
|
// num_internal_keys_skipped is *equal* to max_skippable_internal_keys
|
|
|
|
|
// threshold. (It will fail as incomplete only when the threshold is
|
|
|
|
|
// exceeded.)
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().ok());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().ok());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Fail the request as incomplete when num_internal_keys_skipped >
|
|
|
|
|
// max_skippable_internal_keys
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test that the num_internal_keys_skipped counter resets after a successful
|
|
|
|
|
// read.
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddPut("e", "val_e");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Next(); // num_internal_keys_skipped counter resets here.
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test that the num_internal_keys_skipped counter resets after a successful
|
|
|
|
|
// read.
|
|
|
|
|
// Reverse direction
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddPut("e", "val_e");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "e");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_e");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev(); // num_internal_keys_skipped counter resets here.
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test that skipping separate keys is handled
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddPut("e", "val_e");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "e");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_e");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test if alternating puts and deletes of the same key are handled correctly.
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->AddPut("d", "val_d");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddPut("e", "val_e");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = 2;
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "e");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_e");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test for large number of skippable internal keys with *default*
|
|
|
|
|
// max_sequential_skip_in_iterations.
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 1; i <= 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
for (size_t j = 1; j <= i; ++j) {
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.max_skippable_internal_keys = i;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2 * i + 1,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
if ((options.max_sequential_skip_in_iterations + 1) >=
|
|
|
|
|
ro.max_skippable_internal_keys) {
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
} else {
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
if ((options.max_sequential_skip_in_iterations + 1) >=
|
|
|
|
|
ro.max_skippable_internal_keys) {
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
} else {
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
// Test for large number of skippable internal keys with a *non-default*
|
|
|
|
|
// max_sequential_skip_in_iterations.
|
|
|
|
|
{
|
|
|
|
|
for (size_t i = 1; i <= 200; ++i) {
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
for (size_t j = 1; j <= i; ++j) {
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->AddPut("c", "val_c");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
options.max_sequential_skip_in_iterations = 1000;
|
|
|
|
|
ro.max_skippable_internal_keys = i;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2 * i + 1,
|
2017-10-10 00:05:34 +00:00
|
|
|
options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
2017-03-30 18:57:05 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_a");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val_c");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
ASSERT_TRUE(db_iter->status().IsIncomplete());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator1) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("a", "1");
|
|
|
|
|
internal_iter->AddMerge("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 1, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator2) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("a", "1");
|
|
|
|
|
internal_iter->AddMerge("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 0, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator3) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("a", "1");
|
|
|
|
|
internal_iter->AddMerge("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 2, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2017-04-10 18:13:23 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator4) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("a", "1");
|
|
|
|
|
internal_iter->AddMerge("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 4, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0,1");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "2");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator5) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2014-07-16 21:51:43 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
|
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 0,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 1,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1,merge_2");
|
|
|
|
|
db_iter->Prev();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1,merge_2,merge_3");
|
|
|
|
|
db_iter->Prev();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 3,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "put_1");
|
|
|
|
|
db_iter->Prev();
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 4,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "put_1,merge_4");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 5,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "put_1,merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddPut("a", "put_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 6,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "put_1,merge_4,merge_5,merge_6");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2016-10-18 23:07:10 +00:00
|
|
|
|
|
|
|
|
{
|
|
|
|
|
// put, singledelete, merge
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "val_a");
|
|
|
|
|
internal_iter->AddSingleDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddPut("b", "val_b");
|
|
|
|
|
internal_iter->Finish();
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 10,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2016-10-18 23:07:10 +00:00
|
|
|
db_iter->Seek("b");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
}
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator6) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
|
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 0,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 1,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1,merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1,merge_2,merge_3");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 3,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 4,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 5,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_3");
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 6,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5,merge_6");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator7) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
2017-04-10 18:13:23 +00:00
|
|
|
ImmutableCFOptions cf_options = ImmutableCFOptions(options);
|
|
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 0,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 2,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "val,merge_2");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 4,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 5,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4");
|
|
|
|
|
db_iter->Prev();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 6,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 7,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 9,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_6,merge_7");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->Finish();
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 13,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_4,merge_5");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(),
|
|
|
|
|
"merge_6,merge_7,merge_8,merge_9,merge_10,merge_11");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddPut("b", "val");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_2");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddMerge("c", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("c", "merge_5");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_6");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_7");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_8");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_9");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_10");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_11");
|
|
|
|
|
|
|
|
|
|
internal_iter->AddDeletion("c");
|
2014-07-16 21:51:43 +00:00
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, cf_options, BytewiseComparator(), internal_iter, 14,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /*read_callback*/));
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(),
|
|
|
|
|
"merge_6,merge_7,merge_8,merge_9,merge_10,merge_11");
|
2014-07-16 21:51:43 +00:00
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(!db_iter->Valid());
|
2014-07-16 21:51:43 +00:00
|
|
|
}
|
|
|
|
|
}
|
2015-08-06 17:43:28 +00:00
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator8) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddDeletion("a");
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 10, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Divide test DBIteratorTest.DBIterator to smaller tests
Summary:
When building on my host, I saw warning:
In file included from db/db_iter_test.cc:17:0:
db/db_iter_test.cc: In member function ‘void rocksdb::_Test_DBIterator::_Run()’:
./util/testharness.h:147:14: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
void TCONCAT(_Test_,name)::_Run()
^
./util/testharness.h:134:23: note: in definition of macro ‘TCONCAT1’
#define TCONCAT1(a,b) a##b
^
./util/testharness.h:147:6: note: in expansion of macro ‘TCONCAT’
void TCONCAT(_Test_,name)::_Run()
^
db/db_iter_test.cc:589:1: note: in expansion of macro ‘TEST’
TEST(DBIteratorTest, DBIterator) {
^
By dividing the test into small tests, it should fix the problem
Test Plan: Run the test
Reviewers: rven, yhchiang, igor
Reviewed By: igor
Subscribers: dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D32679
2015-02-03 17:47:29 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
}
|
2014-07-16 21:51:43 +00:00
|
|
|
|
2015-07-07 18:36:24 +00:00
|
|
|
// TODO(3.13): fix the issue of Seek() then Prev() which might not necessary
|
|
|
|
|
// return the biggest element smaller than the seek key.
|
2015-08-04 23:50:40 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator9) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
{
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddMerge("a", "merge_1");
|
|
|
|
|
internal_iter->AddMerge("a", "merge_2");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_3");
|
|
|
|
|
internal_iter->AddMerge("b", "merge_4");
|
|
|
|
|
internal_iter->AddMerge("d", "merge_5");
|
|
|
|
|
internal_iter->AddMerge("d", "merge_6");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 10, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3,merge_4");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_5,merge_6");
|
|
|
|
|
|
|
|
|
|
db_iter->Seek("b");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3,merge_4");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_1,merge_2");
|
|
|
|
|
|
2016-09-28 01:20:57 +00:00
|
|
|
db_iter->SeekForPrev("b");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3,merge_4");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_5,merge_6");
|
|
|
|
|
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
db_iter->Seek("c");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_5,merge_6");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3,merge_4");
|
2016-09-28 01:20:57 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekForPrev("c");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_3,merge_4");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "merge_5,merge_6");
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2015-07-07 18:36:24 +00:00
|
|
|
// TODO(3.13): fix the issue of Seek() then Prev() which might not necessary
|
|
|
|
|
// return the biggest element smaller than the seek key.
|
2015-08-04 23:50:40 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator10) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
Options options;
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "1");
|
|
|
|
|
internal_iter->AddPut("b", "2");
|
|
|
|
|
internal_iter->AddPut("c", "3");
|
|
|
|
|
internal_iter->AddPut("d", "4");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
2017-04-10 18:13:23 +00:00
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 10, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
|
|
|
|
|
db_iter->Seek("c");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "2");
|
|
|
|
|
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "3");
|
2016-09-28 01:20:57 +00:00
|
|
|
|
|
|
|
|
db_iter->SeekForPrev("c");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "3");
|
Fix a comparison in DBIter::FindPrevUserKey()
Summary:
When seek target is a merge key (`kTypeMerge`), `DBIter::FindNextUserEntry()`
advances the underlying iterator _past_ the current key (`saved_key_`); see
`MergeValuesNewToOld()`. However, `FindPrevUserKey()` assumes that `iter_`
points to an entry with the same user key as `saved_key_`. As a result,
`it->Seek(key) && it->Prev()` can cause the iterator to be positioned at the
_next_, instead of the previous, entry (new test, written by @lovro, reproduces
the bug).
This diff changes `FindPrevUserKey()` to also skip keys that are _greater_ than
`saved_key_`.
Test Plan: db_test
Reviewers: igor, sdong
Reviewed By: sdong
Subscribers: leveldb, dhruba, lovro
Differential Revision: https://reviews.facebook.net/D40791
2015-06-26 20:18:27 +00:00
|
|
|
}
|
|
|
|
|
|
2015-08-06 17:43:28 +00:00
|
|
|
TEST_F(DBIteratorTest, SeekToLastOccurrenceSeq0) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2015-08-06 17:43:28 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = nullptr;
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "1");
|
|
|
|
|
internal_iter->AddPut("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 10, 0 /* force seek */, nullptr /*read_callback*/));
|
2015-08-06 17:43:28 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "1");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "2");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator11) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = MergeOperators::CreateFromStringId("stringappend");
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "0");
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddSingleDeletion("b");
|
|
|
|
|
internal_iter->AddMerge("a", "1");
|
|
|
|
|
internal_iter->AddMerge("b", "2");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 1, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "0");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
db_iter->Next();
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TEST_F(DBIteratorTest, DBIterator12) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = nullptr;
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("a", "1");
|
|
|
|
|
internal_iter->AddPut("b", "2");
|
|
|
|
|
internal_iter->AddPut("c", "3");
|
|
|
|
|
internal_iter->AddSingleDeletion("b");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(
|
2017-04-10 18:13:23 +00:00
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 10, 0, nullptr /*read_callback*/));
|
Support for SingleDelete()
Summary:
This patch fixes #7460559. It introduces SingleDelete as a new database
operation. This operation can be used to delete keys that were never
overwritten (no put following another put of the same key). If an overwritten
key is single deleted the behavior is undefined. Single deletion of a
non-existent key has no effect but multiple consecutive single deletions are
not allowed (see limitations).
In contrast to the conventional Delete() operation, the deletion entry is
removed along with the value when the two are lined up in a compaction. Note:
The semantics are similar to @igor's prototype that allowed to have this
behavior on the granularity of a column family (
https://reviews.facebook.net/D42093 ). This new patch, however, is more
aggressive when it comes to removing tombstones: It removes the SingleDelete
together with the value whenever there is no snapshot between them while the
older patch only did this when the sequence number of the deletion was older
than the earliest snapshot.
Most of the complex additions are in the Compaction Iterator, all other changes
should be relatively straightforward. The patch also includes basic support for
single deletions in db_stress and db_bench.
Limitations:
- Not compatible with cuckoo hash tables
- Single deletions cannot be used in combination with merges and normal
deletions on the same key (other keys are not affected by this)
- Consecutive single deletions are currently not allowed (and older version of
this patch supported this so it could be resurrected if needed)
Test Plan: make all check
Reviewers: yhchiang, sdong, rven, anthony, yoshinorim, igor
Reviewed By: igor
Subscribers: maykov, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D43179
2015-09-17 18:42:56 +00:00
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "3");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "1");
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
2017-03-09 01:12:04 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIterator13) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-03-09 01:12:04 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = nullptr;
|
|
|
|
|
|
|
|
|
|
std::string key;
|
|
|
|
|
key.resize(9);
|
|
|
|
|
key.assign(9, static_cast<char>(0));
|
|
|
|
|
key[0] = 'b';
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut(key, "0");
|
|
|
|
|
internal_iter->AddPut(key, "1");
|
|
|
|
|
internal_iter->AddPut(key, "2");
|
|
|
|
|
internal_iter->AddPut(key, "3");
|
|
|
|
|
internal_iter->AddPut(key, "4");
|
|
|
|
|
internal_iter->AddPut(key, "5");
|
|
|
|
|
internal_iter->AddPut(key, "6");
|
|
|
|
|
internal_iter->AddPut(key, "7");
|
|
|
|
|
internal_iter->AddPut(key, "8");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(
|
2017-04-10 18:13:23 +00:00
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 2, 3, nullptr /*read_callback*/));
|
2017-03-09 01:12:04 +00:00
|
|
|
db_iter->Seek("b");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), key);
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "2");
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TEST_F(DBIteratorTest, DBIterator14) {
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro;
|
2017-03-09 01:12:04 +00:00
|
|
|
Options options;
|
|
|
|
|
options.merge_operator = nullptr;
|
|
|
|
|
|
|
|
|
|
std::string key("b");
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddPut("b", "0");
|
|
|
|
|
internal_iter->AddPut("b", "1");
|
|
|
|
|
internal_iter->AddPut("b", "2");
|
|
|
|
|
internal_iter->AddPut("b", "3");
|
|
|
|
|
internal_iter->AddPut("a", "4");
|
|
|
|
|
internal_iter->AddPut("a", "5");
|
|
|
|
|
internal_iter->AddPut("a", "6");
|
|
|
|
|
internal_iter->AddPut("c", "7");
|
|
|
|
|
internal_iter->AddPut("c", "8");
|
|
|
|
|
internal_iter->AddPut("c", "9");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(
|
2017-04-10 18:13:23 +00:00
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
2017-10-10 00:05:34 +00:00
|
|
|
internal_iter, 4, 1, nullptr /*read_callback*/));
|
2017-03-09 01:12:04 +00:00
|
|
|
db_iter->Seek("b");
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "3");
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
ASSERT_EQ(db_iter->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter->value().ToString(), "4");
|
|
|
|
|
}
|
|
|
|
|
|
Added support for differential snapshots
Summary:
The motivation for this PR is to add to RocksDB support for differential (incremental) snapshots, as snapshot of the DB changes between two points in time (one can think of it as diff between to sequence numbers, or the diff D which can be thought of as an SST file or just set of KVs that can be applied to sequence number S1 to get the database to the state at sequence number S2).
This feature would be useful for various distributed storages layers built on top of RocksDB, as it should help reduce resources (time and network bandwidth) needed to recover and rebuilt DB instances as replicas in the context of distributed storages.
From the API standpoint that would like client app requesting iterator between (start seqnum) and current DB state, and reading the "diff".
This is a very draft PR for initial review in the discussion on the approach, i'm going to rework some parts and keep updating the PR.
For now, what's done here according to initial discussions:
Preserving deletes:
- We want to be able to optionally preserve recent deletes for some defined period of time, so that if a delete came in recently and might need to be included in the next incremental snapshot it would't get dropped by a compaction. This is done by adding new param to Options (preserve deletes flag) and new variable to DB Impl where we keep track of the sequence number after which we don't want to drop tombstones, even if they are otherwise eligible for deletion.
- I also added a new API call for clients to be able to advance this cutoff seqnum after which we drop deletes; i assume it's more flexible to let clients control this, since otherwise we'd need to keep some kind of timestamp < -- > seqnum mapping inside the DB, which sounds messy and painful to support. Clients could make use of it by periodically calling GetLatestSequenceNumber(), noting the timestamp, doing some calculation and figuring out by how much we need to advance the cutoff seqnum.
- Compaction codepath in compaction_iterator.cc has been modified to avoid dropping tombstones with seqnum > cutoff seqnum.
Iterator changes:
- couple params added to ReadOptions, to optionally allow client to request internal keys instead of user keys (so that client can get the latest value of a key, be it delete marker or a put), as well as min timestamp and min seqnum.
TableCache changes:
- I modified table_cache code to be able to quickly exclude SST files from iterators heep if creation_time on the file is less then iter_start_ts as passed in ReadOptions. That would help a lot in some DB settings (like reading very recent data only or using FIFO compactions), but not so much for universal compaction with more or less long iterator time span.
What's left:
- Still looking at how to best plug that inside DBIter codepath. So far it seems that FindNextUserKeyInternal only parses values as UserKeys, and iter->key() call generally returns user key. Can we add new API to DBIter as internal_key(), and modify this internal method to optionally set saved_key_ to point to the full internal key? I don't need to store actual seqnum there, but I do need to store type.
Closes https://github.com/facebook/rocksdb/pull/2999
Differential Revision: D6175602
Pulled By: mikhail-antonov
fbshipit-source-id: c779a6696ee2d574d86c69cec866a3ae095aa900
2017-11-02 01:43:29 +00:00
|
|
|
TEST_F(DBIteratorTest, DBIteratorTestDifferentialSnapshots) {
|
|
|
|
|
{ // test that KVs earlier that iter_start_seqnum are filtered out
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iter_start_seqnum=5;
|
|
|
|
|
Options options;
|
|
|
|
|
options.statistics = rocksdb::CreateDBStatistics();
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (size_t i = 0; i < 10; ++i) {
|
|
|
|
|
internal_iter->AddPut(std::to_string(i), std::to_string(i) + "a");
|
|
|
|
|
internal_iter->AddPut(std::to_string(i), std::to_string(i) + "b");
|
|
|
|
|
internal_iter->AddPut(std::to_string(i), std::to_string(i) + "c");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 13,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr));
|
|
|
|
|
// Expecting InternalKeys in [5,8] range with correct type
|
|
|
|
|
int seqnums[4] = {5,8,11,13};
|
|
|
|
|
std::string user_keys[4] = {"1","2","3","4"};
|
|
|
|
|
std::string values[4] = {"1c", "2c", "3c", "4b"};
|
|
|
|
|
int i = 0;
|
|
|
|
|
for (db_iter->SeekToFirst(); db_iter->Valid(); db_iter->Next()) {
|
|
|
|
|
FullKey fkey;
|
|
|
|
|
ParseFullKey(db_iter->key(), &fkey);
|
|
|
|
|
ASSERT_EQ(user_keys[i], fkey.user_key.ToString());
|
|
|
|
|
ASSERT_EQ(EntryType::kEntryPut, fkey.type);
|
|
|
|
|
ASSERT_EQ(seqnums[i], fkey.sequence);
|
|
|
|
|
ASSERT_EQ(values[i], db_iter->value().ToString());
|
|
|
|
|
i++;
|
|
|
|
|
}
|
|
|
|
|
ASSERT_EQ(i, 4);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
{ // Test that deletes are returned correctly as internal KVs
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
ro.iter_start_seqnum=5;
|
|
|
|
|
Options options;
|
|
|
|
|
options.statistics = rocksdb::CreateDBStatistics();
|
|
|
|
|
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (size_t i = 0; i < 10; ++i) {
|
|
|
|
|
internal_iter->AddPut(std::to_string(i), std::to_string(i) + "a");
|
|
|
|
|
internal_iter->AddPut(std::to_string(i), std::to_string(i) + "b");
|
|
|
|
|
internal_iter->AddDeletion(std::to_string(i));
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(
|
|
|
|
|
NewDBIterator(env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 13,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr));
|
|
|
|
|
// Expecting InternalKeys in [5,8] range with correct type
|
|
|
|
|
int seqnums[4] = {5,8,11,13};
|
|
|
|
|
EntryType key_types[4] = {EntryType::kEntryDelete,EntryType::kEntryDelete,
|
|
|
|
|
EntryType::kEntryDelete,EntryType::kEntryPut};
|
|
|
|
|
std::string user_keys[4] = {"1","2","3","4"};
|
|
|
|
|
std::string values[4] = {"", "", "", "4b"};
|
|
|
|
|
int i = 0;
|
|
|
|
|
for (db_iter->SeekToFirst(); db_iter->Valid(); db_iter->Next()) {
|
|
|
|
|
FullKey fkey;
|
|
|
|
|
ParseFullKey(db_iter->key(), &fkey);
|
|
|
|
|
ASSERT_EQ(user_keys[i], fkey.user_key.ToString());
|
|
|
|
|
ASSERT_EQ(key_types[i], fkey.type);
|
|
|
|
|
ASSERT_EQ(seqnums[i], fkey.sequence);
|
|
|
|
|
ASSERT_EQ(values[i], db_iter->value().ToString());
|
|
|
|
|
i++;
|
|
|
|
|
}
|
|
|
|
|
ASSERT_EQ(i, 4);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
class DBIterWithMergeIterTest : public testing::Test {
|
2015-08-06 20:23:02 +00:00
|
|
|
public:
|
|
|
|
|
DBIterWithMergeIterTest()
|
|
|
|
|
: env_(Env::Default()), icomp_(BytewiseComparator()) {
|
|
|
|
|
options_.merge_operator = nullptr;
|
|
|
|
|
|
|
|
|
|
internal_iter1_ = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter1_->Add("a", kTypeValue, "1", 3u);
|
|
|
|
|
internal_iter1_->Add("f", kTypeValue, "2", 5u);
|
|
|
|
|
internal_iter1_->Add("g", kTypeValue, "3", 7u);
|
|
|
|
|
internal_iter1_->Finish();
|
|
|
|
|
|
|
|
|
|
internal_iter2_ = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter2_->Add("a", kTypeValue, "4", 6u);
|
|
|
|
|
internal_iter2_->Add("b", kTypeValue, "5", 1u);
|
|
|
|
|
internal_iter2_->Add("c", kTypeValue, "6", 2u);
|
|
|
|
|
internal_iter2_->Add("d", kTypeValue, "7", 3u);
|
|
|
|
|
internal_iter2_->Finish();
|
|
|
|
|
|
2015-10-12 22:06:38 +00:00
|
|
|
std::vector<InternalIterator*> child_iters;
|
2015-08-06 20:23:02 +00:00
|
|
|
child_iters.push_back(internal_iter1_);
|
|
|
|
|
child_iters.push_back(internal_iter2_);
|
|
|
|
|
InternalKeyComparator icomp(BytewiseComparator());
|
2016-09-08 21:45:32 +00:00
|
|
|
InternalIterator* merge_iter =
|
|
|
|
|
NewMergingIterator(&icomp_, &child_iters[0], 2u);
|
|
|
|
|
|
2017-10-10 00:05:34 +00:00
|
|
|
db_iter_.reset(NewDBIterator(
|
|
|
|
|
env_, ro_, ImmutableCFOptions(options_), BytewiseComparator(),
|
|
|
|
|
merge_iter, 8 /* read data earlier than seqId 8 */,
|
|
|
|
|
3 /* max iterators before reseek */, nullptr /*read_callback*/));
|
2015-08-06 20:23:02 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
Env* env_;
|
2017-04-10 18:13:23 +00:00
|
|
|
ReadOptions ro_;
|
2015-08-06 20:23:02 +00:00
|
|
|
Options options_;
|
|
|
|
|
TestIterator* internal_iter1_;
|
|
|
|
|
TestIterator* internal_iter2_;
|
|
|
|
|
InternalKeyComparator icomp_;
|
|
|
|
|
Iterator* merge_iter_;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter_;
|
|
|
|
|
};
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIterator1) {
|
2015-08-06 20:23:02 +00:00
|
|
|
db_iter_->SeekToFirst();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
db_iter_->Next();
|
|
|
|
|
ASSERT_FALSE(db_iter_->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIterator2) {
|
2015-08-06 20:23:02 +00:00
|
|
|
// Test Prev() when one child iterator is at its end.
|
2016-09-28 01:20:57 +00:00
|
|
|
db_iter_->SeekForPrev("g");
|
2015-08-06 20:23:02 +00:00
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace1) {
|
2015-08-06 20:23:02 +00:00
|
|
|
// Test Prev() when one child iterator is at its end but more rows
|
|
|
|
|
// are added.
|
|
|
|
|
db_iter_->Seek("f");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
|
2015-08-19 01:08:49 +00:00
|
|
|
// Test call back inserts a key in the end of the mem table after
|
|
|
|
|
// MergeIterator::Prev() realized the mem table iterator is at its end
|
|
|
|
|
// and before an SeekToLast() is called.
|
2015-08-06 20:23:02 +00:00
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforeSeekToLast",
|
2018-04-13 00:55:14 +00:00
|
|
|
[&](void* /*arg*/) { internal_iter2_->Add("z", kTypeValue, "7", 12u); });
|
2015-08-06 20:23:02 +00:00
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace2) {
|
2015-08-06 20:23:02 +00:00
|
|
|
// Test Prev() when one child iterator is at its end but more rows
|
|
|
|
|
// are added.
|
|
|
|
|
db_iter_->Seek("f");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
|
2015-08-19 01:08:49 +00:00
|
|
|
// Test call back inserts entries for update a key in the end of the
|
|
|
|
|
// mem table after MergeIterator::Prev() realized the mem tableiterator is at
|
|
|
|
|
// its end and before an SeekToLast() is called.
|
2015-08-06 20:23:02 +00:00
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
2018-04-13 00:55:14 +00:00
|
|
|
"MergeIterator::Prev:BeforeSeekToLast", [&](void* /*arg*/) {
|
2015-08-06 20:23:02 +00:00
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 12u);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 11u);
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace3) {
|
2015-08-06 20:23:02 +00:00
|
|
|
// Test Prev() when one child iterator is at its end but more rows
|
|
|
|
|
// are added and max_skipped is triggered.
|
|
|
|
|
db_iter_->Seek("f");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
|
2015-08-19 01:08:49 +00:00
|
|
|
// Test call back inserts entries for update a key in the end of the
|
|
|
|
|
// mem table after MergeIterator::Prev() realized the mem table iterator is at
|
|
|
|
|
// its end and before an SeekToLast() is called.
|
2015-08-06 20:23:02 +00:00
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
2018-04-13 00:55:14 +00:00
|
|
|
"MergeIterator::Prev:BeforeSeekToLast", [&](void* /*arg*/) {
|
2015-08-19 01:08:49 +00:00
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 16u, true);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 15u, true);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 14u, true);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 13u, true);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 12u, true);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "7", 11u, true);
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace4) {
|
2015-08-19 01:08:49 +00:00
|
|
|
// Test Prev() when one child iterator has more rows inserted
|
|
|
|
|
// between Seek() and Prev() when changing directions.
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "9", 4u);
|
|
|
|
|
|
|
|
|
|
db_iter_->Seek("g");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
|
|
|
|
|
// Test call back inserts entries for update a key before "z" in
|
|
|
|
|
// mem table after MergeIterator::Prev() calls mem table iterator's
|
|
|
|
|
// Seek() and before calling Prev()
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforePrev", [&](void* arg) {
|
|
|
|
|
IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg);
|
|
|
|
|
if (it->key().starts_with("z")) {
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 16u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 15u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 14u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 13u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 12u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 11u, true);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace5) {
|
2015-08-19 01:08:49 +00:00
|
|
|
internal_iter2_->Add("z", kTypeValue, "9", 4u);
|
|
|
|
|
|
|
|
|
|
// Test Prev() when one child iterator has more rows inserted
|
|
|
|
|
// between Seek() and Prev() when changing directions.
|
|
|
|
|
db_iter_->Seek("g");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
|
|
|
|
|
// Test call back inserts entries for update a key before "z" in
|
|
|
|
|
// mem table after MergeIterator::Prev() calls mem table iterator's
|
|
|
|
|
// Seek() and before calling Prev()
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforePrev", [&](void* arg) {
|
|
|
|
|
IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg);
|
|
|
|
|
if (it->key().starts_with("z")) {
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 16u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 15u, true);
|
|
|
|
|
}
|
2015-08-06 20:23:02 +00:00
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
2015-08-19 01:08:49 +00:00
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace6) {
|
2015-08-19 01:08:49 +00:00
|
|
|
internal_iter2_->Add("z", kTypeValue, "9", 4u);
|
|
|
|
|
|
|
|
|
|
// Test Prev() when one child iterator has more rows inserted
|
|
|
|
|
// between Seek() and Prev() when changing directions.
|
|
|
|
|
db_iter_->Seek("g");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
|
|
|
|
|
// Test call back inserts an entry for update a key before "z" in
|
|
|
|
|
// mem table after MergeIterator::Prev() calls mem table iterator's
|
|
|
|
|
// Seek() and before calling Prev()
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforePrev", [&](void* arg) {
|
|
|
|
|
IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg);
|
|
|
|
|
if (it->key().starts_with("z")) {
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 16u, true);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace7) {
|
2015-08-19 01:08:49 +00:00
|
|
|
internal_iter1_->Add("u", kTypeValue, "10", 4u);
|
|
|
|
|
internal_iter1_->Add("v", kTypeValue, "11", 4u);
|
|
|
|
|
internal_iter1_->Add("w", kTypeValue, "12", 4u);
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "9", 4u);
|
|
|
|
|
|
|
|
|
|
// Test Prev() when one child iterator has more rows inserted
|
|
|
|
|
// between Seek() and Prev() when changing directions.
|
|
|
|
|
db_iter_->Seek("g");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
|
|
|
|
|
// Test call back inserts entries for update a key before "z" in
|
|
|
|
|
// mem table after MergeIterator::Prev() calls mem table iterator's
|
|
|
|
|
// Seek() and before calling Prev()
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforePrev", [&](void* arg) {
|
|
|
|
|
IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg);
|
|
|
|
|
if (it->key().starts_with("z")) {
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 16u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 15u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 14u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 13u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 12u, true);
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 11u, true);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
2015-08-06 20:23:02 +00:00
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "c");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "6");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "b");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "5");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "a");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "4");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
|
|
|
|
|
2016-09-08 21:45:32 +00:00
|
|
|
TEST_F(DBIterWithMergeIterTest, InnerMergeIteratorDataRace8) {
|
DBIter to out extra keys with higher sequence numbers when changing direction from forward to backward
Summary:
When DBIter changes iterating direction from forward to backward, it might see some much larger keys with higher sequence ID. With this commit, these rows will be actively filtered out. It should fix existing disabled tests in db_iter_test.
This may not be a perfect fix, but it introduces least impact on existing codes, in order to be safe.
Test Plan:
Enable existing tests and make sure they pass. Add a new test DBIterWithMergeIterTest.InnerMergeIteratorDataRace8.
Also run all existing tests.
Reviewers: yhchiang, rven, anthony, IslamAbdelRahman, kradhakrishnan, igor
Reviewed By: igor
Subscribers: leveldb, dhruba
Differential Revision: https://reviews.facebook.net/D45567
2015-08-25 20:40:52 +00:00
|
|
|
// internal_iter1_: a, f, g
|
|
|
|
|
// internal_iter2_: a, b, c, d, adding (z)
|
|
|
|
|
internal_iter2_->Add("z", kTypeValue, "9", 4u);
|
|
|
|
|
|
|
|
|
|
// Test Prev() when one child iterator has more rows inserted
|
|
|
|
|
// between Seek() and Prev() when changing directions.
|
|
|
|
|
db_iter_->Seek("g");
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "g");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "3");
|
|
|
|
|
|
|
|
|
|
// Test call back inserts two keys before "z" in mem table after
|
|
|
|
|
// MergeIterator::Prev() calls mem table iterator's Seek() and
|
|
|
|
|
// before calling Prev()
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
|
"MergeIterator::Prev:BeforePrev", [&](void* arg) {
|
|
|
|
|
IteratorWrapper* it = reinterpret_cast<IteratorWrapper*>(arg);
|
|
|
|
|
if (it->key().starts_with("z")) {
|
|
|
|
|
internal_iter2_->Add("x", kTypeValue, "7", 16u, true);
|
|
|
|
|
internal_iter2_->Add("y", kTypeValue, "7", 17u, true);
|
|
|
|
|
}
|
|
|
|
|
});
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
|
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "f");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "2");
|
|
|
|
|
db_iter_->Prev();
|
|
|
|
|
ASSERT_TRUE(db_iter_->Valid());
|
|
|
|
|
ASSERT_EQ(db_iter_->key().ToString(), "d");
|
|
|
|
|
ASSERT_EQ(db_iter_->value().ToString(), "7");
|
|
|
|
|
|
|
|
|
|
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
|
|
|
|
|
}
|
2017-10-25 22:08:01 +00:00
|
|
|
|
|
|
|
|
|
|
|
|
|
TEST_F(DBIteratorTest, SeekPrefixTombstones) {
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
Options options;
|
|
|
|
|
options.prefix_extractor.reset(NewNoopTransform());
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
internal_iter->AddDeletion("b");
|
|
|
|
|
internal_iter->AddDeletion("c");
|
|
|
|
|
internal_iter->AddDeletion("d");
|
|
|
|
|
internal_iter->AddDeletion("e");
|
|
|
|
|
internal_iter->AddDeletion("f");
|
|
|
|
|
internal_iter->AddDeletion("g");
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ro.prefix_same_as_start = true;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 10, options.max_sequential_skip_in_iterations,
|
|
|
|
|
nullptr /*read_callback*/));
|
|
|
|
|
|
|
|
|
|
int skipped_keys = 0;
|
|
|
|
|
|
|
|
|
|
get_perf_context()->Reset();
|
|
|
|
|
db_iter->SeekForPrev("z");
|
|
|
|
|
skipped_keys =
|
|
|
|
|
static_cast<int>(get_perf_context()->internal_key_skipped_count);
|
|
|
|
|
ASSERT_EQ(skipped_keys, 0);
|
|
|
|
|
|
|
|
|
|
get_perf_context()->Reset();
|
|
|
|
|
db_iter->Seek("a");
|
|
|
|
|
skipped_keys =
|
|
|
|
|
static_cast<int>(get_perf_context()->internal_key_skipped_count);
|
|
|
|
|
ASSERT_EQ(skipped_keys, 0);
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-27 00:14:04 +00:00
|
|
|
TEST_F(DBIteratorTest, SeekToFirstLowerBound) {
|
|
|
|
|
const int kNumKeys = 3;
|
|
|
|
|
for (int i = 0; i < kNumKeys + 2; ++i) {
|
|
|
|
|
// + 2 for two special cases: lower bound before and lower bound after the
|
|
|
|
|
// internal iterator's keys
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (int j = 1; j <= kNumKeys; ++j) {
|
|
|
|
|
internal_iter->AddPut(std::to_string(j), "val");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
auto lower_bound_str = std::to_string(i);
|
|
|
|
|
Slice lower_bound(lower_bound_str);
|
|
|
|
|
ro.iterate_lower_bound = &lower_bound;
|
|
|
|
|
Options options;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 10 /* sequence */,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /* read_callback */));
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToFirst();
|
|
|
|
|
if (i == kNumKeys + 1) {
|
|
|
|
|
// lower bound was beyond the last key
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
|
|
|
|
} else {
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
int expected;
|
|
|
|
|
if (i == 0) {
|
|
|
|
|
// lower bound was before the first key
|
|
|
|
|
expected = 1;
|
|
|
|
|
} else {
|
|
|
|
|
// lower bound was at the ith key
|
|
|
|
|
expected = i;
|
|
|
|
|
}
|
|
|
|
|
ASSERT_EQ(std::to_string(expected), db_iter->key().ToString());
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
TEST_F(DBIteratorTest, PrevLowerBound) {
|
|
|
|
|
const int kNumKeys = 3;
|
|
|
|
|
const int kLowerBound = 2;
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (int j = 1; j <= kNumKeys; ++j) {
|
|
|
|
|
internal_iter->AddPut(std::to_string(j), "val");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
auto lower_bound_str = std::to_string(kLowerBound);
|
|
|
|
|
Slice lower_bound(lower_bound_str);
|
|
|
|
|
ro.iterate_lower_bound = &lower_bound;
|
|
|
|
|
Options options;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 10 /* sequence */,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /* read_callback */));
|
|
|
|
|
|
|
|
|
|
db_iter->SeekToLast();
|
|
|
|
|
for (int i = kNumKeys; i >= kLowerBound; --i) {
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(std::to_string(i), db_iter->key().ToString());
|
|
|
|
|
db_iter->Prev();
|
|
|
|
|
}
|
|
|
|
|
ASSERT_FALSE(db_iter->Valid());
|
|
|
|
|
}
|
|
|
|
|
|
2017-11-30 06:48:55 +00:00
|
|
|
TEST_F(DBIteratorTest, SeekLessLowerBound) {
|
|
|
|
|
const int kNumKeys = 3;
|
|
|
|
|
const int kLowerBound = 2;
|
|
|
|
|
TestIterator* internal_iter = new TestIterator(BytewiseComparator());
|
|
|
|
|
for (int j = 1; j <= kNumKeys; ++j) {
|
|
|
|
|
internal_iter->AddPut(std::to_string(j), "val");
|
|
|
|
|
}
|
|
|
|
|
internal_iter->Finish();
|
|
|
|
|
|
|
|
|
|
ReadOptions ro;
|
|
|
|
|
auto lower_bound_str = std::to_string(kLowerBound);
|
|
|
|
|
Slice lower_bound(lower_bound_str);
|
|
|
|
|
ro.iterate_lower_bound = &lower_bound;
|
|
|
|
|
Options options;
|
|
|
|
|
std::unique_ptr<Iterator> db_iter(NewDBIterator(
|
|
|
|
|
env_, ro, ImmutableCFOptions(options), BytewiseComparator(),
|
|
|
|
|
internal_iter, 10 /* sequence */,
|
|
|
|
|
options.max_sequential_skip_in_iterations, nullptr /* read_callback */));
|
|
|
|
|
|
|
|
|
|
auto before_lower_bound_str = std::to_string(kLowerBound - 1);
|
|
|
|
|
Slice before_lower_bound(lower_bound_str);
|
|
|
|
|
|
|
|
|
|
db_iter->Seek(before_lower_bound);
|
|
|
|
|
ASSERT_TRUE(db_iter->Valid());
|
|
|
|
|
ASSERT_EQ(lower_bound_str, db_iter->key().ToString());
|
|
|
|
|
}
|
|
|
|
|
|
2014-07-16 21:51:43 +00:00
|
|
|
} // namespace rocksdb
|
|
|
|
|
|
2015-03-17 21:08:00 +00:00
|
|
|
int main(int argc, char** argv) {
|
|
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
|
return RUN_ALL_TESTS();
|
|
|
|
|
}
|