2016-02-09 23:12:00 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
#include "rocksdb/sst_file_writer.h"
|
|
|
|
|
|
|
|
#include <vector>
|
2019-05-30 21:47:29 +00:00
|
|
|
|
2021-08-18 18:32:00 +00:00
|
|
|
#include "db/db_impl/db_impl.h"
|
2015-09-23 19:42:43 +00:00
|
|
|
#include "db/dbformat.h"
|
2019-09-16 17:31:27 +00:00
|
|
|
#include "file/writable_file_writer.h"
|
2021-01-29 06:08:46 +00:00
|
|
|
#include "rocksdb/file_system.h"
|
2015-09-23 19:42:43 +00:00
|
|
|
#include "rocksdb/table.h"
|
2019-05-30 21:47:29 +00:00
|
|
|
#include "table/block_based/block_based_table_builder.h"
|
2016-10-18 23:59:37 +00:00
|
|
|
#include "table/sst_file_writer_collectors.h"
|
2019-05-30 18:21:38 +00:00
|
|
|
#include "test_util/sync_point.h"
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
const std::string ExternalSstFilePropertyNames::kVersion =
|
|
|
|
"rocksdb.external_sst_file.version";
|
2016-10-18 23:59:37 +00:00
|
|
|
const std::string ExternalSstFilePropertyNames::kGlobalSeqno =
|
|
|
|
"rocksdb.external_sst_file.global_seqno";
|
2017-02-28 19:05:08 +00:00
|
|
|
|
|
|
|
#ifndef ROCKSDB_LITE
|
|
|
|
|
2016-12-29 22:51:52 +00:00
|
|
|
const size_t kFadviseTrigger = 1024 * 1024; // 1MB
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
struct SstFileWriter::Rep {
|
2016-05-17 20:11:56 +00:00
|
|
|
Rep(const EnvOptions& _env_options, const Options& options,
|
2017-05-23 18:36:06 +00:00
|
|
|
Env::IOPriority _io_priority, const Comparator* _user_comparator,
|
2021-08-21 03:39:52 +00:00
|
|
|
ColumnFamilyHandle* _cfh, bool _invalidate_page_cache, bool _skip_filters,
|
|
|
|
std::string _db_session_id)
|
2015-09-23 19:42:43 +00:00
|
|
|
: env_options(_env_options),
|
2016-05-17 20:11:56 +00:00
|
|
|
ioptions(options),
|
2016-09-14 04:11:59 +00:00
|
|
|
mutable_cf_options(options),
|
2017-05-23 18:36:06 +00:00
|
|
|
io_priority(_io_priority),
|
2016-12-05 22:16:23 +00:00
|
|
|
internal_comparator(_user_comparator),
|
2016-12-29 22:51:52 +00:00
|
|
|
cfh(_cfh),
|
|
|
|
invalidate_page_cache(_invalidate_page_cache),
|
2021-08-21 03:39:52 +00:00
|
|
|
skip_filters(_skip_filters),
|
|
|
|
db_session_id(_db_session_id) {}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
std::unique_ptr<WritableFileWriter> file_writer;
|
|
|
|
std::unique_ptr<TableBuilder> builder;
|
|
|
|
EnvOptions env_options;
|
2021-05-05 20:59:21 +00:00
|
|
|
ImmutableOptions ioptions;
|
2016-05-17 20:11:56 +00:00
|
|
|
MutableCFOptions mutable_cf_options;
|
2017-05-23 18:36:06 +00:00
|
|
|
Env::IOPriority io_priority;
|
2015-09-23 19:42:43 +00:00
|
|
|
InternalKeyComparator internal_comparator;
|
|
|
|
ExternalSstFileInfo file_info;
|
2016-06-13 16:57:43 +00:00
|
|
|
InternalKey ikey;
|
2016-12-05 22:16:23 +00:00
|
|
|
std::string column_family_name;
|
|
|
|
ColumnFamilyHandle* cfh;
|
2016-12-29 22:51:52 +00:00
|
|
|
// If true, We will give the OS a hint that this file pages is not needed
|
2018-03-08 18:18:34 +00:00
|
|
|
// every time we write 1MB to the file.
|
2016-12-29 22:51:52 +00:00
|
|
|
bool invalidate_page_cache;
|
2017-05-23 18:36:06 +00:00
|
|
|
// The size of the file during the last time we called Fadvise to remove
|
2016-12-29 22:51:52 +00:00
|
|
|
// cached pages from page cache.
|
2021-08-21 03:39:52 +00:00
|
|
|
uint64_t last_fadvise_size = 0;
|
2018-01-22 22:37:37 +00:00
|
|
|
bool skip_filters;
|
2021-08-21 03:39:52 +00:00
|
|
|
std::string db_session_id;
|
|
|
|
uint64_t next_file_number = 1;
|
|
|
|
|
2021-09-10 01:57:01 +00:00
|
|
|
Status AddImpl(const Slice& user_key, const Slice& value,
|
|
|
|
ValueType value_type) {
|
2017-05-26 19:05:19 +00:00
|
|
|
if (!builder) {
|
|
|
|
return Status::InvalidArgument("File is not opened");
|
|
|
|
}
|
|
|
|
|
|
|
|
if (file_info.num_entries == 0) {
|
|
|
|
file_info.smallest_key.assign(user_key.data(), user_key.size());
|
|
|
|
} else {
|
|
|
|
if (internal_comparator.user_comparator()->Compare(
|
|
|
|
user_key, file_info.largest_key) <= 0) {
|
|
|
|
// Make sure that keys are added in order
|
2020-01-06 18:55:53 +00:00
|
|
|
return Status::InvalidArgument(
|
|
|
|
"Keys must be added in strict ascending order.");
|
2017-05-26 19:05:19 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2021-09-10 01:57:01 +00:00
|
|
|
assert(value_type == kTypeValue || value_type == kTypeMerge ||
|
|
|
|
value_type == kTypeDeletion ||
|
|
|
|
value_type == kTypeDeletionWithTimestamp);
|
|
|
|
|
|
|
|
constexpr SequenceNumber sequence_number = 0;
|
|
|
|
|
|
|
|
ikey.Set(user_key, sequence_number, value_type);
|
|
|
|
|
2017-05-26 19:05:19 +00:00
|
|
|
builder->Add(ikey.Encode(), value);
|
|
|
|
|
|
|
|
// update file info
|
|
|
|
file_info.num_entries++;
|
|
|
|
file_info.largest_key.assign(user_key.data(), user_key.size());
|
|
|
|
file_info.file_size = builder->FileSize();
|
|
|
|
|
2021-04-06 18:53:54 +00:00
|
|
|
InvalidatePageCache(false /* closing */).PermitUncheckedError();
|
|
|
|
return Status::OK();
|
2017-05-26 19:05:19 +00:00
|
|
|
}
|
|
|
|
|
2021-09-10 01:57:01 +00:00
|
|
|
Status Add(const Slice& user_key, const Slice& value, ValueType value_type) {
|
|
|
|
if (internal_comparator.timestamp_size() != 0) {
|
|
|
|
return Status::InvalidArgument("Timestamp size mismatch");
|
|
|
|
}
|
|
|
|
|
|
|
|
return AddImpl(user_key, value, value_type);
|
|
|
|
}
|
|
|
|
|
|
|
|
Status Add(const Slice& user_key, const Slice& timestamp, const Slice& value,
|
|
|
|
ValueType value_type) {
|
|
|
|
const size_t timestamp_size = timestamp.size();
|
|
|
|
|
|
|
|
if (internal_comparator.timestamp_size() != timestamp_size) {
|
|
|
|
return Status::InvalidArgument("Timestamp size mismatch");
|
|
|
|
}
|
|
|
|
|
|
|
|
const size_t user_key_size = user_key.size();
|
|
|
|
|
|
|
|
if (user_key.data() + user_key_size == timestamp.data()) {
|
|
|
|
Slice user_key_with_ts(user_key.data(), user_key_size + timestamp_size);
|
|
|
|
return AddImpl(user_key_with_ts, value, value_type);
|
|
|
|
}
|
|
|
|
|
|
|
|
std::string user_key_with_ts;
|
|
|
|
user_key_with_ts.reserve(user_key_size + timestamp_size);
|
|
|
|
user_key_with_ts.append(user_key.data(), user_key_size);
|
|
|
|
user_key_with_ts.append(timestamp.data(), timestamp_size);
|
|
|
|
|
|
|
|
return AddImpl(user_key_with_ts, value, value_type);
|
|
|
|
}
|
|
|
|
|
2018-07-14 05:40:23 +00:00
|
|
|
Status DeleteRange(const Slice& begin_key, const Slice& end_key) {
|
2021-09-10 01:57:01 +00:00
|
|
|
if (internal_comparator.timestamp_size() != 0) {
|
|
|
|
return Status::InvalidArgument("Timestamp size mismatch");
|
|
|
|
}
|
|
|
|
|
2018-07-14 05:40:23 +00:00
|
|
|
if (!builder) {
|
|
|
|
return Status::InvalidArgument("File is not opened");
|
|
|
|
}
|
|
|
|
|
|
|
|
RangeTombstone tombstone(begin_key, end_key, 0 /* Sequence Number */);
|
|
|
|
if (file_info.num_range_del_entries == 0) {
|
|
|
|
file_info.smallest_range_del_key.assign(tombstone.start_key_.data(),
|
|
|
|
tombstone.start_key_.size());
|
|
|
|
file_info.largest_range_del_key.assign(tombstone.end_key_.data(),
|
|
|
|
tombstone.end_key_.size());
|
|
|
|
} else {
|
|
|
|
if (internal_comparator.user_comparator()->Compare(
|
|
|
|
tombstone.start_key_, file_info.smallest_range_del_key) < 0) {
|
|
|
|
file_info.smallest_range_del_key.assign(tombstone.start_key_.data(),
|
|
|
|
tombstone.start_key_.size());
|
|
|
|
}
|
|
|
|
if (internal_comparator.user_comparator()->Compare(
|
|
|
|
tombstone.end_key_, file_info.largest_range_del_key) > 0) {
|
|
|
|
file_info.largest_range_del_key.assign(tombstone.end_key_.data(),
|
|
|
|
tombstone.end_key_.size());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
auto ikey_and_end_key = tombstone.Serialize();
|
|
|
|
builder->Add(ikey_and_end_key.first.Encode(), ikey_and_end_key.second);
|
|
|
|
|
|
|
|
// update file info
|
|
|
|
file_info.num_range_del_entries++;
|
|
|
|
file_info.file_size = builder->FileSize();
|
|
|
|
|
2021-04-06 18:53:54 +00:00
|
|
|
InvalidatePageCache(false /* closing */).PermitUncheckedError();
|
|
|
|
return Status::OK();
|
2018-07-14 05:40:23 +00:00
|
|
|
}
|
|
|
|
|
2020-09-28 22:11:54 +00:00
|
|
|
Status InvalidatePageCache(bool closing) {
|
|
|
|
Status s = Status::OK();
|
2017-05-26 19:05:19 +00:00
|
|
|
if (invalidate_page_cache == false) {
|
|
|
|
// Fadvise disabled
|
2020-09-28 22:11:54 +00:00
|
|
|
return s;
|
2017-05-26 19:05:19 +00:00
|
|
|
}
|
|
|
|
uint64_t bytes_since_last_fadvise =
|
|
|
|
builder->FileSize() - last_fadvise_size;
|
|
|
|
if (bytes_since_last_fadvise > kFadviseTrigger || closing) {
|
|
|
|
TEST_SYNC_POINT_CALLBACK("SstFileWriter::Rep::InvalidatePageCache",
|
|
|
|
&(bytes_since_last_fadvise));
|
2020-02-28 22:10:51 +00:00
|
|
|
// Tell the OS that we don't need this file in page cache
|
2020-09-28 22:11:54 +00:00
|
|
|
s = file_writer->InvalidateCache(0, 0);
|
|
|
|
if (s.IsNotSupported()) {
|
|
|
|
// NotSupported is fine as it could be a file type that doesn't use page
|
|
|
|
// cache.
|
|
|
|
s = Status::OK();
|
|
|
|
}
|
2017-05-26 19:05:19 +00:00
|
|
|
last_fadvise_size = builder->FileSize();
|
|
|
|
}
|
2020-09-28 22:11:54 +00:00
|
|
|
return s;
|
2017-05-26 19:05:19 +00:00
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
SstFileWriter::SstFileWriter(const EnvOptions& env_options,
|
2016-05-17 20:11:56 +00:00
|
|
|
const Options& options,
|
2016-12-05 22:16:23 +00:00
|
|
|
const Comparator* user_comparator,
|
2016-12-29 22:51:52 +00:00
|
|
|
ColumnFamilyHandle* column_family,
|
2017-05-23 18:36:06 +00:00
|
|
|
bool invalidate_page_cache,
|
2018-01-22 22:37:37 +00:00
|
|
|
Env::IOPriority io_priority, bool skip_filters)
|
2017-05-23 18:36:06 +00:00
|
|
|
: rep_(new Rep(env_options, options, io_priority, user_comparator,
|
2021-08-21 03:39:52 +00:00
|
|
|
column_family, invalidate_page_cache, skip_filters,
|
|
|
|
DBImpl::GenerateDbSessionId(options.env))) {
|
|
|
|
// SstFileWriter is used to create sst files that can be added to database
|
|
|
|
// later. Therefore, no real db_id and db_session_id are associated with it.
|
|
|
|
// Here we mimic the way db_session_id behaves by getting a db_session_id
|
|
|
|
// for each SstFileWriter, and (later below) assign unique file numbers
|
|
|
|
// in the table properties. The db_id is set to be "SST Writer" for clarity.
|
|
|
|
|
2016-12-29 22:51:52 +00:00
|
|
|
rep_->file_info.file_size = 0;
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2016-11-13 04:03:39 +00:00
|
|
|
SstFileWriter::~SstFileWriter() {
|
|
|
|
if (rep_->builder) {
|
|
|
|
// User did not call Finish() or Finish() failed, we need to
|
|
|
|
// abandon the builder.
|
|
|
|
rep_->builder->Abandon();
|
|
|
|
}
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
Status SstFileWriter::Open(const std::string& file_path) {
|
2017-05-23 18:36:06 +00:00
|
|
|
Rep* r = rep_.get();
|
2015-09-23 19:42:43 +00:00
|
|
|
Status s;
|
2021-01-29 06:08:46 +00:00
|
|
|
std::unique_ptr<FSWritableFile> sst_file;
|
2021-02-11 06:18:33 +00:00
|
|
|
FileOptions cur_file_opts(r->env_options);
|
2021-01-29 06:08:46 +00:00
|
|
|
s = r->ioptions.env->GetFileSystem()->NewWritableFile(
|
2021-02-11 06:18:33 +00:00
|
|
|
file_path, cur_file_opts, &sst_file, nullptr);
|
2015-09-23 19:42:43 +00:00
|
|
|
if (!s.ok()) {
|
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
2017-05-23 18:36:06 +00:00
|
|
|
sst_file->SetIOPriority(r->io_priority);
|
|
|
|
|
2016-06-20 18:26:25 +00:00
|
|
|
CompressionType compression_type;
|
2018-06-28 00:34:07 +00:00
|
|
|
CompressionOptions compression_opts;
|
2020-03-31 19:08:41 +00:00
|
|
|
if (r->mutable_cf_options.bottommost_compression !=
|
|
|
|
kDisableCompressionOption) {
|
|
|
|
compression_type = r->mutable_cf_options.bottommost_compression;
|
|
|
|
if (r->mutable_cf_options.bottommost_compression_opts.enabled) {
|
|
|
|
compression_opts = r->mutable_cf_options.bottommost_compression_opts;
|
2018-06-28 00:34:07 +00:00
|
|
|
} else {
|
2020-03-31 19:08:41 +00:00
|
|
|
compression_opts = r->mutable_cf_options.compression_opts;
|
2018-06-28 00:34:07 +00:00
|
|
|
}
|
2016-06-20 18:26:25 +00:00
|
|
|
} else if (!r->ioptions.compression_per_level.empty()) {
|
2015-09-23 19:42:43 +00:00
|
|
|
// Use the compression of the last level if we have per level compression
|
|
|
|
compression_type = *(r->ioptions.compression_per_level.rbegin());
|
2020-03-31 19:08:41 +00:00
|
|
|
compression_opts = r->mutable_cf_options.compression_opts;
|
2016-06-20 18:26:25 +00:00
|
|
|
} else {
|
|
|
|
compression_type = r->mutable_cf_options.compression;
|
2020-03-31 19:08:41 +00:00
|
|
|
compression_opts = r->mutable_cf_options.compression_opts;
|
2015-09-23 19:42:43 +00:00
|
|
|
}
|
|
|
|
|
2021-05-18 01:27:42 +00:00
|
|
|
IntTblPropCollectorFactories int_tbl_prop_collector_factories;
|
2016-08-19 23:17:56 +00:00
|
|
|
|
|
|
|
// SstFileWriter properties collector to add SstFileWriter version.
|
2015-09-23 19:42:43 +00:00
|
|
|
int_tbl_prop_collector_factories.emplace_back(
|
2016-10-18 23:59:37 +00:00
|
|
|
new SstFileWriterPropertiesCollectorFactory(2 /* version */,
|
|
|
|
0 /* global_seqno*/));
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2016-08-19 23:17:56 +00:00
|
|
|
// User collector factories
|
|
|
|
auto user_collector_factories =
|
|
|
|
r->ioptions.table_properties_collector_factories;
|
|
|
|
for (size_t i = 0; i < user_collector_factories.size(); i++) {
|
|
|
|
int_tbl_prop_collector_factories.emplace_back(
|
|
|
|
new UserKeyTablePropertiesCollectorFactory(
|
|
|
|
user_collector_factories[i]));
|
|
|
|
}
|
2016-09-18 05:30:43 +00:00
|
|
|
int unknown_level = -1;
|
2016-12-05 22:16:23 +00:00
|
|
|
uint32_t cf_id;
|
|
|
|
|
|
|
|
if (r->cfh != nullptr) {
|
|
|
|
// user explicitly specified that this file will be ingested into cfh,
|
|
|
|
// we can persist this information in the file.
|
|
|
|
cf_id = r->cfh->GetID();
|
|
|
|
r->column_family_name = r->cfh->GetName();
|
|
|
|
} else {
|
|
|
|
r->column_family_name = "";
|
|
|
|
cf_id = TablePropertiesCollectorFactory::Context::kUnknownColumnFamily;
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
TableBuilderOptions table_builder_options(
|
2018-05-21 21:33:55 +00:00
|
|
|
r->ioptions, r->mutable_cf_options, r->internal_comparator,
|
2021-03-25 21:58:23 +00:00
|
|
|
&int_tbl_prop_collector_factories, compression_type, compression_opts,
|
Add more LSM info to FilterBuildingContext (#8246)
Summary:
Add `num_levels`, `is_bottommost`, and table file creation
`reason` to `FilterBuildingContext`, in anticipation of more powerful
Bloom-like filter support.
To support this, added `is_bottommost` and `reason` to
`TableBuilderOptions`, which allowed removing `reason` parameter from
`rocksdb::BuildTable`.
I attempted to remove `skip_filters` from `TableBuilderOptions`, because
filter construction decisions should arise from options, not one-off
parameters. I could not completely remove it because the public API for
SstFileWriter takes a `skip_filters` parameter, and translating this
into an option change would mean awkwardly replacing the table_factory
if it is BlockBasedTableFactory with new filter_policy=nullptr option.
I marked this public skip_filters option as deprecated because of this
oddity. (skip_filters on the read side probably makes sense.)
At least `skip_filters` is now largely hidden for users of
`TableBuilderOptions` and is no longer used for implementing the
optimize_filters_for_hits option. Bringing the logic for that option
closer to handling of FilterBuildingContext makes it more obvious that
hese two are using the same notion of "bottommost." (Planned:
configuration options for Bloom-like filters that generalize
`optimize_filters_for_hits`)
Recommended follow-up: Try to get away from "bottommost level" naming of
things, which is inaccurate (see
VersionStorageInfo::RangeMightExistAfterSortedRun), and move to
"bottommost run" or just "bottommost."
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8246
Test Plan:
extended an existing unit test to exercise and check various
filter building contexts. Also, existing tests for
optimize_filters_for_hits validate some of the "bottommost" handling,
which is now closely connected to FilterBuildingContext::is_bottommost
through TableBuilderOptions::is_bottommost
Reviewed By: mrambacher
Differential Revision: D28099346
Pulled By: pdillinger
fbshipit-source-id: 2c1072e29c24d4ac404c761a7b7663292372600a
2021-04-30 20:49:24 +00:00
|
|
|
cf_id, r->column_family_name, unknown_level, false /* is_bottommost */,
|
|
|
|
TableFileCreationReason::kMisc, 0 /* creation_time */,
|
|
|
|
0 /* oldest_key_time */, 0 /* file_creation_time */,
|
2021-08-21 03:39:52 +00:00
|
|
|
"SST Writer" /* db_id */, r->db_session_id, 0 /* target_file_size */,
|
|
|
|
r->next_file_number);
|
|
|
|
// External SST files used to each get a unique session id. Now for
|
|
|
|
// slightly better uniqueness probability in constructing cache keys, we
|
|
|
|
// assign fake file numbers to each file (into table properties) and keep
|
|
|
|
// the same session id for the life of the SstFileWriter.
|
|
|
|
r->next_file_number++;
|
Add more LSM info to FilterBuildingContext (#8246)
Summary:
Add `num_levels`, `is_bottommost`, and table file creation
`reason` to `FilterBuildingContext`, in anticipation of more powerful
Bloom-like filter support.
To support this, added `is_bottommost` and `reason` to
`TableBuilderOptions`, which allowed removing `reason` parameter from
`rocksdb::BuildTable`.
I attempted to remove `skip_filters` from `TableBuilderOptions`, because
filter construction decisions should arise from options, not one-off
parameters. I could not completely remove it because the public API for
SstFileWriter takes a `skip_filters` parameter, and translating this
into an option change would mean awkwardly replacing the table_factory
if it is BlockBasedTableFactory with new filter_policy=nullptr option.
I marked this public skip_filters option as deprecated because of this
oddity. (skip_filters on the read side probably makes sense.)
At least `skip_filters` is now largely hidden for users of
`TableBuilderOptions` and is no longer used for implementing the
optimize_filters_for_hits option. Bringing the logic for that option
closer to handling of FilterBuildingContext makes it more obvious that
hese two are using the same notion of "bottommost." (Planned:
configuration options for Bloom-like filters that generalize
`optimize_filters_for_hits`)
Recommended follow-up: Try to get away from "bottommost level" naming of
things, which is inaccurate (see
VersionStorageInfo::RangeMightExistAfterSortedRun), and move to
"bottommost run" or just "bottommost."
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8246
Test Plan:
extended an existing unit test to exercise and check various
filter building contexts. Also, existing tests for
optimize_filters_for_hits validate some of the "bottommost" handling,
which is now closely connected to FilterBuildingContext::is_bottommost
through TableBuilderOptions::is_bottommost
Reviewed By: mrambacher
Differential Revision: D28099346
Pulled By: pdillinger
fbshipit-source-id: 2c1072e29c24d4ac404c761a7b7663292372600a
2021-04-30 20:49:24 +00:00
|
|
|
// XXX: when we can remove skip_filters from the SstFileWriter public API
|
|
|
|
// we can remove it from TableBuilderOptions.
|
|
|
|
table_builder_options.skip_filters = r->skip_filters;
|
2021-02-11 06:18:33 +00:00
|
|
|
FileTypeSet tmp_set = r->ioptions.checksum_handoff_file_types;
|
2020-05-20 18:53:49 +00:00
|
|
|
r->file_writer.reset(new WritableFileWriter(
|
2021-03-15 11:32:24 +00:00
|
|
|
std::move(sst_file), file_path, r->env_options, r->ioptions.clock,
|
|
|
|
nullptr /* io_tracer */, nullptr /* stats */, r->ioptions.listeners,
|
2021-04-23 03:42:50 +00:00
|
|
|
r->ioptions.file_checksum_gen_factory.get(),
|
Using existing crc32c checksum in checksum handoff for Manifest and WAL (#8412)
Summary:
In PR https://github.com/facebook/rocksdb/issues/7523 , checksum handoff is introduced in RocksDB for WAL, Manifest, and SST files. When user enable checksum handoff for a certain type of file, before the data is written to the lower layer storage system, we calculate the checksum (crc32c) of each piece of data and pass the checksum down with the data, such that data verification can be down by the lower layer storage system if it has the capability. However, it cannot cover the whole lifetime of the data in the memory and also it potentially introduces extra checksum calculation overhead.
In this PR, we introduce a new interface in WritableFileWriter::Append, which allows the caller be able to pass the data and the checksum (crc32c) together. In this way, WritableFileWriter can directly use the pass-in checksum (crc32c) to generate the checksum of data being passed down to the storage system. It saves the calculation overhead and achieves higher protection coverage. When a new checksum is added with the data, we use Crc32cCombine https://github.com/facebook/rocksdb/issues/8305 to combine the existing checksum and the new checksum. To avoid the segmenting of data by rate-limiter before it is stored, rate-limiter is called enough times to accumulate enough credits for a certain write. This design only support Manifest and WAL which use log_writer in the current stage.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8412
Test Plan: make check, add new testing cases.
Reviewed By: anand1976
Differential Revision: D29151545
Pulled By: zhichao-cao
fbshipit-source-id: 75e2278c5126cfd58393c67b1efd18dcc7a30772
2021-06-25 07:46:33 +00:00
|
|
|
tmp_set.Contains(FileType::kTableFile), false));
|
2016-10-18 23:59:37 +00:00
|
|
|
|
|
|
|
// TODO(tec) : If table_factory is using compressed block cache, we will
|
|
|
|
// be adding the external sst file blocks into it, which is wasteful.
|
2015-09-23 19:42:43 +00:00
|
|
|
r->builder.reset(r->ioptions.table_factory->NewTableBuilder(
|
2021-04-29 13:59:53 +00:00
|
|
|
table_builder_options, r->file_writer.get()));
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2018-07-14 05:40:23 +00:00
|
|
|
r->file_info = ExternalSstFileInfo();
|
2015-09-23 19:42:43 +00:00
|
|
|
r->file_info.file_path = file_path;
|
2016-10-18 23:59:37 +00:00
|
|
|
r->file_info.version = 2;
|
2015-09-23 19:42:43 +00:00
|
|
|
return s;
|
|
|
|
}
|
|
|
|
|
|
|
|
Status SstFileWriter::Add(const Slice& user_key, const Slice& value) {
|
2017-05-26 19:05:19 +00:00
|
|
|
return rep_->Add(user_key, value, ValueType::kTypeValue);
|
|
|
|
}
|
2016-12-29 22:51:52 +00:00
|
|
|
|
2017-05-26 19:05:19 +00:00
|
|
|
Status SstFileWriter::Put(const Slice& user_key, const Slice& value) {
|
|
|
|
return rep_->Add(user_key, value, ValueType::kTypeValue);
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2021-09-10 01:57:01 +00:00
|
|
|
Status SstFileWriter::Put(const Slice& user_key, const Slice& timestamp,
|
|
|
|
const Slice& value) {
|
|
|
|
return rep_->Add(user_key, timestamp, value, ValueType::kTypeValue);
|
|
|
|
}
|
|
|
|
|
2017-05-26 19:05:19 +00:00
|
|
|
Status SstFileWriter::Merge(const Slice& user_key, const Slice& value) {
|
|
|
|
return rep_->Add(user_key, value, ValueType::kTypeMerge);
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
2017-05-26 19:05:19 +00:00
|
|
|
Status SstFileWriter::Delete(const Slice& user_key) {
|
|
|
|
return rep_->Add(user_key, Slice(), ValueType::kTypeDeletion);
|
2015-09-23 19:42:43 +00:00
|
|
|
}
|
|
|
|
|
2021-09-10 01:57:01 +00:00
|
|
|
Status SstFileWriter::Delete(const Slice& user_key, const Slice& timestamp) {
|
|
|
|
return rep_->Add(user_key, timestamp, Slice(),
|
|
|
|
ValueType::kTypeDeletionWithTimestamp);
|
|
|
|
}
|
|
|
|
|
2018-07-14 05:40:23 +00:00
|
|
|
Status SstFileWriter::DeleteRange(const Slice& begin_key,
|
|
|
|
const Slice& end_key) {
|
|
|
|
return rep_->DeleteRange(begin_key, end_key);
|
|
|
|
}
|
|
|
|
|
2015-09-23 19:42:43 +00:00
|
|
|
Status SstFileWriter::Finish(ExternalSstFileInfo* file_info) {
|
2017-05-23 18:36:06 +00:00
|
|
|
Rep* r = rep_.get();
|
2015-09-23 19:42:43 +00:00
|
|
|
if (!r->builder) {
|
|
|
|
return Status::InvalidArgument("File is not opened");
|
|
|
|
}
|
2018-07-14 05:40:23 +00:00
|
|
|
if (r->file_info.num_entries == 0 &&
|
|
|
|
r->file_info.num_range_del_entries == 0) {
|
2016-01-25 21:47:07 +00:00
|
|
|
return Status::InvalidArgument("Cannot create sst file with no entries");
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
|
|
|
|
Status s = r->builder->Finish();
|
2016-12-29 22:51:52 +00:00
|
|
|
r->file_info.file_size = r->builder->FileSize();
|
|
|
|
|
2015-09-23 19:42:43 +00:00
|
|
|
if (s.ok()) {
|
2017-02-13 18:54:38 +00:00
|
|
|
s = r->file_writer->Sync(r->ioptions.use_fsync);
|
2021-04-06 18:53:54 +00:00
|
|
|
r->InvalidatePageCache(true /* closing */).PermitUncheckedError();
|
2015-09-23 19:42:43 +00:00
|
|
|
if (s.ok()) {
|
|
|
|
s = r->file_writer->Close();
|
|
|
|
}
|
|
|
|
}
|
2020-05-20 18:53:49 +00:00
|
|
|
if (s.ok()) {
|
|
|
|
r->file_info.file_checksum = r->file_writer->GetFileChecksum();
|
|
|
|
r->file_info.file_checksum_func_name =
|
|
|
|
r->file_writer->GetFileChecksumFuncName();
|
|
|
|
}
|
2015-09-23 19:42:43 +00:00
|
|
|
if (!s.ok()) {
|
|
|
|
r->ioptions.env->DeleteFile(r->file_info.file_path);
|
|
|
|
}
|
|
|
|
|
2016-12-29 22:51:52 +00:00
|
|
|
if (file_info != nullptr) {
|
2015-09-23 19:42:43 +00:00
|
|
|
*file_info = r->file_info;
|
|
|
|
}
|
|
|
|
|
|
|
|
r->builder.reset();
|
|
|
|
return s;
|
|
|
|
}
|
2016-12-17 02:26:56 +00:00
|
|
|
|
|
|
|
uint64_t SstFileWriter::FileSize() {
|
|
|
|
return rep_->file_info.file_size;
|
|
|
|
}
|
2017-02-28 19:05:08 +00:00
|
|
|
#endif // !ROCKSDB_LITE
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|