2016-02-09 23:12:00 +00:00
|
|
|
// Copyright (c) 2011-present, Facebook, Inc. All rights reserved.
|
2013-11-06 19:55:43 +00:00
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
2017-04-28 00:50:56 +00:00
|
|
|
// This source code is also licensed under the GPLv2 license found in the
|
|
|
|
// COPYING file in the root directory of this source tree.
|
2013-11-06 19:55:43 +00:00
|
|
|
//
|
|
|
|
|
2014-04-15 20:39:26 +00:00
|
|
|
#ifndef ROCKSDB_LITE
|
2015-10-16 21:10:33 +00:00
|
|
|
#include "memtable/hash_skiplist_rep.h"
|
2013-12-03 20:42:15 +00:00
|
|
|
|
2014-10-27 21:50:21 +00:00
|
|
|
#include <atomic>
|
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
#include "rocksdb/memtablerep.h"
|
2014-01-31 01:18:17 +00:00
|
|
|
#include "util/arena.h"
|
2013-11-06 19:55:43 +00:00
|
|
|
#include "rocksdb/slice.h"
|
|
|
|
#include "rocksdb/slice_transform.h"
|
|
|
|
#include "port/port.h"
|
|
|
|
#include "util/murmurhash.h"
|
2013-11-21 03:49:27 +00:00
|
|
|
#include "db/memtable.h"
|
2017-04-06 20:59:31 +00:00
|
|
|
#include "memtable/skiplist.h"
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
namespace rocksdb {
|
|
|
|
namespace {
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
class HashSkipListRep : public MemTableRep {
|
2013-11-06 19:55:43 +00:00
|
|
|
public:
|
2014-12-02 20:09:20 +00:00
|
|
|
HashSkipListRep(const MemTableRep::KeyComparator& compare,
|
|
|
|
MemTableAllocator* allocator, const SliceTransform* transform,
|
|
|
|
size_t bucket_size, int32_t skiplist_height,
|
|
|
|
int32_t skiplist_branching_factor);
|
2013-11-06 19:55:43 +00:00
|
|
|
|
2014-04-04 22:37:28 +00:00
|
|
|
virtual void Insert(KeyHandle handle) override;
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
virtual bool Contains(const char* key) const override;
|
|
|
|
|
|
|
|
virtual size_t ApproximateMemoryUsage() override;
|
|
|
|
|
2014-02-11 17:46:30 +00:00
|
|
|
virtual void Get(const LookupKey& k, void* callback_args,
|
|
|
|
bool (*callback_func)(void* arg,
|
|
|
|
const char* entry)) override;
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
virtual ~HashSkipListRep();
|
2013-11-06 19:55:43 +00:00
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-02 23:38:00 +00:00
|
|
|
virtual MemTableRep::Iterator* GetIterator(Arena* arena = nullptr) override;
|
2013-11-06 19:55:43 +00:00
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-02 23:38:00 +00:00
|
|
|
virtual MemTableRep::Iterator* GetDynamicPrefixIterator(
|
|
|
|
Arena* arena = nullptr) override;
|
2014-01-16 02:17:58 +00:00
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
private:
|
2013-11-08 08:31:09 +00:00
|
|
|
friend class DynamicIterator;
|
2014-03-10 19:56:46 +00:00
|
|
|
typedef SkipList<const char*, const MemTableRep::KeyComparator&> Bucket;
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
size_t bucket_size_;
|
|
|
|
|
2013-11-22 21:31:00 +00:00
|
|
|
const int32_t skiplist_height_;
|
|
|
|
const int32_t skiplist_branching_factor_;
|
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
// Maps slices (which are transformed user keys) to buckets of keys sharing
|
|
|
|
// the same transform.
|
2014-10-27 21:50:21 +00:00
|
|
|
std::atomic<Bucket*>* buckets_;
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
// The user-supplied transform whose domain is the user keys.
|
|
|
|
const SliceTransform* transform_;
|
|
|
|
|
2014-03-10 19:56:46 +00:00
|
|
|
const MemTableRep::KeyComparator& compare_;
|
2013-11-06 19:55:43 +00:00
|
|
|
// immutable after construction
|
2014-12-02 20:09:20 +00:00
|
|
|
MemTableAllocator* const allocator_;
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
inline size_t GetHash(const Slice& slice) const {
|
2014-11-11 21:47:22 +00:00
|
|
|
return MurmurHash(slice.data(), static_cast<int>(slice.size()), 0) %
|
|
|
|
bucket_size_;
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
inline Bucket* GetBucket(size_t i) const {
|
2014-10-27 21:50:21 +00:00
|
|
|
return buckets_[i].load(std::memory_order_acquire);
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
inline Bucket* GetBucket(const Slice& slice) const {
|
|
|
|
return GetBucket(GetHash(slice));
|
|
|
|
}
|
|
|
|
// Get a bucket from buckets_. If the bucket hasn't been initialized yet,
|
|
|
|
// initialize it before returning.
|
|
|
|
Bucket* GetInitializedBucket(const Slice& transformed);
|
|
|
|
|
|
|
|
class Iterator : public MemTableRep::Iterator {
|
|
|
|
public:
|
2014-03-14 17:02:04 +00:00
|
|
|
explicit Iterator(Bucket* list, bool own_list = true,
|
|
|
|
Arena* arena = nullptr)
|
|
|
|
: list_(list), iter_(list), own_list_(own_list), arena_(arena) {}
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
virtual ~Iterator() {
|
|
|
|
// if we own the list, we should also delete it
|
|
|
|
if (own_list_) {
|
2013-11-08 08:31:09 +00:00
|
|
|
assert(list_ != nullptr);
|
2013-11-06 19:55:43 +00:00
|
|
|
delete list_;
|
|
|
|
}
|
2013-11-08 08:31:09 +00:00
|
|
|
}
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
// Returns true iff the iterator is positioned at a valid node.
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual bool Valid() const override {
|
2013-11-08 08:31:09 +00:00
|
|
|
return list_ != nullptr && iter_.Valid();
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Returns the key at the current position.
|
|
|
|
// REQUIRES: Valid()
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual const char* key() const override {
|
2013-11-08 08:31:09 +00:00
|
|
|
assert(Valid());
|
2013-11-06 19:55:43 +00:00
|
|
|
return iter_.key();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Advances to the next position.
|
|
|
|
// REQUIRES: Valid()
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void Next() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
assert(Valid());
|
2013-11-06 19:55:43 +00:00
|
|
|
iter_.Next();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Advances to the previous position.
|
|
|
|
// REQUIRES: Valid()
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void Prev() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
assert(Valid());
|
2013-11-06 19:55:43 +00:00
|
|
|
iter_.Prev();
|
|
|
|
}
|
|
|
|
|
|
|
|
// Advance to the first entry with a key >= target
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void Seek(const Slice& internal_key,
|
|
|
|
const char* memtable_key) override {
|
2013-11-08 08:31:09 +00:00
|
|
|
if (list_ != nullptr) {
|
2013-11-21 03:49:27 +00:00
|
|
|
const char* encoded_key =
|
|
|
|
(memtable_key != nullptr) ?
|
2013-11-27 22:27:02 +00:00
|
|
|
memtable_key : EncodeKey(&tmp_, internal_key);
|
2013-11-21 03:49:27 +00:00
|
|
|
iter_.Seek(encoded_key);
|
2013-11-08 08:31:09 +00:00
|
|
|
}
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
2016-09-28 01:20:57 +00:00
|
|
|
// Retreat to the last entry with a key <= target
|
|
|
|
virtual void SeekForPrev(const Slice& internal_key,
|
|
|
|
const char* memtable_key) override {
|
|
|
|
// not supported
|
|
|
|
assert(false);
|
|
|
|
}
|
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
// Position at the first entry in collection.
|
|
|
|
// Final state of iterator is Valid() iff collection is not empty.
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void SeekToFirst() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
if (list_ != nullptr) {
|
|
|
|
iter_.SeekToFirst();
|
|
|
|
}
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Position at the last entry in collection.
|
|
|
|
// Final state of iterator is Valid() iff collection is not empty.
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void SeekToLast() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
if (list_ != nullptr) {
|
|
|
|
iter_.SeekToLast();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
protected:
|
|
|
|
void Reset(Bucket* list) {
|
|
|
|
if (own_list_) {
|
|
|
|
assert(list_ != nullptr);
|
|
|
|
delete list_;
|
|
|
|
}
|
|
|
|
list_ = list;
|
|
|
|
iter_.SetList(list);
|
|
|
|
own_list_ = false;
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
private:
|
2013-11-08 08:31:09 +00:00
|
|
|
// if list_ is nullptr, we should NEVER call any methods on iter_
|
|
|
|
// if list_ is nullptr, this Iterator is not Valid()
|
2013-11-06 19:55:43 +00:00
|
|
|
Bucket* list_;
|
|
|
|
Bucket::Iterator iter_;
|
|
|
|
// here we track if we own list_. If we own it, we are also
|
|
|
|
// responsible for it's cleaning. This is a poor man's shared_ptr
|
|
|
|
bool own_list_;
|
2014-03-14 17:02:04 +00:00
|
|
|
std::unique_ptr<Arena> arena_;
|
2013-11-21 03:49:27 +00:00
|
|
|
std::string tmp_; // For passing to EncodeKey
|
2013-11-06 19:55:43 +00:00
|
|
|
};
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
class DynamicIterator : public HashSkipListRep::Iterator {
|
|
|
|
public:
|
|
|
|
explicit DynamicIterator(const HashSkipListRep& memtable_rep)
|
|
|
|
: HashSkipListRep::Iterator(nullptr, false),
|
|
|
|
memtable_rep_(memtable_rep) {}
|
|
|
|
|
|
|
|
// Advance to the first entry with a key >= target
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void Seek(const Slice& k, const char* memtable_key) override {
|
2014-01-25 01:50:59 +00:00
|
|
|
auto transformed = memtable_rep_.transform_->Transform(ExtractUserKey(k));
|
2013-11-08 08:31:09 +00:00
|
|
|
Reset(memtable_rep_.GetBucket(transformed));
|
2013-11-21 03:49:27 +00:00
|
|
|
HashSkipListRep::Iterator::Seek(k, memtable_key);
|
2013-11-08 08:31:09 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// Position at the first entry in collection.
|
|
|
|
// Final state of iterator is Valid() iff collection is not empty.
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void SeekToFirst() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
// Prefix iterator does not support total order.
|
|
|
|
// We simply set the iterator to invalid state
|
|
|
|
Reset(nullptr);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Position at the last entry in collection.
|
|
|
|
// Final state of iterator is Valid() iff collection is not empty.
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void SeekToLast() override {
|
2013-11-08 08:31:09 +00:00
|
|
|
// Prefix iterator does not support total order.
|
|
|
|
// We simply set the iterator to invalid state
|
|
|
|
Reset(nullptr);
|
|
|
|
}
|
|
|
|
private:
|
|
|
|
// the underlying memtable
|
|
|
|
const HashSkipListRep& memtable_rep_;
|
|
|
|
};
|
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
class EmptyIterator : public MemTableRep::Iterator {
|
|
|
|
// This is used when there wasn't a bucket. It is cheaper than
|
|
|
|
// instantiating an empty bucket over which to iterate.
|
|
|
|
public:
|
|
|
|
EmptyIterator() { }
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual bool Valid() const override { return false; }
|
|
|
|
virtual const char* key() const override {
|
2013-11-06 19:55:43 +00:00
|
|
|
assert(false);
|
|
|
|
return nullptr;
|
|
|
|
}
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void Next() override {}
|
|
|
|
virtual void Prev() override {}
|
2014-01-25 01:50:59 +00:00
|
|
|
virtual void Seek(const Slice& internal_key,
|
2015-02-26 19:28:41 +00:00
|
|
|
const char* memtable_key) override {}
|
2016-09-28 01:20:57 +00:00
|
|
|
virtual void SeekForPrev(const Slice& internal_key,
|
|
|
|
const char* memtable_key) override {}
|
2015-02-26 19:28:41 +00:00
|
|
|
virtual void SeekToFirst() override {}
|
|
|
|
virtual void SeekToLast() override {}
|
|
|
|
|
2013-11-06 19:55:43 +00:00
|
|
|
private:
|
|
|
|
};
|
|
|
|
};
|
|
|
|
|
2014-03-10 19:56:46 +00:00
|
|
|
HashSkipListRep::HashSkipListRep(const MemTableRep::KeyComparator& compare,
|
2014-12-02 20:09:20 +00:00
|
|
|
MemTableAllocator* allocator,
|
|
|
|
const SliceTransform* transform,
|
2013-11-22 21:31:00 +00:00
|
|
|
size_t bucket_size, int32_t skiplist_height,
|
|
|
|
int32_t skiplist_branching_factor)
|
2014-12-02 20:09:20 +00:00
|
|
|
: MemTableRep(allocator),
|
2014-04-04 22:37:28 +00:00
|
|
|
bucket_size_(bucket_size),
|
2014-01-16 07:12:31 +00:00
|
|
|
skiplist_height_(skiplist_height),
|
|
|
|
skiplist_branching_factor_(skiplist_branching_factor),
|
2014-01-16 02:17:58 +00:00
|
|
|
transform_(transform),
|
|
|
|
compare_(compare),
|
2014-12-02 20:09:20 +00:00
|
|
|
allocator_(allocator) {
|
|
|
|
auto mem = allocator->AllocateAligned(
|
|
|
|
sizeof(std::atomic<void*>) * bucket_size);
|
2014-10-27 21:50:21 +00:00
|
|
|
buckets_ = new (mem) std::atomic<Bucket*>[bucket_size];
|
2013-11-06 19:55:43 +00:00
|
|
|
|
|
|
|
for (size_t i = 0; i < bucket_size_; ++i) {
|
2014-10-27 21:50:21 +00:00
|
|
|
buckets_[i].store(nullptr, std::memory_order_relaxed);
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
HashSkipListRep::~HashSkipListRep() {
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
HashSkipListRep::Bucket* HashSkipListRep::GetInitializedBucket(
|
2013-11-06 19:55:43 +00:00
|
|
|
const Slice& transformed) {
|
|
|
|
size_t hash = GetHash(transformed);
|
|
|
|
auto bucket = GetBucket(hash);
|
|
|
|
if (bucket == nullptr) {
|
2014-12-02 20:09:20 +00:00
|
|
|
auto addr = allocator_->AllocateAligned(sizeof(Bucket));
|
|
|
|
bucket = new (addr) Bucket(compare_, allocator_, skiplist_height_,
|
2013-11-22 21:31:00 +00:00
|
|
|
skiplist_branching_factor_);
|
2014-10-27 21:50:21 +00:00
|
|
|
buckets_[hash].store(bucket, std::memory_order_release);
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
return bucket;
|
|
|
|
}
|
|
|
|
|
2014-04-04 22:37:28 +00:00
|
|
|
void HashSkipListRep::Insert(KeyHandle handle) {
|
|
|
|
auto* key = static_cast<char*>(handle);
|
2013-11-06 19:55:43 +00:00
|
|
|
assert(!Contains(key));
|
|
|
|
auto transformed = transform_->Transform(UserKey(key));
|
|
|
|
auto bucket = GetInitializedBucket(transformed);
|
|
|
|
bucket->Insert(key);
|
|
|
|
}
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
bool HashSkipListRep::Contains(const char* key) const {
|
2013-11-06 19:55:43 +00:00
|
|
|
auto transformed = transform_->Transform(UserKey(key));
|
|
|
|
auto bucket = GetBucket(transformed);
|
|
|
|
if (bucket == nullptr) {
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
return bucket->Contains(key);
|
|
|
|
}
|
|
|
|
|
2013-11-08 08:31:09 +00:00
|
|
|
size_t HashSkipListRep::ApproximateMemoryUsage() {
|
2014-06-30 22:54:31 +00:00
|
|
|
return 0;
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
2014-02-11 17:46:30 +00:00
|
|
|
void HashSkipListRep::Get(const LookupKey& k, void* callback_args,
|
|
|
|
bool (*callback_func)(void* arg, const char* entry)) {
|
|
|
|
auto transformed = transform_->Transform(k.user_key());
|
|
|
|
auto bucket = GetBucket(transformed);
|
|
|
|
if (bucket != nullptr) {
|
|
|
|
Bucket::Iterator iter(bucket);
|
|
|
|
for (iter.Seek(k.memtable_key().data());
|
|
|
|
iter.Valid() && callback_func(callback_args, iter.key());
|
|
|
|
iter.Next()) {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-02 23:38:00 +00:00
|
|
|
MemTableRep::Iterator* HashSkipListRep::GetIterator(Arena* arena) {
|
2014-03-14 17:02:04 +00:00
|
|
|
// allocate a new arena of similar size to the one currently in use
|
2014-12-02 20:09:20 +00:00
|
|
|
Arena* new_arena = new Arena(allocator_->BlockSize());
|
2014-03-14 17:02:04 +00:00
|
|
|
auto list = new Bucket(compare_, new_arena);
|
2013-11-06 19:55:43 +00:00
|
|
|
for (size_t i = 0; i < bucket_size_; ++i) {
|
|
|
|
auto bucket = GetBucket(i);
|
|
|
|
if (bucket != nullptr) {
|
|
|
|
Bucket::Iterator itr(bucket);
|
|
|
|
for (itr.SeekToFirst(); itr.Valid(); itr.Next()) {
|
|
|
|
list->Insert(itr.key());
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-02 23:38:00 +00:00
|
|
|
if (arena == nullptr) {
|
|
|
|
return new Iterator(list, true, new_arena);
|
|
|
|
} else {
|
|
|
|
auto mem = arena->AllocateAligned(sizeof(Iterator));
|
|
|
|
return new (mem) Iterator(list, true, new_arena);
|
|
|
|
}
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
In DB::NewIterator(), try to allocate the whole iterator tree in an arena
Summary:
In this patch, try to allocate the whole iterator tree starting from DBIter from an arena
1. ArenaWrappedDBIter is created when serves as the entry point of an iterator tree, with an arena in it.
2. Add an option to create iterator from arena for following iterators: DBIter, MergingIterator, MemtableIterator, all mem table's iterators, all table reader's iterators and two level iterator.
3. MergeIteratorBuilder is created to incrementally build the tree of internal iterators. It is passed to mem table list and version set and add iterators to it.
Limitations:
(1) Only DB::NewIterator() without tailing uses the arena. Other cases, including readonly DB and compactions are still from malloc
(2) Two level iterator itself is allocated in arena, but not iterators inside it.
Test Plan: make all check
Reviewers: ljin, haobo
Reviewed By: haobo
Subscribers: leveldb, dhruba, yhchiang, igor
Differential Revision: https://reviews.facebook.net/D18513
2014-06-02 23:38:00 +00:00
|
|
|
MemTableRep::Iterator* HashSkipListRep::GetDynamicPrefixIterator(Arena* arena) {
|
|
|
|
if (arena == nullptr) {
|
|
|
|
return new DynamicIterator(*this);
|
|
|
|
} else {
|
|
|
|
auto mem = arena->AllocateAligned(sizeof(DynamicIterator));
|
|
|
|
return new (mem) DynamicIterator(*this);
|
|
|
|
}
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
} // anon namespace
|
|
|
|
|
2014-01-16 02:17:58 +00:00
|
|
|
MemTableRep* HashSkipListRepFactory::CreateMemTableRep(
|
2014-12-02 20:09:20 +00:00
|
|
|
const MemTableRep::KeyComparator& compare, MemTableAllocator* allocator,
|
2014-05-04 22:52:23 +00:00
|
|
|
const SliceTransform* transform, Logger* logger) {
|
2014-12-02 20:09:20 +00:00
|
|
|
return new HashSkipListRep(compare, allocator, transform, bucket_count_,
|
2014-01-16 07:12:31 +00:00
|
|
|
skiplist_height_, skiplist_branching_factor_);
|
2013-12-03 20:42:15 +00:00
|
|
|
}
|
2013-11-08 08:31:09 +00:00
|
|
|
|
|
|
|
MemTableRepFactory* NewHashSkipListRepFactory(
|
2014-03-10 19:56:46 +00:00
|
|
|
size_t bucket_count, int32_t skiplist_height,
|
|
|
|
int32_t skiplist_branching_factor) {
|
|
|
|
return new HashSkipListRepFactory(bucket_count, skiplist_height,
|
|
|
|
skiplist_branching_factor);
|
2013-11-06 19:55:43 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
} // namespace rocksdb
|
2014-04-15 20:39:26 +00:00
|
|
|
#endif // ROCKSDB_LITE
|