2016-04-21 22:59:17 +00:00
|
|
|
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
2017-07-15 23:03:42 +00:00
|
|
|
// This source code is licensed under both the GPLv2 (found in the
|
|
|
|
// COPYING file in the root directory) and Apache 2.0 License
|
|
|
|
// (found in the LICENSE.Apache file in the root directory).
|
2016-04-21 22:59:17 +00:00
|
|
|
//
|
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
|
|
|
#include "utilities/persistent_cache/persistent_cache_test.h"
|
|
|
|
|
|
|
|
#include <functional>
|
|
|
|
#include <memory>
|
|
|
|
#include <thread>
|
|
|
|
|
2021-01-09 17:42:21 +00:00
|
|
|
#include "file/file_util.h"
|
2016-05-03 18:05:42 +00:00
|
|
|
#include "utilities/persistent_cache/block_cache_tier.h"
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
namespace ROCKSDB_NAMESPACE {
|
2016-04-21 22:59:17 +00:00
|
|
|
|
2016-05-03 18:05:42 +00:00
|
|
|
static const double kStressFactor = .125;
|
|
|
|
|
2016-08-01 22:22:58 +00:00
|
|
|
#ifdef OS_LINUX
|
2016-05-03 18:05:42 +00:00
|
|
|
static void OnOpenForRead(void* arg) {
|
|
|
|
int* val = static_cast<int*>(arg);
|
|
|
|
*val &= ~O_DIRECT;
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
2016-05-03 18:05:42 +00:00
|
|
|
"NewRandomAccessFile:O_DIRECT",
|
|
|
|
std::bind(OnOpenForRead, std::placeholders::_1));
|
|
|
|
}
|
|
|
|
|
|
|
|
static void OnOpenForWrite(void* arg) {
|
|
|
|
int* val = static_cast<int*>(arg);
|
|
|
|
*val &= ~O_DIRECT;
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
2016-05-03 18:05:42 +00:00
|
|
|
"NewWritableFile:O_DIRECT",
|
|
|
|
std::bind(OnOpenForWrite, std::placeholders::_1));
|
|
|
|
}
|
2016-08-01 22:22:58 +00:00
|
|
|
#endif
|
2016-05-03 18:05:42 +00:00
|
|
|
|
2016-11-22 18:26:08 +00:00
|
|
|
static void OnDeleteDir(void* arg) {
|
|
|
|
char* dir = static_cast<char*>(arg);
|
2021-01-09 17:42:21 +00:00
|
|
|
ASSERT_OK(DestroyDir(Env::Default(), std::string(dir)));
|
2016-11-22 18:26:08 +00:00
|
|
|
}
|
|
|
|
|
2016-05-03 18:05:42 +00:00
|
|
|
//
|
|
|
|
// Simple logger that prints message on stdout
|
|
|
|
//
|
|
|
|
class ConsoleLogger : public Logger {
|
|
|
|
public:
|
|
|
|
using Logger::Logv;
|
|
|
|
ConsoleLogger() : Logger(InfoLogLevel::ERROR_LEVEL) {}
|
|
|
|
|
|
|
|
void Logv(const char* format, va_list ap) override {
|
|
|
|
MutexLock _(&lock_);
|
|
|
|
vprintf(format, ap);
|
|
|
|
printf("\n");
|
|
|
|
}
|
|
|
|
|
|
|
|
port::Mutex lock_;
|
|
|
|
};
|
|
|
|
|
|
|
|
// construct a tiered RAM+Block cache
|
|
|
|
std::unique_ptr<PersistentTieredCache> NewTieredCache(
|
|
|
|
const size_t mem_size, const PersistentCacheConfig& opt) {
|
|
|
|
std::unique_ptr<PersistentTieredCache> tcache(new PersistentTieredCache());
|
|
|
|
// create primary tier
|
|
|
|
assert(mem_size);
|
|
|
|
auto pcache = std::shared_ptr<PersistentCacheTier>(new VolatileCacheTier(
|
|
|
|
/*is_compressed*/ true, mem_size));
|
|
|
|
tcache->AddTier(pcache);
|
|
|
|
// create secondary tier
|
|
|
|
auto scache = std::shared_ptr<PersistentCacheTier>(new BlockCacheTier(opt));
|
|
|
|
tcache->AddTier(scache);
|
|
|
|
|
|
|
|
Status s = tcache->Open();
|
|
|
|
assert(s.ok());
|
|
|
|
return tcache;
|
|
|
|
}
|
|
|
|
|
|
|
|
// create block cache
|
|
|
|
std::unique_ptr<PersistentCacheTier> NewBlockCache(
|
|
|
|
Env* env, const std::string& path,
|
|
|
|
const uint64_t max_size = std::numeric_limits<uint64_t>::max(),
|
|
|
|
const bool enable_direct_writes = false) {
|
2022-10-24 23:38:09 +00:00
|
|
|
const uint32_t max_file_size =
|
|
|
|
static_cast<uint32_t>(12 * 1024 * 1024 * kStressFactor);
|
2016-05-03 18:05:42 +00:00
|
|
|
auto log = std::make_shared<ConsoleLogger>();
|
|
|
|
PersistentCacheConfig opt(env, path, max_size, log);
|
|
|
|
opt.cache_file_size = max_file_size;
|
|
|
|
opt.max_write_pipeline_backlog_size = std::numeric_limits<uint64_t>::max();
|
|
|
|
opt.enable_direct_writes = enable_direct_writes;
|
|
|
|
std::unique_ptr<PersistentCacheTier> scache(new BlockCacheTier(opt));
|
|
|
|
Status s = scache->Open();
|
|
|
|
assert(s.ok());
|
|
|
|
return scache;
|
|
|
|
}
|
|
|
|
|
|
|
|
// create a new cache tier
|
|
|
|
std::unique_ptr<PersistentTieredCache> NewTieredCache(
|
|
|
|
Env* env, const std::string& path, const uint64_t max_volatile_cache_size,
|
|
|
|
const uint64_t max_block_cache_size =
|
|
|
|
std::numeric_limits<uint64_t>::max()) {
|
2022-10-24 23:38:09 +00:00
|
|
|
const uint32_t max_file_size =
|
|
|
|
static_cast<uint32_t>(12 * 1024 * 1024 * kStressFactor);
|
2016-05-03 18:05:42 +00:00
|
|
|
auto log = std::make_shared<ConsoleLogger>();
|
|
|
|
auto opt = PersistentCacheConfig(env, path, max_block_cache_size, log);
|
|
|
|
opt.cache_file_size = max_file_size;
|
|
|
|
opt.max_write_pipeline_backlog_size = std::numeric_limits<uint64_t>::max();
|
|
|
|
// create tier out of the two caches
|
|
|
|
auto cache = NewTieredCache(max_volatile_cache_size, opt);
|
|
|
|
return cache;
|
|
|
|
}
|
|
|
|
|
|
|
|
PersistentCacheTierTest::PersistentCacheTierTest()
|
2018-07-14 00:18:39 +00:00
|
|
|
: path_(test::PerThreadDBPath("cache_test")) {
|
2016-08-01 22:22:58 +00:00
|
|
|
#ifdef OS_LINUX
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
"NewRandomAccessFile:O_DIRECT", OnOpenForRead);
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
"NewWritableFile:O_DIRECT", OnOpenForWrite);
|
2016-08-01 22:22:58 +00:00
|
|
|
#endif
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
2016-11-22 18:26:08 +00:00
|
|
|
// Block cache tests
|
2016-12-13 19:42:42 +00:00
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_BlockCacheInsertWithFileCreateError) {
|
2016-11-22 18:26:08 +00:00
|
|
|
cache_ = NewBlockCache(Env::Default(), path_,
|
|
|
|
/*size=*/std::numeric_limits<uint64_t>::max(),
|
2022-10-24 23:38:09 +00:00
|
|
|
/*direct_writes=*/false);
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
"BlockCacheTier::NewCacheFile:DeleteDir", OnDeleteDir);
|
2016-11-22 18:26:08 +00:00
|
|
|
|
2022-10-24 23:38:09 +00:00
|
|
|
RunNegativeInsertTest(/*nthreads=*/1,
|
2016-11-22 18:26:08 +00:00
|
|
|
/*max_keys*/
|
2022-10-24 23:38:09 +00:00
|
|
|
static_cast<size_t>(10 * 1024 * kStressFactor));
|
2016-11-22 18:26:08 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearAllCallBacks();
|
2016-11-22 18:26:08 +00:00
|
|
|
}
|
|
|
|
|
2016-08-10 20:26:15 +00:00
|
|
|
// Travis is unable to handle the normal version of the tests running out of
|
|
|
|
// fds, out of space and timeouts. This is an easier version of the test
|
|
|
|
// specifically written for Travis
|
2022-09-15 18:14:48 +00:00
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_BasicTest) {
|
2016-08-10 20:26:15 +00:00
|
|
|
cache_ = std::make_shared<VolatileCacheTier>();
|
|
|
|
RunInsertTest(/*nthreads=*/1, /*max_keys=*/1024);
|
|
|
|
|
|
|
|
cache_ = NewBlockCache(Env::Default(), path_,
|
|
|
|
/*size=*/std::numeric_limits<uint64_t>::max(),
|
|
|
|
/*direct_writes=*/true);
|
|
|
|
RunInsertTest(/*nthreads=*/1, /*max_keys=*/1024);
|
|
|
|
|
|
|
|
cache_ = NewTieredCache(Env::Default(), path_,
|
|
|
|
/*memory_size=*/static_cast<size_t>(1 * 1024 * 1024));
|
|
|
|
RunInsertTest(/*nthreads=*/1, /*max_keys=*/1024);
|
|
|
|
}
|
2020-03-27 02:34:06 +00:00
|
|
|
|
2016-04-21 22:59:17 +00:00
|
|
|
// Volatile cache tests
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (somewhat expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_VolatileCacheInsert) {
|
2016-04-21 22:59:17 +00:00
|
|
|
for (auto nthreads : {1, 5}) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto max_keys :
|
|
|
|
{10 * 1024 * kStressFactor, 1 * 1024 * 1024 * kStressFactor}) {
|
2016-04-21 22:59:17 +00:00
|
|
|
cache_ = std::make_shared<VolatileCacheTier>();
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTest(nthreads, static_cast<size_t>(max_keys));
|
2016-04-21 22:59:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (somewhat expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_VolatileCacheInsertWithEviction) {
|
2016-04-21 22:59:17 +00:00
|
|
|
for (auto nthreads : {1, 5}) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto max_keys : {1 * 1024 * 1024 * kStressFactor}) {
|
|
|
|
cache_ = std::make_shared<VolatileCacheTier>(
|
2022-10-24 23:38:09 +00:00
|
|
|
/*compressed=*/true,
|
|
|
|
/*size=*/static_cast<size_t>(1 * 1024 * 1024 * kStressFactor));
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTestWithEviction(nthreads, static_cast<size_t>(max_keys));
|
2016-04-21 22:59:17 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-05-03 18:05:42 +00:00
|
|
|
// Block cache tests
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_BlockCacheInsert) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto direct_writes : {true, false}) {
|
|
|
|
for (auto nthreads : {1, 5}) {
|
|
|
|
for (auto max_keys :
|
|
|
|
{10 * 1024 * kStressFactor, 1 * 1024 * 1024 * kStressFactor}) {
|
|
|
|
cache_ = NewBlockCache(Env::Default(), path_,
|
|
|
|
/*size=*/std::numeric_limits<uint64_t>::max(),
|
|
|
|
direct_writes);
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTest(nthreads, static_cast<size_t>(max_keys));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (somewhat expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_BlockCacheInsertWithEviction) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto nthreads : {1, 5}) {
|
|
|
|
for (auto max_keys : {1 * 1024 * 1024 * kStressFactor}) {
|
2022-10-24 23:38:09 +00:00
|
|
|
cache_ = NewBlockCache(
|
|
|
|
Env::Default(), path_,
|
|
|
|
/*max_size=*/static_cast<size_t>(200 * 1024 * 1024 * kStressFactor));
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTestWithEviction(nthreads, static_cast<size_t>(max_keys));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Tiered cache tests
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_TieredCacheInsert) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto nthreads : {1, 5}) {
|
|
|
|
for (auto max_keys :
|
|
|
|
{10 * 1024 * kStressFactor, 1 * 1024 * 1024 * kStressFactor}) {
|
2022-10-24 23:38:09 +00:00
|
|
|
cache_ = NewTieredCache(
|
|
|
|
Env::Default(), path_,
|
|
|
|
/*memory_size=*/static_cast<size_t>(1 * 1024 * 1024 * kStressFactor));
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTest(nthreads, static_cast<size_t>(max_keys));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-08 22:12:48 +00:00
|
|
|
// the tests causes a lot of file deletions which Travis limited testing
|
|
|
|
// environment cannot handle
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (somewhat expensive)
|
|
|
|
TEST_F(PersistentCacheTierTest, DISABLED_TieredCacheInsertWithEviction) {
|
2016-05-03 18:05:42 +00:00
|
|
|
for (auto nthreads : {1, 5}) {
|
|
|
|
for (auto max_keys : {1 * 1024 * 1024 * kStressFactor}) {
|
|
|
|
cache_ = NewTieredCache(
|
|
|
|
Env::Default(), path_,
|
2016-08-03 00:15:18 +00:00
|
|
|
/*memory_size=*/static_cast<size_t>(1 * 1024 * 1024 * kStressFactor),
|
2022-10-24 23:38:09 +00:00
|
|
|
/*block_cache_size*/
|
|
|
|
static_cast<size_t>(200 * 1024 * 1024 * kStressFactor));
|
2016-08-03 00:15:18 +00:00
|
|
|
RunInsertTestWithEviction(nthreads, static_cast<size_t>(max_keys));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
std::shared_ptr<PersistentCacheTier> MakeVolatileCache(
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
Env* /*env*/, const std::string& /*dbname*/) {
|
2016-05-03 18:05:42 +00:00
|
|
|
return std::make_shared<VolatileCacheTier>();
|
|
|
|
}
|
|
|
|
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
std::shared_ptr<PersistentCacheTier> MakeBlockCache(Env* env,
|
|
|
|
const std::string& dbname) {
|
|
|
|
return NewBlockCache(env, dbname);
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
std::shared_ptr<PersistentCacheTier> MakeTieredCache(
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
Env* env, const std::string& dbname) {
|
2016-05-03 18:05:42 +00:00
|
|
|
const auto memory_size = 1 * 1024 * 1024 * kStressFactor;
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
return NewTieredCache(env, dbname, static_cast<size_t>(memory_size));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
2016-08-01 22:22:58 +00:00
|
|
|
#ifdef OS_LINUX
|
2016-05-03 18:05:42 +00:00
|
|
|
static void UniqueIdCallback(void* arg) {
|
|
|
|
int* result = reinterpret_cast<int*>(arg);
|
|
|
|
if (*result == -1) {
|
|
|
|
*result = 0;
|
|
|
|
}
|
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->ClearTrace();
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
2016-05-03 18:05:42 +00:00
|
|
|
"GetUniqueIdFromFile:FS_IOC_GETVERSION", UniqueIdCallback);
|
|
|
|
}
|
2016-08-01 22:22:58 +00:00
|
|
|
#endif
|
2016-05-03 18:05:42 +00:00
|
|
|
|
2016-09-30 01:02:13 +00:00
|
|
|
TEST_F(PersistentCacheTierTest, FactoryTest) {
|
|
|
|
for (auto nvm_opt : {true, false}) {
|
|
|
|
ASSERT_FALSE(cache_);
|
|
|
|
auto log = std::make_shared<ConsoleLogger>();
|
|
|
|
std::shared_ptr<PersistentCache> cache;
|
|
|
|
ASSERT_OK(NewPersistentCache(Env::Default(), path_,
|
|
|
|
/*size=*/1 * 1024 * 1024 * 1024, log, nvm_opt,
|
|
|
|
&cache));
|
|
|
|
ASSERT_TRUE(cache);
|
2016-11-22 01:22:01 +00:00
|
|
|
ASSERT_EQ(cache->Stats().size(), 1);
|
|
|
|
ASSERT_TRUE(cache->Stats()[0].size());
|
2016-09-30 01:02:13 +00:00
|
|
|
cache.reset();
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2020-08-18 01:41:20 +00:00
|
|
|
PersistentCacheDBTest::PersistentCacheDBTest()
|
2021-07-23 15:37:27 +00:00
|
|
|
: DBTestBase("cache_test", /*env_do_fsync=*/true) {
|
2016-08-01 22:22:58 +00:00
|
|
|
#ifdef OS_LINUX
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->EnableProcessing();
|
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
2016-05-03 18:05:42 +00:00
|
|
|
"GetUniqueIdFromFile:FS_IOC_GETVERSION", UniqueIdCallback);
|
2020-02-20 20:07:53 +00:00
|
|
|
ROCKSDB_NAMESPACE::SyncPoint::GetInstance()->SetCallBack(
|
|
|
|
"NewRandomAccessFile:O_DIRECT", OnOpenForRead);
|
2016-08-01 22:22:58 +00:00
|
|
|
#endif
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// test template
|
|
|
|
void PersistentCacheDBTest::RunTest(
|
2016-08-10 20:26:15 +00:00
|
|
|
const std::function<std::shared_ptr<PersistentCacheTier>(bool)>& new_pcache,
|
2023-01-25 01:09:19 +00:00
|
|
|
const size_t max_keys = 100 * 1024, const size_t max_usecase = 3) {
|
2016-05-03 18:05:42 +00:00
|
|
|
// number of insertion interations
|
2016-08-10 20:26:15 +00:00
|
|
|
int num_iter = static_cast<int>(max_keys * kStressFactor);
|
2016-05-03 18:05:42 +00:00
|
|
|
|
2016-08-10 20:26:15 +00:00
|
|
|
for (size_t iter = 0; iter < max_usecase; iter++) {
|
2016-05-03 18:05:42 +00:00
|
|
|
Options options;
|
|
|
|
options.write_buffer_size =
|
2022-10-24 23:38:09 +00:00
|
|
|
static_cast<size_t>(64 * 1024 * kStressFactor); // small write buffer
|
2020-02-20 20:07:53 +00:00
|
|
|
options.statistics = ROCKSDB_NAMESPACE::CreateDBStatistics();
|
2016-05-03 18:05:42 +00:00
|
|
|
options = CurrentOptions(options);
|
|
|
|
|
|
|
|
// setup page cache
|
|
|
|
std::shared_ptr<PersistentCacheTier> pcache;
|
|
|
|
BlockBasedTableOptions table_options;
|
|
|
|
table_options.cache_index_and_filter_blocks = true;
|
|
|
|
|
2017-03-30 23:47:19 +00:00
|
|
|
const size_t size_max = std::numeric_limits<size_t>::max();
|
2016-05-03 18:05:42 +00:00
|
|
|
|
|
|
|
switch (iter) {
|
|
|
|
case 0:
|
|
|
|
// page cache, block cache, no-compressed cache
|
|
|
|
pcache = new_pcache(/*is_compressed=*/true);
|
|
|
|
table_options.persistent_cache = pcache;
|
2017-03-30 23:47:19 +00:00
|
|
|
table_options.block_cache = NewLRUCache(size_max);
|
2016-05-03 18:05:42 +00:00
|
|
|
options.table_factory.reset(NewBlockBasedTableFactory(table_options));
|
|
|
|
break;
|
|
|
|
case 1:
|
|
|
|
// page cache, no block cache, no compressed cache
|
|
|
|
pcache = new_pcache(/*is_compressed=*/false);
|
|
|
|
table_options.persistent_cache = pcache;
|
|
|
|
table_options.block_cache = nullptr;
|
|
|
|
options.table_factory.reset(NewBlockBasedTableFactory(table_options));
|
|
|
|
break;
|
2023-01-25 01:09:19 +00:00
|
|
|
case 2:
|
2016-05-03 18:05:42 +00:00
|
|
|
// page cache, no block cache, no compressed cache
|
|
|
|
// Page cache caches compressed blocks
|
|
|
|
pcache = new_pcache(/*is_compressed=*/true);
|
|
|
|
table_options.persistent_cache = pcache;
|
|
|
|
table_options.block_cache = nullptr;
|
|
|
|
options.table_factory.reset(NewBlockBasedTableFactory(table_options));
|
|
|
|
break;
|
|
|
|
default:
|
2017-07-17 04:23:33 +00:00
|
|
|
FAIL();
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
std::vector<std::string> values;
|
|
|
|
// insert data
|
|
|
|
Insert(options, table_options, num_iter, &values);
|
|
|
|
// flush all data in cache to device
|
|
|
|
pcache->TEST_Flush();
|
|
|
|
// verify data
|
|
|
|
Verify(num_iter, values);
|
|
|
|
|
|
|
|
auto block_miss = TestGetTickerCount(options, BLOCK_CACHE_MISS);
|
|
|
|
auto page_hit = TestGetTickerCount(options, PERSISTENT_CACHE_HIT);
|
|
|
|
auto page_miss = TestGetTickerCount(options, PERSISTENT_CACHE_MISS);
|
|
|
|
|
|
|
|
// check that we triggered the appropriate code paths in the cache
|
|
|
|
switch (iter) {
|
|
|
|
case 0:
|
|
|
|
// page cache, block cache, no-compressed cache
|
|
|
|
ASSERT_GT(page_miss, 0);
|
|
|
|
ASSERT_GT(page_hit, 0);
|
|
|
|
ASSERT_GT(block_miss, 0);
|
|
|
|
break;
|
|
|
|
case 1:
|
|
|
|
case 2:
|
|
|
|
// page cache, no block cache, no compressed cache
|
|
|
|
ASSERT_GT(page_miss, 0);
|
|
|
|
ASSERT_GT(page_hit, 0);
|
|
|
|
break;
|
|
|
|
default:
|
2017-07-17 04:23:33 +00:00
|
|
|
FAIL();
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
options.create_if_missing = true;
|
|
|
|
DestroyAndReopen(options);
|
|
|
|
|
2020-09-16 22:45:30 +00:00
|
|
|
ASSERT_OK(pcache->Close());
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-08-10 20:26:15 +00:00
|
|
|
// Travis is unable to handle the normal version of the tests running out of
|
|
|
|
// fds, out of space and timeouts. This is an easier version of the test
|
2020-03-27 02:34:06 +00:00
|
|
|
// specifically written for Travis.
|
|
|
|
// Now used generally because main tests are too expensive as unit tests.
|
2016-08-10 20:26:15 +00:00
|
|
|
TEST_F(PersistentCacheDBTest, BasicTest) {
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
RunTest(std::bind(&MakeBlockCache, env_, dbname_), /*max_keys=*/1024,
|
2016-08-10 20:26:15 +00:00
|
|
|
/*max_usecase=*/1);
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
2020-03-27 02:34:06 +00:00
|
|
|
|
2016-05-03 18:05:42 +00:00
|
|
|
// test table with block page cache
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (very expensive, especially memory)
|
|
|
|
TEST_F(PersistentCacheDBTest, DISABLED_BlockCacheTest) {
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
RunTest(std::bind(&MakeBlockCache, env_, dbname_));
|
2016-05-03 18:05:42 +00:00
|
|
|
}
|
|
|
|
|
2016-08-10 20:26:15 +00:00
|
|
|
// test table with volatile page cache
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (very expensive, especially memory)
|
|
|
|
TEST_F(PersistentCacheDBTest, DISABLED_VolatileCacheTest) {
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
RunTest(std::bind(&MakeVolatileCache, env_, dbname_));
|
2016-08-10 20:26:15 +00:00
|
|
|
}
|
|
|
|
|
2016-05-03 18:05:42 +00:00
|
|
|
// test table with tiered page cache
|
2020-03-27 02:34:06 +00:00
|
|
|
// DISABLED for now (very expensive, especially memory)
|
|
|
|
TEST_F(PersistentCacheDBTest, DISABLED_TieredCacheTest) {
|
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class (#7566)
Summary:
This PR does a few things:
1. The MockFileSystem class was split out from the MockEnv. This change would theoretically allow a MockFileSystem to be used by other Environments as well (if we created a means of constructing one). The MockFileSystem implements a FileSystem in its entirety and does not rely on any Wrapper implementation.
2. Make the RocksDB test suite work when MOCK_ENV=1 and ENCRYPTED_ENV=1 are set. To accomplish this, a few things were needed:
- The tests that tried to use the "wrong" environment (Env::Default() instead of env_) were updated
- The MockFileSystem was changed to support the features it was missing or mishandled (such as recursively deleting files in a directory or supporting renaming of a directory).
3. Updated the test framework to have a ROCKSDB_GTEST_SKIP macro. This can be used to flag tests that are skipped. Currently, this defaults to doing nothing (marks the test as SUCCESS) but will mark the tests as SKIPPED when RocksDB is upgraded to a version of gtest that supports this (gtest-1.10).
I have run a full "make check" with MEM_ENV, ENCRYPTED_ENV, both, and neither under both MacOS and RedHat. A few tests were disabled/skipped for the MEM/ENCRYPTED cases. The error_handler_fs_test fails/hangs for MEM_ENV (presumably a timing problem) and I will introduce another PR/issue to track that problem. (I will also push a change to disable those tests soon). There is one more test in DBTest2 that also fails which I need to investigate or skip before this PR is merged.
Theoretically, this PR should also allow the test suite to run against an Env loaded from the registry, though I do not have one to try it with currently.
Finally, once this is accepted, it would be nice if there was a CircleCI job to run these tests on a checkin so this effort does not become stale. I do not know how to do that, so if someone could write that job, it would be appreciated :)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7566
Reviewed By: zhichao-cao
Differential Revision: D24408980
Pulled By: jay-zhuang
fbshipit-source-id: 911b1554a4d0da06fd51feca0c090a4abdcb4a5f
2020-10-27 17:31:34 +00:00
|
|
|
RunTest(std::bind(&MakeTieredCache, env_, dbname_));
|
2016-04-21 22:59:17 +00:00
|
|
|
}
|
2016-09-30 01:02:13 +00:00
|
|
|
|
2020-02-20 20:07:53 +00:00
|
|
|
} // namespace ROCKSDB_NAMESPACE
|
2016-04-21 22:59:17 +00:00
|
|
|
|
|
|
|
int main(int argc, char** argv) {
|
2022-10-18 07:35:35 +00:00
|
|
|
ROCKSDB_NAMESPACE::port::InstallStackTraceHandler();
|
2016-04-21 22:59:17 +00:00
|
|
|
::testing::InitGoogleTest(&argc, argv);
|
|
|
|
return RUN_ALL_TESTS();
|
|
|
|
}
|