2013-10-16 21:59:46 +00:00
|
|
|
// Copyright (c) 2013, Facebook, Inc. All rights reserved.
|
|
|
|
// This source code is licensed under the BSD-style license found in the
|
|
|
|
// LICENSE file in the root directory of this source tree. An additional grant
|
|
|
|
// of patent rights can be found in the PATENTS file in the same directory.
|
|
|
|
//
|
2011-03-18 22:37:00 +00:00
|
|
|
// Copyright (c) 2011 The LevelDB Authors. All rights reserved.
|
|
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
|
|
// found in the LICENSE file. See the AUTHORS file for names of contributors.
|
|
|
|
|
2014-01-31 01:18:17 +00:00
|
|
|
#include "util/arena.h"
|
2011-03-18 22:37:00 +00:00
|
|
|
#include "util/random.h"
|
|
|
|
#include "util/testharness.h"
|
|
|
|
|
2013-10-04 04:49:15 +00:00
|
|
|
namespace rocksdb {
|
2011-03-18 22:37:00 +00:00
|
|
|
|
2014-11-21 22:11:22 +00:00
|
|
|
namespace {
|
|
|
|
const size_t kHugePageSize = 2 * 1024 * 1024;
|
|
|
|
} // namespace
|
2014-01-31 01:18:17 +00:00
|
|
|
class ArenaTest {};
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
|
2014-01-31 01:18:17 +00:00
|
|
|
TEST(ArenaTest, Empty) { Arena arena0; }
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
|
2014-11-21 22:11:22 +00:00
|
|
|
namespace {
|
|
|
|
void MemoryAllocatedBytesTest(size_t huge_page_size) {
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
const int N = 17;
|
2014-01-31 01:18:17 +00:00
|
|
|
size_t req_sz; // requested size
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
size_t bsz = 8192; // block size
|
|
|
|
size_t expected_memory_allocated;
|
2011-03-18 22:37:00 +00:00
|
|
|
|
2014-11-21 22:11:22 +00:00
|
|
|
Arena arena(bsz, huge_page_size);
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
|
|
|
|
// requested size > quarter of a block:
|
|
|
|
// allocate requested size separately
|
|
|
|
req_sz = 3001;
|
|
|
|
for (int i = 0; i < N; i++) {
|
2014-01-31 01:18:17 +00:00
|
|
|
arena.Allocate(req_sz);
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
}
|
2014-05-09 18:01:54 +00:00
|
|
|
expected_memory_allocated = req_sz * N + Arena::kInlineSize;
|
2014-01-31 01:18:17 +00:00
|
|
|
ASSERT_EQ(arena.MemoryAllocatedBytes(), expected_memory_allocated);
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
|
2014-05-09 18:01:54 +00:00
|
|
|
arena.Allocate(Arena::kInlineSize - 1);
|
|
|
|
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
// requested size < quarter of a block:
|
|
|
|
// allocate a block with the default size, then try to use unused part
|
|
|
|
// of the block. So one new block will be allocated for the first
|
|
|
|
// Allocate(99) call. All the remaining calls won't lead to new allocation.
|
|
|
|
req_sz = 99;
|
|
|
|
for (int i = 0; i < N; i++) {
|
2014-01-31 01:18:17 +00:00
|
|
|
arena.Allocate(req_sz);
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
}
|
2014-11-21 22:11:22 +00:00
|
|
|
if (huge_page_size) {
|
|
|
|
ASSERT_TRUE(arena.MemoryAllocatedBytes() ==
|
|
|
|
expected_memory_allocated + bsz ||
|
|
|
|
arena.MemoryAllocatedBytes() ==
|
|
|
|
expected_memory_allocated + huge_page_size);
|
|
|
|
} else {
|
|
|
|
expected_memory_allocated += bsz;
|
|
|
|
ASSERT_EQ(arena.MemoryAllocatedBytes(), expected_memory_allocated);
|
|
|
|
}
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
|
|
|
|
// requested size > quarter of a block:
|
|
|
|
// allocate requested size separately
|
|
|
|
req_sz = 99999999;
|
|
|
|
for (int i = 0; i < N; i++) {
|
2014-01-31 01:18:17 +00:00
|
|
|
arena.Allocate(req_sz);
|
Make arena block size configurable
Summary:
Add an option for arena block size, default value 4096 bytes. Arena will allocate blocks with such size.
I am not sure about passing parameter to skiplist in the new virtualized framework, though I talked to Jim a bit. So add Jim as reviewer.
Test Plan:
new unit test, I am running db_test.
For passing paramter from configured option to Arena, I tried tests like:
TEST(DBTest, Arena_Option) {
std::string dbname = test::TmpDir() + "/db_arena_option_test";
DestroyDB(dbname, Options());
DB* db = nullptr;
Options opts;
opts.create_if_missing = true;
opts.arena_block_size = 1000000; // tested 99, 999999
Status s = DB::Open(opts, dbname, &db);
db->Put(WriteOptions(), "a", "123");
}
and printed some debug info. The results look good. Any suggestion for such a unit-test?
Reviewers: haobo, dhruba, emayanke, jpaton
Reviewed By: dhruba
CC: leveldb, zshao
Differential Revision: https://reviews.facebook.net/D11799
2013-07-31 19:42:23 +00:00
|
|
|
}
|
|
|
|
expected_memory_allocated += req_sz * N;
|
2014-11-21 22:11:22 +00:00
|
|
|
if (huge_page_size) {
|
|
|
|
ASSERT_TRUE(arena.MemoryAllocatedBytes() ==
|
|
|
|
expected_memory_allocated + bsz ||
|
|
|
|
arena.MemoryAllocatedBytes() ==
|
|
|
|
expected_memory_allocated + huge_page_size);
|
|
|
|
} else {
|
|
|
|
ASSERT_EQ(arena.MemoryAllocatedBytes(), expected_memory_allocated);
|
|
|
|
}
|
2011-03-18 22:37:00 +00:00
|
|
|
}
|
|
|
|
|
2014-01-08 23:06:07 +00:00
|
|
|
// Make sure we didn't count the allocate but not used memory space in
|
|
|
|
// Arena::ApproximateMemoryUsage()
|
2014-11-21 22:11:22 +00:00
|
|
|
static void ApproximateMemoryUsageTest(size_t huge_page_size) {
|
2014-01-08 23:06:07 +00:00
|
|
|
const size_t kBlockSize = 4096;
|
|
|
|
const size_t kEntrySize = kBlockSize / 8;
|
2014-01-31 01:18:17 +00:00
|
|
|
const size_t kZero = 0;
|
2014-11-21 22:11:22 +00:00
|
|
|
Arena arena(kBlockSize, huge_page_size);
|
2014-01-10 09:56:35 +00:00
|
|
|
ASSERT_EQ(kZero, arena.ApproximateMemoryUsage());
|
2014-01-08 23:06:07 +00:00
|
|
|
|
2014-05-09 18:01:54 +00:00
|
|
|
// allocate inline bytes
|
|
|
|
arena.AllocateAligned(8);
|
|
|
|
arena.AllocateAligned(Arena::kInlineSize / 2 - 16);
|
|
|
|
arena.AllocateAligned(Arena::kInlineSize / 2);
|
|
|
|
ASSERT_EQ(arena.ApproximateMemoryUsage(), Arena::kInlineSize - 8);
|
|
|
|
ASSERT_EQ(arena.MemoryAllocatedBytes(), Arena::kInlineSize);
|
|
|
|
|
2014-01-08 23:06:07 +00:00
|
|
|
auto num_blocks = kBlockSize / kEntrySize;
|
|
|
|
|
|
|
|
// first allocation
|
|
|
|
arena.AllocateAligned(kEntrySize);
|
|
|
|
auto mem_usage = arena.MemoryAllocatedBytes();
|
2014-11-21 22:11:22 +00:00
|
|
|
if (huge_page_size) {
|
|
|
|
ASSERT_TRUE(mem_usage == kBlockSize + Arena::kInlineSize ||
|
|
|
|
mem_usage == huge_page_size + Arena::kInlineSize);
|
|
|
|
} else {
|
|
|
|
ASSERT_EQ(mem_usage, kBlockSize + Arena::kInlineSize);
|
|
|
|
}
|
2014-01-08 23:06:07 +00:00
|
|
|
auto usage = arena.ApproximateMemoryUsage();
|
|
|
|
ASSERT_LT(usage, mem_usage);
|
|
|
|
for (size_t i = 1; i < num_blocks; ++i) {
|
|
|
|
arena.AllocateAligned(kEntrySize);
|
|
|
|
ASSERT_EQ(mem_usage, arena.MemoryAllocatedBytes());
|
|
|
|
ASSERT_EQ(arena.ApproximateMemoryUsage(), usage + kEntrySize);
|
|
|
|
usage = arena.ApproximateMemoryUsage();
|
|
|
|
}
|
2014-11-21 22:11:22 +00:00
|
|
|
if (huge_page_size) {
|
|
|
|
ASSERT_TRUE(usage > mem_usage ||
|
|
|
|
usage + huge_page_size - kBlockSize == mem_usage);
|
|
|
|
} else {
|
|
|
|
ASSERT_GT(usage, mem_usage);
|
|
|
|
}
|
2014-01-08 23:06:07 +00:00
|
|
|
}
|
|
|
|
|
2014-11-21 22:11:22 +00:00
|
|
|
static void SimpleTest(size_t huge_page_size) {
|
2014-01-08 23:06:07 +00:00
|
|
|
std::vector<std::pair<size_t, char*>> allocated;
|
2014-11-21 22:11:22 +00:00
|
|
|
Arena arena(Arena::kMinBlockSize, huge_page_size);
|
2011-03-18 22:37:00 +00:00
|
|
|
const int N = 100000;
|
|
|
|
size_t bytes = 0;
|
|
|
|
Random rnd(301);
|
|
|
|
for (int i = 0; i < N; i++) {
|
|
|
|
size_t s;
|
|
|
|
if (i % (N / 10) == 0) {
|
|
|
|
s = i;
|
|
|
|
} else {
|
2014-01-08 23:06:07 +00:00
|
|
|
s = rnd.OneIn(4000)
|
|
|
|
? rnd.Uniform(6000)
|
|
|
|
: (rnd.OneIn(10) ? rnd.Uniform(100) : rnd.Uniform(20));
|
2011-03-18 22:37:00 +00:00
|
|
|
}
|
|
|
|
if (s == 0) {
|
|
|
|
// Our arena disallows size 0 allocations.
|
|
|
|
s = 1;
|
|
|
|
}
|
|
|
|
char* r;
|
|
|
|
if (rnd.OneIn(10)) {
|
2014-01-31 01:18:17 +00:00
|
|
|
r = arena.AllocateAligned(s);
|
2011-03-18 22:37:00 +00:00
|
|
|
} else {
|
2014-01-31 01:18:17 +00:00
|
|
|
r = arena.Allocate(s);
|
2011-03-18 22:37:00 +00:00
|
|
|
}
|
|
|
|
|
2012-11-06 20:02:18 +00:00
|
|
|
for (unsigned int b = 0; b < s; b++) {
|
2011-03-18 22:37:00 +00:00
|
|
|
// Fill the "i"th allocation with a known bit pattern
|
|
|
|
r[b] = i % 256;
|
|
|
|
}
|
|
|
|
bytes += s;
|
|
|
|
allocated.push_back(std::make_pair(s, r));
|
2014-01-31 01:18:17 +00:00
|
|
|
ASSERT_GE(arena.ApproximateMemoryUsage(), bytes);
|
2014-01-08 23:06:07 +00:00
|
|
|
if (i > N / 10) {
|
2014-01-31 01:18:17 +00:00
|
|
|
ASSERT_LE(arena.ApproximateMemoryUsage(), bytes * 1.10);
|
2011-03-18 22:37:00 +00:00
|
|
|
}
|
|
|
|
}
|
2012-11-06 20:02:18 +00:00
|
|
|
for (unsigned int i = 0; i < allocated.size(); i++) {
|
2011-03-18 22:37:00 +00:00
|
|
|
size_t num_bytes = allocated[i].first;
|
|
|
|
const char* p = allocated[i].second;
|
2012-11-06 20:02:18 +00:00
|
|
|
for (unsigned int b = 0; b < num_bytes; b++) {
|
2011-03-18 22:37:00 +00:00
|
|
|
// Check the "i"th allocation for the known bit pattern
|
2012-11-06 20:02:18 +00:00
|
|
|
ASSERT_EQ(int(p[b]) & 0xff, (int)(i % 256));
|
2011-03-18 22:37:00 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
2014-11-21 22:11:22 +00:00
|
|
|
} // namespace
|
2011-03-18 22:37:00 +00:00
|
|
|
|
2014-11-21 22:11:22 +00:00
|
|
|
TEST(ArenaTest, MemoryAllocatedBytes) {
|
|
|
|
MemoryAllocatedBytesTest(0);
|
|
|
|
MemoryAllocatedBytesTest(kHugePageSize);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(ArenaTest, ApproximateMemoryUsage) {
|
|
|
|
ApproximateMemoryUsageTest(0);
|
|
|
|
ApproximateMemoryUsageTest(kHugePageSize);
|
|
|
|
}
|
|
|
|
|
|
|
|
TEST(ArenaTest, Simple) {
|
|
|
|
SimpleTest(0);
|
|
|
|
SimpleTest(kHugePageSize);
|
|
|
|
}
|
2013-10-04 04:49:15 +00:00
|
|
|
} // namespace rocksdb
|
2011-03-18 22:37:00 +00:00
|
|
|
|
2014-01-31 01:18:17 +00:00
|
|
|
int main(int argc, char** argv) { return rocksdb::test::RunAllTests(); }
|