dolysis/ohmyzsh
3
0
Fork 0
Code Issues Pull requests Releases Activity

fix(cli): fix commit.gpgsign test in omz pr test

Browse source 
Since `set -e` is enabled, when `commit.gpgsign` is not set the
`git config` command would show an error. Given that it is technically
not ignored, the subshell would exit.

With this change, the `commit.gpgsign` setting is properly tested
by doing the fallback test if the command fails, so no exit status
code ends up quiting the subshell.
This commit is contained in:
Marc Cornellà 2022-04-14 12:05:02 +02:00
parent 7ea6ff8d04
commit f1a5fb5ee9
No known key found for this signature in database
GPG key ID: 0314585E776A9C1B
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
lib/cli.zsh
View file

@ -578,8 +578,9 @@ function _omz::pr::test {
# Back up commit.gpgsign setting: use --local to get the current repository # Back up commit.gpgsign setting: use --local to get the current repository
# setting, not the global one. If --local is not a known option, it will # setting, not the global one. If --local is not a known option, it will
# exit with a 129 status code. # exit with a 129 status code.
gpgsign=$(command git config --local commit.gpgsign 2>/dev/null) if ! gpgsign=$(command git config --local commit.gpgsign 2>/dev/null); then
[[ $? -ne 129 ]] || gpgsign=$(command git config commit.gpgsign 2>/dev/null) [[ $? -ne 129 ]] || gpgsign=$(command git config commit.gpgsign 2>/dev/null)
fi
command git config commit.gpgsign false command git config commit.gpgsign false
command git rebase master ohmyzsh/pull-$1 || { command git rebase master ohmyzsh/pull-$1 || {