From 757ba60ff99c3270a48bd6980df1c68f1591f64b Mon Sep 17 00:00:00 2001 From: strawberry Date: Sun, 24 Dec 2023 00:38:06 -0500 Subject: [PATCH] add comment about the blocking await above this config check comment saying this would have been nice. moved the config checks above that blocking call. Signed-off-by: strawberry --- src/main.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/main.rs b/src/main.rs index 82ff5a45..2d8be644 100644 --- a/src/main.rs +++ b/src/main.rs @@ -176,6 +176,8 @@ async fn main() { info!("Starting server"); run_server().await.unwrap(); + // if server runs into critical error and shuts down, shut down the tracer provider if jaegar is used. + // awaiting run_server() is a blocking call so putting this after is fine, but not the other options above. if config.allow_jaeger { opentelemetry::global::shutdown_tracer_provider(); }