mirror of https://github.com/google/benchmark.git
caa2fcb19c
* Counter(): add 'one thousand' param. Needed for https://github.com/google/benchmark/pull/654 Custom user counters are quite custom. It is not guaranteed that the user *always* expects for these to have 1k == 1000. If the counter represents bytes/memory/etc, 1k should be 1024. Some bikeshedding points: 1. Is this sufficient, or do we really want to go full on into custom types with names? I think just the '1000' is sufficient for now. 2. Should there be a helper benchmark::Counter::Counter{1000,1024}() static 'constructor' functions, since these two, by far, will be the most used? 3. In the future, we should be somehow encoding this info into JSON. * Counter(): use std::pair<> to represent 'one thousand' * Counter(): just use a new enum with two values 1000 vs 1024. Simpler is better. If someone comes up with a real reason to need something more advanced, it can be added later on. * Counter: just store the 1000 or 1024 in the One_K values directly * Counter: s/One_K/OneK/ |
||
|---|---|---|
| .. | ||
| AssemblyTests.cmake | ||
| BUILD | ||
| CMakeLists.txt | ||
| basic_test.cc | ||
| benchmark_gtest.cc | ||
| benchmark_test.cc | ||
| clobber_memory_assembly_test.cc | ||
| complexity_test.cc | ||
| cxx03_test.cc | ||
| diagnostics_test.cc | ||
| donotoptimize_assembly_test.cc | ||
| donotoptimize_test.cc | ||
| filter_test.cc | ||
| fixture_test.cc | ||
| link_main_test.cc | ||
| map_test.cc | ||
| memory_manager_test.cc | ||
| multiple_ranges_test.cc | ||
| options_test.cc | ||
| output_test.h | ||
| output_test_helper.cc | ||
| register_benchmark_test.cc | ||
| reporter_output_test.cc | ||
| skip_with_error_test.cc | ||
| state_assembly_test.cc | ||
| statistics_gtest.cc | ||
| string_util_gtest.cc | ||
| templated_fixture_test.cc | ||
| user_counters_tabular_test.cc | ||
| user_counters_test.cc | ||
| user_counters_thousands_test.cc | ||