mirror of
https://github.com/google/benchmark.git
synced 2024-11-25 22:47:20 +00:00
207b9c7aec
* Improve State packing: put important members on first cache line. This patch does a few different things to ensure commonly accessed data is on the first cache line of the `State` object. First, it moves the `error_occurred_` member to reside after the `started_` and `finished_` bools, since there was internal padding there that was unused. Second, it moves `batch_leftover_` and `max_iterations` further up in the struct declaration. These variables are used in the calculation of `iterations()` which users might call within the loop. Therefore it's more important they exist on the first cache line. Finally, this patch turns the bool members into bitfields. Although this shouldn't have much of an effect currently, because padding is still needed between the last bool and the first size_t, it should help in future changes that require more "bool like" members. * Remove bitfield change for now * Move bools (and their padding) to end of "first cache line" vars. I think it makes the most sense to move the padding required following the group of bools to the end of the variables we want on the first cache line. This also means that the `total_iterations_` variable, which is the most accessed, has the same address as the State object. * Fix static assertion after moving bools
75 lines
2.8 KiB
CMake
75 lines
2.8 KiB
CMake
# - Adds a compiler flag if it is supported by the compiler
|
|
#
|
|
# This function checks that the supplied compiler flag is supported and then
|
|
# adds it to the corresponding compiler flags
|
|
#
|
|
# add_cxx_compiler_flag(<FLAG> [<VARIANT>])
|
|
#
|
|
# - Example
|
|
#
|
|
# include(AddCXXCompilerFlag)
|
|
# add_cxx_compiler_flag(-Wall)
|
|
# add_cxx_compiler_flag(-no-strict-aliasing RELEASE)
|
|
# Requires CMake 2.6+
|
|
|
|
if(__add_cxx_compiler_flag)
|
|
return()
|
|
endif()
|
|
set(__add_cxx_compiler_flag INCLUDED)
|
|
|
|
include(CheckCXXCompilerFlag)
|
|
|
|
function(mangle_compiler_flag FLAG OUTPUT)
|
|
string(TOUPPER "HAVE_CXX_FLAG_${FLAG}" SANITIZED_FLAG)
|
|
string(REPLACE "+" "X" SANITIZED_FLAG ${SANITIZED_FLAG})
|
|
string(REGEX REPLACE "[^A-Za-z_0-9]" "_" SANITIZED_FLAG ${SANITIZED_FLAG})
|
|
string(REGEX REPLACE "_+" "_" SANITIZED_FLAG ${SANITIZED_FLAG})
|
|
set(${OUTPUT} "${SANITIZED_FLAG}" PARENT_SCOPE)
|
|
endfunction(mangle_compiler_flag)
|
|
|
|
function(add_cxx_compiler_flag FLAG)
|
|
mangle_compiler_flag("${FLAG}" MANGLED_FLAG)
|
|
set(OLD_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
|
|
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${FLAG}")
|
|
check_cxx_compiler_flag("${FLAG}" ${MANGLED_FLAG})
|
|
set(CMAKE_REQUIRED_FLAGS "${OLD_CMAKE_REQUIRED_FLAGS}")
|
|
if(${MANGLED_FLAG})
|
|
set(VARIANT ${ARGV1})
|
|
if(ARGV1)
|
|
string(TOUPPER "_${VARIANT}" VARIANT)
|
|
endif()
|
|
set(CMAKE_CXX_FLAGS${VARIANT} "${CMAKE_CXX_FLAGS${VARIANT}} ${BENCHMARK_CXX_FLAGS${VARIANT}} ${FLAG}" PARENT_SCOPE)
|
|
endif()
|
|
endfunction()
|
|
|
|
function(add_required_cxx_compiler_flag FLAG)
|
|
mangle_compiler_flag("${FLAG}" MANGLED_FLAG)
|
|
set(OLD_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
|
|
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${FLAG}")
|
|
check_cxx_compiler_flag("${FLAG}" ${MANGLED_FLAG})
|
|
set(CMAKE_REQUIRED_FLAGS "${OLD_CMAKE_REQUIRED_FLAGS}")
|
|
if(${MANGLED_FLAG})
|
|
set(VARIANT ${ARGV1})
|
|
if(ARGV1)
|
|
string(TOUPPER "_${VARIANT}" VARIANT)
|
|
endif()
|
|
set(CMAKE_CXX_FLAGS${VARIANT} "${CMAKE_CXX_FLAGS${VARIANT}} ${FLAG}" PARENT_SCOPE)
|
|
set(CMAKE_EXE_LINKER_FLAGS "${CMAKE_EXE_LINKER_FLAGS} ${FLAG}" PARENT_SCOPE)
|
|
set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} ${FLAG}" PARENT_SCOPE)
|
|
set(CMAKE_MODULE_LINKER_FLAGS "${CMAKE_MODULE_LINKER_FLAGS} ${FLAG}" PARENT_SCOPE)
|
|
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} ${FLAG}" PARENT_SCOPE)
|
|
else()
|
|
message(FATAL_ERROR "Required flag '${FLAG}' is not supported by the compiler")
|
|
endif()
|
|
endfunction()
|
|
|
|
function(check_cxx_warning_flag FLAG)
|
|
mangle_compiler_flag("${FLAG}" MANGLED_FLAG)
|
|
set(OLD_CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS}")
|
|
# Add -Werror to ensure the compiler generates an error if the warning flag
|
|
# doesn't exist.
|
|
set(CMAKE_REQUIRED_FLAGS "${CMAKE_REQUIRED_FLAGS} -Werror ${FLAG}")
|
|
check_cxx_compiler_flag("${FLAG}" ${MANGLED_FLAG})
|
|
set(CMAKE_REQUIRED_FLAGS "${OLD_CMAKE_REQUIRED_FLAGS}")
|
|
endfunction()
|