mirror of
https://github.com/google/benchmark.git
synced 2024-11-29 00:34:42 +00:00
bd721f9859
* Removing warnings appearing with C++20 / CLang 15
```
[ 70%] Building CXX object _deps/benchmark-build/test/CMakeFiles/benchmark_min_time_flag_time_test.dir/benchmark_min_time_flag_time_test.cc.o
/home/xxx/cpp/_deps/benchmark-src/test/benchmark_min_time_flag_time_test.cc:31:55: warning: unused parameter 'has_explicit_iters' [-Wunused-parameter]
virtual void ReportRunsConfig(double min_time, bool has_explicit_iters,
^
/home/xxx/cpp/_deps/benchmark-src/test/benchmark_min_time_flag_time_test.cc:32:48: warning: unused parameter 'iters' [-Wunused-parameter]
IterationCount iters) BENCHMARK_OVERRIDE {
^
2 warnings generated.
```
```
[ 70%] Building CXX object _deps/benchmark-build/test/CMakeFiles/benchmark_min_time_flag_iters_test.dir/benchmark_min_time_flag_iters_test.cc.o
/home/xxx/cpp/_deps/benchmark-src/test/benchmark_min_time_flag_iters_test.cc:22:36: warning: implicit conversion loses integer precision: 'const benchmark::IterationCount' (aka 'const long') to 'std::vector<int>::value_type' (aka 'int') [-Wshorten-64-to-32]
iter_nums_.push_back(report[0].iterations);
~~~~~~~~~ ~~~~~~~~~~^~~~~~~~~~
1 warning generated.
```
* Refactoring to get the proper type of collection
* Refactoring to get the proper type of collection
* clang format
* bug fix in main
91 lines
2.3 KiB
C++
91 lines
2.3 KiB
C++
#include <cassert>
|
|
#include <climits>
|
|
#include <cmath>
|
|
#include <cstdlib>
|
|
#include <cstring>
|
|
#include <iostream>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
#include "benchmark/benchmark.h"
|
|
|
|
// Tests that we can specify the min time with
|
|
// --benchmark_min_time=<NUM> (no suffix needed) OR
|
|
// --benchmark_min_time=<NUM>s
|
|
namespace {
|
|
|
|
// This is from benchmark.h
|
|
typedef int64_t IterationCount;
|
|
|
|
class TestReporter : public benchmark::ConsoleReporter {
|
|
public:
|
|
virtual bool ReportContext(const Context& context) BENCHMARK_OVERRIDE {
|
|
return ConsoleReporter::ReportContext(context);
|
|
};
|
|
|
|
virtual void ReportRuns(const std::vector<Run>& report) BENCHMARK_OVERRIDE {
|
|
assert(report.size() == 1);
|
|
ConsoleReporter::ReportRuns(report);
|
|
};
|
|
|
|
virtual void ReportRunsConfig(double min_time, bool /* has_explicit_iters */,
|
|
IterationCount /* iters */) BENCHMARK_OVERRIDE {
|
|
min_times_.push_back(min_time);
|
|
}
|
|
|
|
TestReporter() {}
|
|
|
|
virtual ~TestReporter() {}
|
|
|
|
const std::vector<double>& GetMinTimes() const { return min_times_; }
|
|
|
|
private:
|
|
std::vector<double> min_times_;
|
|
};
|
|
|
|
bool AlmostEqual(double a, double b) {
|
|
return std::fabs(a - b) < std::numeric_limits<double>::epsilon();
|
|
}
|
|
|
|
void DoTestHelper(int* argc, const char** argv, double expected) {
|
|
benchmark::Initialize(argc, const_cast<char**>(argv));
|
|
|
|
TestReporter test_reporter;
|
|
const size_t returned_count =
|
|
benchmark::RunSpecifiedBenchmarks(&test_reporter, "BM_MyBench");
|
|
assert(returned_count == 1);
|
|
|
|
// Check the min_time
|
|
const std::vector<double>& min_times = test_reporter.GetMinTimes();
|
|
assert(!min_times.empty() && AlmostEqual(min_times[0], expected));
|
|
}
|
|
|
|
} // end namespace
|
|
|
|
static void BM_MyBench(benchmark::State& state) {
|
|
for (auto s : state) {
|
|
}
|
|
}
|
|
BENCHMARK(BM_MyBench);
|
|
|
|
int main(int argc, char** argv) {
|
|
// Make a fake argv and append the new --benchmark_min_time=<foo> to it.
|
|
int fake_argc = argc + 1;
|
|
const char** fake_argv = new const char*[fake_argc];
|
|
|
|
for (int i = 0; i < argc; ++i) fake_argv[i] = argv[i];
|
|
|
|
const char* no_suffix = "--benchmark_min_time=4";
|
|
const char* with_suffix = "--benchmark_min_time=4.0s";
|
|
double expected = 4.0;
|
|
|
|
fake_argv[argc] = no_suffix;
|
|
DoTestHelper(&fake_argc, fake_argv, expected);
|
|
|
|
fake_argv[argc] = with_suffix;
|
|
DoTestHelper(&fake_argc, fake_argv, expected);
|
|
|
|
delete[] fake_argv;
|
|
return 0;
|
|
}
|