mirror of
https://github.com/google/benchmark.git
synced 2024-12-01 07:16:07 +00:00
6d51a119ff
This commit contains a fix for macOS ARM64 wheel buils in Google Benchmark's wheel building CI. Previously, while `cibuildwheel` itself properly identified the need for cross-compilations and produced valid ARM platform wheels, the included shared library containing the Python bindings built by `bazel` was built for x86, resulting in immediate errors upon import. To fix this, logic was added to the setup.py file that adds the "--cpu=darwin_arm64" and "--macos_cpus=arm64" switches to the `bazel build` command if 1) The current system platform is macOS Darwin running on the x86_64 architecture, and 2) The ARCHFLAGS environment variable, set by wheel build systems like conda and cibuildwheel, contains the tag "arm64". This way, bazel correctly sets the target CPU to ARM64, and produces functional wheels for the macOS ARM line of CPUs.
150 lines
4.8 KiB
Python
150 lines
4.8 KiB
Python
import os
|
|
import posixpath
|
|
import platform
|
|
import re
|
|
import shutil
|
|
import sys
|
|
|
|
from distutils import sysconfig
|
|
import setuptools
|
|
from setuptools.command import build_ext
|
|
|
|
|
|
HERE = os.path.dirname(os.path.abspath(__file__))
|
|
|
|
|
|
IS_WINDOWS = sys.platform.startswith("win")
|
|
|
|
|
|
def _get_version():
|
|
"""Parse the version string from __init__.py."""
|
|
with open(
|
|
os.path.join(HERE, "bindings", "python", "google_benchmark", "__init__.py")
|
|
) as init_file:
|
|
try:
|
|
version_line = next(
|
|
line for line in init_file if line.startswith("__version__")
|
|
)
|
|
except StopIteration:
|
|
raise ValueError("__version__ not defined in __init__.py")
|
|
else:
|
|
namespace = {}
|
|
exec(version_line, namespace) # pylint: disable=exec-used
|
|
return namespace["__version__"]
|
|
|
|
|
|
def _parse_requirements(path):
|
|
with open(os.path.join(HERE, path)) as requirements:
|
|
return [
|
|
line.rstrip()
|
|
for line in requirements
|
|
if not (line.isspace() or line.startswith("#"))
|
|
]
|
|
|
|
|
|
class BazelExtension(setuptools.Extension):
|
|
"""A C/C++ extension that is defined as a Bazel BUILD target."""
|
|
|
|
def __init__(self, name, bazel_target):
|
|
self.bazel_target = bazel_target
|
|
self.relpath, self.target_name = posixpath.relpath(bazel_target, "//").split(
|
|
":"
|
|
)
|
|
setuptools.Extension.__init__(self, name, sources=[])
|
|
|
|
|
|
class BuildBazelExtension(build_ext.build_ext):
|
|
"""A command that runs Bazel to build a C/C++ extension."""
|
|
|
|
def run(self):
|
|
for ext in self.extensions:
|
|
self.bazel_build(ext)
|
|
build_ext.build_ext.run(self)
|
|
|
|
def bazel_build(self, ext):
|
|
"""Runs the bazel build to create the package."""
|
|
with open("WORKSPACE", "r") as workspace:
|
|
workspace_contents = workspace.read()
|
|
|
|
with open("WORKSPACE", "w") as workspace:
|
|
workspace.write(
|
|
re.sub(
|
|
r'(?<=path = ").*(?=", # May be overwritten by setup\.py\.)',
|
|
sysconfig.get_python_inc().replace(os.path.sep, posixpath.sep),
|
|
workspace_contents,
|
|
)
|
|
)
|
|
|
|
if not os.path.exists(self.build_temp):
|
|
os.makedirs(self.build_temp)
|
|
|
|
bazel_argv = [
|
|
"bazel",
|
|
"build",
|
|
ext.bazel_target,
|
|
"--symlink_prefix=" + os.path.join(self.build_temp, "bazel-"),
|
|
"--compilation_mode=" + ("dbg" if self.debug else "opt"),
|
|
]
|
|
|
|
if IS_WINDOWS:
|
|
# Link with python*.lib.
|
|
for library_dir in self.library_dirs:
|
|
bazel_argv.append("--linkopt=/LIBPATH:" + library_dir)
|
|
elif sys.platform == "darwin" and platform.machine() == "x86_64":
|
|
bazel_argv.append("--macos_minimum_os=10.9")
|
|
|
|
# ARCHFLAGS is always set by cibuildwheel before macOS wheel builds.
|
|
archflags = os.getenv("ARCHFLAGS", "")
|
|
if "arm64" in archflags:
|
|
bazel_argv.append("--cpu=darwin_arm64")
|
|
bazel_argv.append("--macos_cpus=arm64")
|
|
|
|
self.spawn(bazel_argv)
|
|
|
|
shared_lib_suffix = '.dll' if IS_WINDOWS else '.so'
|
|
ext_bazel_bin_path = os.path.join(
|
|
self.build_temp, 'bazel-bin',
|
|
ext.relpath, ext.target_name + shared_lib_suffix)
|
|
|
|
ext_dest_path = self.get_ext_fullpath(ext.name)
|
|
ext_dest_dir = os.path.dirname(ext_dest_path)
|
|
if not os.path.exists(ext_dest_dir):
|
|
os.makedirs(ext_dest_dir)
|
|
shutil.copyfile(ext_bazel_bin_path, ext_dest_path)
|
|
|
|
|
|
setuptools.setup(
|
|
name="google_benchmark",
|
|
version=_get_version(),
|
|
url="https://github.com/google/benchmark",
|
|
description="A library to benchmark code snippets.",
|
|
author="Google",
|
|
author_email="benchmark-py@google.com",
|
|
# Contained modules and scripts.
|
|
package_dir={"": "bindings/python"},
|
|
packages=setuptools.find_packages("bindings/python"),
|
|
install_requires=_parse_requirements("bindings/python/requirements.txt"),
|
|
cmdclass=dict(build_ext=BuildBazelExtension),
|
|
ext_modules=[
|
|
BazelExtension(
|
|
"google_benchmark._benchmark",
|
|
"//bindings/python/google_benchmark:_benchmark",
|
|
)
|
|
],
|
|
zip_safe=False,
|
|
# PyPI package information.
|
|
classifiers=[
|
|
"Development Status :: 4 - Beta",
|
|
"Intended Audience :: Developers",
|
|
"Intended Audience :: Science/Research",
|
|
"License :: OSI Approved :: Apache Software License",
|
|
"Programming Language :: Python :: 3.6",
|
|
"Programming Language :: Python :: 3.7",
|
|
"Programming Language :: Python :: 3.8",
|
|
"Topic :: Software Development :: Testing",
|
|
"Topic :: System :: Benchmark",
|
|
],
|
|
license="Apache 2.0",
|
|
keywords="benchmark",
|
|
)
|