From 6d74c0625b8e88c1afce72b4f383c91b9a99dbe6 Mon Sep 17 00:00:00 2001 From: Deniz Evrenci Date: Mon, 14 May 2018 23:02:49 +0900 Subject: [PATCH] split_list is not defined for assembly tests (#595) * Update AUTHORS and CONTRIBUTORS * split_list is not defined for assembly tests --- AUTHORS | 1 + CONTRIBUTORS | 1 + cmake/HandleGTest.cmake | 4 +--- cmake/split_list.cmake | 3 +++ test/AssemblyTests.cmake | 1 + 5 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 cmake/split_list.cmake diff --git a/AUTHORS b/AUTHORS index 45adb27e..f8219036 100644 --- a/AUTHORS +++ b/AUTHORS @@ -13,6 +13,7 @@ Arne Beer Carto Christopher Seymour David Coeurjolly +Deniz Evrenci Dirac Research Dominik Czarnota Eric Fiselier diff --git a/CONTRIBUTORS b/CONTRIBUTORS index 2f1999be..1cf04db1 100644 --- a/CONTRIBUTORS +++ b/CONTRIBUTORS @@ -28,6 +28,7 @@ Billy Robert O'Neal III Chris Kennelly Christopher Seymour David Coeurjolly +Deniz Evrenci Dominic Hamon Dominik Czarnota Eric Fiselier diff --git a/cmake/HandleGTest.cmake b/cmake/HandleGTest.cmake index 43c71bf9..7ce1a633 100644 --- a/cmake/HandleGTest.cmake +++ b/cmake/HandleGTest.cmake @@ -1,7 +1,5 @@ -macro(split_list listname) - string(REPLACE ";" " " ${listname} "${${listname}}") -endmacro() +include(split_list) macro(build_external_gtest) include(ExternalProject) diff --git a/cmake/split_list.cmake b/cmake/split_list.cmake new file mode 100644 index 00000000..67aed3fd --- /dev/null +++ b/cmake/split_list.cmake @@ -0,0 +1,3 @@ +macro(split_list listname) + string(REPLACE ";" " " ${listname} "${${listname}}") +endmacro() diff --git a/test/AssemblyTests.cmake b/test/AssemblyTests.cmake index d8f321aa..3d078586 100644 --- a/test/AssemblyTests.cmake +++ b/test/AssemblyTests.cmake @@ -1,4 +1,5 @@ +include(split_list) set(ASM_TEST_FLAGS "") check_cxx_compiler_flag(-O3 BENCHMARK_HAS_O3_FLAG)