Declare a Python 3.13 toolchain, revert setup.py toolchain arget selection (#1876)

The new solution was too smart (read: dense), because it did not account for
the fact that we look for the Windows libs of the interpreter building
the wheel, not the hermetic one supplying the header files.

The fix is to just align the versions again, so that the libs and headers
come from the same minor version.
This commit is contained in:
Nicholas Junge 2024-11-07 16:04:51 +01:00 committed by GitHub
parent a6af6eeb6a
commit 50ffd3e546
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 10 deletions

View File

@ -27,6 +27,7 @@ python.toolchain(
is_default = True, is_default = True,
python_version = "3.12", python_version = "3.12",
) )
python.toolchain(python_version = "3.13")
pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip", dev_dependency = True) pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip", dev_dependency = True)
pip.parse( pip.parse(

View File

@ -92,16 +92,10 @@ class BuildBazelExtension(build_ext.build_ext):
def bazel_build(self, ext: BazelExtension) -> None: def bazel_build(self, ext: BazelExtension) -> None:
"""Runs the bazel build to create the package.""" """Runs the bazel build to create the package."""
temp_path = Path(self.build_temp) temp_path = Path(self.build_temp)
if py_limited_api:
# We only need to know the minimum ABI version, # We round to the minor version, which makes rules_python
# since it is stable across minor versions by definition. # look up the latest available patch version internally.
# The value here is calculated as the minimum of a) the minimum python_version = "{0}.{1}".format(*sys.version_info[:2])
# Python version required, and b) the stable ABI version target.
# NB: This needs to be kept in sync with [project.requires-python]
# in pyproject.toml.
python_version = "3.12"
else:
python_version = "{0}.{1}".format(*sys.version_info[:2])
bazel_argv = [ bazel_argv = [
"bazel", "bazel",