dolysis
/
benchmark
mirror of https://github.com/google/benchmark.git
3
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a bug in the destruction of BenchmarkFamilies.

This commit is contained in:
pleroy 2014-06-09 13:27:47 +02:00
parent 35da167b9e
commit 10dc155372
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/benchmark.cc
View File

@ -343,6 +343,14 @@ BenchmarkFamilies::~BenchmarkFamilies() {
int BenchmarkFamilies::AddBenchmark(Benchmark* family) { int BenchmarkFamilies::AddBenchmark(Benchmark* family) {
mutex_lock l(&benchmark_mutex); mutex_lock l(&benchmark_mutex);
// This loop attempts to reuse an entry that was previously removed to avoid
// unncessary growth of the vector.
for (int index = 0; index < families_.size(); ++index) {
if (families_[index] == nullptr) {
families_[index] = family;
return index;
}
}
int index = families_.size(); int index = families_.size();
families_.push_back(family); families_.push_back(family);
return index; return index;
@ -351,11 +359,8 @@ int BenchmarkFamilies::AddBenchmark(Benchmark* family) {
void BenchmarkFamilies::RemoveBenchmark(int index) { void BenchmarkFamilies::RemoveBenchmark(int index) {
mutex_lock l(&benchmark_mutex); mutex_lock l(&benchmark_mutex);
families_[index] = NULL; families_[index] = NULL;
// Don't shrink families_ here, we might be called by the destructor of
// Shrink the vector if convenient. // BenchmarkFamilies which iterates over the vector.
while (!families_.empty() && families_.back() == NULL) {
families_.pop_back();
}
} }
void BenchmarkFamilies::FindBenchmarks( void BenchmarkFamilies::FindBenchmarks(