Commit Graph

115 Commits

Author SHA1 Message Date
Adam Liddell f6dc2de237 Fix buildifier lint 2023-12-14 17:22:04 +00:00
Adam Liddell 72e5f39e8d Apply buildifier 2023-12-14 17:12:27 +00:00
Adam Liddell 60b8b27460 Update rulegen to apply Bazel 7 attr fix 2023-12-14 15:07:22 +00:00
Walter Gray fcc828b67f
Update cpp_proto_library.bzl
Modifies the cc_library call to only forward arguments if they're present in kwargs.
This is vital for bazel 7.0.0 compatibility since the `nocopts` attribute is removed (it's actually been deprecated since 2019 but the documentation was never updated).
2023-12-06 11:18:57 -08:00
Adam Liddell 6d0eadd0ab
Merge branch 'master' into rust-prost-tonic 2023-09-08 11:44:10 +01:00
Adam Liddell 798a95fca2 Fix test failures due to ipv4/ipv6 mismatch 2023-09-08 11:38:51 +01:00
Adam Liddell e58969fd93 Improve C++ client error logging to debug test failure 2023-09-08 11:30:16 +01:00
Jeremy Meador dd753a2881 Support NO_PREFIX output_mode for cpp rules 2023-08-09 09:37:52 -07:00
Adam Liddell 7064b28a75 Speed up C++ routegen test client 2023-07-25 23:15:10 +01:00
William Smith 684375c6ce Remove grpc sources from runfiles trees.
If a C++ binary uses grpc code generated with cpp_grpc_library,
the resulting runfiles tree includes the generated grpc sources.

Reproducer here:
https://gist.github.com/william-smith-skydio/e3b630f7cc826ad33f283b8017a88cc7

```bash
> tree bazel-bin/test.runfiles/__main__/
bazel-bin/test.runfiles/__main__/
├── grpc_test_proto_cpp_pb
│   ├── grpc_test.grpc.pb.cc -> ...
│   ├── grpc_test.grpc.pb.h -> ...
│   ├── grpc_test_mock.grpc.pb.h -> ...
│   ├── grpc_test.pb.cc -> ...
│   └── grpc_test.pb.h -> ...
└── test -> ...
```

With this patch applied, I get the expected behavior:

```bash
tree bazel-bin/test.runfiles
bazel-bin/test.runfiles
├── __main__
│   └── test -> ...
└── MANIFEST
```

This issue does not affect cpp_proto_library since that was
already using the split srcs/hdrs targets.
2023-05-31 15:51:02 -07:00
Adam Liddell bc21b70be1 Fix typo in dict comprehension 2022-12-01 22:35:25 +00:00
Adam Liddell b5c64a09dc Apply buildifier 2022-12-01 22:13:20 +00:00
Adam Liddell aed1a01df3 Rename var 2022-12-01 21:53:45 +00:00
Adam Liddell 339b5370f3 Forward all Bazel common attrs in library macros
Closes #218
2022-12-01 21:45:56 +00:00
Adam Liddell d143d46d42 Add doc_template_compile, closes #121 2021-09-21 00:20:19 +01:00
Adam Liddell 6bc61634f7 Remove unneeded check 2021-09-19 23:16:06 +01:00
Adam Liddell 5b6ab842ff Simplify args forwarding snippet 2021-09-17 18:53:19 +00:00
Adam Liddell 8d09a4d73e Drop transitive aspect-based compilation. Closes #137 2021-09-17 18:25:48 +00:00
Adam Liddell 92d4f039e7 Restructure docs 2021-04-05 19:54:37 +00:00
Adam Liddell 49598ca028 Fixup more MD -> RST 2021-04-05 14:50:35 +00:00
Adam Liddell 71ad087add Use RST for language readmes 2021-04-05 13:41:57 +00:00
Adam Liddell 4cbbbe3d32 Add Buf lint and breaking rules 2021-03-02 23:11:51 +00:00
Adam Liddell 5cad44efcc Tidy readme 2021-02-28 00:58:11 +00:00
Adam Liddell d161e62f92 Update rule descriptions to be more readable 2021-02-24 22:43:29 +00:00
Adam Liddell 18d4e22bf7 Pass name attr directly rather than via kwargs 2021-02-21 20:30:40 +00:00
Adam Liddell c0533d9ccf Fix empty default values in docs 2021-02-20 13:31:57 +00:00
Adam Liddell 4a7c44ce77 Pass cc_library attrs through in C/C++/ObjC 2021-02-20 12:30:50 +00:00
Adam Liddell 957e5ef811 Split generated C++ files into correct srcs and hdrs fields, closes #40 2021-02-19 23:40:29 +00:00
Adam Liddell a7b937dd75 Remove ProtoLibraryAspectNodeInfo from require providers for protos attr 2021-02-19 15:25:09 +00:00
Adam Liddell 6a810a7872 Test disabling aspect on protos attr to compile rules 2021-02-19 15:23:12 +00:00
Adam Liddell bae2ccfb41 Apply buildifier 2021-02-15 11:40:12 +00:00
Adam Liddell a53a68a680 Ensure new args are forwarded in library rules 2021-02-15 10:57:43 +00:00
Adam Liddell cd983841c1 Add plugin labels to language readmes 2021-02-15 10:25:11 +00:00
Adam Liddell 2a1ecc25a8 Add extra_protoc_args at rule level, closes #105 2021-02-14 22:51:54 +00:00
Adam Liddell ce60b3471f Add prefix_path option to docs 2021-02-14 22:26:09 +00:00
Adam Liddell 683bdd5de0 In direct compilation mode, setup protoc actions directly
This allows adding support for 'options' attr :)
2021-02-14 22:05:51 +00:00
Adam Liddell 7012cefcf8 Apply yet more buildifier fixes 2021-02-14 20:14:48 +00:00
Adam Liddell 247cba9a4d Apply some more buildifier fixes 2021-02-14 18:21:14 +00:00
Adam Liddell dc25b2ec6d Load ProtoInfo from rules_proto in aspect definitions 2021-02-14 18:13:14 +00:00
Adam Liddell 4f4408177c Restructure starlark files 2021-02-14 18:03:31 +00:00
Adam Liddell 5dd3f6c6bd Apply buildifier 2021-02-13 23:23:38 +00:00
Adam Liddell d69fbe1e08 Add non-transitive compilation mode 2021-02-13 20:12:00 +00:00
Mikhail Mazurskiy eefec56e3d
skylark was renamed into starlark 2021-01-20 22:40:30 +11:00
Mikhail Mazurskiy 4f18e97d4d
Use skylark syntax instead of Python 2021-01-20 14:21:36 +11:00
Adam Liddell a433c3762e Propagate 'tags' attr to underlying language libraries 2020-10-11 21:35:25 +00:00
Adam Liddell dc954d18a9 Remove deps.bzl files that have been deprecated since 1.0.0 2020-10-11 21:27:21 +00:00
Adam Liddell 8d775e0bac Rename rules_proto_grpc_dependencies to rules_proto_grpc_repos 2019-11-06 23:44:07 +00:00
Adam Liddell abef78a944 Remove protobuf_repos and grpc_repos 2019-10-18 23:01:35 +01:00
Adam Liddell 11193b0a02 Update gRPC plugin target paths 2019-10-18 22:16:28 +01:00
Adam Liddell 2098905fe4 Write rule aliases in deterministic order 2019-07-31 15:22:46 +00:00