mirror of https://github.com/bazelbuild/rules_pkg
Fix spelling mistakes (#695)
This commit is contained in:
parent
c86a3e56eb
commit
0aa9277cc6
|
@ -264,7 +264,7 @@ and Ulf Adams
|
|||
- Author: aiuto <aiuto@google.com>
|
||||
Date: Fri Aug 7 11:33:01 2020 -0400
|
||||
use runfiles for pkg_tar_test to enable on Windows (#215)
|
||||
This is a precursor to geting pkg_tar_test to run on Windows.
|
||||
This is a precursor to getting pkg_tar_test to run on Windows.
|
||||
There are still problems to resolve.
|
||||
- commit 933fa6fc7fc49788af04a60558722180818d091f
|
||||
|
||||
|
@ -306,8 +306,8 @@ and Ulf Adams
|
|||
Drop dependency on xzcat (#205)
|
||||
We simply switch to use tarfile mode 'r:*' so that the Python runtime can pick the correct decompression.
|
||||
This simplifies the code enormously.
|
||||
The removed lines expressed concerns about the peformance of the python3 implementaion of xz decompression.
|
||||
Those comments are fairly old, and were addressed in recent Python implementions as noted here: https://bugs.python.org/issue18003
|
||||
The removed lines expressed concerns about the performance of the python3 implementation of xz decompression.
|
||||
Those comments are fairly old, and were addressed in recent Python implementations as noted here: https://bugs.python.org/issue18003
|
||||
- commit 67d64ba774b3e4c33061cf7a95215112c65657a9
|
||||
|
||||
- Author: aiuto <aiuto@google.com>
|
||||
|
|
|
@ -71,12 +71,12 @@ def _names_from_toolchains_impl(ctx):
|
|||
return PackageVariablesInfo(values = values)
|
||||
|
||||
#
|
||||
# Extracting variables from the toolchain to use in the pacakge name.
|
||||
# Extracting variables from the toolchain to use in the package name.
|
||||
#
|
||||
names_from_toolchains = rule(
|
||||
implementation = _names_from_toolchains_impl,
|
||||
# Going forward, the preferred way to depend on a toolchain through the
|
||||
# toolchains atttribute. The current C++ toolchains, however, are still not
|
||||
# toolchains attribute. The current C++ toolchains, however, are still not
|
||||
# using toolchain resolution, so we have to depend on the toolchain
|
||||
# directly.
|
||||
# TODO(https://github.com/bazelbuild/bazel/issues/7260): Delete the
|
||||
|
|
|
@ -6,7 +6,7 @@ License: Apache License, v2.0
|
|||
|
||||
# Do not try to use magic to determine file types
|
||||
%define __spec_install_post %{nil}
|
||||
# Do not die becuse we give it more input files than are in the files section
|
||||
# Do not die because we give it more input files than are in the files section
|
||||
%define _unpackaged_files_terminate_build 0
|
||||
|
||||
%description
|
||||
|
|
|
@ -78,7 +78,7 @@ created file, we can do that with a filegroup that specifies the specific
|
|||
output group containing that file.
|
||||
|
||||
In the example below, `:deb` is a rule producing an explicit .deb output
|
||||
and an implict .changes output. We refer to the .changes file using the
|
||||
and an implicit .changes output. We refer to the .changes file using the
|
||||
`filegroup` and specifying the desired output group name. Then, any rule
|
||||
can use this `filegroup` as an input.
|
||||
|
||||
|
|
|
@ -87,7 +87,7 @@ _pkg_install_script = rule(
|
|||
doc = """Create an executable package installation script.
|
||||
|
||||
The outputs of this rule are a single python script intended to be used as
|
||||
an input to a `py_binary` target. All files necesary to run the script are
|
||||
an input to a `py_binary` target. All files necessary to run the script are
|
||||
included as runfiles.
|
||||
""",
|
||||
implementation = _pkg_install_script_impl,
|
||||
|
|
|
@ -7,7 +7,7 @@ License: Apache License, v2.0
|
|||
|
||||
# Do not try to use magic to determine file types
|
||||
%define __spec_install_post %{nil}
|
||||
# Do not die becuse we give it more input files than are in the files section
|
||||
# Do not die because we give it more input files than are in the files section
|
||||
%define _unpackaged_files_terminate_build 0
|
||||
|
||||
%description
|
||||
|
|
|
@ -52,7 +52,7 @@ def GetFlagValue(flagvalue, strip=True):
|
|||
"""Converts a raw flag string to a useable value.
|
||||
|
||||
1. Expand @filename style flags to the content of filename.
|
||||
2. Cope with Python3 strangness of sys.argv.
|
||||
2. Cope with Python3 strangeness of sys.argv.
|
||||
sys.argv is not actually proper str types on Unix with Python3
|
||||
The bytes of the arg are each directly transcribed to the characters of
|
||||
the str. It is actually more complex than that, as described in the docs.
|
||||
|
|
|
@ -186,7 +186,7 @@ def main(args):
|
|||
installer = NativeInstaller(destdir=args.destdir)
|
||||
|
||||
if not CALLED_FROM_BAZEL_RUN and RUNFILE_PREFIX is None:
|
||||
logging.critical("RUNFILES_DIR must be set in your enviornment when this is run as a bazel build tool.")
|
||||
logging.critical("RUNFILES_DIR must be set in your environment when this is run as a bazel build tool.")
|
||||
logging.critical("This is most likely an issue on Windows. See https://github.com/bazelbuild/rules_pkg/issues/387.")
|
||||
return 1
|
||||
|
||||
|
|
|
@ -293,7 +293,7 @@ class TarFile(object):
|
|||
gname=names[1])
|
||||
|
||||
def add_manifest_entry(self, entry, file_attributes):
|
||||
# Use the pkg_tar mode/owner remaping as a fallback
|
||||
# Use the pkg_tar mode/owner remapping as a fallback
|
||||
non_abs_path = entry.dest.strip('/')
|
||||
if file_attributes:
|
||||
attrs = file_attributes(non_abs_path)
|
||||
|
|
|
@ -134,7 +134,7 @@ class ZipWriter(object):
|
|||
user = entry.user
|
||||
group = entry.group
|
||||
|
||||
# Use the pkg_tar mode/owner remaping as a fallback
|
||||
# Use the pkg_tar mode/owner remapping as a fallback
|
||||
dst_path = dest.strip('/')
|
||||
if entry_type == manifest.ENTRY_IS_DIR and not dst_path.endswith('/'):
|
||||
dst_path += '/'
|
||||
|
|
|
@ -37,7 +37,7 @@ PackageFilesInfo = provider(
|
|||
|
||||
Keys are strings representing attribute identifiers, values are
|
||||
arbitrary data structures that represent the associated data. These are
|
||||
most often strings, but are not explicity defined.
|
||||
most often strings, but are not explicitly defined.
|
||||
|
||||
For known attributes and data type expectations, see the Common
|
||||
Attributes documentation in the `rules_pkg` reference.
|
||||
|
|
|
@ -1,4 +1,4 @@
|
|||
"""Impementation for print_rel_notes."""
|
||||
"""Implementation for print_rel_notes."""
|
||||
|
||||
def print_rel_notes(
|
||||
name,
|
||||
|
|
|
@ -47,7 +47,7 @@ def pkg_rpm(name, srcs = None, spec_file = None, **kwargs):
|
|||
name: rule name
|
||||
srcs: pkg_rpm_pfg `srcs` attribute
|
||||
spec_file: pkg_rpm_legacy `spec_file` attribute
|
||||
**kwargs: arguments to eihter `pkg_rpm_pfg` or `pkg_rpm_legacy`,
|
||||
**kwargs: arguments to either `pkg_rpm_pfg` or `pkg_rpm_legacy`,
|
||||
depending on mode
|
||||
|
||||
"""
|
||||
|
|
|
@ -142,7 +142,7 @@ def _make_absolute_if_not_already_or_is_macro(path):
|
|||
# this can be inlined easily.
|
||||
return path if path.startswith(("/", "%")) else "/" + path
|
||||
|
||||
#### Input processing helper functons.
|
||||
#### Input processing helper functions.
|
||||
|
||||
# TODO(nacl, #459): These are redundant with functions and structures in
|
||||
# pkg/private/pkg_files.bzl. We should really use the infrastructure provided
|
||||
|
|
|
@ -51,7 +51,7 @@ class VerifyArchiveTest(unittest.TestCase):
|
|||
"""Check that the archive contains at least min_size entries.
|
||||
|
||||
Args:
|
||||
min_size: The minium number of targets we expect.
|
||||
min_size: The minimum number of targets we expect.
|
||||
"""
|
||||
actual_size = len(self.paths)
|
||||
self.assertGreaterEqual(
|
||||
|
|
|
@ -136,7 +136,7 @@ pkg_deb(
|
|||
package = "fizzbuzz",
|
||||
version = "7",
|
||||
# This does not make sense for architecture, but for testing, compilation
|
||||
# mode is more stable thatn cpu.
|
||||
# mode is more stable than cpu.
|
||||
architecture = "$(COMPILATION_MODE)",
|
||||
)
|
||||
|
||||
|
|
|
@ -111,7 +111,7 @@ class PkgDebTest(unittest.TestCase):
|
|||
if k == 'data':
|
||||
value = f.extractfile(info).read()
|
||||
elif k == 'name':
|
||||
# The test data uses / as path sep, but the tarbal is in OS native
|
||||
# The test data uses / as path sep, but the tarball is in OS native
|
||||
# format. This aligns the tarball name back to what we expect.
|
||||
value = name_in_tar_file.replace(os.path.sep, '/')
|
||||
elif k == 'isdir':
|
||||
|
|
|
@ -109,7 +109,7 @@ class FilterDirectoryInternalTest(unittest.TestCase):
|
|||
def test_invalid_prefixes(self):
|
||||
self.assertFilterDirectoryFails(
|
||||
prefix="/absolute/path",
|
||||
message="--prefix with aboslute paths should be rejected",
|
||||
message="--prefix with absolute paths should be rejected",
|
||||
)
|
||||
|
||||
self.assertFilterDirectoryFails(
|
||||
|
|
|
@ -87,7 +87,7 @@ class ZipContentsTestBase(ZipTest):
|
|||
if "attr_mask" in expected:
|
||||
attr &= expected.get("attr_mask")
|
||||
else:
|
||||
# I would argue this is a dumb choice, but it matchs the
|
||||
# I would argue this is a dumb choice, but it matches the
|
||||
# legacy rule implementation.
|
||||
attr = 0o555
|
||||
self.assertEqual(oct((info.external_attr >> 16) & UNIX_RWX_BITS),
|
||||
|
|
|
@ -16,7 +16,7 @@
|
|||
Type: @rules_pkg//toolchains/git:git_toolchain_type
|
||||
|
||||
Toolchains:
|
||||
- git_missing_toolchain: provides a fallback toolchain for exec plaforms
|
||||
- git_missing_toolchain: provides a fallback toolchain for exec platforms
|
||||
where git might not be available.
|
||||
|
||||
- git_auto_toolchain: a toolchain that uses the installed git. See
|
||||
|
|
|
@ -48,7 +48,7 @@ _find_system_git = repository_rule(
|
|||
local = True,
|
||||
attrs = {
|
||||
"workspace_file": attr.label(
|
||||
doc = "Referece to calling repository WORKSPACE file.",
|
||||
doc = "Reference to calling repository WORKSPACE file.",
|
||||
allow_single_file = True,
|
||||
mandatory = True,
|
||||
),
|
||||
|
|
|
@ -17,7 +17,7 @@
|
|||
Type: @rules_pkg//toolchains/rpm:rpmbuild_toolchain_type
|
||||
|
||||
Toolchains:
|
||||
- rpmbuild_missing_toolchain: provides a fallback toolchain for exec plaforms
|
||||
- rpmbuild_missing_toolchain: provides a fallback toolchain for exec platforms
|
||||
where rpmbuild might not be available.
|
||||
|
||||
- rpmbuild_auto_toolchain: a toolchain that uses the installed rpmbuild. See
|
||||
|
|
Loading…
Reference in New Issue