bazel
/
rules_foreign_cc
mirror of https://github.com/bazel-contrib/rules_foreign_cc
2
0
Fork 0
Code Issues Releases Activity

Do not convert depset to list for iteration (#98)

This commit is contained in:
irengrig 2018-09-14 10:40:38 +02:00 committed by GitHub
parent b69aec07b6
commit fc29335572
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/build_defs/framework.bzl
View File

@ -411,11 +411,11 @@ def _define_inputs(attrs):
for tool in attrs.tools_deps:
tool_root = detect_root(tool)
tools_roots += [tool_root]
for file_list in tool.files.to_list():
for file_list in tool.files:
tools_files += _list(file_list)
for tool in attrs.additional_tools:
for file_list in tool.files.to_list():
for file_list in tool.files:
tools_files += _list(file_list)
# For Bazel-built libraries: copy headers and libs.
@ -444,6 +444,7 @@ def _define_inputs(attrs):
attrs.additional_inputs + deps_compilation.headers + ext_build_dirs,
)
# consider optimization here to do not iterate both collections
def _get_headers(compilation_info):
include_dirs = collections.uniq(compilation_info.system_includes.to_list())
headers = []
@ -490,7 +491,7 @@ def _extract_link_params(cc_linking):
def _collect_libs(cc_linking):
libs = []
for params in _extract_link_params(cc_linking):
libs += [lib.artifact() for lib in params.libraries_to_link.to_list()]
libs += [lib.artifact() for lib in params.libraries_to_link]
libs += params.dynamic_libraries_for_runtime.to_list()
return collections.uniq(libs)