bazel
/
rules_foreign_cc
mirror of https://github.com/bazel-contrib/rules_foreign_cc
2
0
Fork 0
Code Issues Releases Activity

Update framework.bzl to account for externalIncludes (#1215) 

During our migration to Bazel 7, some of our cmake() rules broke. It
turns out there is a new field in CcCompilationContext to account for
external includes, as opposed to internal system_includes.

See
a6ef0b341a
This commit is contained in:
Guillaume Maudoux 2024-06-14 22:35:24 +02:00 committed by GitHub
parent c15a5201f5
commit d2815388f8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
foreign_cc/private/framework.bzl
View File

@ -926,7 +926,8 @@ def get_foreign_cc_dep(dep):
# consider optimization here to do not iterate both collections
def _get_headers(compilation_info):
include_dirs = compilation_info.system_includes.to_list() + \
compilation_info.includes.to_list()
compilation_info.includes.to_list() + \
getattr(compilation_info, "external_includes", depset()).to_list()
# do not use quote includes, currently they do not contain
# library-specific information