bazel
/
rules_foreign_cc
mirror of https://github.com/bazel-contrib/rules_foreign_cc
2
0
Fork 0
Code Issues Releases Activity

Correct "use default shell environment" action argument (#83) 

We should take the default PATH passed by Bazel, not that from cc_toolchain for Windows, because the PATH under msys2 is different and that is which we need for shell commands
This commit is contained in:
irengrig 2018-09-10 11:34:43 +02:00 committed by GitHub
parent 06970670ae
commit b467afc40f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
tools/build_defs/framework.bzl
View File

@ -201,7 +201,10 @@ def cc_external_rule_impl(ctx, attrs):
inputs = depset(inputs.declared_inputs) + ctx.attr._cc_toolchain.files,
outputs = outputs.declared_outputs,
tools = ctx.attr._utils.files,
use_default_shell_env = False,
# We should take the default PATH passed by Bazel, not that from cc_toolchain
# for Windows, because the PATH under msys2 is different and that is which we need
# for shell commands
use_default_shell_env = targets_windows(ctx, None),
command = script_text,
execution_requirements = execution_requirements,
env = env,