bazel
/
rules_foreign_cc
mirror of https://github.com/bazel-contrib/rules_foreign_cc
2
0
Fork 0
Code Issues Releases Activity

Disable coverage when a C library is not instrumented (#1021)

This commit is contained in:
Zhongpeng Lin 2023-02-28 15:26:33 -08:00 committed by GitHub
parent b7074f111e
commit 798242e04d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
foreign_cc/private/cc_toolchain_util.bzl
View File

@ -49,11 +49,17 @@ FOREIGN_CC_DISABLED_FEATURES = [
] ]
def _configure_features(ctx, cc_toolchain): def _configure_features(ctx, cc_toolchain):
disabled_features = ctx.disabled_features + FOREIGN_CC_DISABLED_FEATURES
if not ctx.coverage_instrumented():
# In coverage mode, cc_common.configure_features() adds coverage related flags,
# such as --coverage to the compiler and linker. However, if this library is not
# instrumented, we don't need to pass those flags, and avoid unncessary rebuilds.
disabled_features.append("coverage")
return cc_common.configure_features( return cc_common.configure_features(
ctx = ctx, ctx = ctx,
cc_toolchain = cc_toolchain, cc_toolchain = cc_toolchain,
requested_features = ctx.features, requested_features = ctx.features,
unsupported_features = ctx.disabled_features + FOREIGN_CC_DISABLED_FEATURES, unsupported_features = disabled_features,
) )
def _create_libraries_to_link(ctx, files): def _create_libraries_to_link(ctx, files):