bazel
/
rules_foreign_cc
mirror of https://github.com/bazel-contrib/rules_foreign_cc
2
0
Fork 0
Code Issues Releases Activity
rules_foreign_cc/test/cmake_text_tests.bzl

470 lines
20 KiB
Python
Raw Normal View History

Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
""" Unit tests for CMake script creation """
load("@bazel_skylib//lib:unittest.bzl", "asserts", "unittest")
load("//tools/build_defs:cmake_script.bzl", "create_cmake_script", "export_for_test")
load("//tools/build_defs:cc_toolchain_util.bzl", "CxxFlagsInfo", "CxxToolsInfo")
def _absolutize_test(ctx):
env = unittest.begin(ctx)
cases = {
"abs/a12": "abs/a12",
"/abs/a12": "/abs/a12",
"external/cmake/aaa": "$EXT_BUILD_ROOT/external/cmake/aaa",
"-Lexternal/cmake/aaa": "-L$EXT_BUILD_ROOT/external/cmake/aaa",
"ws/cmake/aaa": "$EXT_BUILD_ROOT/ws/cmake/aaa",
"name=ws/cmake/aaa": "name=$EXT_BUILD_ROOT/ws/cmake/aaa",
}
for case in cases:
res = export_for_test.absolutize("ws", case)
asserts.equals(env, cases[case], res)
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _tail_extraction_test(ctx):
env = unittest.begin(ctx)
res = export_for_test.tail_if_starts_with("absolutely", "abs")
asserts.equals(env, "olutely", res)
res = export_for_test.tail_if_starts_with("--option=value", "-option")
asserts.equals(env, None, res)
res = export_for_test.tail_if_starts_with("--option=value", "--option")
asserts.equals(env, "=value", res)
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _find_flag_value_test(ctx):
env = unittest.begin(ctx)
found_cases = [
["--gcc_toolchain=/abc/def"],
["--gcc_toolchain =/abc/def"],
["--gcc_toolchain= /abc/def"],
["--gcc_toolchain = /abc/def"],
[" --gcc_toolchain = /abc/def"],
["--gcc_toolchain", "=/abc/def"],
["--gcc_toolchain", "/abc/def"],
["-gcc_toolchain", "/abc/def"],
["-gcc_toolchain=/abc/def"],
["-gcc_toolchain = /abc/def"],
["--gcc_toolchain /abc/def"],
]
for case in found_cases:
res = export_for_test.find_flag_value(case, "gcc_toolchain")
asserts.equals(env, "/abc/def", res, msg = "Not equals: " + str(case))
not_found_cases = [
["--gcc_toolchainn=/abc/def"],
["--gcc_toolchain abc/def"],
]
for case in not_found_cases:
res = export_for_test.find_flag_value(case, "gcc_toolchain")
asserts.false(env, "/abc/def" == res, msg = "Equals: " + str(case))
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _fill_crossfile_from_toolchain_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
cc = "/some-cc-value",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx = "external/cxx-value",
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
cxx_linker_static = "/cxx_linker_static",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx_linker_executable = "ws/cxx_linker_executable",
)
flags = CxxFlagsInfo(
cc = ["-cc-flag", "-gcc_toolchain", "cc-toolchain"],
cxx = ["--quoted=\"abc def\"", "--sysroot=/abc/sysroot", "--gcc_toolchain", "cxx-toolchain"],
cxx_linker_shared = ["shared1", "shared2"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["executable"],
assemble = ["assemble"],
)
Extract shell fragments into a toolchain (#196) * Extract shell fragments into a toolchain Construct script in framework.bzl using special notation for calling shell fragments, defining and referencing environment variables; have the script converted from this special notation into a real script (see README.md notes.) The special notation is used to keep script construction in code still readable. Tools scripts (cmake, ninja) were also converted. * Fix reference to environment variables in examples .. and reference it correctly $$var_name$$ so it is replaced further * Review comments: documentation, explicitly mark functions from toolchain - mark functions from shell toolchain as ##funname##, so that they can not be mixed with usual shell functions * Fix operating system name for windows in toolchain file * Additional env vars for windows * Correct cmake tool build * Do not build ninja on Windows * When run on Windows under msys, find utility from Window could "leak"... into the script. Use heuristics to use /usr/bin/find if it exists. Also, use pwd -W to get Windows-styled paths (for cmake)
2019-01-18 17:06:10 +00:00
res = export_for_test.fill_crossfile_from_toolchain("ws", "linux", tools, flags)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
system = res.pop("CMAKE_SYSTEM_NAME")
asserts.true(env, system != None)
expected = {
"CMAKE_SYSROOT": "/abc/sysroot",
"CMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN": "cc-toolchain",
"CMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN": "cxx-toolchain",
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
"CMAKE_C_COMPILER": "/some-cc-value",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
"CMAKE_CXX_COMPILER": "$EXT_BUILD_ROOT/external/cxx-value",
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
"CMAKE_AR": "/cxx_linker_static",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
"CMAKE_CXX_LINK_EXECUTABLE": "$EXT_BUILD_ROOT/ws/cxx_linker_executable <FLAGS> <CMAKE_CXX_LINK_FLAGS> <LINK_FLAGS> <OBJECTS> -o <TARGET> <LINK_LIBRARIES>",
"CMAKE_C_FLAGS_INIT": "-cc-flag -gcc_toolchain cc-toolchain",
"CMAKE_CXX_FLAGS_INIT": "--quoted=\\\"abc def\\\" --sysroot=/abc/sysroot --gcc_toolchain cxx-toolchain",
"CMAKE_ASM_FLAGS_INIT": "assemble",
"CMAKE_SHARED_LINKER_FLAGS_INIT": "shared1 shared2",
"CMAKE_EXE_LINKER_FLAGS_INIT": "executable",
}
for key in expected:
asserts.equals(env, expected[key], res[key])
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _move_dict_values_test(ctx):
env = unittest.begin(ctx)
target = {
"CMAKE_C_COMPILER": "some-cc-value",
"CMAKE_CXX_COMPILER": "$EXT_BUILD_ROOT/external/cxx-value",
"CMAKE_C_FLAGS_INIT": "-cc-flag -gcc_toolchain cc-toolchain",
"CMAKE_CXX_LINK_EXECUTABLE": "was",
}
source_env = {
"CC": "sink-cc-value",
"CXX": "sink-cxx-value",
"CFLAGS": "--from-env",
"CUSTOM": "YES",
}
source_cache = {
"CMAKE_C_FLAGS": "--additional-flag",
"CMAKE_ASM_FLAGS": "assemble",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
"CUSTOM": "YES",
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
export_for_test.move_dict_values(target, source_env,
export_for_test.CMAKE_ENV_VARS_FOR_CROSSTOOL)
export_for_test.move_dict_values(target, source_cache,
export_for_test.CMAKE_CACHE_ENTRIES_CROSSTOOL)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
expected_target = {
"CMAKE_C_COMPILER": "sink-cc-value",
"CMAKE_CXX_COMPILER": "sink-cxx-value",
"CMAKE_C_FLAGS_INIT": "-cc-flag -gcc_toolchain cc-toolchain --from-env --additional-flag",
"CMAKE_ASM_FLAGS_INIT": "assemble",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
}
for key in expected_target:
asserts.equals(env, expected_target[key], target[key])
asserts.equals(env, "YES", source_env["CUSTOM"])
asserts.equals(env, "YES", source_cache["CUSTOM"])
asserts.equals(env, 1, len(source_env))
asserts.equals(env, 1, len(source_cache))
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _reverse_descriptor_dict_test(ctx):
env = unittest.begin(ctx)
res = export_for_test.reverse_descriptor_dict(export_for_test.CMAKE_CACHE_ENTRIES_CROSSTOOL)
expected = {
"CMAKE_SYSTEM_NAME": struct(value = "CMAKE_SYSTEM_NAME", replace = True),
"CMAKE_AR": struct(value = "CMAKE_AR", replace = True),
"CMAKE_CXX_LINK_EXECUTABLE": struct(value = "CMAKE_CXX_LINK_EXECUTABLE", replace = True),
"CMAKE_C_FLAGS_INIT": struct(value = "CMAKE_C_FLAGS", replace = False),
"CMAKE_CXX_FLAGS_INIT": struct(value = "CMAKE_CXX_FLAGS", replace = False),
"CMAKE_ASM_FLAGS_INIT": struct(value = "CMAKE_ASM_FLAGS", replace = False),
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
"CMAKE_STATIC_LINKER_FLAGS_INIT": struct(value = "CMAKE_STATIC_LINKER_FLAGS",
replace = False),
"CMAKE_SHARED_LINKER_FLAGS_INIT": struct(value = "CMAKE_SHARED_LINKER_FLAGS",
replace = False),
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
"CMAKE_EXE_LINKER_FLAGS_INIT": struct(value = "CMAKE_EXE_LINKER_FLAGS", replace = False),
}
for key in expected:
asserts.equals(env, expected[key], res[key])
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _merge_toolchain_and_user_values_test(ctx):
env = unittest.begin(ctx)
target = {
"CMAKE_C_COMPILER": "some-cc-value",
"CMAKE_CXX_COMPILER": "$EXT_BUILD_ROOT/external/cxx-value",
"CMAKE_C_FLAGS_INIT": "-cc-flag -gcc_toolchain cc-toolchain",
"CMAKE_CXX_FLAGS_INIT": "-ccx-flag",
"CMAKE_CXX_LINK_EXECUTABLE": "was",
}
source_cache = {
"CMAKE_C_FLAGS": "--additional-flag",
"CMAKE_ASM_FLAGS": "assemble",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
"CUSTOM": "YES",
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
res = export_for_test.merge_toolchain_and_user_values(target, source_cache,
export_for_test.CMAKE_CACHE_ENTRIES_CROSSTOOL)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
expected_target = {
"CMAKE_C_FLAGS": "-cc-flag -gcc_toolchain cc-toolchain --additional-flag",
"CMAKE_CXX_FLAGS": "-ccx-flag",
"CMAKE_ASM_FLAGS": "assemble",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
"CUSTOM": "YES",
}
for key in expected_target:
asserts.equals(env, expected_target[key], res[key])
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
def _merge_flag_values_no_toolchain_file_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
cc = "/usr/bin/gcc",
cxx = "/usr/bin/gcc",
cxx_linker_static = "/usr/bin/ar",
cxx_linker_executable = "/usr/bin/gcc",
)
flags = CxxFlagsInfo(
cc = [],
cxx = ["foo=\"bar\""],
cxx_linker_shared = [],
cxx_linker_static = [],
cxx_linker_executable = [],
assemble = [],
)
user_env = {}
user_cache = {
"CMAKE_CXX_FLAGS": "-Fbat",
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
"CMAKE_BUILD_TYPE": "RelWithDebInfo",
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
script = create_cmake_script("ws", "linux", "cmake", tools, flags, "test_rule",
"external/test_rule", True, user_cache, user_env, [])
expected = """CC=\"/usr/bin/gcc\" CXX=\"/usr/bin/gcc\" CXXFLAGS=\"foo=\\\"bar\\\" -Fbat" cmake -DCMAKE_AR=\"/usr/bin/ar\" -DCMAKE_BUILD_TYPE="RelWithDebInfo" -DCMAKE_PREFIX_PATH=\"$EXT_BUILD_DEPS\" -DCMAKE_INSTALL_PREFIX=\"test_rule\" -DCMAKE_RANLIB=\"\" $EXT_BUILD_ROOT/external/test_rule"""
Extract cmake and ninja into a toolchain; provide defaults. (#192) * Extract cmake and ninja into a toolchain; provide defaults. In the workspace-level rule registration function, default toolchain implementations are registered for all platforms, which are calling the cmake and ninja just by name, assuming they are preinstalled. Also, the user can pass the custom toolchains in the initialization function, they will be registered before the defaults. * Do not run ninja build test for now without nested workspaces support * Corrections after merge * Always build ninja from sources for tests, correct initialization order * Add example of using prebuilt artefact in the native tools toolchain. * Review comments, have native_tool_toolchain#target, not label + improve documentation * Correct ninja toolchain label * Correct documentation in native_tools_toolchain.bzl
2019-01-08 11:25:16 +00:00
asserts.equals(env, expected, script)
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _create_min_cmake_script_no_toolchain_file_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
cc = "/usr/bin/gcc",
cxx = "/usr/bin/gcc",
cxx_linker_static = "/usr/bin/ar",
cxx_linker_executable = "/usr/bin/gcc",
)
flags = CxxFlagsInfo(
cc = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx_linker_shared = ["-shared", "-fuse-ld=gold"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["-fuse-ld=gold", "-Wl", "-no-as-needed"],
assemble = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
)
user_env = {}
user_cache = {
"NOFORTRAN": "on",
Merge CMAKE_PREFIX_PATH, passed by user, with $EXT_BUILD_DEPS (#76) This allows using locally installed libraries to be found by CMake + test
2018-08-31 08:50:38 +00:00
"CMAKE_PREFIX_PATH": "/abc/def",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
script = create_cmake_script("ws", "linux", "cmake", tools, flags, "test_rule",
"external/test_rule", True, user_cache, user_env, ["-GNinja"])
expected = "CC=\"/usr/bin/gcc\" CXX=\"/usr/bin/gcc\" CFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" CXXFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" ASMFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" cmake -DCMAKE_AR=\"/usr/bin/ar\" -DCMAKE_SHARED_LINKER_FLAGS=\"-shared -fuse-ld=gold\" -DCMAKE_EXE_LINKER_FLAGS=\"-fuse-ld=gold -Wl -no-as-needed\" -DNOFORTRAN=\"on\" -DCMAKE_PREFIX_PATH=\"$EXT_BUILD_DEPS;/abc/def\" -DCMAKE_INSTALL_PREFIX=\"test_rule\" -DCMAKE_BUILD_TYPE=\"Debug\" -DCMAKE_RANLIB=\"\" -GNinja $EXT_BUILD_ROOT/external/test_rule"
asserts.equals(env, expected, script)
return unittest.end(env)
def _create_min_cmake_script_wipe_toolchain_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
cc = "/usr/bin/gcc",
cxx = "/usr/bin/gcc",
cxx_linker_static = "/usr/bin/ar",
cxx_linker_executable = "/usr/bin/gcc",
)
flags = CxxFlagsInfo(
cc = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx_linker_shared = ["-shared", "-fuse-ld=gold"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["-fuse-ld=gold", "-Wl", "-no-as-needed"],
assemble = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
)
user_env = {}
user_cache = {
"CMAKE_PREFIX_PATH": "/abc/def",
# These two flags/CMake cache entries must be wiped,
# but the second is not present in toolchain flags.
"CMAKE_SHARED_LINKER_FLAGS": "",
"WIPE_ME_IF_PRESENT": "",
}
script = create_cmake_script("ws", "linux", "cmake", tools, flags, "test_rule",
"external/test_rule", True, user_cache, user_env, ["-GNinja"])
expected = "CC=\"/usr/bin/gcc\" CXX=\"/usr/bin/gcc\" CFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" CXXFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" ASMFLAGS=\"-U_FORTIFY_SOURCE -fstack-protector -Wall\" cmake -DCMAKE_AR=\"/usr/bin/ar\" -DCMAKE_EXE_LINKER_FLAGS=\"-fuse-ld=gold -Wl -no-as-needed\" -DCMAKE_PREFIX_PATH=\"$EXT_BUILD_DEPS;/abc/def\" -DCMAKE_INSTALL_PREFIX=\"test_rule\" -DCMAKE_BUILD_TYPE=\"Debug\" -DCMAKE_RANLIB=\"\" -GNinja $EXT_BUILD_ROOT/external/test_rule"
Extract cmake and ninja into a toolchain; provide defaults. (#192) * Extract cmake and ninja into a toolchain; provide defaults. In the workspace-level rule registration function, default toolchain implementations are registered for all platforms, which are calling the cmake and ninja just by name, assuming they are preinstalled. Also, the user can pass the custom toolchains in the initialization function, they will be registered before the defaults. * Do not run ninja build test for now without nested workspaces support * Corrections after merge * Always build ninja from sources for tests, correct initialization order * Add example of using prebuilt artefact in the native tools toolchain. * Review comments, have native_tool_toolchain#target, not label + improve documentation * Correct ninja toolchain label * Correct documentation in native_tools_toolchain.bzl
2019-01-08 11:25:16 +00:00
asserts.equals(env, expected, script)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _create_min_cmake_script_toolchain_file_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
cc = "/usr/bin/gcc",
cxx = "/usr/bin/gcc",
cxx_linker_static = "/usr/bin/ar",
cxx_linker_executable = "/usr/bin/gcc",
)
flags = CxxFlagsInfo(
cc = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
cxx_linker_shared = ["-shared", "-fuse-ld=gold"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["-fuse-ld=gold", "-Wl", "-no-as-needed"],
assemble = ["-U_FORTIFY_SOURCE", "-fstack-protector", "-Wall"],
)
user_env = {}
user_cache = {
"NOFORTRAN": "on",
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
script = create_cmake_script("ws", "linux", "cmake", tools, flags, "test_rule",
"external/test_rule", False, user_cache, user_env, ["-GNinja"])
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
expected = """cat > crosstool_bazel.cmake <<EOF
set(CMAKE_SYSTEM_NAME "Linux")
set(CMAKE_C_COMPILER "/usr/bin/gcc")
set(CMAKE_CXX_COMPILER "/usr/bin/gcc")
set(CMAKE_AR "/usr/bin/ar" CACHE FILEPATH "Archiver")
set(CMAKE_C_FLAGS_INIT "-U_FORTIFY_SOURCE -fstack-protector -Wall")
set(CMAKE_CXX_FLAGS_INIT "-U_FORTIFY_SOURCE -fstack-protector -Wall")
set(CMAKE_ASM_FLAGS_INIT "-U_FORTIFY_SOURCE -fstack-protector -Wall")
set(CMAKE_SHARED_LINKER_FLAGS_INIT "-shared -fuse-ld=gold")
set(CMAKE_EXE_LINKER_FLAGS_INIT "-fuse-ld=gold -Wl -no-as-needed")
EOF
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
cmake -DNOFORTRAN="on" -DCMAKE_TOOLCHAIN_FILE="crosstool_bazel.cmake" -DCMAKE_PREFIX_PATH="$EXT_BUILD_DEPS" -DCMAKE_INSTALL_PREFIX="test_rule" -DCMAKE_BUILD_TYPE=\"Debug\" -DCMAKE_RANLIB=\"\" -GNinja $EXT_BUILD_ROOT/external/test_rule"""
Extract cmake and ninja into a toolchain; provide defaults. (#192) * Extract cmake and ninja into a toolchain; provide defaults. In the workspace-level rule registration function, default toolchain implementations are registered for all platforms, which are calling the cmake and ninja just by name, assuming they are preinstalled. Also, the user can pass the custom toolchains in the initialization function, they will be registered before the defaults. * Do not run ninja build test for now without nested workspaces support * Corrections after merge * Always build ninja from sources for tests, correct initialization order * Add example of using prebuilt artefact in the native tools toolchain. * Review comments, have native_tool_toolchain#target, not label + improve documentation * Correct ninja toolchain label * Correct documentation in native_tools_toolchain.bzl
2019-01-08 11:25:16 +00:00
asserts.equals(env, expected.splitlines(), script.splitlines())
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _create_cmake_script_no_toolchain_file_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
cc = "/some-cc-value",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx = "external/cxx-value",
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
cxx_linker_static = "/cxx_linker_static",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx_linker_executable = "ws/cxx_linker_executable",
)
flags = CxxFlagsInfo(
cc = ["-cc-flag", "-gcc_toolchain", "cc-toolchain"],
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
cxx = ["--quoted=\"abc def\"", "--sysroot=/abc/sysroot", "--gcc_toolchain",
"cxx-toolchain"],
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx_linker_shared = ["shared1", "shared2"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["executable"],
assemble = ["assemble"],
)
user_env = {
"CC": "sink-cc-value",
"CXX": "sink-cxx-value",
"CFLAGS": "--from-env",
"CUSTOM_ENV": "YES",
}
user_cache = {
"CMAKE_C_FLAGS": "--additional-flag",
"CMAKE_ASM_FLAGS": "assemble-user",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
"CUSTOM_CACHE": "YES",
Pass the value of --compilation_mode dbg to the rule and to CMake (#96) CMAKE_BUILD_TYPE=DEBUG (otherwise RELEASE) Can be overriden by user passing CMAKE_BUILD_TYPE in cache_entries
2018-09-14 08:18:38 +00:00
"CMAKE_BUILD_TYPE": "user_type",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
script = create_cmake_script("ws", "linux", "cmake", tools, flags, "test_rule",
"external/test_rule", True, user_cache, user_env, ["-GNinja"])
expected = "CC=\"sink-cc-value\" CXX=\"sink-cxx-value\" CFLAGS=\"-cc-flag -gcc_toolchain cc-toolchain --from-env --additional-flag\" CXXFLAGS=\"--quoted=\\\"abc def\\\" --sysroot=/abc/sysroot --gcc_toolchain cxx-toolchain\" ASMFLAGS=\"assemble assemble-user\" CUSTOM_ENV=\"YES\" cmake -DCMAKE_AR=\"/cxx_linker_static\" -DCMAKE_CXX_LINK_EXECUTABLE=\"became\" -DCMAKE_SHARED_LINKER_FLAGS=\"shared1 shared2\" -DCMAKE_EXE_LINKER_FLAGS=\"executable\" -DCUSTOM_CACHE=\"YES\" -DCMAKE_BUILD_TYPE=\"user_type\" -DCMAKE_PREFIX_PATH=\"$EXT_BUILD_DEPS\" -DCMAKE_INSTALL_PREFIX=\"test_rule\" -DCMAKE_RANLIB=\"\" -GNinja $EXT_BUILD_ROOT/external/test_rule"
Extract cmake and ninja into a toolchain; provide defaults. (#192) * Extract cmake and ninja into a toolchain; provide defaults. In the workspace-level rule registration function, default toolchain implementations are registered for all platforms, which are calling the cmake and ninja just by name, assuming they are preinstalled. Also, the user can pass the custom toolchains in the initialization function, they will be registered before the defaults. * Do not run ninja build test for now without nested workspaces support * Corrections after merge * Always build ninja from sources for tests, correct initialization order * Add example of using prebuilt artefact in the native tools toolchain. * Review comments, have native_tool_toolchain#target, not label + improve documentation * Correct ninja toolchain label * Correct documentation in native_tools_toolchain.bzl
2019-01-08 11:25:16 +00:00
asserts.equals(env, expected, script)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def _create_cmake_script_toolchain_file_test(ctx):
env = unittest.begin(ctx)
tools = CxxToolsInfo(
cc = "some-cc-value",
cxx = "external/cxx-value",
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
cxx_linker_static = "/cxx_linker_static",
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx_linker_executable = "ws/cxx_linker_executable",
)
flags = CxxFlagsInfo(
cc = ["-cc-flag", "-gcc_toolchain", "cc-toolchain"],
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
cxx = ["--quoted=\"abc def\"", "--sysroot=/abc/sysroot", "--gcc_toolchain",
"cxx-toolchain"],
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
cxx_linker_shared = ["shared1", "shared2"],
cxx_linker_static = ["static"],
cxx_linker_executable = ["executable"],
assemble = ["assemble"],
)
user_env = {
"CC": "sink-cc-value",
"CXX": "sink-cxx-value",
"CFLAGS": "--from-env",
"CUSTOM_ENV": "YES",
}
user_cache = {
"CMAKE_C_FLAGS": "--additional-flag",
"CMAKE_ASM_FLAGS": "assemble-user",
"CMAKE_CXX_LINK_EXECUTABLE": "became",
"CUSTOM_CACHE": "YES",
}
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
script = create_cmake_script("ws", "osx", "cmake", tools, flags, "test_rule",
"external/test_rule", False, user_cache, user_env, ["-GNinja"])
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
expected = """cat > crosstool_bazel.cmake <<EOF
set(CMAKE_SYSTEM_NAME "Apple")
set(CMAKE_SYSROOT "/abc/sysroot")
set(CMAKE_C_COMPILER_EXTERNAL_TOOLCHAIN "cc-toolchain")
set(CMAKE_CXX_COMPILER_EXTERNAL_TOOLCHAIN "cxx-toolchain")
set(CMAKE_C_COMPILER "sink-cc-value")
set(CMAKE_CXX_COMPILER "sink-cxx-value")
Crosstool example + fixes (#174) * Add crosstool example; does not work with cmake rule yet the code is taken from Bazel test data (bazel_toolchain_test_data) * Make crosstool compilation of cmake_external + cc_binary work To build example, cd examples/cmake_crosstool bazel build //:libhello_test Changes: 1) Initially suggested in #124: put $EXT_BUILD_ROOT on path, so that relative paths can be resolved by CMake 2) Toolchain tools are references as relative paths, and they themselves refer to external repository with external/ prefix. This will not work with CMake, as CMake also perform compiler tests and the build is performed in some temp directory. We need to convert to absolute paths. I did a trick with checking of $EXT_BUILD_ROOT is defined and then using it as a prefix. 3) I had to change the visibility of the cc-compiler-k8 toolchain to public 4) For CMake crosstool file, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, CMAKE_AR need to be absolute, so in cases when they are relative and not under external directory, force paths conversion
2018-12-06 17:14:00 +00:00
set(CMAKE_AR "/cxx_linker_static" CACHE FILEPATH "Archiver")
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
set(CMAKE_CXX_LINK_EXECUTABLE "became")
set(CMAKE_C_FLAGS_INIT "-cc-flag -gcc_toolchain cc-toolchain --from-env --additional-flag")
set(CMAKE_CXX_FLAGS_INIT "--quoted=\\\"abc def\\\" --sysroot=/abc/sysroot --gcc_toolchain cxx-toolchain")
set(CMAKE_ASM_FLAGS_INIT "assemble assemble-user")
set(CMAKE_SHARED_LINKER_FLAGS_INIT "shared1 shared2")
set(CMAKE_EXE_LINKER_FLAGS_INIT "executable")
EOF
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
CUSTOM_ENV="YES" cmake -DCUSTOM_CACHE="YES" -DCMAKE_TOOLCHAIN_FILE="crosstool_bazel.cmake" -DCMAKE_PREFIX_PATH="$EXT_BUILD_DEPS" -DCMAKE_INSTALL_PREFIX="test_rule" -DCMAKE_BUILD_TYPE=\"Debug\" -DCMAKE_RANLIB=\"\" -GNinja $EXT_BUILD_ROOT/external/test_rule"""
Extract cmake and ninja into a toolchain; provide defaults. (#192) * Extract cmake and ninja into a toolchain; provide defaults. In the workspace-level rule registration function, default toolchain implementations are registered for all platforms, which are calling the cmake and ninja just by name, assuming they are preinstalled. Also, the user can pass the custom toolchains in the initialization function, they will be registered before the defaults. * Do not run ninja build test for now without nested workspaces support * Corrections after merge * Always build ninja from sources for tests, correct initialization order * Add example of using prebuilt artefact in the native tools toolchain. * Review comments, have native_tool_toolchain#target, not label + improve documentation * Correct ninja toolchain label * Correct documentation in native_tools_toolchain.bzl
2019-01-08 11:25:16 +00:00
asserts.equals(env, expected.splitlines(), script.splitlines())
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
Windows, tests: fix for native test wrapper (#246) * Windows, tests: fix for native test wrapper In this PR: - Update `@bazel_skylib` to 0.8.0, which has a Windows-compatible unittest.bzl - Fix unittest-using tests. Correct usage of `unittest.end(env)` is to return its value. Result: //test:all now passes with Bazel 0.25.0rc3 and --incompatible_windows_native_test_wrapper * Register Skylib toolchains * rules_foreign_cc_dep registers unittest toolchains * Address review comments * Add bazel_skylib_workspace to WORKSPACE files * Remove stale toolchain init code
2019-04-30 13:50:26 +00:00
return unittest.end(env)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
absolutize_test = unittest.make(_absolutize_test)
tail_extraction_test = unittest.make(_tail_extraction_test)
find_flag_value_test = unittest.make(_find_flag_value_test)
fill_crossfile_from_toolchain_test = unittest.make(_fill_crossfile_from_toolchain_test)
move_dict_values_test = unittest.make(_move_dict_values_test)
reverse_descriptor_dict_test = unittest.make(_reverse_descriptor_dict_test)
merge_toolchain_and_user_values_test = unittest.make(_merge_toolchain_and_user_values_test)
create_min_cmake_script_no_toolchain_file_test = unittest.make(_create_min_cmake_script_no_toolchain_file_test)
create_min_cmake_script_toolchain_file_test = unittest.make(_create_min_cmake_script_toolchain_file_test)
create_cmake_script_no_toolchain_file_test = unittest.make(_create_cmake_script_no_toolchain_file_test)
create_cmake_script_toolchain_file_test = unittest.make(_create_cmake_script_toolchain_file_test)
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
merge_flag_values_no_toolchain_file_test = unittest.make(_merge_flag_values_no_toolchain_file_test)
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
create_min_cmake_script_wipe_toolchain_test = unittest.make(_create_min_cmake_script_wipe_toolchain_test)
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
def cmake_script_test_suite():
unittest.suite(
"cmake_script_test_suite",
absolutize_test,
tail_extraction_test,
find_flag_value_test,
fill_crossfile_from_toolchain_test,
move_dict_values_test,
reverse_descriptor_dict_test,
merge_toolchain_and_user_values_test,
create_min_cmake_script_no_toolchain_file_test,
create_min_cmake_script_toolchain_file_test,
create_cmake_script_no_toolchain_file_test,
create_cmake_script_toolchain_file_test,
Add test for #163 (do not strip quotes when merging flag values) (#167)
2018-12-04 15:08:30 +00:00
merge_flag_values_no_toolchain_file_test,
Fix a way of wiping CMake cache entry values defined by toolchain fro… (#293) * Fix a way of wiping CMake cache entry values defined by toolchain from a command line, in case user specified empty values for these cache entries explicitly in cmake_external target - it was a problem that we did not check that there was some value in the "toolchain" dict before we pop() - reported in comment in #292 - make code which does wiping empty values more explicit * Additionally, if non-empty value for CMAKE_RANLIB was not specified by user or Bazel toolchain, put empty value for it to forbid CMake to auto detect it context: https://github.com/bazelbuild/rules_foreign_cc/issues/252 * Add test for user's redefined value for CMAKE_BUILD_TYPE
2019-07-17 11:51:21 +00:00
create_min_cmake_script_wipe_toolchain_test,
Add a feature of generating CMake toolchain file and writing tools and flags information there (#70) * cmake toolchain files support * extract cmake script consruction code into a separate file for further testing * simplify cmake script creation code * first four tests for CMake script creation functions * + move_dict_values_test for CMake script creation functions * + reverse_descriptor_dict_test for CMake script creation functions * + toolchain_and_user_values_test for CMake script creation functions * add create_cmake_script_no_toolchain_file_test for CMake script creation * do not insert executable linker rule option if it uses cxx compiler since it would be the same as default add one more test for command line * add test for cmake script with toolchain file * add test for cmake script with toolchain file with user values * propagate information about target into CMake toolchain file
2018-08-30 11:12:51 +00:00
)