mirror of
https://github.com/bazelbuild/rules_cc
synced 2024-11-30 22:41:22 +00:00
e1c7ebb858
This CL is an alternative to unknown commit. I left the other CL seperately, because I wasn't 100% sure that we'd agree to this, since this is an API change.
I did it this way because I believe it's much less hacky, and it also allows us to format things that aren't variables.
BEGIN_PUBLIC
Add support for select'ing on cc_args(args=...).
This is quite tricky because the one parameter was being split into two in a macro, one of type label and the other of type string.
For example, `args = ["--foo", format_arg("--bar=%s", "//path/to:bar")]` was rewritten by the macro to `args = [json.encode(struct(format_type="raw", format="foo")), json.encode(struct(format_type="format_arg", format="--bar=%s", value=0))], variables = ["//path/to:bar"]`.
To allow it to work with selects, we need to ensure that we don't perform post-processing on the inside of the select. To solve this, we:
* Ensure that args only take strings
* Provide a seperate parameter for substitutions.
This new mechanism also has the useful property that we can now format things that are not variables. For example, I can do the following:
```
directory(name = "sysroot", ...)
cc_args(
name = "sysroot_arg",
args = ["--sysroot={sysroot}"],
format = {
":sysroot": "sysroot"
}
)
```
END_PUBLIC
PiperOrigin-RevId: 656211278
Change-Id: If83f1ea5a99090c18f2a561c51ec6d39ce9fe419
50 lines
1.4 KiB
Python
50 lines
1.4 KiB
Python
# Copyright 2024 The Bazel Authors. All rights reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
"""All providers for rule-based bazel toolchain config."""
|
|
|
|
load(
|
|
"//cc/toolchains/impl:nested_args.bzl",
|
|
"NESTED_ARGS_ATTRS",
|
|
"nested_args_provider_from_ctx",
|
|
)
|
|
load(
|
|
":cc_toolchain_info.bzl",
|
|
"NestedArgsInfo",
|
|
)
|
|
|
|
visibility("public")
|
|
|
|
_cc_nested_args = rule(
|
|
implementation = lambda ctx: [nested_args_provider_from_ctx(ctx)],
|
|
attrs = NESTED_ARGS_ATTRS,
|
|
provides = [NestedArgsInfo],
|
|
doc = """Declares a list of arguments bound to a set of actions.
|
|
|
|
Roughly equivalent to ctx.actions.args()
|
|
|
|
Examples:
|
|
cc_nested_args(
|
|
name = "warnings_as_errors",
|
|
args = ["-Werror"],
|
|
)
|
|
""",
|
|
)
|
|
|
|
def cc_nested_args(name, format = {}, **kwargs):
|
|
return _cc_nested_args(
|
|
name = name,
|
|
format = {k: v for v, k in format.items()},
|
|
**kwargs
|
|
)
|