mirror of
https://github.com/bazelbuild/rules_cc
synced 2024-11-27 20:43:26 +00:00
ac3f19bac7
BEGIN_PUBLIC Remove support for args from action_type_config. Args in individual action type configs result in redundant configuration, where both the cc_args and the cc_action_type_config control which actions they're enabled for. Instead of: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"], args = [":compile_args"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"], args = [":compile_args"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"]) ``` We should force users to write the following: ``` cc_args(name = "compile_args", action_types = [":c_compile", ":cpp_compile]) cc_action_type_config(name = "c_compile_config", actions = [":c_compile"]) cc_action_type_config(name = "cpp_compile_config", actions = [":cpp_compile"]) cc_toolchain(action_type_configs = [":c_compile_config", ":cpp_compile_config"], args = [":compile_args"]) ``` END_PUBLIC PiperOrigin-RevId: 642432029 Change-Id: I1aa7c1752f4d915d8c84c17a06314ae9ad2c69f0 |
||
---|---|---|
.. | ||
compiler_settings | ||
load_from_macro | ||
rule_based_toolchain | ||
simple_binary | ||
system_library |