rules_cc/tests/rule_based_toolchain
Googler a2949e206e Fix toolchain argument ordering
BEGIN_PUBLIC

Fix argument ordering

Expected argument ordering should be:

1. Arguments listed in `args`.
2. Legacy/built-in features.
3. User-defined features.

Due to some implementation changes, user-defined arguments were being applied last, reducing the ability for features to properly toggle behaviors dynamically.

This also fixes an issue caught by this change where cc_sysroot was applying flags to actions that had no associated action config.

END_PUBLIC

PiperOrigin-RevId: 683677895
Change-Id: I60e25ca22ffefce717e4e5ce476db0a070ca1993
2024-10-08 10:34:59 -07:00
..
actions BEGIN_PUBLIC 2024-02-20 15:54:10 -08:00
args Add support for implicit include directories to rule-based toolchains 2024-09-05 09:06:15 -07:00
args_list Add support for implicit include directories to rule-based toolchains 2024-09-05 09:06:15 -07:00
features Add support for implicit include directories to rule-based toolchains 2024-09-05 09:06:15 -07:00
legacy_features_as_args Fix rule-based implementation of runtime_library_search_directories 2024-09-08 22:14:44 -07:00
nested_args Remove feature requirements from tools. 2024-07-29 17:37:10 -07:00
testdata Add support for implicit include directories to rule-based toolchains 2024-09-05 09:06:15 -07:00
tool Create a concept of a tool capability. 2024-10-02 19:56:22 -07:00
tool_map Integrate cc_tool_map into rule-based toolchains 2024-08-22 08:46:18 -07:00
toolchain_config Fix toolchain argument ordering 2024-10-08 10:34:59 -07:00
variables Add support for select'ing on cc_args(args=...). 2024-07-25 20:13:42 -07:00
BUILD BEGIN_PUBLIC 2024-02-20 15:54:10 -08:00
analysis_test_suite.bzl BEGIN_PUBLIC 2024-02-20 15:54:10 -08:00
generate_factory.bzl Create a concept of a tool capability. 2024-10-02 19:56:22 -07:00
generics.bzl Integrate cc_tool_map into rule-based toolchains 2024-08-22 08:46:18 -07:00
subjects.bzl Create a concept of a tool capability. 2024-10-02 19:56:22 -07:00
testing_rules.bzl Create a new cc_tool_config rule which will, in the future, replace cc_action_type_config. 2024-08-01 09:20:43 -07:00